Re: [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString

Hi Phil Thank you for the review. I have checked the accessibility package, and found that contains is used with a Vector of AccessibleState objects in the file AccessibleStateset. However in AccessibilityBundle, the table is used to store a set of values associated with a particular

Re: [11][JDK-8195095]Images are not scaled correctly in JEditorPane

Hi Krishna, I tried your test before the fix and it passed. --Semyon On 03/03/2018 12:07 AM, Krishna Addepalli wrote: Hi Prasanta, Thanks for the quick review. I have updated the testcase with your suggestion. Here it is: http://cr.openjdk.java.net/~kaddepalli/8195095/webrev01

Re: [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString

Hi Krishna, Is there any reason to use Hashmap. It seems the synchronization is surplus here and its better to use HashMap. --Semyon On 03/05/2018 05:39 AM, Krishna Addepalli wrote: Hi Phil Thank you for the review. I have checked the accessibility package, and found that contains is

Re: [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString

On 03/05/2018 09:00 AM, Semyon Sadetsky wrote: Hi Krishna, Is there any reason to use Hashmap. It seems the synchronization is surplus here and its better to use HashMap. I meant Hashtable. Sorry. --Semyon --Semyon On 03/05/2018 05:39 AM, Krishna Addepalli wrote: Hi Phil Thank you

Re: [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString

Hi Semyon, Thank you for the review. I don't see any reason why HashMap can't be used here. But could you clarify what you meant by "synchronization is surplus here"? Besides, whether we use HashMap /Hashtable, the fix for this particular bug still remains. As for changing (if that is

Re: [11][JDK-8195095]Images are not scaled correctly in JEditorPane

Hi Semyon, Did you try it in Windows or Linux? I have tested it on Mac, and found that it fails before the fix and passes after the fix. Thanks, Krishna From: Semyon Sadetsky Sent: Monday, March 5, 2018 10:01 PM To: Krishna Addepalli ; Prasanta

Re: [11] JDK-8190347: [TESTBUG] Test javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentJComboBox.java fails

On 01/03/2018 04:36, Pankaj Bansal wrote: The mac specific issue "Flag is not triggered for point **" will be fixed by the bug you pointed out JDK-8024627. This same issue "Flag is not triggered for point **" is also observed in

Re: [11][JDK-8195095]Images are not scaled correctly in JEditorPane

I tried on Ubuntu 17.10, but since the getPixelColor always returns black, the test will pass, which is why I was asking. Thanks, Krishna From: Semyon Sadetsky Sent: Monday, March 5, 2018 11:57 PM To: Krishna Addepalli ; Prasanta Sadhukhan

Re: [11][JDK-8195095]Images are not scaled correctly in JEditorPane

On 03/05/2018 10:23 AM, Krishna Addepalli wrote: Hi Semyon, Did you try it in Windows or Linux? I have tested it on Mac, and found that it fails before the fix and passes after the fix. I tried it on Linux. But the change is in generic code why the test result depends on the platform?

Re: [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString

On 03/05/2018 10:41 AM, Krishna Addepalli wrote: Hi Semyon, Thank you for the review. I don’t see any reason why HashMap can’t be used here. But could you clarify what you meant by “synchronization is surplus here”? Sure. Hashtable is synchronized. And since the locale bundle is created

Re: [11][JDK-8197785]javax.accessibility.AccessibilityBundle will reload the ResourceBundle for every call to toDisplayString

I originally thought you were referring to the Hashtable in the test ? That really doesn't matter. If you are referring to the use of hashtable in the JDK class then I think it is safer to leave it as is. Hashtable is provably safe here, and for HashMap you'd need to ensure that concurrent read