[12] RFR JDK-8198334: java/awt/FileDialog/8003399/bug8003399.java fails in headless mode

2018-11-05 Thread Prasanta Sadhukhan
Hi All, Please review a fix for an issue where some tests are found to be failing with HeadlessException in mach5 systems. Proposed fix is to mark those tests as headful. Bug: https://bugs.openjdk.java.net/browse/JDK-8198334 webrev: http://cr.openjdk.java.net/~psadhukhan/8198334/webrev.0/

Re: Swing dev>[12] Review request for JDK-8189253: [macos] JPopupMenu is inadvertently shown when using setComponentPopupMenu

2018-11-05 Thread Manajit Halder
Hi Dmitry, Thanks for you reply. Please find my reply inline. Regards, Manajit On 01/11/18 4:59 PM, Dmitry Markov wrote: Hi Manajit, The usage of addChildWindow will introduce some undesirable behaviour. For example, parent and child windows are created on the same screen; on the build

[12] JDK-8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac

2018-11-05 Thread shashidhara . veerabhadraiah
Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-8198624 Webrev: http://cr.openjdk.java.net/~sveerabhadra/8198624/webrev.00/ The problem was the swing components were used in the main thread, causing syncing issues between the key press events

Re: [12] RFR JDK-8213116:javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java fails in Windows

2018-11-05 Thread Phil Race
On 11/4/18 8:54 PM, Prasanta Sadhukhan wrote: On 04-Nov-18 12:02 AM, Philip Race wrote: What a sorry list of bugs. Didn't quite understand this statement... are you saying the original combobox fix has spawned bad list of bugs? Yes. I was just commenting on the list of issues you cite.

Re: [12] RFR [JDK-8213168] Enable different look and feel tests in SwingSet3 demo test FileChooserDemoTest

2018-11-05 Thread Sergey Bylokhov
Looks fine. On 04/11/2018 21:24, Muneer Kolarkunnu wrote: Gentle Reminder. Regards, Muneer *From:* Muneer Kolarkunnu *Sent:* Wednesday, October 31, 2018 10:40 AM *To:* swing-dev@openjdk.java.net *Cc:* Aleksandre Iline *Subject:* [12] RFR [JDK-8213168] Enable different look and feel tests

Re: [12] JDK-8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac

2018-11-05 Thread Sergey Bylokhov
Hi, Shashi. A few notes: 1. All Swing components are still created on non-EDT thread. 2. Why did you change this line: this.setLayout (new BorderLayout ()); to this: frame.setLayout (new BorderLayout ()); The first line was related to the applet, and actually it was

Re: [12] RFR JDK-8213181:Updation of ProblemList.txt for removal of passing swing test

2018-11-05 Thread Sergey Bylokhov
> > So shouldn't this test just be marked @headful ? > I can mark it headful if Sergey is ok with it. This will skip the test in our nightly, but actually does not solve the existed bug in the test. > fails last time due to some update dialog or antivirus popup) >