RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Pankaj Bansal
Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233550 Patch: diff -r dd652a1b2a39 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt  Sat May 09 09:49:08 2020 +0530 +++ b/test/jdk/ProblemList.txt  Fri May 22 12:59:08 2020 +0530

Re: RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Jayathirth D v
Looks good to me. Thanks, Jay > On 22-May-2020, at 1:08 PM, Pankaj Bansal wrote: > > https://bugs.openjdk.java.net/browse/JDK-8233550 >

Re: RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Prasanta Sadhukhan
I guess just to ensure these tests not hampering other tests, you can add a frame.dispose() at finally block. Regards Prasanta On 22-May-20 1:08 PM, Pankaj Bansal wrote: Hi All, Please review the following test only fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8233550 Patch:

RFR: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual

2020-05-22 Thread Tejpal Rebari
Hi All, Please review the following test only fix for jdk15. Bug: https://bugs.openjdk.java.net/browse/JDK-8239827 Webrev : http://cr.openjdk.java.net/~trebari/swing/8239827/webrev00/

Re: RFR: 8233559 [TESTBUG] TestNimbusOverride.java is failing on macos

2020-05-22 Thread Pankaj Bansal
Looks good to me -Pankaj On 20/05/20 2:20 PM, Tejpal Rebari wrote: Hi All, I have added a try-finally block to dispose the frame in the finally block. Webrev : http://cr.openjdk.java.net/~trebari/swing/8233559/webrev01/ Tested

Re: RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Pankaj Bansal
Hello Prasanta, Thanks for the review. I have made the suggested changes. webrev: http://cr.openjdk.java.net/~pbansal/8233550/webrev01/ Regards, Pankaj On 22/05/20 1:44 PM, Prasanta Sadhukhan wrote: I guess just to ensure these test

Re: RFR: 8199529 : javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows

2020-05-22 Thread Sergey Bylokhov
On 5/20/20 9:40 am, Philip Race wrote: I don't see any problem in "Swing itself".  Where do you see a bug ? I have rechecked implementation of both usages and agreed, both already take care about AA hint, even Motif L&F. +1. -phil. On 5/20/20, 8:33 AM, Sergey Bylokhov wrote: On 5/20/20 7

Re: RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

2020-05-22 Thread Prasanta Sadhukhan
+1 On 22-May-20 5:31 PM, Pankaj Bansal wrote: Hello Prasanta, Thanks for the review. I have made the suggested changes. webrev: http://cr.openjdk.java.net/~pbansal/8233550/webrev01/ Regards, Pankaj On 22/05/20 1:44 PM, Prasanta Sa