Hi All,
Please review a fix for an issue whereby
javax.swing.plaf.basic.BasicComboBoxUI.isPopupVisible returns
NullPointerException when called from a overridden method of getModel().
If a class extends JComboBox and overrides getModel() and then it calls
isPopupVisible() from the overriden
Hi All,
Please review a fix for issue where it was seen that several classes
rely on default constructors as part of their public API.
It's to be noted that "A no-arg public constructor is generated by the
compiler for a class if it does not declare an explicit constructor.
While
ping, any reviewers?
Regards,
Pankaj
On 26/07/20 4:24 PM, Pankaj Bansal wrote:
Hi All,
Please review the following fix for jdk16.
Bug : https://bugs.openjdk.java.net/browse/JDK-8249548
webrev: http://cr.openjdk.java.net/~pbansal/8249548/webrev00/
Ok. The bugid should read https://bugs.openjdk.java.net/browse/JDK-8250811
On 30-Jul-20 9:04 PM, Prasanta Sadhukhan wrote:
I had talked with Joe and it was decided to break up in parts as it
will be easy for him.
Regards
PRasanta
On 30-Jul-20 9:02 PM, Sergey Bylokhov wrote:
On 30.07.2020
it will be easier for me to break up in parts if I have to do all of it.
Regards
Prasanta
On 30-Jul-20 9:26 PM, Joe Darcy wrote:
If you want to make the changes all in one go, I can accommodate that
too.
Thanks,
-Joe
On 7/30/2020 8:34 AM, Prasanta Sadhukhan wrote:
I had talked with Joe
Well let's not use 8250639 so yes a new review.
But I think first step is to file all the sub-issues which I think
should be by component
area and we'll need to list like Joe did in the description and then we
should be able
to more easily track that the aggregate is the same ..
Perhaps
On 30.07.2020 01:24, Prasanta Sadhukhan wrote:
Proposed fix is to create no-arg default constructor for javax.swing.plaf.multi
module (as one part of overalll java.desktop change)
This change is about "javax.swing.plaf.multi" package in the java.desktop
module, but it refers to the
Kevin mentioned even if fx they are breaking it up and tackling these issue.
Regards
Prasanta
On 30-Jul-20 9:27 PM, Prasanta Sadhukhan wrote:
it will be easier for me to break up in parts if I have to do all of it.
Regards
Prasanta
On 30-Jul-20 9:26 PM, Joe Darcy wrote:
If you want to make
I had talked with Joe and it was decided to break up in parts as it will
be easy for him.
Regards
PRasanta
On 30-Jul-20 9:02 PM, Sergey Bylokhov wrote:
On 30.07.2020 01:24, Prasanta Sadhukhan wrote:
Proposed fix is to create no-arg default constructor for
javax.swing.plaf.multi module (as
If you want to make the changes all in one go, I can accommodate that too.
Thanks,
-Joe
On 7/30/2020 8:34 AM, Prasanta Sadhukhan wrote:
I had talked with Joe and it was decided to break up in parts as it
will be easy for him.
Regards
PRasanta
On 30-Jul-20 9:02 PM, Sergey Bylokhov wrote:
Let's look at how to logically break it up.
Sergey's first point was that you are here grabbing the bug that lists
all issues
and making it the fix for everything.
I think you should withdraw this, turn it into an umbrella and file
separate issues.
But let's not make too many issues. It is
Hi Phil,
I actually erred on that. I should have used
bughttps://bugs.openjdk.java.net/browse/JDK-8250811 which I created for
this.
I will like probably 3-5 issues out of umbrella task comprising each
module. I can see we have 100 issues for plaf.basic and 40 odd for
plaf.metal so that
Hi, Kumar.
I suggest improving the test a little bit. The test in the description of the
bug checks
all Swing components, it will be useful to do the same. Also, can you please
iterate
over all installed L and test each.
On 29.07.2020 09:21, Kumar Abhishek wrote:
Hello,
Could you review a
13 matches
Mail list logo
