Re: [systemd-devel] [ANNOUNCE] systemd 199

2013-03-27 Thread William Giokas
On Tue, Mar 26, 2013 at 05:40:59PM +0100, Philip Müller wrote: systemd-199 build just fine on 64bit, but on 32bit it fails during check: PASS: test-sleep ./build-aux/test-driver: line 95: 18318 Segmentation fault (core dumped) $@ $log_file 21 Fixed as of

Re: [systemd-devel] [PATCH] condition: add option ConditionArchitecture

2013-03-27 Thread Tollef Fog Heen
]] Cristian Rodríguez El 26/03/13 15:17, Bill Nottingham escribió: Lukas Nykryn (lnyk...@redhat.com) said: --- TODO | 2 -- man/systemd.unit.xml.in | 8 src/core/condition.c | 16

[systemd-devel] [PATCH 1/2] sd-bus: check c-path for null instead of path

2013-03-27 Thread Lukas Nykryn
--- src/libsystemd-bus/sd-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libsystemd-bus/sd-bus.c b/src/libsystemd-bus/sd-bus.c index 5f2ede0..6acc59e 100644 --- a/src/libsystemd-bus/sd-bus.c +++ b/src/libsystemd-bus/sd-bus.c @@ -1944,7 +1944,7 @@ static int

[systemd-devel] [PATCH 2/2] log: fix error codes handling in catalog_list_items

2013-03-27 Thread Lukas Nykryn
Previously r was set to zero and so if(r0) was never true. Also it does not make sense to print error code from previous loop. --- src/journal/catalog.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/journal/catalog.c b/src/journal/catalog.c index

Re: [systemd-devel] [ANNOUNCE] systemd 199

2013-03-27 Thread Philip Müller
Here on this machine it still fails. It can also be an issue with this installation. I created a tarball out of git with followed commit as last one: 590888a0d0cb813714fa2a521e2ca711f75862fb http://cgit.freedesktop.org/systemd/systemd/commit/?id=590888a0d0cb813714fa2a521e2ca711f75862fb Still

Re: [systemd-devel] [PATCH] support statically configured acls

2013-03-27 Thread Ludwig Nussel
Kay Sievers wrote: On Sat, Mar 23, 2013 at 1:57 PM, Kay Sievers k...@vrfy.org wrote: On Sat, Mar 23, 2013 at 12:16 AM, Lennart Poettering lenn...@poettering.net wrote: On Tue, 19.03.13 17:36, Ludwig Nussel (ludwig.nus...@suse.de) wrote: useful to get ACLs on files, sockets etc not known to

[systemd-devel] Optimizing systemd binaries for small deployments

2013-03-27 Thread Tino Breddin
Hi there, We are in the process of creating a very small image for devices with a maximum of 4MB flash. Compared to a SysV variant which clocks in at ~1MB using Systemd we are currently getting images sizes of ~10MB. At first glance the systemd binaries seem quite large. Before diving into

Re: [systemd-devel] [PATCH] [RFC][PLEASE TEST] readahead: chunk on spinning media

2013-03-27 Thread Kay Sievers
On Sun, Mar 24, 2013 at 3:38 AM, Kok, Auke-jan H auke-jan.h@intel.com wrote: I don't see anything in udev code setting IOPRIO... perhaps elevating the few calls doing bklid and mount might be helpful? Maybe that really makes a difference, we should definitely try that. The blkid calls

Re: [systemd-devel] [PATCH] condition: add option ConditionArchitecture

2013-03-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 27, 2013 at 08:22:14AM +0100, Tollef Fog Heen wrote: ]] Cristian Rodríguez El 26/03/13 15:17, Bill Nottingham escribió: Lukas Nykryn (lnyk...@redhat.com) said: --- TODO | 2 -- man/systemd.unit.xml.in | 8

[systemd-devel] [PATCH] systemd-sysctl: Handle missing /etc/sysctl.conf properly

2013-03-27 Thread Eelco Dolstra
Since fabe5c0e5fce730aa66e10a9c4f9fdd443d7aeda, systemd-sysctl returns a non-zero exit code if /etc/sysctl.conf does not exist, due to a broken ENOENT check. --- src/sysctl/sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sysctl/sysctl.c b/src/sysctl/sysctl.c index

Re: [systemd-devel] [PATCH] condition: add option ConditionArchitecture

2013-03-27 Thread Lukáš Nykrýn
St 27. březen 2013, 13:21:28 CET, Zbigniew Jędrzejewski-Szmek napsal: On Wed, Mar 27, 2013 at 08:22:14AM +0100, Tollef Fog Heen wrote: ]] Cristian Rodríguez El 26/03/13 15:17, Bill Nottingham escribió: Lukas Nykryn (lnyk...@redhat.com) said: --- TODO | 2

Re: [systemd-devel] Possible race condition for setting cgroup sticky bit

2013-03-27 Thread Anders Olofsson
I just tested it with systemd 199 and the problem still occurs. However it now fails with Failed at step CGROUP spawning /etc/init.d/rc: No such file or directory just like in 197 and not with a segfault as I saw (at least sometimes) with 198. /Anders -Original Message- From:

Re: [systemd-devel] Optimizing systemd binaries for small deployments

2013-03-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 27, 2013 at 11:49:44AM +0100, Tino Breddin wrote: Hi there, We are in the process of creating a very small image for devices with a maximum of 4MB flash. Compared to a SysV variant which clocks in at ~1MB using Systemd we are currently getting images sizes of ~10MB. At first

Re: [systemd-devel] Optimizing systemd binaries for small deployments

2013-03-27 Thread Tino Breddin
I figured the next step would be to dive in and remove duplicate or unneeded functionality. I couldn't find information about a shared library approach yet, which should naturally be a great improvement. Guess I should check the ML archives a little more. Tino - Original Message -

[systemd-devel] [PATCH 1/3] core: check return value of rm_rf_dangerous and warn if it fails

2013-03-27 Thread Vaclav Pavlin
From: Václav Pavlín vpav...@redhat.com --- src/core/execute.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/core/execute.c b/src/core/execute.c index bc876a3..936e7d8 100644 --- a/src/core/execute.c +++ b/src/core/execute.c @@ -1559,10 +1559,16 @@ void

[systemd-devel] [PATCH 3/3] shared: free dt (temporary dir name) on fail

2013-03-27 Thread Vaclav Pavlin
From: Václav Pavlín vpav...@redhat.com --- src/shared/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/util.c b/src/shared/util.c index 0444cf4..b724959 100644 --- a/src/shared/util.c +++ b/src/shared/util.c @@ -5733,6 +5733,7 @@ int create_tmp_dir(char template[], char**

Re: [systemd-devel] [PATCH 2/3] udev: check return value of uname.

2013-03-27 Thread Lennart Poettering
On Wed, 27.03.13 15:16, Vaclav Pavlin (vpav...@redhat.com) wrote: From: Václav Pavlín vpav...@redhat.com --- src/udev/udevd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index b30bedf..379168d 100644 --- a/src/udev/udevd.c

Re: [systemd-devel] [PATCH 2/3] udev: check return value of uname.

2013-03-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 27, 2013 at 04:50:48PM +0100, Lennart Poettering wrote: On Wed, 27.03.13 15:16, Vaclav Pavlin (vpav...@redhat.com) wrote: From: Václav Pavlín vpav...@redhat.com --- src/udev/udevd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH] systemd-sysctl: Handle missing /etc/sysctl.conf properly

2013-03-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 27, 2013 at 01:41:59PM +0100, Eelco Dolstra wrote: Since fabe5c0e5fce730aa66e10a9c4f9fdd443d7aeda, systemd-sysctl returns a non-zero exit code if /etc/sysctl.conf does not exist, due to a broken ENOENT check. Applied. Zbyszek ___

Re: [systemd-devel] [PATCH 2/2] log: fix error codes handling in catalog_list_items

2013-03-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 27, 2013 at 10:44:21AM +0100, Lukas Nykryn wrote: Previously r was set to zero and so if(r0) was never true. Also it does not make sense to print error code from previous loop. Applied the first one and a half of this one. You're right that k should be used instead of r, but this

Re: [systemd-devel] [PATCH 1/3] core: check return value of rm_rf_dangerous and warn if it fails

2013-03-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 27, 2013 at 03:16:35PM +0100, Vaclav Pavlin wrote: From: Václav Pavlín vpav...@redhat.com --- src/core/execute.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/core/execute.c b/src/core/execute.c index bc876a3..936e7d8 100644 ---

Re: [systemd-devel] [PATCH 3/3] shared: free dt (temporary dir name) on fail

2013-03-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 27, 2013 at 03:16:37PM +0100, Vaclav Pavlin wrote: From: Václav Pavlín vpav...@redhat.com --- src/shared/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shared/util.c b/src/shared/util.c index 0444cf4..b724959 100644 --- a/src/shared/util.c +++

Re: [systemd-devel] [PATCH 2/2] log: fix error codes handling in catalog_list_items

2013-03-27 Thread Lukáš Nykrýn
So if we want to return first error there should be -if (r 0) +if (r == 0) r = k; Am I right? Lukas St 27. březen 2013, 17:06:27 CET, Zbigniew Jędrzejewski-Szmek napsal: On Wed, Mar 27, 2013 at 10:44:21AM +0100,

[systemd-devel] [PATCH] catalog: fix error codes handling in catalog_list_items

2013-03-27 Thread Lukas Nykryn
Previously r was set to zero and so if(r0) was never true. --- src/journal/catalog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/journal/catalog.c b/src/journal/catalog.c index 6b195f6..7ae7b3e 100644 --- a/src/journal/catalog.c +++ b/src/journal/catalog.c @@

Re: [systemd-devel] [PATCH] catalog: fix error codes handling in catalog_list_items

2013-03-27 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Mar 27, 2013 at 05:35:55PM +0100, Lukas Nykryn wrote: Previously r was set to zero and so if(r0) was never true. Applied. Thanks. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

Re: [systemd-devel] Optimizing systemd binaries for small deployments

2013-03-27 Thread Cristian Rodríguez
El 27/03/13 07:49, Tino Breddin escribió: Hi there, We are in the process of creating a very small image for devices with a maximum of 4MB flash. Compared to a SysV variant which clocks in at ~1MB using Systemd we are currently getting images sizes of ~10MB. At first glance the systemd

Re: [systemd-devel] [PATCH] condition: add option ConditionArchitecture

2013-03-27 Thread Kok, Auke-jan H
On Wed, Mar 27, 2013 at 12:22 AM, Tollef Fog Heen tfh...@err.no wrote: ]] Cristian Rodríguez El 26/03/13 15:17, Bill Nottingham escribió: Lukas Nykryn (lnyk...@redhat.com) said: --- TODO | 2 -- man/systemd.unit.xml.in | 8

[systemd-devel] [PATCH 1/2] cryptsetup: RequiresMountsFor if source is a file

2013-03-27 Thread Thomas Weißschuh
Fixes bug 60821 --- TODO | 1 - src/cryptsetup/cryptsetup-generator.c | 22 -- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/TODO b/TODO index e54f84b..fc05317 100644 --- a/TODO +++ b/TODO @@ -354,7 +354,6 @@ Features: *

[systemd-devel] [PATCH 2/2] cryptsetup: add RequiresMountsFor for passfile

2013-03-27 Thread Thomas Weißschuh
Removed Before=local-fs.target because the respective mountpoint already does this. --- src/cryptsetup/cryptsetup-generator.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/cryptsetup/cryptsetup-generator.c b/src/cryptsetup/cryptsetup-generator.c index

Re: [systemd-devel] [PATCHv2] man/os-release: Add BUILD_ID field

2013-03-27 Thread Kok, Auke-jan H
On Mon, Mar 25, 2013 at 2:07 PM, William Douglas william.doug...@intel.com wrote: BUILD_ID is a fairly generic field used to identify the system image that was used to install the distribution. Signed-off-by: William Douglas william.doug...@intel.com --- man/os-release.xml | 22

[systemd-devel] systemd-inhibit --what=handle-power-key broken with systemd 198

2013-03-27 Thread Manuel Reimer
Hello, I'm using ArchLinux which currently uses systemd 198. I try to inhibit the power key to get sure systemd doesn't shut down if it is pressed. My testcase is as follows: # systemd-inhibit --what=handle-power-key --mode=block sleep 100 Now I switch to another shell to check if the

Re: [systemd-devel] systemd-inhibit --what=handle-power-key broken with systemd 198

2013-03-27 Thread Manuel Reimer
Just one more information: It seems like the inhibitors work if I'm on the same shell/virtual terminal where the inhibitor was created. So the inhibitors, created by KDE, only work if I'm on the KDE screen. If I switch to another VT, then the power button forcefully shuts down the system.

Re: [systemd-devel] [PATCH] [RFC][PLEASE TEST] readahead: chunk on spinning media

2013-03-27 Thread Kok, Auke-jan H
On Wed, Mar 27, 2013 at 10:50 AM, Kok, Auke-jan H auke-jan.h@intel.com wrote: On Wed, Mar 27, 2013 at 4:55 AM, Kay Sievers k...@vrfy.org wrote: On Sun, Mar 24, 2013 at 3:38 AM, Kok, Auke-jan H auke-jan.h@intel.com wrote: I don't see anything in udev code setting IOPRIO... perhaps