Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Jay D Bhatt
Hi Mantas, Thanks for your suggestions. I was able to run init=/sbin/init and run systemd but it completed only partially. I changed kernel options pointed by you and I was able to start /sbin/init. I have attached the log. In the log, I still see some [FAILED] parts. Can you suggest how to

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Jay D Bhatt
I logged in shell script using init=/bin/sh and executed journalctl --boot, It says No journal files were found. Failed to set boot id: No such file or directory . I don't get login prompt when I use init=/sbin/init, so tried with init=/bin/sh. Is it correct? Thanks, Jay

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Mantas Mikulėnas
On Fri, Jun 13, 2014 at 9:31 AM, Jay D Bhatt jay.bh...@igate.com wrote: I logged in shell script using init=/bin/sh and executed journalctl --boot, It says No journal files were found. Failed to set boot id: No such file or directory . I don't get login prompt when I use init=/sbin/init, so

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Kirill Elagin
I'm sorry to cut in but that's too interesting to keep just observing. I guess it was `Failed to _g_et boot id` and it its about `/proc/sys/kernel/random/boot_id`. Is that kernel 2.3.15 or what? {- offtopic ~~~ systemd-readahead[1486]: Failed to create fanotify object: Function not implemented

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Kirill Elagin
On Fri, Jun 13, 2014 at 11:01 AM, Kirill Elagin kirela...@gmail.com wrote: I guess it was `Failed to _g_et boot id` and it its about `/proc/sys/kernel/random/boot_id`. Is that kernel 2.3.15 or what? Oh, never mind, that's probably just because `/proc` is not mounted when `init=/bin/sh`.

[systemd-devel] Reorder usage of streq_ptr, don't think it was correct in the first place

2014-06-13 Thread Robert Milasan
It seems that in udevd.c synthesize_change that order of arguments in streq_ptr is wrong, or at least it looks wrong to me. I've attached the patch which should fix the issue. -- Robert Milasan L3 Support Engineer SUSE Linux (http://www.suse.com) email: rmila...@suse.com GPG fingerprint: B6FE

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Jay D Bhatt
I got the previous log by command use `journalctl --boot -1` Please find the log attached. This time the system stopped prior to previous run. This time it stopped at : [ OK ] Started D-Bus System Message Bus. Starting Authorization Manager... Thanks, Jay

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Jay D Bhatt
Hi Kirill, I got to enable CONFIG_FANOTIFY in kernel, but I think this will not be high priority or blocking thing. Is it blocking thing? Thanks, Jay ~~Disclaimer~~~

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Jay D Bhatt
HI Cristian, I got my systemd running but only partly. Though I haven't tried disabling smack and ima, does these effect my initialization(i.e. is disabling necessary), since my systemd log just says failed and moves ahead. Actually currently my system gets stuck at one point, I want to move

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Kirill Elagin
No it's definitely not a blocker. You forgot to attach a log your previous message. -- Кирилл Елагин On Fri, Jun 13, 2014 at 1:09 PM, Jay D Bhatt jay.bh...@igate.com wrote: Hi Kirill, I got to enable CONFIG_FANOTIFY in kernel, but I think this will not be high priority or blocking

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Jay D Bhatt
Thanks. I surely forgot to attach log. Now you can find it attached. Thanks, Jay ~~Disclaimer~~~ Information contained and transmitted by this e-mail is confidential and

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Mantas Mikulėnas
It seems systemd cannot mount /tmp, possibly because the kernel does not have CONFIG_TMPFS=y. I think this is required – while tmp.mount (in-memory /tmp) can be masked, but systemd will always try to mount a tmpfs on /run, for daemons' runtime data. Not sure if that's why it hangs though. Would

Re: [systemd-devel] Reorder usage of streq_ptr, don't think it was correct in the first place

2014-06-13 Thread Lennart Poettering
On Fri, 13.06.14 10:49, Robert Milasan (rmila...@suse.com) wrote: It seems that in udevd.c synthesize_change that order of arguments in streq_ptr is wrong, or at least it looks wrong to me. I've attached the patch which should fix the issue. Hmm? Not following? streq_ptr() compares two

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Kirill Elagin
First of all the log is somewhat deformed. You could probably add `--no-pager` or something like this to see the full lines. It's not clear why mounting /tmp fails as I can't see any errors about failing to mount /run and as far as I can tell there should be an error logged in case it fails as

[systemd-devel] new user/group population on bootup

2014-06-13 Thread Colin Walters
Hi, I had a quick look at the new: http://cgit.freedesktop.org/systemd/systemd/commit/?id=1b99214789101976d6bbf75c351279584b071998 and followon commits. My high level takeaway right now is that this looks OK for nspawn containers, but it's not clear to me it's viable or right for the host OS, at

Re: [systemd-devel] new user/group population on bootup

2014-06-13 Thread Colin Walters
On Fri, Jun 13, 2014, at 05:36 AM, Colin Walters wrote: My high level takeaway right now is that this looks OK for nspawn containers, but it's not clear to me it's viable or right for the host OS, at least for general purpose systems. That was wrongly stated - basically I'm just skeptical of

[systemd-devel] [PATCH 03/24] sd-dhcp6-client: Add initial Router Advertisement test case

2014-06-13 Thread Patrik Flykt
Feed a Router Advertisement to the code and expect proper events each time. The sending part is ignored, as all of it is static code in the real dhcp_network_icmp6_send_rs() function. --- Makefile.am| 13 ++- src/libsystemd-network/test-dhcp6-rs.c | 155

[systemd-devel] [PATCH 04/24] sd-dhcp6-client: Initialize Router Solicitation on startup

2014-06-13 Thread Patrik Flykt
Try DHCPv6 if router solicitation times out as a link without routers may use DHCPv6 according to RFC 4862 section 5.5.2. --- src/libsystemd-network/sd-dhcp6-client.c | 70 +++- src/systemd/sd-dhcp6-client.h| 1 + 2 files changed, 69 insertions(+), 2

[systemd-devel] [PATCH 14/24] sd-dhcp6-lease: Add DHCPv6 lease handling

2014-06-13 Thread Patrik Flykt
Create a structure describing a DHCPv6 lease. Add internal functions for creating a new lease and accessing the server ID, preference and IAID. Provide functions for clearing addresses and associated timers. External users are initially given only the capabilities of referencing and unreferencing

[systemd-devel] [PATCH 11/24] sd-dhcp6-client: Add functions to bind to DHCPv6 UDP socket

2014-06-13 Thread Patrik Flykt
Add a function that creates a UDP socket bound to the given interface and optionally to an IPv6 address. Add another function that will send the DHCPv6 UDP packet to its destination. Using IPV6_PKTINFO in setsockopt to bind the IPv6 socket to an interface is documented in section 4. of RFC 3542,

[systemd-devel] [PATCH 09/24] sd-dhcp6-client: Add DHCPv6 client Solicitation timeout handling

2014-06-13 Thread Patrik Flykt
Add the core of DHCPv6 client message retransmission and upper bound timer and message count handling according to RFC 3315 Secions 7.1.2 and 14. Omit the DHCPv6 initial delay; for now it is assumed that systemd-networkd will provide decent startup randomization that will desynchronize the

[systemd-devel] [PATCH 10/24] sd-dhcp6-client: Add basic DHCPv6 option handling

2014-06-13 Thread Patrik Flykt
Add option appending and parsing. DHCPv6 options are not aligned, thus the option handling code must be able to handle options starting at any byte boundary. Add a test case for the basic option handling. --- Makefile.am| 4 +-

[systemd-devel] [PATCH 16/24] sd-dhcp6-client: Receive and parse Advertise messages

2014-06-13 Thread Patrik Flykt
When receiving DHCPv6 messages, discard the ones that are not meant for DHCPv6 clients and verify the transaction id. Once that is done, process the Advertise message and select the Advertise with the highest preference. Create a separate function for lease information parsing so that it can be

[systemd-devel] [PATCH 20/24] sd-dhcp6-client: Add Request message sending

2014-06-13 Thread Patrik Flykt
As described in RFC 3315, Section 17.1.2, a client has to wait until the first timeout has elapsed before it is allowed to request IPv6 addresses from the DHCPv6 server. This is indicated by a non-NULL lease and a non-zero resend count. Should the Advertisement contain a preference value of 255 or

[systemd-devel] [PATCH 13/24] sd-dhcp6-client: Add RA and DHCPv6 Solicit test case

2014-06-13 Thread Patrik Flykt
Copy Router Advertisement functions and data from the previous test case and verify the created Solicit message. The test will take some non-trivial time to run due to the DHCPv6 initial delay. --- Makefile.am| 1 + src/libsystemd-network/test-dhcp6-client.c |

[systemd-devel] [PATCH 21/24] sd-dhcp6-client: Add Advertise sending for test cases

2014-06-13 Thread Patrik Flykt
Enhance the test case by replying with an Advertise message to the client. Copy the transaction id, IAID and DUID from the Solicit message. Verify the Request message created by the DHCPv6 client implementation and move the main loop exit to the end of the Request message verification. Provide

[systemd-devel] [PATCH 22/24] sd-dhcp6-client: Receive and parse a reply and set T1 and T2 timers

2014-06-13 Thread Patrik Flykt
Receive and parse a Reply from the server. Set up T1 and T2 timers and notify the library user of an acquired DHCPv6 lease. --- src/libsystemd-network/dhcp6-protocol.h | 1 + src/libsystemd-network/sd-dhcp6-client.c | 145 +++ src/systemd/sd-dhcp6-client.h

[systemd-devel] [PATCH 15/24] sd-dhcp6-client: Add IA Address option parsing

2014-06-13 Thread Patrik Flykt
Add functionality to parse DHCPv6 Identity Association for Non-temporary (IA_NA) and Temporary Addresses (IA_TA) options. Both of them contain one or more IA Address (IAADDR) options and optinally a status code option. Only the IA_NA option contains lease lifetimes. See RFC 3315, sections 22.4.,

[systemd-devel] [PATCH 06/24] network-internal: split out net_get_name()

2014-06-13 Thread Patrik Flykt
From: Tom Gundersen t...@jklm.no --- src/libsystemd-network/network-internal.c | 26 +++--- src/libsystemd-network/network-internal.h | 1 + 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/src/libsystemd-network/network-internal.c

[systemd-devel] [PATCH 12/24] sd-dhcp6-client: Add DHCPv6 Solicit message creation and sending

2014-06-13 Thread Patrik Flykt
Implement the initial functionality used for creating a DHCPv6 Solicit message containing the needed options and send it to the DHCPv6 broadcast address. Increase the sent message count and ensure that the Solicit Initial Retransmission Time is strictly greater than the Solicitation IRT as

[systemd-devel] [PATCH 07/24] sd-dhcp6-client: Add DHCPv6 IAID functionality

2014-06-13 Thread Patrik Flykt
Create structures describing Identity Association IDentifiers and IPv6 lease addresses. [tomegun: initialize the IAID when client is started. Base this off of the predictable udev names, if available, as these satisfy the requirement of the IAID, and base it off the mac addres otherwise, as that

[systemd-devel] [PATCH 24/24] networkd: Add initial DHCPv6 support

2014-06-13 Thread Patrik Flykt
Enable DHCPv6 support by creating a DHCPv6 boolean in the Network section. Add necessary dhcp6 structures and initial function calls. --- src/network/networkd-link.c | 75 src/network/networkd-network-gperf.gperf | 1 + src/network/networkd.h

[systemd-devel] [PATCH 17/24] sd-dhcp6-lease: Add functions for accessing lease and addresses

2014-06-13 Thread Patrik Flykt
Add support functions for accessing the current client lease as well as iterating over the addresses and get their preferred and valid lifetimes. --- src/libsystemd-network/dhcp6-lease-internal.h | 2 ++ src/libsystemd-network/sd-dhcp6-client.c | 12 +

[systemd-devel] [PATCH 19/24] sd-dhcp6-client: Update start function to take a state

2014-06-13 Thread Patrik Flykt
Updated the start function so that the client state can be conveniently changed with the previous message resend timers cleared. On initial startup also create and bind to the UDP socket. --- src/libsystemd-network/sd-dhcp6-client.c | 62 +--- 1 file changed, 42

[systemd-devel] [PATCH 02/24] sd-dhcp6-client: Add Router Solicitation and Advertisement support

2014-06-13 Thread Patrik Flykt
Provide functions to bind the ICMPv6 socket to the approriate interface and set multicast sending and receiving according to RFC 3493, section 5.2. and RFC 3542, sections 3. and 3.3. Filter out all ICMPv6 messages except Router Advertisements for the socket in question according to RFC 3542,

[systemd-devel] [PATCH 00/24] Initial DHCPv6 client support

2014-06-13 Thread Patrik Flykt
Hi, This patch set provides initial DHCPv6 client support for systemd-networkd. It adds support for ICMPv6 Router Solicitation sending and Router Advertisment receiving and the very basic Solicit, Advertise, Request and Reply message transactions. Networkd is able to start DHCPv6

[systemd-devel] [PATCH 08/24] sd-dhcp6-client: Add basic DHCPv6 test cases

2014-06-13 Thread Patrik Flykt
Add test cases for basic DHCPv6 client handling, e.g. setting interface index, mac address and attaching event loop. --- Makefile.am| 13 - src/libsystemd-network/test-dhcp6-client.c | 76 ++ 2 files changed, 88 insertions(+), 1

[systemd-devel] [PATCH 05/24] sd-dhcp6-client: Initialize DUID

2014-06-13 Thread Patrik Flykt
From: Tom Gundersen t...@jklm.no Initialize DHCP Unique Identifier when creating the client. The DUID is generated based on the machine-id, which satisfies all the requirements of what an DUID should be. The DUID type is DUID-EN. Based on patch by Patrik Flykt. ---

[systemd-devel] [PATCH 23/24] sd-dhcp6-client: Add reply sending for test

2014-06-13 Thread Patrik Flykt
Enhance the test case by generating a Reply. With a properly formed Reply the callback function will be called and the additional earlier event loop exit can now be removed. --- src/libsystemd-network/test-dhcp6-client.c | 45 ++ 1 file changed, 40 insertions(+), 5

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Cristian Rodríguez
El 13/06/14 05:19, Jay D Bhatt escribió: Thanks. I surely forgot to attach log. Now you can find it attached. Nope, there is no attached log in your message. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] [PATCH 01/11] Ensure that systemd-sysctl.service is applied after modules are loaded

2014-06-13 Thread Werner Fink
From: Frederic Crozat fcro...@suse.com --- units/systemd-sysctl.service.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git units/systemd-sysctl.service.in units/systemd-sysctl.service.in index 5baf22c..c4bc0da 100644 --- units/systemd-sysctl.service.in +++

[systemd-devel] [PATCH 02/11] Use valid symlink for serial /dev/3270/tty1 in systemd-getty-generator

2014-06-13 Thread Werner Fink
Otherwise the add_symlink() function tries to make directories for each slash even for the slash after the @ symbol in the final link name. --- src/getty-generator/getty-generator.c |9 + 1 file changed, 9 insertions(+) diff --git src/getty-generator/getty-generator.c

[systemd-devel] [PATCH 05/11] After emergency service had been started any incoming traffic on syslog.socket

2014-06-13 Thread Werner Fink
From: arvidj...@gmail.com will terminate emergency.service due to implicit dependencies on basic.target and therefore sysinit.target which in turn conflict with emergency.target. --- units/emergency.service.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[systemd-devel] [PATCH 08/11] Avoid abort due timeout at user service

2014-06-13 Thread Werner Fink
It was seen only once, nevertheless this change does avoid the assert on s-user-slice in session_start_scope() --- src/login/logind-session.c |6 ++ 1 file changed, 6 insertions(+) diff --git src/login/logind-session.c src/login/logind-session.c index fdeacb1..86ce418 100644 ---

[systemd-devel] [PATCH 09/11] Avoid conflict between su shell and agetty on the same console

2014-06-13 Thread Werner Fink
Otherwise this leads to a poweroff at boot time. --- units/console-shell.service.m4.in |3 --- 1 file changed, 3 deletions(-) diff --git units/console-shell.service.m4.in units/console-shell.service.m4.in index 3f4904a..295dc8d 100644 --- units/console-shell.service.m4.in +++

[systemd-devel] [PATCH 11/11] Make redirections work with the bash command completions

2014-06-13 Thread Werner Fink
--- shell-completion/bash/hostnamectl |6 +- shell-completion/bash/journalctl |6 +- shell-completion/bash/kernel-install | 13 - shell-completion/bash/localectl |6 +- shell-completion/bash/loginctl|6 +-

[systemd-devel] [PATCH 03/11] Ensure that ask-password-wall starts after getty.target

2014-06-13 Thread Werner Fink
From: Frederic Crozat fcro...@suse.com --- units/systemd-ask-password-wall.service.in |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git units/systemd-ask-password-wall.service.in units/systemd-ask-password-wall.service.in index 0eaa274..179b010 100644 ---

[systemd-devel] [PATCH 06/11] There is no ANSI support on common 3215 consoles

2014-06-13 Thread Werner Fink
Therefore strip off the ANSI escape sequences for 3215 consoles but support 3270 consoles if found. --- src/core/manager.c | 24 src/shared/util.c | 80 +--- src/shared/util.h |1 + 3 files changed, 96 insertions(+), 9

[systemd-devel] [PATCH 04/11] Allow multiple sulogin to be started

2014-06-13 Thread Werner Fink
From: Frederic Crozat fcro...@suse.com Otherwise any agetty on the devices of the system console will conflict with sulogin and its input. --- units/getty@.service.m4|1 + units/rescue.target|1 + units/serial-getty@.service.m4 |1 + 3 files changed, 3

[systemd-devel] [PATCH 10/11] Avoid doubling the efforts for /var/log/journal

2014-06-13 Thread Werner Fink
That is: set NOATIME, NOCOW, and NOCOMP for the journal directory --- src/journal/journald-server.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git src/journal/journald-server.c src/journal/journald-server.c index eda5dcf..37d6dc3 100644 ---

Re: [systemd-devel] systemd not initializing

2014-06-13 Thread Reindl Harald
Am 13.06.2014 16:35, schrieb Cristian Rodríguez: El 13/06/14 05:19, Jay D Bhatt escribió: Thanks. I surely forgot to attach log. Now you can find it attached. Nope, there is no attached log in your message because he sent the attachment one message before and found it useful to drop

Re: [systemd-devel] [RFC] sd-dhcp-server: add a basic DHCPv4 server library

2014-06-13 Thread Tom Gundersen
On Mon, May 26, 2014 at 9:39 PM, Tom Gundersen t...@jklm.no wrote: This is the beginning of DHCPv4 server support in networkd. The main usecase I'm targeting is to be able to hand out DHCP leases to containers on the local machine. I have attempted to keep the library as minimal as possible

Re: [systemd-devel] [PATCH 07/11] Support init=/bin/bash on the kernel command line

2014-06-13 Thread Tom Gundersen
On Fri, Jun 13, 2014 at 4:41 PM, Werner Fink wer...@suse.de wrote: From: Ruediger Oertel r...@suse.de Process 1 (aka init) needs to be started with an empty signal mask. That includes the process 1 that's started after the initrd is finished. When the initrd is using systemd (as it does with

Re: [systemd-devel] [PATCH 01/11] Ensure that systemd-sysctl.service is applied after modules are loaded

2014-06-13 Thread Tom Gundersen
On Fri, Jun 13, 2014 at 4:41 PM, Werner Fink wer...@suse.de wrote: From: Frederic Crozat fcro...@suse.com Hm, this would not help at all for modules loaded on-demand (which are most of them). What is the problem being solved here? --- units/systemd-sysctl.service.in |2 +- 1 file

Re: [systemd-devel] [PATCH 11/11] Make redirections work with the bash command completions

2014-06-13 Thread Ran Benita
From a cursory look, the bash-completion package deals with this issue in a more systematic way. See _init_completion() in /usr/share/bash-completion/bash_completion. Maybe it's worthwhile to (conditionally?) use that if possible. Ran On Fri, Jun 13, 2014 at 04:41:10PM +0200, Werner Fink wrote:

Re: [systemd-devel] [PATCH 00/24] Initial DHCPv6 client support

2014-06-13 Thread Dan Williams
On Fri, 2014-06-13 at 16:44 +0300, Patrik Flykt wrote: Hi, This patch set provides initial DHCPv6 client support for systemd-networkd. It adds support for ICMPv6 Router Solicitation sending and Router Advertisment receiving and the very basic Solicit, Advertise, Request and Reply

Re: [systemd-devel] new user/group population on bootup

2014-06-13 Thread Lennart Poettering
On Fri, 13.06.14 05:36, Colin Walters (walt...@verbum.org) wrote: Hi, I had a quick look at the new: http://cgit.freedesktop.org/systemd/systemd/commit/?id=1b99214789101976d6bbf75c351279584b071998 and followon commits. My high level takeaway right now is that this looks OK for nspawn

Re: [systemd-devel] [networkd] v213 log messages

2014-06-13 Thread Tom Gundersen
On Wed, Jun 4, 2014 at 6:53 AM, Mark Oteiza mvote...@udel.edu wrote: It seems networkd has acquired some right-justification in its logging. Why? This is very strange. I moved this to be left-aligned now. Cheers, Tom $ journalctl -b -u systemd-networkd -- Logs begin at Sun 2014-03-09

Re: [systemd-devel] [PATCH 00/24] Initial DHCPv6 client support

2014-06-13 Thread Tom Gundersen
On Fri, Jun 13, 2014 at 6:26 PM, Dan Williams d...@redhat.com wrote: On Fri, 2014-06-13 at 16:44 +0300, Patrik Flykt wrote: Hi, This patch set provides initial DHCPv6 client support for systemd-networkd. It adds support for ICMPv6 Router Solicitation sending and Router Advertisment

[systemd-devel] [PATCH 4/4] udev: fix invalid free() in enable_name_policy()

2014-06-13 Thread Andreas Henriksson
static bool enable_name_policy(...) in ./src/udev/net/link-config.c calls proc_cmdline(...) to get line initialized, but proc_cmdline(...) does not guarantee that atleast when both conditions (detect_container(NULL) 0) and read_full_file(...) returned 0. Signed-off-by: Andreas Henriksson

[systemd-devel] [PATCH 2/4] core: fix invalid free() in killall()

2014-06-13 Thread Andreas Henriksson
static int killall() in ./src/core/killall.c tries to get s initialized by calling get_process_comm(...) which calls read_one_line_file(...) which if it fails will mean it is left uninitialized. It is then used in argument to strna(s) call where it is dereferenced(!), in addition to nothing

[systemd-devel] [PATCH 1/4] install: fix invalid free() in unit_file_mask()

2014-06-13 Thread Andreas Henriksson
int unit_file_mask(...) in ./src/shared/install.c calls get_config_path(...) which can in 4 error cases return without setting ret, and thus prefix can be uninitialized when unit_file_mask(...) finishes (which it does directly after the error is returned from get_config_path(...)). Signed-off-by:

[systemd-devel] [PATCH 3/4] sd-dhcp-client: fix invalid free() in client_send_request()

2014-06-13 Thread Andreas Henriksson
static int client_send_request(...) in ./src/libsystemd-network/sd-dhcp-client.c tries to initialize request by calling client_message_init(...), which has atleast 5 error cases where it can return without that happening. This leads to the function finishing without request being initialized.

[systemd-devel] [PATCH 0/4] looking at _cleanup_free_ usage

2014-06-13 Thread Andreas Henriksson
Hello all! I was recently bitten by a problem which I found the solution to in http://lists.freedesktop.org/archives/systemd-commits/2013-October/004421.html The second patch there made me curious to look at more occurances. I do not have prior experience with _cleanup_free_ but as I understand

Re: [systemd-devel] new user/group population on bootup

2014-06-13 Thread Lennart Poettering
On Fri, 13.06.14 06:37, Colin Walters (walt...@verbum.org) wrote: On Fri, Jun 13, 2014, at 05:36 AM, Colin Walters wrote: My high level takeaway right now is that this looks OK for nspawn containers, but it's not clear to me it's viable or right for the host OS, at least for general

[systemd-devel] [hybrid-sleep] hibernation delay

2014-06-13 Thread Tom Sherpen
Hi, I am wondering if hybrid-sleep could support a hibernation delay, similar to what is found in pm-utils [1] Thus, you would be able to first suspend, with the machine going automatically into hibernation after a certain amount of time. Is support for such a hibernation delay planned

Re: [systemd-devel] [PATCH 0/4] looking at _cleanup_free_ usage

2014-06-13 Thread Tom Gundersen
On Fri, Jun 13, 2014 at 6:48 PM, Andreas Henriksson andr...@fatal.se wrote: Hello all! Hi Andreas, I was recently bitten by a problem which I found the solution to in http://lists.freedesktop.org/archives/systemd-commits/2013-October/004421.html The second patch there made me curious to

Re: [systemd-devel] [PATCH 00/24] Initial DHCPv6 client support

2014-06-13 Thread Dan Williams
On Fri, 2014-06-13 at 18:38 +0200, Tom Gundersen wrote: On Fri, Jun 13, 2014 at 6:26 PM, Dan Williams d...@redhat.com wrote: On Fri, 2014-06-13 at 16:44 +0300, Patrik Flykt wrote: Hi, This patch set provides initial DHCPv6 client support for systemd-networkd. It adds support for

Re: [systemd-devel] [PATCH 00/24] Initial DHCPv6 client support

2014-06-13 Thread Tom Gundersen
On Fri, Jun 13, 2014 at 7:10 PM, Dan Williams d...@redhat.com wrote: On Fri, 2014-06-13 at 18:38 +0200, Tom Gundersen wrote: On Fri, Jun 13, 2014 at 6:26 PM, Dan Williams d...@redhat.com wrote: On Fri, 2014-06-13 at 16:44 +0300, Patrik Flykt wrote: Hi, This patch set provides

Re: [systemd-devel] [PATCH 02/24] sd-dhcp6-client: Add Router Solicitation and Advertisement support

2014-06-13 Thread Dan Williams
On Fri, 2014-06-13 at 16:44 +0300, Patrik Flykt wrote: Provide functions to bind the ICMPv6 socket to the approriate interface and set multicast sending and receiving according to RFC 3493, section 5.2. and RFC 3542, sections 3. and 3.3. Filter out all ICMPv6 messages except Router

Re: [systemd-devel] [PATCH 0/4] looking at _cleanup_free_ usage

2014-06-13 Thread Andreas Henriksson
Hello Tom Gundersen. Thanks for all your interesting feedback and your quick review! For anyone interested in following up with more work on the same topic here, I'll add that I have not looked at any files named test* or files under src/test/. I have also not looked at cases which did not

[systemd-devel] [PATCH] sd-dhcp-server: remove unused cleanup function

2014-06-13 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com Removes _cleanup_dhcp_lease_free_. While the automatic cleanup functions are great to have this one is never used and causes a warning in clang. --- src/libsystemd-network/sd-dhcp-server.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [systemd-devel] new user/group population on bootup

2014-06-13 Thread Michael Marineau
On Fri, Jun 13, 2014 at 6:37 AM, Colin Walters walt...@verbum.org wrote: On Fri, Jun 13, 2014, at 05:36 AM, Colin Walters wrote: My high level takeaway right now is that this looks OK for nspawn containers, but it's not clear to me it's viable or right for the host OS, at least for general

[systemd-devel] [PATCH] networkd: link - check returned value from set_lease_pool

2014-06-13 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com --- src/network/networkd-link.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c index 81872f7..baa0756 100644 --- a/src/network/networkd-link.c +++ b/src/network/networkd-link.c

Re: [systemd-devel] [PATCH] networkd: link - check returned value from set_lease_pool

2014-06-13 Thread Tom Gundersen
Thanks! Please push. On Fri, Jun 13, 2014 at 10:01 PM, Thomas H.P. Andersen pho...@gmail.com wrote: From: Thomas Hindoe Paaboel Andersen pho...@gmail.com --- src/network/networkd-link.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/network/networkd-link.c

[systemd-devel] [PATCH] dd-dhcp-server: fix a leak

2014-06-13 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com We must use free instead of dhcp_lease_free here to avoid freeing client_id.data. --- src/libsystemd-network/sd-dhcp-server.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libsystemd-network/sd-dhcp-server.c

Re: [systemd-devel] [PATCH] Fix spelling mistake, scirpt -- script

2014-06-13 Thread Thomas H.P. Andersen
On Thu, Jun 12, 2014 at 5:41 PM, Colin King colin.k...@canonical.com wrote: From: Colin Ian King colin.k...@canonical.com Signed-off-by: Colin Ian King colin.k...@canonical.com --- src/sysv-generator/sysv-generator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[systemd-devel] mdns support to networkd

2014-06-13 Thread Vasiliy Tolstov
As i see avahi development stopped. Does mdns support goes to networkd or no? Now i have a problem with avahim that i can't publish address via avahi-publish-address its not respond after connecting to avahi daemon. =( -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru

[systemd-devel] [PATCH] networkd: link - avoid null pointer deref

2014-06-13 Thread Thomas H.P. Andersen
From: Thomas Hindoe Paaboel Andersen pho...@gmail.com --- src/network/networkd-link.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c index baa0756..39c8329 100644 --- a/src/network/networkd-link.c +++

Re: [systemd-devel] R: Re: Slow startup of systemd-journal on BTRFS

2014-06-13 Thread Goffredo Baroncelli
Hi Dave On 06/13/2014 01:24 AM, Dave Chinner wrote: On Thu, Jun 12, 2014 at 12:37:13PM +, Duncan wrote: Goffredo Baroncelli kreij...@libero.it posted on Thu, 12 Jun 2014 13:13:26 +0200 as excerpted: systemd has a very stupid journal write pattern. It checks if there is space in the file

Re: [systemd-devel] [PATCH 0/4] looking at _cleanup_free_ usage

2014-06-13 Thread Thomas H.P. Andersen
On Fri, Jun 13, 2014 at 7:04 PM, Tom Gundersen t...@jklm.no wrote: On Fri, Jun 13, 2014 at 6:48 PM, Andreas Henriksson andr...@fatal.se wrote: Hello all! Hi Andreas, I was recently bitten by a problem which I found the solution to in