[systemd-devel] [PATCH 04/11] tmpfiles: attach an array of items to each path

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
Zbigniew Jędrzejewski-Szmek systemd is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by @@ -113,6 +114,12 @@ typedef struct Item { bool done:1; } Item; +typedef struct ItemArray { +Item *items; +

[systemd-devel] [PATCH 01/11] tmpfiles: simplification

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
Certain conditions were checked more than once. Warning message is improved. --- This is a sprawling set of changes to add ACL support to tmpfiles. The patches are not entirely clean, you can see how my understanding of the problem evolved :) Comments, suggestions for improved syntax, etc., very m

[systemd-devel] [PATCH 02/11] tmpfiles: detect all combinations of + and !

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
The same algorithm as with - and @ in ExecStart= is used. --- src/tmpfiles/tmpfiles.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 91ae62da45..8811f27482 100644 --- a/src/tmpfiles/tmpfil

[systemd-devel] [PATCH 03/11] tmpfiles: make sure not to concatenate non-absolute path

2015-01-18 Thread Zbigniew Jędrzejewski-Szmek
If the path is absolute was only checked later. Also do not check if path if absolute if we just specified it starting with a slash. --- src/tmpfiles/tmpfiles.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index 8811f

Re: [systemd-devel] Making udev emit a signal when it is done loading modules

2015-01-17 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 17, 2015 at 09:44:00AM +0100, Hans de Goede wrote: > We would like > udev to emit a signal (ABI to be discussed) when it is done > trying to load modules for everything which was already enumerated > when it starts, iow when there are no new device events pending > anymore when udev doe

Re: [systemd-devel] Readahead collect - root filesystem only?

2015-01-15 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 15, 2015 at 02:31:22PM +0100, Reindl Harald wrote: > > Am 15.01.2015 um 14:40 schrieb Nikolai Zhubr: > >15.01.2015 16:07, Cristian Rodríguez: > >>The readahead collector is no longer included in systemd. > > > >Hm. It is still there in not-very-old opensuse 13.2 ... > >Anyway. Where ha

Re: [systemd-devel] [RFC] hwdb: add MOUSE_WHEEL_CLICK_ANGLE as property

2015-01-14 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 15, 2015 at 07:21:31AM +1000, Peter Hutterer wrote: > On Wed, Jan 14, 2015 at 01:07:40PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > On Wed, Jan 14, 2015 at 03:57:03PM +1000, Peter Hutterer wrote: > > > On Mon, Jan 12, 2015 at 09:48:55AM +1000, Peter Hutterer wrote:

Re: [systemd-devel] Should a unit be able to start, while its OnFailure unit is active?

2015-01-14 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 14, 2015 at 04:24:15PM +0100, jean-pierre.bog...@continental-corporation.com wrote: > Hi all, > > I'd like to have your opinion on the following problem: > > In case a unit fails, we are using an OnFailure unit to > handle the error (e. g. reset the config of the failed > unit) an

Re: [systemd-devel] [RFC] hwdb: add MOUSE_WHEEL_CLICK_ANGLE as property

2015-01-14 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 14, 2015 at 03:57:03PM +1000, Peter Hutterer wrote: > On Mon, Jan 12, 2015 at 09:48:55AM +1000, Peter Hutterer wrote: > > Most mice have a wheel click angle of 15 degrees, i.e. 24 clicks per full > > wheel rotation. Some mice, like the Logitech M325 have a larger angle. To > > allow use

Re: [systemd-devel] [PATCH 1/2] machinectl: use GNU basename, not the XPG version

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jan 11, 2015 at 02:50:15PM -0300, Cristian Rodríguez wrote: > --- > src/machine/machinectl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/machine/machinectl.c b/src/machine/machinectl.c > index 749170e..980fba1 100644 > --- a/src/machine/machinectl.c > +++

Re: [systemd-devel] make install busted in git

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 03:16:52PM +0100, Jan Engelhardt wrote: > > On Tuesday 2015-01-13 15:07, Mike Gilbert wrote: > >> > >> /usr/bin/xsltproc -o man/bootup.7 --nonet --xinclude --stringparam > >> man.output.quietly 1 --stringparam funcsynopsis.style ansi > >> --stringparam man.authors.section

Re: [systemd-devel] [PATCH] TODO: DHCPv6 Information Request has been implemented

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 03:10:35PM +0200, Patrik Flykt wrote: > On Tue, 2015-01-13 at 14:32 +0200, Patrik Flykt wrote: > > Just a trivial TODO update, I'll push it right away. > > Patch applied. > > Patrik Yeah, there's no need to sent this to the mailing list. It is unlikely to be wrong, a

Re: [systemd-devel] [PATCH 00/11] DHCPv6 address assignment

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:10PM +0200, Patrik Flykt wrote: > > Hi, > > Here is a patch set covering on-link prefix detection and using the prefix > length information when setting DHCPv6 addresses. > > To be able to have a correct prefix for the IPv6 adresses, the prefixes > need to be

Re: [systemd-devel] [PATCH 11/11] sd_dhcp6_lease: Support DNS and NTP options

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:21PM +0200, Patrik Flykt wrote: > Store arrays of found DNS and NTP IPv6 addresses and strings of DNS > search domains and NTP host names as specified in RFC 3646 and RFC > 5908. > --- > src/libsystemd-network/dhcp6-internal.h | 3 + > src/libsystemd-network/d

Re: [systemd-devel] [PATCH 10/11] networkd-dhcp6: Assign DHCPv6 addresses and prefix lengths

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:20PM +0200, Patrik Flykt wrote: > Once IPv6 addresses have been acquired, assign these to the interface > with the prefix lengths taken from the ICMPv6 Router Advertisement > handling code. The preferred and valid IPv6 address lifetimes are > handed to the kernel which

Re: [systemd-devel] [PATCH 07/11] sd-icmp6-nd: Parse ICMPv6 prefix information

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:17PM +0200, Patrik Flykt wrote: > Save each new onlink IPv6 prefix and attach an expiry timer to it. > If the prefixes overlap, take the shorter prefix and write a debug > message about the event. Once the prefix is resent in a Router > Advertisement, update the timer.

Re: [systemd-devel] [PATCH 06/11] test-icmp6-rs: Add trivial test case for a MTU that is not present

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:16PM +0200, Patrik Flykt wrote: > --- > src/libsystemd-network/test-icmp6-rs.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/src/libsystemd-network/test-icmp6-rs.c > b/src/libsystemd-network/test-icmp6-rs.c > index be64d33.

Re: [systemd-devel] [PATCH 05/11] sd-icmp6-nd: Add helper function to get the IPv6 link MTU

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:15PM +0200, Patrik Flykt wrote: > Update MTU according to the latest value received. > --- > src/libsystemd-network/sd-icmp6-nd.c | 30 ++ > src/systemd/sd-icmp6-nd.h| 2 ++ > 2 files changed, 32 insertions(+) > > diff --git a

Re: [systemd-devel] [PATCH 03/11] sd-icmp6-nd: Update Router Advertisement handling

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:13PM +0200, Patrik Flykt wrote: > As the IPv6 prefixes are needed, update the ICMPv6 Router Advertisement > code to dynamically allocate a suitably sized buffer. Iterate through > the ICMPv6 options one by one returning error if the option length is > too big to fit th

Re: [systemd-devel] [PATCH 02/11] sd-dhcp6-lease: Revise address iteration functions

2015-01-13 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 13, 2015 at 02:02:12PM +0200, Patrik Flykt wrote: > Revise the address iteration functions so that one helper function > resets the iterator to the start of the address list while the > second one fetches addresses one by one. > > The test case is also updated. > --- > src/libsystemd-

Re: [systemd-devel] Wierd Segfault in sd_rtnl_message_unref (libnss_myhostname.so.2 by sshd )

2015-01-12 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 12, 2015 at 10:08:30PM +0100, Svenne Krap wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Hi. > > On Arch X64 using 218-1 (first packaging of 218) I have run into the > following wierd problem. > > When trying to connect to a ssh server running dualstack (both ipv4

Re: [systemd-devel] [PATCH] Add usernames as arguments to tmpfiles ignore directives.

2015-01-12 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 12, 2015 at 03:11:08PM +0100, Thomas Blume wrote: > On Donnerstag 2015-01-08 21:29, Zbigniew Jędrzejewski-Szmek wrote: > > >On Thu, Jan 08, 2015 at 01:37:57PM +0100, Thomas Blume wrote: > >>Currently, systemd can only ignore files specified by their path, duri

Re: [systemd-devel] [systemd-commits] src/core

2015-01-12 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 12, 2015 at 05:03:51AM -0800, Daniel Mack wrote: > src/core/mount.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > New commits: > commit 0c47569ac9eb365ebeb9342f47fb98d52bcc4704 > Author: Daniel Mack > Date: Mon Jan 12 13:46:39 2015 +0100 > > core/mount: use is

Re: [systemd-devel] [PATCH udev v5] udev: Add builtin/rule to export evdev information as udev properties

2015-01-11 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Jan 11, 2015 at 08:47:19PM +0100, Carlos Garnacho wrote: > This rule is only run on tablet/touchscreen devices, and extracts their size > in millimeters, as it can be found out through their struct input_absinfo. > > The first usecase is exporting device size from tablets/touchscreens. Thi

Re: [systemd-devel] Fw: [PATCH] systemd-nspawn bash autocompletion

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
Applied. On Thu, Jan 08, 2015 at 09:51:49PM +0100, Carlos Morata Castillo wrote: > -complete -F _systemd_nspawn systemd-nspawn > +complete -F _systemd_nspawn systemd_nspawn This looks like a typo. I skipped that part. Zbyszek ___ systemd-devel mailing

Re: [systemd-devel] [PATCH] man (5) machine-info: add hostnamed chassis type "embedded"

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 20, 2014 at 03:09:19PM +0100, Peter Mattern wrote: > man machine-info lacks hostnamed chassis type "embedded" as introduced in > 218. The following lines should fix this. > > --- > man/machine-info.xml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/man/ma

Re: [systemd-devel] [PATCH 1/2] test-verbs: add unit tests for verbs minilib

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Dec 20, 2014 at 03:31:21PM -0800, Filipe Brandenburger wrote: > Hi, > > On Sat, Dec 20, 2014 at 8:19 AM, Dave Reisner wrote: > > --- > > Makefile.am | 9 +- > > src/test/test-verbs.c | 78 > > +++ > > 2 files changed, 86 ins

Re: [systemd-devel] [PATCH] Add usernames as arguments to tmpfiles ignore directives.

2015-01-08 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 08, 2015 at 01:37:57PM +0100, Thomas Blume wrote: > Currently, systemd can only ignore files specified by their path, during > tmpdir cleanup. This patch adds the feature to give usernames as argument. > > During cleanup the file ownership is checked and files that match the > specifi

Re: [systemd-devel] [PATCH] sysv-generator: avoid wrong orderings for failing units

2015-01-07 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jan 07, 2015 at 01:44:17PM +0100, Michael Biebl wrote: > sysv-generator: initialize units before use to ensure correct > ordering > > The original loop called fix_order() on each service immediately after > loading it, but fix_order() would reference other units which were not > loaded ye

Re: [systemd-devel] [PATCH] gitignore: add another test

2015-01-06 Thread Zbigniew Jędrzejewski-Szmek
Already fixed by Lennart. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH v2] bootchart: ship a configuration that will boot without sysvinit compat

2015-01-06 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Dec 28, 2014 at 07:18:16PM +0100, Gabriel de Perthuis wrote: > Change the default through /etc/systemd/bootchart.conf. > Keep the /sbin/init default in the source code, in case > some users rely on that. No, as a rule, all files in /etc installed by systemd can only contain comments. Boot-w

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-01-06 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 11:15:47PM +0100, Jouke Witteveen wrote: > On Thu, Jan 1, 2015 at 7:15 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Tue, Dec 30, 2014 at 08:22:27PM +0100, Jouke Witteveen wrote: > >> --- > >> > >> This fixes #87251 > > &g

Re: [systemd-devel] systemd console messages (crippled)

2015-01-06 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 02:51:50PM +0300, Nikolai Zhubr wrote: > Hi people, > > I'm now fighting with opensuse 13.2 failing to mount some or all > disks at boot, obviously resulting in unusable system. This > distribution is systemd-based, hence I'm here. While I haven't yet > exactly understood m

Re: [systemd-devel] Relative links in tmpfiles.d/etc.conf

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 03, 2015 at 12:07:59PM +0100, Umut Tezduyar Lindskog wrote: > Hi, > > Our /etc is a sym link and due to that all the links created by > tmpfiles.d/etc.conf are wrong. Is there a reason why the links are > relative? They are relative so that if you're looking into a container (or a syst

Re: [systemd-devel] [PATCH] Clarify path escaping and reference systemd-escape

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 04:35:34PM -0500, Chris Atkinson wrote: > See Bug 87688 (https://bugs.freedesktop.org/show_bug.cgi?id=87688). > This patch adds more detail to the description of how path escaping > operates and provides a pointer to the systemd-escape program. Either > would serve to answer

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 03:28:09AM +0100, Lennart Poettering wrote: > On Mon, 05.01.15 16:03, Lennart Poettering (lenn...@poettering.net) wrote: > > > On Mon, 05.01.15 15:02, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > > What we can

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 06, 2015 at 12:01:35AM +0100, Michael Biebl wrote: > Hi, > > > 2015-01-05 14:35 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > > On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: > >> +link = strjoin(arg_dest, "/",

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 02:55:11PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > SO_PEERCRED apparently returns the euid/egid of the original > > process. The UNIX "saved" uid was invented precisely to allow > > temporarily lowering the euid and later on returning to

Re: [systemd-devel] rsync output is not captured in the journal

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 03:25:33PM +0100, Igor Bukanov wrote: > On 5 January 2015 at 15:08, Daniel J Walsh wrote: > > chcon -t bin_t /usr/bin/rsync, should stop SELinux from interfering, or > > set the rsync_client boolean. > > > > http://danwalsh.livejournal.com/61646.html > > Yes, that solved t

Re: [systemd-devel] [PATCH] machine: add reference to machine-dbus.h to Makefile.am

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 02, 2015 at 09:45:23AM -0800, Filipe Brandenburger wrote: > On Mon, Dec 29, 2014 at 3:22 PM, Filipe Brandenburger > wrote: > > Commit 003dffde2c1b93 ("machined: Move image discovery logic into > > src/shared, > > so that we can make use of it from nspawn") moved some definitions from

Re: [systemd-devel] [PATCH 1/4] path-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install.c and use it

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 05:08:07PM +0300, Ivan Shapovalov wrote: > --- > src/shared/install.c | 16 > src/shared/path-lookup.c | 16 > src/shared/path-lookup.h | 4 > src/systemctl/systemctl.c | 6 +- > 4 files changed, 21 insertions(+), 21 delet

Re: [systemd-devel] [PATCH 4/4] systemctl: unit_find_paths(): unify error handling in two code pathes

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
"two code paths". 1/4 and 4/4 are fine, but I think it's better to have them applied adjacent to the remaing two, so I leave them for now too. Zbyszek On Fri, Dec 19, 2014 at 05:08:10PM +0300, Ivan Shapovalov wrote: > --- > src/systemctl/systemctl.c | 63 > ++---

Re: [systemd-devel] [PATCH 3/4] systemctl: edit: further reword error messages

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 05:08:09PM +0300, Ivan Shapovalov wrote: > --- > src/systemctl/systemctl.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c > index 658793e..20c367c 100644 > --- a/src/sy

Re: [systemd-devel] [PATCH 2/4] systemctl: edit: improve error messages, report actual error for units which could not be loaded

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
This is a minor thing, but makes things easier, especially when using gitk or git format-patch: please keep the patch subject at around 80 characters (<=72 is best). I know we don't always to this, sometimes it just isn't possible, but in this case something like 'systemctl: report actual load err

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 02:24:35PM +0100, Tomasz Torcz wrote: > On Mon, Jan 05, 2015 at 02:12:45PM +0100, Lennart Poettering wrote: > > On Thu, 01.01.15 04:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > Sounds generally OK. > > >

Re: [systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 02:12:45PM +0100, Lennart Poettering wrote: > On Thu, 01.01.15 04:40, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > Sounds generally OK. > > > A disadvantage of the solution implemented here, otoh, is that both > > systemd and journa

Re: [systemd-devel] [PATCH] sysv-generator: handle Provides: for non-virtual facility names

2015-01-05 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 05, 2015 at 10:30:11AM +0100, Michael Biebl wrote: > See attached patch. > > The commit message reads: > > The list of provided facility names as specified via Provides: in the > LSB header was originally implemented by adding those facilities to the > Names= property via unit_add_nam

Re: [systemd-devel] [PATCH 1/4] path-lookup, systemctl: export lookup_paths_init_from_scope() from shared/install.c and use it

2015-01-02 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Jan 03, 2015 at 02:10:18AM +0300, Ivan Shapovalov wrote: > On Friday 26 December 2014 at 00:27:16, Ivan Shapovalov wrote: > > On Friday 19 December 2014 at 17:08:07, Ivan Shapovalov wrote: > > > --- > > > src/shared/install.c | 16 > > > src/shared/path-

Re: [systemd-devel] [PATCH] util: Fix signedness error in lines(), match implementations

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 03:05:15PM -0500, Colin Walters wrote: > > From a74befe02b8a8141a2ffc5613372ef8082a2c6d2 Mon Sep 17 00:00:00 2001 > From: Colin Walters > Date: Thu, 1 Jan 2015 14:57:08 -0500 > Subject: [PATCH] util: Fix signedness error in lines(), match implementations > > Regression i

Re: [systemd-devel] [PATCH] Type of mount(2) flags is unsigned long

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 07:40:07PM +0200, Topi Miettinen wrote: > Signed-off-by: Topi Miettinen We don't use signed-off-by. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinf

Re: [systemd-devel] [PATCH] improve help/usage for some more programs

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 06:11:22PM +0100, Robert Milasan wrote: > From 9cd266590dbf1d22b1a7fc184ecc8c3868f280f9 Mon Sep 17 00:00:00 2001 > From: Robert Milasan > Date: Wed, 31 Dec 2014 13:17:23 +0100 > Subject: [PATCH] improve help/usage for some more programs Applied. Zbyszek ___

Re: [systemd-devel] [PATCH] po: update French translation

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 06:02:54PM +0100, Sylvain Plantefève wrote: > --- > po/fr.po | 33 - > 1 file changed, 16 insertions(+), 17 deletions(-) Applied. The strings changed in the meanwhile. I fixed up the po file, so everything should be fine, but please check.

Re: [systemd-devel] [PATCH] Update Russian translation

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 09:42:47PM +0300, Sergey Ptashnick wrote: > By analogy with commit 4038d7502f. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] systemd coredumps

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 01:13:30PM -0500, Dave Reisner wrote: > On Thu, Jan 01, 2015 at 07:05:04PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > On Thu, Jan 01, 2015 at 05:57:43PM -, Markus Moeller wrote: > > > Hi, > > > > > > How can I find out why sys

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 30, 2014 at 08:22:27PM +0100, Jouke Witteveen wrote: > --- > > This fixes #87251 This is actually important information that should be included in the commit message (i.e. above not below "---"). We usually include the full url, since we also use distribution bug trackers and having t

Re: [systemd-devel] systemd coredumps

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 05:57:43PM -, Markus Moeller wrote: > Hi, > > How can I find out why systemd core dumps and requires system > reboot :-( ? > > I just did > > # systemctl status sockd-1.5.0 > Failed to issue method call: Did not receive a reply. Possible > causes include: the remote

Re: [systemd-devel] [PATCH] improve help/usage for some more programs

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 01:18:55PM +0100, Robert Milasan wrote: > --- > src/udev/ata_id/ata_id.c | 4 ++-- > src/udev/cdrom_id/cdrom_id.c | 10 +- > src/udev/collect/collect.c | 10 ++ > src/udev/scsi_id/scsi_id.c | 2 +- > src/udev/v4l_id/v4l_id.c | 2 +- > 5 files

Re: [systemd-devel] [PATCH 2/2] libsystemd-network : Fix resource leaks in test-lldp

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 04:16:03PM +0200, Philippe De Swert wrote: > Fix some resources leaks in test-lldp found with coverity: > CID#1261388, CID#1261385, CID#1261383 > --- > src/libsystemd-network/test-lldp.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/li

Re: [systemd-devel] [PATCH 1/2] machine: machinectl, remove some dead code

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 04:16:02PM +0200, Philippe De Swert wrote: > The variable r is already checked one time before and the same error returned. > So the second check is unneeded. > --- > src/machine/machinectl.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/machine/machinect

Re: [systemd-devel] [PATCH] Fix install location of systemd.pc

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 08:44:35PM +0100, Michael Biebl wrote: > Am 31.12.2014 12:54 schrieb "Simon Peeters" : > > > > 2014-12-31 11:12 GMT+00:00 Martin Pitt : > > > Simon Peeters [2014-12-29 15:01 +]: > > >> I have no preference between the 2, but moving the pc file to > > >> $libdir/pkgconfig

Re: [systemd-devel] [PATCH v2] Makefile.am : Fix build issue with machines.target

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 06:02:12PM +0200, Philippe De Swert wrote: > When doing "make clean" the unit/machines.target file gets deleted. > This causes a build error later on when trying to rebuild systemd. > V2: The file probably belongs to dist_systemunit_DATA > --- Applied. Zbyszek > Makefile.

Re: [systemd-devel] [PATCH] Clarify effect when both calendar day and date are listed in timer

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 09:59:16PM -0500, Chris Atkinson wrote: > See bug 87859 (https://bugs.freedesktop.org/show_bug.cgi?id=87859). Bug > reporter found the language describing the effect of specifying both a > day and date unclear; hopefully the attached patch will clarify and > allow the bug to

[systemd-devel] [RFC PATCH] journal: pass uid.gid in the stream header

2014-12-31 Thread Zbigniew Jędrzejewski-Szmek
When systemd starts a service, it first opens /run/systemd/journal/stdout socket, and only later switches to the right user.group (if they are specified). Later on, journald looks at the credentials, and sees root.root, because credentials are stored at the time the socket is opened. As a result, a

Re: [systemd-devel] [systemd-commits] man/sd_bus_negotiate_fds.xml man/sd_event_add_child.xml man/systemd.link.xml man/systemd-machine-id-commit.service.xml man/systemd-nspawn.xml man/udev.xml NEWS sr

2014-12-31 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 01:39:19PM +0100, David Herrmann wrote: > Hi > > On Wed, Dec 31, 2014 at 2:08 AM, Zbigniew Jędrzejewski-Szmek > wrote: > > NEWS|2 +- > > TODO

Re: [systemd-devel] [PATCH 1/2] typofixes - https://github.com/vlajos/misspell_fixer

2014-12-30 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 30, 2014 at 11:50:06AM +, Veres Lajos wrote: > Hi, > > I reviewed it one time, but it seems I wasn't enough accurate... > Should I change the patch and resend it? > > Best regards, > Lajos > > On Mon, 29 Dec 2014, J Callahan wrote: > > > On 29/12/2014 4:46 am, "Veres Lajos" wro

Re: [systemd-devel] [PATCH 2/2] accelerometer: display short options too

2014-12-30 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 30, 2014 at 08:29:27PM +0100, Paul Menzel wrote: > Am Dienstag, den 30.12.2014, 18:58 +0100 schrieb Robert Milasan: > > --- > > src/udev/accelerometer/accelerometer.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Awesome! Thank you for splitting these up and submit

Re: [systemd-devel] [systemd-commits] 8 commits - src/core src/libsystemd src/test

2014-12-30 Thread Zbigniew Jędrzejewski-Szmek
> commit e95e909d820429ba34fa6f6f1b0109ac22743b47 > Author: Tom Gundersen > Date: Sun Dec 28 13:38:23 2014 +0100 > > core: loopback - simplify check_loopback() > > We no longer configure the addresses on the loopback interface, but > simply bring it up > and let the kernel do

Re: [systemd-devel] [PATCH] Fix install location of systemd.pc

2014-12-30 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 29, 2014 at 03:01:12PM +, Simon Peeters wrote: > 2014-12-29 13:02 GMT+00:00 Martin Pitt : > > Mike Gilbert [2014-12-28 12:41 -0500]: > >> From Lennart's commit message, it seems like this was done intentionally. > > > > The addition of libdir was certainly intentional, that's why I

Re: [systemd-devel] [PATCH 1/2] test: only use assert_se in test_raw_clone

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:14:46AM -0800, Filipe Brandenburger wrote: > The asserts used in the tests should never be allowed to be optimized away. Applied 1/2 too. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.f

Re: [systemd-devel] [PATCH 2/2] test: wait for cloned thread to exit

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:15:49AM -0800, Filipe Brandenburger wrote: > In test_raw_clone, make sure the cloned thread calls _exit() and in the parent > thread call waitpid(..., __WCLONE) to wait for the child thread to terminate, > otherwise there is a race condition where the child thread will lo

Re: [systemd-devel] [PATCH 2/2] udev: fix another strict aliasing issue

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 03:04:37PM -0800, Shawn Paul Landden wrote: > --- > src/udev/ata_id/ata_id.c | 62 > +++- > 1 file changed, 30 insertions(+), 32 deletions(-) Both applied. I made a follow up commit to remove an uint64_t* temp variable. The compi

Re: [systemd-devel] [PATCH 2/3] build-sys: update path in reference to sd-lldp.h

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 03:03:21PM -0800, Filipe Brandenburger wrote: > The file was moved from src/libsystemd-network to src/systemd in commit > 7a6f1457462840 ("sd-lldp: minor header cleanup"). > > This fixes "make distcheck". Applied. Zbyszek ___ sys

Re: [systemd-devel] [PATCH 1/3] machined: add org.freedesktop.machine1.policy.in to POTFILES.in

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 03:02:14PM -0800, Filipe Brandenburger wrote: > The new polkit file was introduced in commit d04c1fb8e21560 ("machined: > introduce polkit for OpenLogin() call"). Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists

Re: [systemd-devel] [PATCH] timesync: remove square(), use pow instead

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 05:52:51PM -0300, Cristian Rodríguez wrote: > In any case, the compiler generates the same code inline and never > actually calls the library function. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedeskto

Re: [systemd-devel] [PATCHv2 2/2] build-sys: remove references to dbusinterfacedir

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:59:15AM -0800, Filipe Brandenburger wrote: > This directory is not used by systemd. > > Tested by running a full build, running `make install` and comparing the file > list in the target trees and making sure that `make distcheck` still works. > --- > configure.ac | 7 -

Re: [systemd-devel] [PATCH] doc: os-release: mention all shell characters that must be escaped

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 24, 2014 at 02:46:20PM +0200, Mantas Mikulėnas wrote: > Since the manpage already talks about shell-compatibility, it should be > more accurate about what needs to be escaped and how. > --- Applied. Zbyszek ___ systemd-devel mailing list syst

Re: [systemd-devel] [PATCHv2] update .gitignore to include test-lldp

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:51:54AM -0800, Filipe Brandenburger wrote: > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 1b5d60f..078fd9a 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -207,6 +207,7 @@ > /test-libudev-sym* > /test-list

Re: [systemd-devel] [PATCHv2] test: do not use last cap from kernel in test-cap-list

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 01:51:40PM -0800, Filipe Brandenburger wrote: > The new test-cap-list introduced in commit 2822da4fb7f891 uses the included > table of capabilities. However, it uses cap_last_cap() which probes the kernel > for the last available capability. On an older kernel (e.g. 3.10 fro

Re: [systemd-devel] [PATCH 0/9] capabilities: remove include of where possible

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 23, 2014 at 10:45:07AM -0800, Filipe Brandenburger wrote: > On Tue, Dec 23, 2014 at 5:23 AM, David Herrmann wrote: > > I cannot find these patches on systemd-devel@lists.freedesktop.org. > > This might be due to fdo mail-server issues, or me just being > > incapable of searching throug

Re: [systemd-devel] Variable expansion in ConditionPathExists

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 25, 2014 at 03:36:15PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Dec 24, 2014 at 10:37:50AM -0200, Marcos Felipe Rasia de Mello wrote: > > Hi, > > > > I have a system service that runs with a normal user account > > ([Service] User=b

Re: [systemd-devel] Variable expansion in ConditionPathExists

2014-12-25 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 24, 2014 at 10:37:50AM -0200, Marcos Felipe Rasia de Mello wrote: > Hi, > > I have a system service that runs with a normal user account > ([Service] User=bla). I tried > > [Unit] > ConditionPathExists=$HOME/config.xml > > but it does not work: > > systemd[1]: [/etc/systemd/system/b

Re: [systemd-devel] I am trying to hook up docker and systemd.

2014-12-24 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 22, 2014 at 09:20:03AM -0500, Daniel J Walsh wrote: > I have a working version of docker which runs systemd/journald within > the container and sets up the /var/log/journal/UUID inside the container > to match the version outside. I also have registered the container with > machinectl.

Re: [systemd-devel] [PATCH udev v2] udev: Add program/rule to export touchscreen/tablet size as udev properties

2014-12-19 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 04:01:11PM +0100, Carlos Garnacho wrote: > This rule is only run on tablet/touchscreen devices, and extracts their size > in millimeters, as it can be found out through their struct input_absinfo. > > This may be useful to separate policy and application at the time of mapp

Re: [systemd-devel] [PATCH] build: add option to disable hwdb

2014-12-19 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 19, 2014 at 08:42:13AM -0800, Filipe Brandenburger wrote: > On Fri, Dec 19, 2014 at 8:31 AM, Michael Biebl wrote: > > 2014-12-19 17:10 GMT+01:00 Filipe Brandenburger : > >> On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl wrote: > >>> This also removed the HAVE_PYTHON section from Makef

Re: [systemd-devel] [PATCH] systemctl: print unit package in status

2014-12-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 18, 2014 at 07:09:34PM +, "Jóhann B. Guðmundsson" wrote: > > On 12/18/2014 06:44 PM, "Jóhann B. Guðmundsson" wrote: > > > >On 12/18/2014 06:36 PM, Zbigniew Jędrzejewski-Szmek wrote: > >>You missed the part where I said "yo

Re: [systemd-devel] [PATCH] systemctl: print unit package in status

2014-12-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 18, 2014 at 06:44:25PM +, "Jóhann B. Guðmundsson" wrote: > > On 12/18/2014 06:36 PM, Zbigniew Jędrzejewski-Szmek wrote: > >You missed the part where I said "you should make it opt-in". > > Should we not first determine the practicality of

Re: [systemd-devel] [PATCH] systemctl: print unit package in status

2014-12-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 18, 2014 at 06:33:50PM +, "Jóhann B. Guðmundsson" wrote: > > On 12/18/2014 05:48 PM, Zbigniew Jędrzejewski-Szmek wrote: > >I think you should make it opt-in, with a command-line switch > >(--show-package ?). > >In some cases it can be very use

Re: [systemd-devel] [PATCH] systemctl: print unit package in status

2014-12-18 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Dec 18, 2014 at 11:19:22AM -0500, Spencer Baugh wrote: > Quoting Jóhann B. Guðmundsson (2014-12-18 04:08:32) > > > > On 12/18/2014 04:00 AM, Spencer Baugh wrote: > > > When printing the status of a unit, open a connection to the session bus > > > and query PackageKit for the package that t

Re: [systemd-devel] [PATCH] path: follow symbolic link for parent path

2014-12-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 17, 2014 at 08:59:15AM +0100, Umut Tezduyar Lindskog wrote: > Thanks Zbigniew, > > I have only fixed the fallback: case and missed to fix the real case > where we use the name_to_handle. Could you please change that too. It > will look something like this: > > @@ -489,7 +489,7 @@ int

Re: [systemd-devel] [PATCH] path: follow symbolic link for parent path

2014-12-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 17, 2014 at 10:48:55AM +0100, Umut Tezduyar Lindskog wrote: > On Wed, Dec 17, 2014 at 10:21 AM, "Jóhann B. Guðmundsson" > wrote: > > > > On 12/17/2014 02:20 AM, Zbigniew Jędrzejewski-Szmek wrote: > >> > >> On Tue, Dec 16, 2014 at

Re: [systemd-devel] journald syslog forwarding

2014-12-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 17, 2014 at 08:30:41PM +, Holger Winkelmann [TP] wrote: > Hi, sorry for delay in reply.. > > >> Journal carries messages from the initramfs. We cannot send them from > >> the initramfs, unless we bring up the network then, which we don't want > >> to do just for this purpose. But t

Re: [systemd-devel] Using `systemctl edit` on "invalid" unit names

2014-12-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 17, 2014 at 11:29:38AM +0300, Ivan Shapovalov wrote: > On Tuesday, December 16, 2014 at 06:35:09 AM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Sun, Dec 14, 2014 at 04:21:32PM +0300, Ivan Shapovalov wrote: > > > On Saturday 13 December 2014 at 15:34:01,

Re: [systemd-devel] [PATCH] nspawn: fix invocation of the raw clone() system call on s390 and cris

2014-12-16 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 16, 2014 at 06:06:41PM +0100, Ken Werner wrote: > From: Ken Werner > > Since the order of the first and second arguments of the raw clone() system > call is reversed on s390 and cris it needs to be invoked differently. Applied. Zbyszek ___

Re: [systemd-devel] [PATCH] path: follow symbolic link for parent path

2014-12-16 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 16, 2014 at 09:58:39PM +0100, Umut Tezduyar Lindskog wrote: > --- > src/shared/path-util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/shared/path-util.c b/src/shared/path-util.c > index dcc8321..304281f 100644 > --- a/src/shared/path-util.c > +++ b/sr

Re: [systemd-devel] [PATCH v3] systemctl: add edit verb

2014-12-15 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Oct 21, 2014 at 10:55:46PM +0200, Ronny Chevalier wrote: > >> >> +if (arg_transport != BUS_TRANSPORT_LOCAL) { > >> >> +log_error("Cannot remotely edit units"); > >> >> +return -EINVAL; > >> >> +} > >> >> + > >> >> +if (arg_runtime) { >

Re: [systemd-devel] Using `systemctl edit` on "invalid" unit names

2014-12-15 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Dec 14, 2014 at 04:21:32PM +0300, Ivan Shapovalov wrote: > On Saturday 13 December 2014 at 15:34:01, Ronny Chevalier wrote: > > 2014-12-13 11:33 GMT+01:00 Ivan Shapovalov : > > > Hello all, > > > > Hi, > > > > > > > > it seems that the newly added `systemctl edit` command requires i

Re: [systemd-devel] [PATCH] nss-myhostname: also recognize "gateway."

2014-12-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 15, 2014 at 11:34:24AM +0100, har...@redhat.com wrote: > From: Harald Hoyer > > "gateway." skips adding the domain search path and saves some queries to > the nameserver. Pushed it... Works nicely and seems useful. Zbyszek ___ systemd-devel

Re: [systemd-devel] [PATCH] systemctl: fix argument handling when invoked as "shutdown"

2014-12-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 15, 2014 at 10:39:00AM +0100, Jan Synacek wrote: > --- > src/systemctl/systemctl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c > index 8400bc8..91e8f7c 100644 > --- a/src/systemctl/systemctl.c > +++

Re: [systemd-devel] [PATCH] fix compiler warning

2014-12-15 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 16, 2014 at 08:48:34AM +0530, Susant Sahani wrote: > src/shared/utf8.c:268:13: warning: unused variable 'd' > [-Wunused-variable] > int d; Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lis

Re: [systemd-devel] [PATCH] build-sys: remove commented-out m4 from user@.service

2014-12-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 15, 2014 at 04:36:51PM +0100, Lennart Poettering wrote: > On Sun, 14.12.14 19:12, Mantas Mikulėnas (graw...@gmail.com) wrote: > > > Otherwise this actually remains in the generated unit in /usr/lib. > > > > If you want to keep it commented out, a m4-compatible way would be: > > > >

<    3   4   5   6   7   8   9   10   11   12   >