Re: [systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-29 Thread Lennart Poettering
On Fri, 25.05.12 16:34, shawn (shawnland...@gmail.com) wrote: On Tue, 2012-05-22 at 13:12 +0200, Lennart Poettering wrote: Hmm, this is misleading. THis has little to do with being ready, as the cgroup VFS are mounted synchronously very early in PID 1 and it is basically very hard to

Re: [systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-25 Thread shawn
On Tue, 2012-05-22 at 13:12 +0200, Lennart Poettering wrote: Hmm, this is misleading. THis has little to do with being ready, as the cgroup VFS are mounted synchronously very early in PID 1 and it is basically very hard to run in parallel with that. So this check actually would check for

Re: [systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-22 Thread shawn
Uggh, sorry for sending that super-buggy patch. Here is a better version. On Mon, 2012-05-21 at 22:59 -0700, Shawn Landden wrote: cgtop quits on startup if all the cgroup mounts it expects are not ready. Provide user with some indication of why cgtop failed. From

Re: [systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-22 Thread Lennart Poettering
On Mon, 21.05.12 23:04, shawn (shawnland...@gmail.com) wrote: Heya, Uggh, sorry for sending that super-buggy patch. Here is a better version. On Mon, 2012-05-21 at 22:59 -0700, Shawn Landden wrote: cgtop quits on startup if all the cgroup mounts it expects are not ready. Provide user

Re: [systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-22 Thread shawn
On Tue, 2012-05-22 at 13:12 +0200, Lennart Poettering wrote: On Mon, 21.05.12 23:04, shawn (shawnland...@gmail.com) wrote: Heya, Uggh, sorry for sending that super-buggy patch. Here is a better version. On Mon, 2012-05-21 at 22:59 -0700, Shawn Landden wrote: cgtop quits on

[systemd-devel] [PATCH] cgtop: useful error messages when bootup fails

2012-05-21 Thread Shawn Landden
cgtop quits on startup if all the cgroup mounts it expects are not ready. Provide user with some indication of why cgtop failed. --- src/cgtop/cgtop.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/cgtop/cgtop.c b/src/cgtop/cgtop.c index ddb5709..381f399 100644 ---