Re: [systemd-devel] [PATCH] connection: fix kernel oop when conn_name not set

2014-05-12 Thread Jacek Janczyk
On 05/12/2014 04:20 PM, Kay Sievers wrote: On Mon, May 12, 2014 at 3:24 PM, Jacek Janczyk wrote: kernel oops when connection name (kdbus_conn.name) not set via HELLO message but requested with attach flags KDBUS_ATTACH_CONN_NAME. Hmm, here does it crash? Seems the code that attaches the string

Re: [systemd-devel] [PATCH] connection: fix kernel oop when conn_name not set

2014-05-12 Thread Kay Sievers
On Mon, May 12, 2014 at 3:24 PM, Jacek Janczyk wrote: > kernel oops when connection name (kdbus_conn.name) not set via HELLO > message but requested with attach flags KDBUS_ATTACH_CONN_NAME. Hmm, here does it crash? Seems the code that attaches the string checks for the string being set: if ((m

[systemd-devel] [PATCH] connection: fix kernel oop when conn_name not set

2014-05-12 Thread Jacek Janczyk
kernel oops when connection name (kdbus_conn.name) not set via HELLO message but requested with attach flags KDBUS_ATTACH_CONN_NAME. As conn.name is defined as "for debug purposes" I find it more convenient to return generic name than to strip the field from requested metadata or raise an error on