Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-04 Thread Lennart Poettering
On Tue, 04.01.11 14:20, Tollef Fog Heen (tfh...@err.no) wrote: > > ]] Lennart Poettering > > | Hmm, so, given that we check PAGER ourselves, calling sensible-pager is > | of little benefit for us, right? And I probably should change the > | invocation of sensible-pager to pager in my code, so t

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-04 Thread Tollef Fog Heen
]] Lennart Poettering | Hmm, so, given that we check PAGER ourselves, calling sensible-pager is | of little benefit for us, right? And I probably should change the | invocation of sensible-pager to pager in my code, so that we search for | "pager", "less" and "more" in this order? Sounds fine.

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-04 Thread Lennart Poettering
On Tue, 04.01.11 09:29, Tollef Fog Heen (tfh...@err.no) wrote: > > ]] Lennart Poettering > > | Can you elaborate on the precise semantics of pager(1) and > | sensible-pager(1)? I found the latter man pages online and hence added > | this to the things systemctl will now look for by default. But

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-04 Thread Tollef Fog Heen
]] Lennart Poettering | Can you elaborate on the precise semantics of pager(1) and | sensible-pager(1)? I found the latter man pages online and hence added | this to the things systemctl will now look for by default. But "pager" | was a little bit too generic to find anything. pager(1) is the a

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-03 Thread Lennart Poettering
On Sun, 02.01.11 14:07, Miklos Vajna (vmik...@frugalware.org) wrote: > On Sun, Jan 02, 2011 at 08:24:02AM +0100, Tollef Fog Heen > wrote: > > | + if (!pager) > > | + pager = "less"; > > > > Doesn't other distributions have sensible-pager(1) or pager(1)? Also, > > at least on Debian, les

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-03 Thread Miklos Vajna
On Tue, Jan 04, 2011 at 01:10:48AM +0100, Lennart Poettering wrote: > I had merged this already shortly after you posted it and made some > minor changes to it before you sent the updated patch, but I think I > added everything you changed later on, too. Tollef, Miklos, could you > please check i

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-03 Thread Lennart Poettering
On Sun, 02.01.11 08:24, Tollef Fog Heen (tfh...@err.no) wrote: > > ]] Miklos Vajna > > Hi, > > | I hope the subjects describes the patch enough - though I would like to > | point out one detail. I guess there can be great flames about the > | default value of LESS if it's unset - I took FRSX a

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-03 Thread Lennart Poettering
On Sun, 02.01.11 00:25, Miklos Vajna (vmik...@frugalware.org) wrote: > I hope the subjects describes the patch enough - though I would like to > point out one detail. I guess there can be great flames about the > default value of LESS if it's unset - I took FRSX as that's what git > uses right now

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-02 Thread Tollef Fog Heen
]] Miklos Vajna | On Sun, Jan 02, 2011 at 08:24:02AM +0100, Tollef Fog Heen wrote: | > | + if (!pager) | > | + pager = "less"; | > | > Doesn't other distributions have sensible-pager(1) or pager(1)? Also, | > at least on Debian, less(1) isn't in the base distribution, while | > more(1

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-02 Thread Miklos Vajna
On Sun, Jan 02, 2011 at 08:24:02AM +0100, Tollef Fog Heen wrote: > | + if (!pager) > | + pager = "less"; > > Doesn't other distributions have sensible-pager(1) or pager(1)? Also, > at least on Debian, less(1) isn't in the base distribution, while > more(1) comes from util-linux so is

Re: [systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-01 Thread Tollef Fog Heen
]] Miklos Vajna Hi, | I hope the subjects describes the patch enough - though I would like to | point out one detail. I guess there can be great flames about the | default value of LESS if it's unset - I took FRSX as that's what git | uses right now. You're not using a default value of LESS, yo

[systemd-devel] [PATCH] systemctl: implement auto-pager a la git

2011-01-01 Thread Miklos Vajna
--- Hi, I hope the subjects describes the patch enough - though I would like to point out one detail. I guess there can be great flames about the default value of LESS if it's unset - I took FRSX as that's what git uses right now. TODO |2 -- man/systemctl.xml |7 +++ s