Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-07 Thread David Herrmann
Hi On Tue, Apr 7, 2015 at 3:47 AM, Peter Hutterer wrote: > On Sat, Apr 04, 2015 at 02:07:27PM +0200, David Herrmann wrote: >> Hi >> >> On Fri, Apr 3, 2015 at 8:55 PM, Hans de Goede wrote: >> [...] >> >> I don't think we should return when we see INPUT_PROP_ACCEL. If a >> >> keyboard embeds an ac

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-06 Thread Peter Hutterer
On Sat, Apr 04, 2015 at 02:07:27PM +0200, David Herrmann wrote: > Hi > > On Fri, Apr 3, 2015 at 8:55 PM, Hans de Goede wrote: > [...] > >> I don't think we should return when we see INPUT_PROP_ACCEL. If a > >> keyboard embeds an accelerometer, we will miss it. I think I went too > >> deep in deta

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-04 Thread David Herrmann
Hi On Fri, Apr 3, 2015 at 8:55 PM, Hans de Goede wrote: [...] >> I don't think we should return when we see INPUT_PROP_ACCEL. If a >> keyboard embeds an accelerometer, we will miss it. I think I went too >> deep in detail for Wacoms/tablets devices and it confused you. Those >> don't need much pr

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Hans de Goede
Hi, On 03-04-15 20:21, Benjamin Tissoires wrote: On Apr 03 2015 or thereabouts, David Herrmann wrote: Hi On Fri, Apr 3, 2015 at 5:30 PM, Benjamin Tissoires wrote: On Apr 03 2015 or thereabouts, David Herrmann wrote: Hi On Fri, Apr 3, 2015 at 4:38 PM, Benjamin Tissoires wrote: On Apr 03 2

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Benjamin Tissoires
On Apr 03 2015 or thereabouts, David Herrmann wrote: > Hi > > On Fri, Apr 3, 2015 at 5:30 PM, Benjamin Tissoires > wrote: > > On Apr 03 2015 or thereabouts, David Herrmann wrote: > >> Hi > >> > >> On Fri, Apr 3, 2015 at 4:38 PM, Benjamin Tissoires > >> wrote: > >> > On Apr 03 2015 or thereabou

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread David Herrmann
Hi On Fri, Apr 3, 2015 at 5:30 PM, Benjamin Tissoires wrote: > On Apr 03 2015 or thereabouts, David Herrmann wrote: >> Hi >> >> On Fri, Apr 3, 2015 at 4:38 PM, Benjamin Tissoires >> wrote: >> > On Apr 03 2015 or thereabouts, Hans de Goede wrote: >> >> Hi, >> >> >> >> On 03-04-15 15:51, David He

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Benjamin Tissoires
On Apr 03 2015 or thereabouts, David Herrmann wrote: > Hi > > On Fri, Apr 3, 2015 at 4:38 PM, Benjamin Tissoires > wrote: > > On Apr 03 2015 or thereabouts, Hans de Goede wrote: > >> Hi, > >> > >> On 03-04-15 15:51, David Herrmann wrote: > >> >Hi > >> > > >> >On Fri, Apr 3, 2015 at 12:07 PM, Han

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread David Herrmann
Hi On Fri, Apr 3, 2015 at 4:38 PM, Benjamin Tissoires wrote: > On Apr 03 2015 or thereabouts, Hans de Goede wrote: >> Hi, >> >> On 03-04-15 15:51, David Herrmann wrote: >> >Hi >> > >> >On Fri, Apr 3, 2015 at 12:07 PM, Hans de Goede wrote: >> >>input_id already (tries to) tag accelerometers as su

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Benjamin Tissoires
On Apr 03 2015 or thereabouts, Hans de Goede wrote: > Hi, > > On 03-04-15 15:51, David Herrmann wrote: > >Hi > > > >On Fri, Apr 3, 2015 at 12:07 PM, Hans de Goede wrote: > >>input_id already (tries to) tag accelerometers as such, but this only works > >>for absolute accelerometers. Recent kernels

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Hans de Goede
Hi, On 03-04-15 15:51, David Herrmann wrote: Hi On Fri, Apr 3, 2015 at 12:07 PM, Hans de Goede wrote: input_id already (tries to) tag accelerometers as such, but this only works for absolute accelerometers. Recent kernels mark accelerometers through an input prop. Trust that prop and always t

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread David Herrmann
Hi On Fri, Apr 3, 2015 at 12:07 PM, Hans de Goede wrote: > input_id already (tries to) tag accelerometers as such, but this only works > for absolute accelerometers. Recent kernels mark accelerometers through an > input prop. Trust that prop and always tag devices with it with > ID_INPUT_ACCELERO

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Hans de Goede
Hi, On 03-04-15 13:13, Lennart Poettering wrote: On Fri, 03.04.15 12:07, Hans de Goede (hdego...@redhat.com) wrote: input_id already (tries to) tag accelerometers as such, but this only works for absolute accelerometers. Recent kernels mark accelerometers through an input prop. Trust that prop

Re: [systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Lennart Poettering
On Fri, 03.04.15 12:07, Hans de Goede (hdego...@redhat.com) wrote: > input_id already (tries to) tag accelerometers as such, but this only works > for absolute accelerometers. Recent kernels mark accelerometers through an > input prop. Trust that prop and always tag devices with it with > ID_INPUT

[systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

2015-04-03 Thread Hans de Goede
input_id already (tries to) tag accelerometers as such, but this only works for absolute accelerometers. Recent kernels mark accelerometers through an input prop. Trust that prop and always tag devices with it with ID_INPUT_ACCELEROMETER. Note that detection by the prop bit works the same as the e