Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-08 Thread Patrik Flykt
On Tue, 2015-04-07 at 21:13 +0200, Alexander Sverdlin wrote: But if the backend code for this flag appears first in Linux 3.14 (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=479840ffdbe4), working around the compilation issue (against older uapi headers) will not

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Patrik Flykt
On Fri, 2015-04-03 at 06:46 +0200, Alexander Sverdlin wrote: Hi! On 25/03/15 14:36, Patrik Flykt wrote: IFA_FLAGS is a discrete value and has no preprocessor #define defined for it. Fix this by always using the value. Seems that fix was not a real fix: CC

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Lennart Poettering
On Tue, 07.04.15 16:55, Patrik Flykt (patrik.fl...@linux.intel.com) wrote: On Fri, 2015-04-03 at 06:46 +0200, Alexander Sverdlin wrote: Hi! On 25/03/15 14:36, Patrik Flykt wrote: IFA_FLAGS is a discrete value and has no preprocessor #define defined for it. Fix this by always using

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Alexander Sverdlin
Hi! On 07/04/15 15:55, Patrik Flykt wrote: IFA_FLAGS seems to appear in kernel ~3.13 and the kernel requirements from README state 3.8/3.7 at the moment. One could let the sd_rtnl_message_append_u32 for IFA_FLAGS fail in patch 2/3, but then user space has to play tricks with IPv6 DHCPv6

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Lennart Poettering
On Tue, 07.04.15 20:01, Alexander Sverdlin (alexander.sverd...@gmail.com) wrote: Hi! On 07/04/15 19:24, Alexander Sverdlin wrote: IFA_FLAGS seems to appear in kernel ~3.13 and the kernel requirements [...] Oh, sorry, the headers are from 3.12, but that's still newer than 3.8 in

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Alexander Sverdlin
Hi! On 07/04/15 19:06, Alexander Sverdlin wrote: On 07/04/15 15:55, Patrik Flykt wrote: IFA_FLAGS seems to appear in kernel ~3.13 and the kernel requirements from README state 3.8/3.7 at the moment. One could let the sd_rtnl_message_append_u32 for IFA_FLAGS fail in patch 2/3, but then

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Alexander Sverdlin
Hi! On 07/04/15 19:09, Alexander Sverdlin wrote: IFA_FLAGS seems to appear in kernel ~3.13 and the kernel requirements from README state 3.8/3.7 at the moment. One could let the sd_rtnl_message_append_u32 for IFA_FLAGS fail in patch 2/3, but then user space has to play tricks

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Alexander Sverdlin
Hi! On 07/04/15 19:24, Alexander Sverdlin wrote: IFA_FLAGS seems to appear in kernel ~3.13 and the kernel requirements [...] Oh, sorry, the headers are from 3.12, but that's still newer than 3.8 in the doc... actually wrong, but your patch actually brakes compilation for me.

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Lennart Poettering
On Tue, 07.04.15 19:24, Alexander Sverdlin (alexander.sverd...@gmail.com) wrote: Hi! On 07/04/15 19:09, Alexander Sverdlin wrote: IFA_FLAGS seems to appear in kernel ~3.13 and the kernel requirements from README state 3.8/3.7 at the moment. One could let the

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Alexander Sverdlin
Hi! On 07/04/15 20:49, Lennart Poettering wrote: IFA_FLAGS seems to appear in kernel ~3.13 and the kernel requirements from README state 3.8/3.7 at the moment. One could let the sd_rtnl_message_append_u32 for IFA_FLAGS fail in patch 2/3, but then user space has to play

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-07 Thread Alexander Sverdlin
Hi Lennart, On 07/04/15 21:09, Lennart Poettering wrote: IFA_FLAGS seems to appear in kernel ~3.13 and the kernel requirements [...] Oh, sorry, the headers are from 3.12, but that's still newer than 3.8 in the doc... actually wrong, but your patch actually brakes

Re: [systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-04-02 Thread Alexander Sverdlin
Hi! On 25/03/15 14:36, Patrik Flykt wrote: IFA_FLAGS is a discrete value and has no preprocessor #define defined for it. Fix this by always using the value. Seems that fix was not a real fix: CC src/libsystemd/sd-id128/libsystemd_internal_la-sd-id128.lo

[systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

2015-03-25 Thread Patrik Flykt
IFA_FLAGS is a discrete value and has no preprocessor #define defined for it. Fix this by always using the value. --- src/libsystemd/sd-rtnl/rtnl-types.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/libsystemd/sd-rtnl/rtnl-types.c b/src/libsystemd/sd-rtnl/rtnl-types.c index