Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-11 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jul 11, 2014 at 12:01:19AM +, "Jóhann B. Guðmundsson" wrote: > I had already submitted new patch with deployment "[PATCH] Add > DEPLOYMENT to hostnamectl" which Zbyszek had suggested and you > agreed to and FYI this has nothing to with trying to standardize > anything it's about bringin

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Jóhann B. Guðmundsson
On 07/10/2014 11:37 PM, Lennart Poettering wrote: On Thu, 10.07.14 21:04, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: > > >On 07/10/2014 08:44 PM, Lennart Poettering wrote: > >On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: > > > Seeing this list, why not

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Lennart Poettering
On Thu, 10.07.14 21:04, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: > > > On 07/10/2014 08:44 PM, Lennart Poettering wrote: > >On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: > > > Seeing this list, why not name the variable Tier= ? Or > DeploymentTier=, i

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Jóhann B. Guðmundsson
On 07/10/2014 08:53 PM, Tollef Fog Heen wrote: ]] Lennart Poettering On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environm

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Jóhann B. Guðmundsson
On 07/10/2014 08:44 PM, Lennart Poettering wrote: On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: Seeing this list, why not name the variable Tier= ? Or DeploymentTier=, if just Tier is too specific? This is specific for defining staging environment not their layer s

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Tollef Fog Heen
]] Lennart Poettering > On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: > > > >>Seeing this list, why not name the variable Tier= ? Or > > >>DeploymentTier=, if just Tier is too specific? > > > > This is specific for defining staging environment not their layer so > >

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Lennart Poettering
On Thu, 10.07.14 18:45, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: > >>Seeing this list, why not name the variable Tier= ? Or > >>DeploymentTier=, if just Tier is too specific? > > This is specific for defining staging environment not their layer so > can I simple get an ack nack on the de

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Jóhann B. Guðmundsson
On 07/10/2014 05:06 PM, Tom Gundersen wrote: On Thu, Jul 10, 2014 at 7:06 PM, Tom Gundersen wrote: On Tue, Jul 8, 2014 at 10:23 PM, "Jóhann B. Guðmundsson" wrote: On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: ]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up w

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Tom Gundersen
On Thu, Jul 10, 2014 at 7:06 PM, Tom Gundersen wrote: > On Tue, Jul 8, 2014 at 10:23 PM, "Jóhann B. Guðmundsson" > wrote: >> >> On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: >> >> ]] Tom Gundersen >> >> Patches look good. Only found one tiny nit. We should come up with a >> better name though, f

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-10 Thread Tom Gundersen
On Tue, Jul 8, 2014 at 10:23 PM, "Jóhann B. Guðmundsson" wrote: > > On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: > > ]] Tom Gundersen > > Patches look good. Only found one tiny nit. We should come up with a > better name though, feels wrong that the name is very generic (and > clashes with other

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Jóhann B. Guðmundsson
On 07/08/2014 08:31 PM, Tomasz Torcz wrote: We also have Disaster Recovery (DR) tier. It's basically copy of production, started when disaster strucks. I dont think we should add "Recovery" as an layer since it's just a replica of production in one form or another and as an administrator

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Tollef Fog Heen
]] "Jóhann B. Guðmundsson" > On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: > > ]] Tom Gundersen > > > >> Patches look good. Only found one tiny nit. We should come up with a > >> better name though, feels wrong that the name is very generic (and > >> clashes with other uses), whilst the usage is

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Tomasz Torcz
On Tue, Jul 08, 2014 at 08:23:15PM +, "Jóhann B. Guðmundsson" wrote: > > On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: > >]] Tom Gundersen > > > >>Patches look good. Only found one tiny nit. We should come up with a > >>better name though, feels wrong that the name is very generic (and > >>cl

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Jóhann B. Guðmundsson
On 07/08/2014 07:31 PM, Tollef Fog Heen wrote: ]] Tom Gundersen Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to "testing", "staging",

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Tollef Fog Heen
]] Tom Gundersen > Patches look good. Only found one tiny nit. We should come up with a > better name though, feels wrong that the name is very generic (and > clashes with other uses), whilst the usage is quite specific (limited > to "testing", "staging", "production"). Surely at least qa and de

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Tollef Fog Heen
]] Lennart Poettering > On Tue, 08.07.14 02:55, Kay Sievers (k...@vrfy.org) wrote: > > > On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson > > wrote: > > > --- > > > src/hostname/hostnamectl.c | 20 +--- > > > 1 file changed, 17 insertions(+), 3 deletions(-) > > > > > > dif

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Lennart Poettering
On Tue, 08.07.14 20:36, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > On Tue, Jul 08, 2014 at 01:16:43PM +, "Jóhann B. Guðmundsson" wrote: > > This is very specific to deployment environment and to solve a very > > specific long standing problem ( describe the operating environme

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jul 08, 2014 at 01:16:43PM +, "Jóhann B. Guðmundsson" wrote: > This is very specific to deployment environment and to solve a very > specific long standing problem ( describe the operating environment > ) so the options can only be development,staging,production or if > people see the n

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Jóhann B. Guðmundsson
On 07/08/2014 11:40 AM, Lennart Poettering wrote: On Tue, 08.07.14 02:55, Kay Sievers (k...@vrfy.org) wrote: On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson wrote: --- src/hostname/hostnamectl.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Michael Biebl
2014-07-08 13:49 GMT+02:00 Kay Sievers : >> This information looks like local state, i.e. can't be part of >> /usr/lib/os-release. > > machine-info Ah, k. Sorry for the noise. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Jóhann B. Guðmundsson
On 07/08/2014 11:28 AM, Peter Sztanojev wrote: On Tue, Jul 8, 2014 at 9:31 AM, "Jóhann B. Guðmundsson" wrote: On 07/08/2014 12:55 AM, Kay Sievers wrote: Shouldn't we possibly we find a word for "environment" which explains itself a bit better? Environment we usually call the numerous variable

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Lennart Poettering
On Tue, 08.07.14 13:47, Michael Biebl (mbi...@gmail.com) wrote: > > 2014-07-08 13:40 GMT+02:00 Lennart Poettering : > > I'd go for something generic like "description" or "comment" or so. Or > > maybe "purpose". I think simply "description" appears to be the best > > option for me. > > > > BTW, s

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Kay Sievers
On Tue, Jul 8, 2014 at 1:47 PM, Michael Biebl wrote: > 2014-07-08 13:40 GMT+02:00 Lennart Poettering : >> I'd go for something generic like "description" or "comment" or so. Or >> maybe "purpose". I think simply "description" appears to be the best >> option for me. >> >> BTW, something I also wan

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Michael Biebl
2014-07-08 13:40 GMT+02:00 Lennart Poettering : > I'd go for something generic like "description" or "comment" or so. Or > maybe "purpose". I think simply "description" appears to be the best > option for me. > > BTW, something I also wanted to see for a long time, was a "location" > field, that ca

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Lennart Poettering
On Tue, 08.07.14 02:55, Kay Sievers (k...@vrfy.org) wrote: > On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson > wrote: > > --- > > src/hostname/hostnamectl.c | 20 +--- > > 1 file changed, 17 insertions(+), 3 deletions(-) > > > > diff --git a/src/hostname/hostnamectl.c b/src

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Peter Sztanojev
On Tue, Jul 8, 2014 at 9:31 AM, "Jóhann B. Guðmundsson" wrote: > > On 07/08/2014 12:55 AM, Kay Sievers wrote: >> >> Shouldn't we possibly we find a word for "environment" which explains >> itself a bit better? Environment we usually call the numerous >> variables of a process or service. > > > I w

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Jóhann B. Guðmundsson
On 07/08/2014 12:55 AM, Kay Sievers wrote: Shouldn't we possibly we find a word for "environment" which explains itself a bit better? Environment we usually call the numerous variables of a process or service. I was aware of that but decided to move forward since people should be able to make

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-08 Thread Tom Gundersen
Patches look good. Only found one tiny nit. We should come up with a better name though, feels wrong that the name is very generic (and clashes with other uses), whilst the usage is quite specific (limited to "testing", "staging", "production"). Cheers, Tom On Tue, Jul 8, 2014 at 2:38 AM, Jóhann

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-07 Thread Jan Alexander Steffens
Am 08.07.2014 02:55 schrieb "Kay Sievers" : > Shouldn't we possibly we find a word for "environment" which explains > itself a bit better? Environment we usually call the numerous > variables of a process or service. Just "TAG" maybe? It's unfortunate, but ENVIRONMENT is the most widespread term f

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-07 Thread Steven Noonan
On Mon, Jul 7, 2014 at 5:55 PM, Kay Sievers wrote: > On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson > wrote: >> --- >> src/hostname/hostnamectl.c | 20 +--- >> 1 file changed, 17 insertions(+), 3 deletions(-) >> >> diff --git a/src/hostname/hostnamectl.c b/src/hostname/hos

Re: [systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-07 Thread Kay Sievers
On Tue, Jul 8, 2014 at 2:38 AM, Jóhann B. Guðmundsson wrote: > --- > src/hostname/hostnamectl.c | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c > index 267cd74..e164086 100644 > --- a/src/hostna

[systemd-devel] [PATCH 1/4] Add ENVIRONMENT to hostnamectl

2014-07-07 Thread Jóhann B . Guðmundsson
--- src/hostname/hostnamectl.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/hostname/hostnamectl.c b/src/hostname/hostnamectl.c index 267cd74..e164086 100644 --- a/src/hostname/hostnamectl.c +++ b/src/hostname/hostnamectl.c @@ -67,6 +67,7 @@ typedef