Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-05-03 Thread Lennart Poettering
On Fri, 26.04.13 21:10, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > On Fri, Apr 26, 2013 at 08:14:07PM +0200, Daniel Buch wrote: > > I felt the inconsistentsy was kinda awfull. > > > > I can change all to void* (instead of, void *) if you like but else leave > > this patch to the

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 26, 2013 at 08:14:07PM +0200, Daniel Buch wrote: > I felt the inconsistentsy was kinda awfull. > > I can change all to void* (instead of, void *) if you like but else leave > this patch to the trash? I think it doesn't matter too much, it can stay as is. Zbyszek __

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 26, 2013 at 07:42:34PM +0100, Simon McVittie wrote: > On 26/04/13 18:49, Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buch wrote: > >> -void* hashmap_get(Hashmap *h, const void *key); > >> -void* hashmap_get2(Hashmap *h, const void *key, void *

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Simon McVittie
On 26/04/13 18:49, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buch wrote: >> -void* hashmap_get(Hashmap *h, const void *key); >> -void* hashmap_get2(Hashmap *h, const void *key, void **rkey); >> +void *hashmap_get(Hashmap *h, const void *key); >> +void *ha

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Daniel Buch
I felt the inconsistentsy was kinda awfull. I can change all to void* (instead of, void *) if you like but else leave this patch to the trash? 2013/4/26 Kay Sievers > On Fri, Apr 26, 2013 at 7:49 PM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buc

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Kay Sievers
On Fri, Apr 26, 2013 at 7:49 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buch wrote: >> --- >> src/shared/hashmap.h | 14 +++--- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h

Re: [systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Apr 26, 2013 at 06:40:08PM +0200, Daniel Buch wrote: > --- > src/shared/hashmap.h | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h > index 26bd030..f52517f 100644 > --- a/src/shared/hashmap.h > +++ b/src/sh

[systemd-devel] [PATCH 2/2] hashmap.h: fix coding style issue

2013-04-26 Thread Daniel Buch
--- src/shared/hashmap.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/shared/hashmap.h b/src/shared/hashmap.h index 26bd030..f52517f 100644 --- a/src/shared/hashmap.h +++ b/src/shared/hashmap.h @@ -57,11 +57,11 @@ int hashmap_ensure_allocated(Hashmap **h,