Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-11 Thread Lennart Poettering
On Wed, 11.09.13 19:48, Colin Walters (walt...@verbum.org) wrote: > > On Wed, 2013-09-11 at 19:11 +0200, Lennart Poettering wrote: > > > Can you elaborate on this? Why wouldn't it suffice to drop in a .mount > > unit for the mount in question which excludes the mount point from being > > unmount

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-11 Thread Colin Walters
On Wed, 2013-09-11 at 19:11 +0200, Lennart Poettering wrote: > Can you elaborate on this? Why wouldn't it suffice to drop in a .mount > unit for the mount in question which excludes the mount point from being > unmounted with this? It doesn't appear possible to remove the default Conflicts= just

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-11 Thread Lennart Poettering
On Wed, 11.09.13 12:00, Colin Walters (walt...@verbum.org) wrote: > > On Wed, 2013-09-11 at 16:55 +0200, Lennart Poettering wrote: > > > Well, but /etc would be one of those which would be listed in that "OS > > resource dir list"... > > Sure, it makes total sense for systemd to hard require i

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-11 Thread Colin Walters
On Wed, 2013-09-11 at 16:55 +0200, Lennart Poettering wrote: > Well, but /etc would be one of those which would be listed in that "OS > resource dir list"... Sure, it makes total sense for systemd to hard require it (and the others) to be mounted; again I'm just more interested in the unmounting

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-11 Thread Lennart Poettering
On Wed, 11.09.13 10:46, Colin Walters (walt...@verbum.org) wrote: > > > Well, everything that this list would declare is that /, /etc, /usr (and > > maybe very few others) are the bits that systemd requires to be > > mounted when the host's systemd is first invoked. Where it is mounted > > from,

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-11 Thread Colin Walters
On Wed, 2013-09-11 at 16:31 +0200, Lennart Poettering wrote: > Well, everything that this list would declare is that /, /etc, /usr (and > maybe very few others) are the bits that systemd requires to be > mounted when the host's systemd is first invoked. Where it is mounted > from, and in which ord

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-11 Thread Lennart Poettering
On Tue, 10.09.13 19:54, Tom Gundersen (t...@jklm.no) wrote: > >> But it annoys me that we're propagating this hardcoding in the new code > >> too. How about we make systemd inspect /proc/self/mountinfo *very* > >> early on at boot when it starts, and ensure skip unmounting these, under > >> the a

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-11 Thread Lennart Poettering
On Tue, 10.09.13 13:33, Colin Walters (walt...@verbum.org) wrote: > > On Tue, 2013-09-10 at 18:47 +0200, Lennart Poettering wrote: > > > I'd actually prefer having an explicit blacklist for this, so that we > > don't have to trust the initrd too much that... > > But nowadays it's systemd runnin

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-10 Thread Colin Walters
On Tue, 2013-09-10 at 18:47 +0200, Lennart Poettering wrote: > I'd actually prefer having an explicit blacklist for this, so that we > don't have to trust the initrd too much that... But nowadays it's systemd running in the initrd, what's not to trust? > However, I'd really like to see this blac

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-10 Thread Lennart Poettering
On Fri, 23.08.13 15:51, Colin Walters (walt...@verbum.org) wrote: > > First, thanks for working on this, most of these patches look sane to > me. > > On Fri, 2013-08-23 at 15:09 +0800, Tom Gundersen wrote: > > > +if (path_equal(m->where, "/") || > > +path_equal(m->where, "/u

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-10 Thread Colin Guthrie
'Twas brillig, and Tom Gundersen at 10/09/13 18:54 did gyre and gimble: > I'm not too keen on a blacklist. It would work for the simple case of > course, but I have seen lots of fancy/complicated stuff being mounted > in the initrd for people doing live media/install discs, which I > really don't t

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-09-10 Thread Tom Gundersen
On Tue, Sep 10, 2013 at 6:47 PM, Lennart Poettering wrote: > On Fri, 23.08.13 15:51, Colin Walters (walt...@verbum.org) wrote: > >> >> First, thanks for working on this, most of these patches look sane to >> me. >> >> On Fri, 2013-08-23 at 15:09 +0800, Tom Gundersen wrote: >> >> > +if (pat

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-08-23 Thread Tom Gundersen
On 24 Aug 2013 03:51, "Colin Walters" wrote: > > First, thanks for working on this, most of these patches look sane to > me. > > On Fri, 2013-08-23 at 15:09 +0800, Tom Gundersen wrote: > > > +if (path_equal(m->where, "/") || > > +path_equal(m->where, "/usr")) > > +

Re: [systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-08-23 Thread Colin Walters
First, thanks for working on this, most of these patches look sane to me. On Fri, 2013-08-23 at 15:09 +0800, Tom Gundersen wrote: > +if (path_equal(m->where, "/") || > +path_equal(m->where, "/usr")) > +return false; But it annoys me that we're propagating this

[systemd-devel] [PATCH 6/7] mount: filesystems mounted in the initrd should not conflict with umount.target in the real root

2013-08-23 Thread Tom Gundersen
These mounts should be kept around and unmounted in the shutdown ramfs. Currently, we will still attempt to umount these in the final kill spree, but we should consider avoiding that too. --- src/core/mount.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff