[systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
Hello, Lennart Poettering [2015-05-28 19:44 +0200]: I really think this should work as close as the usual *at() calls work. i.e. take a dir fd as first argument, and a filename *within*that*directory* to check. Maybe even give it the _at() suffix: int fd_is_mount_point_at(int fd, const char

Re: [systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Martin Pitt
Lennart Poettering [2015-05-29 17:31 +0200]: I think this: flags = flags ~AT_SYMLINK_FOLLOW; should better be written like this: flags = ~AT_SYMLINK_FOLLOW; this matches the other if branch better then... Of course, little brainfart.. Looks good otherwise, please

Re: [systemd-devel] [PATCH v2 1/2] path-util: Fix path_is_mount_point for files

2015-05-29 Thread Lennart Poettering
On Fri, 29.05.15 17:22, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello, Lennart Poettering [2015-05-28 19:44 +0200]: I really think this should work as close as the usual *at() calls work. i.e. take a dir fd as first argument, and a filename *within*that*directory* to check. Maybe