Re: [systemd-devel] [PATCH 1/2] kernel-install: avoid using 'cp --preserve'

2013-09-29 Thread Jan Engelhardt
On Thursday 2013-09-26 01:18, Mantas Mikulėnas wrote: >> -cp --preserve "$KERNEL_IMAGE" "$BOOT_DIR_ABS/linux" || { >> +cp "$KERNEL_IMAGE" "$BOOT_DIR_ABS/linux" && >> + chown root:root "$BOOT_DIR_ABS/linux" && >> + chmod 0600 "$BOOT_DIR_ABS/linux" || { > >How about `install -m 0600 -o root -g r

Re: [systemd-devel] [PATCH 1/2] kernel-install: avoid using 'cp --preserve'

2013-09-25 Thread Kay Sievers
On Thu, Sep 26, 2013 at 2:50 AM, Sébastien Luttringer wrote: > On Thu, Sep 26, 2013 at 1:45 AM, Kay Sievers wrote: >>> On non UEFI systems, world readable rights set by kernel-install matter. >> >> Why would that matter? > On non UEFI system your boot partition (when there is one) is almost > _n

Re: [systemd-devel] [PATCH 1/2] kernel-install: avoid using 'cp --preserve'

2013-09-25 Thread Sébastien Luttringer
On Thu, Sep 26, 2013 at 1:45 AM, Kay Sievers wrote: > On Thu, Sep 26, 2013 at 1:13 AM, Sébastien Luttringer wrote: >> On Thu, Sep 26, 2013 at 12:56 AM, Kay Sievers wrote: >>> On Thu, Sep 26, 2013 at 12:38 AM, Tom Gundersen wrote: Force 0600 and root:root instead, to avoid problems with fat

Re: [systemd-devel] [PATCH 1/2] kernel-install: avoid using 'cp --preserve'

2013-09-25 Thread Kay Sievers
On Thu, Sep 26, 2013 at 1:13 AM, Sébastien Luttringer wrote: > On Thu, Sep 26, 2013 at 12:56 AM, Kay Sievers wrote: >> On Thu, Sep 26, 2013 at 12:38 AM, Tom Gundersen wrote: >>> Force 0600 and root:root instead, to avoid problems with fat filesystems. >> >> Sounds fine to me, to enforce root per

Re: [systemd-devel] [PATCH 1/2] kernel-install: avoid using 'cp --preserve'

2013-09-25 Thread Mantas Mikulėnas
On Thu, Sep 26, 2013 at 1:38 AM, Tom Gundersen wrote: > Force 0600 and root:root instead, to avoid problems with fat filesystems. > --- > src/kernel-install/90-loaderentry.install | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/kernel-install/90-loaderentry.install

Re: [systemd-devel] [PATCH 1/2] kernel-install: avoid using 'cp --preserve'

2013-09-25 Thread Sébastien Luttringer
On Thu, Sep 26, 2013 at 12:56 AM, Kay Sievers wrote: > On Thu, Sep 26, 2013 at 12:38 AM, Tom Gundersen wrote: >> Force 0600 and root:root instead, to avoid problems with fat filesystems. > > Sounds fine to me, to enforce root permissions. Boot kernel was world readable, and it makes sense. Why m

Re: [systemd-devel] [PATCH 1/2] kernel-install: avoid using 'cp --preserve'

2013-09-25 Thread Kay Sievers
On Thu, Sep 26, 2013 at 12:38 AM, Tom Gundersen wrote: > Force 0600 and root:root instead, to avoid problems with fat filesystems. Sounds fine to me, to enforce root permissions. If people want special permissions, they can always drop-in their own install.d/ callout to mangle them. Kay ___