[systemd-devel] [RFC][PATCH] sd-bus: split ref-counting of queues from ref-counting of the rest of the sd-bus object

2014-03-23 Thread Tom Gundersen
Introduce a new ref-count, n_ref_queues, which only protects the {r,w}queue of a bus, and introduce bus_{un,}ref(), which are only available internally, and which do not protect these queues. Make sure that sd_bus_message object do not call sd_bus_ref(), but only the internal bus_ref(). This is

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Tom Gundersen
On Sun, Mar 23, 2014 at 4:14 PM, Susant Sahani sus...@redhat.com wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs super user privileges to run and respective kernel

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp. Yeah, that looks useful. You don't test negative values. Maybe you could an example with a negative value to the documentation and tests? Zbyszek Suggested by:

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp. Yeah, that looks useful. You don't test negative values. Maybe you could an example

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Susant Sahani
On 03/23/2014 09:34 PM, Tom Gundersen wrote: On Sun, Mar 23, 2014 at 4:14 PM, Susant Sahani sus...@redhat.com wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs super

Re: [systemd-devel] [PATCH 1/1] sd-rtnl: add support for tunnel attributes

2014-03-23 Thread Susant Sahani
On 03/23/2014 10:00 PM, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 08:44:09PM +0530, Susant Sahani wrote: Added support for tunneling netlink attrributes (ipip, gre, sit). These works with kernel module ipip, gre and sit . The test cases are commented out because they requirs

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Tollef Fog Heen
]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp. Yeah, that looks useful. You don't test negative values. Maybe

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: ]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner wrote: Also adds a few tests for the absolute cases of parse_timestamp.

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Mar 23, 2014 at 02:27:04PM -0400, Dave Reisner wrote: On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: ]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 11:06:47AM -0400, Dave Reisner

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Dave Reisner
On Sun, Mar 23, 2014 at 10:04:00PM +0100, Zbigniew Jędrzejewski-Szmek wrote: On Sun, Mar 23, 2014 at 02:27:04PM -0400, Dave Reisner wrote: On Sun, Mar 23, 2014 at 06:30:02PM +0100, Tollef Fog Heen wrote: ]] Dave Reisner On Sun, Mar 23, 2014 at 05:27:08PM +0100, Zbigniew

[systemd-devel] [PATCH 1/2] endpoint: free the policy_db on error path

2014-03-23 Thread Djalal Harouni
Signed-off-by: Djalal Harouni tix...@opendz.org --- endpoint.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/endpoint.c b/endpoint.c index 465ae31..5afabf9 100644 --- a/endpoint.c +++ b/endpoint.c @@ -236,7 +236,7 @@ int kdbus_ep_new(struct kdbus_bus *bus, const char

[systemd-devel] [PATCH 2/2] test-kdbus: rename check bus and domain functions

2014-03-23 Thread Djalal Harouni
Signed-off-by: Djalal Harouni tix...@opendz.org --- test/test-kdbus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test-kdbus.c b/test/test-kdbus.c index 0427419..6f9b3e9 100644 --- a/test/test-kdbus.c +++ b/test/test-kdbus.c @@ -259,7 +259,7 @@ static int

Re: [systemd-devel] [RFC][PATCH] sd-bus: split ref-counting of queues from ref-counting of the rest of the sd-bus object

2014-03-23 Thread David Herrmann
Hi On Sun, Mar 23, 2014 at 4:49 PM, Tom Gundersen t...@jklm.no wrote: Introduce a new ref-count, n_ref_queues, which only protects the {r,w}queue of a bus, and introduce bus_{un,}ref(), which are only available internally, and which do not protect these queues. Make sure that sd_bus_message

Re: [systemd-devel] [RFC][PATCH] sd-bus: split ref-counting of queues from ref-counting of the rest of the sd-bus object

2014-03-23 Thread Tom Gundersen
On Sun, Mar 23, 2014 at 11:50 PM, David Herrmann dh.herrm...@gmail.com wrote: On Sun, Mar 23, 2014 at 4:49 PM, Tom Gundersen t...@jklm.no wrote: Introduce a new ref-count, n_ref_queues, which only protects the {r,w}queue of a bus, and introduce bus_{un,}ref(), which are only available

[systemd-devel] [PATCH] handle: unref handle-ep and free handle-meta on error path

2014-03-23 Thread Djalal Harouni
Signed-off-by: Djalal Harouni tix...@opendz.org --- handle.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/handle.c b/handle.c index 921faca..3af6119 100644 --- a/handle.c +++ b/handle.c @@ -130,7 +130,7 @@ static int kdbus_handle_open(struct inode *inode, struct

Re: [systemd-devel] [PATCH] time-util: accept epoch timetamps prefixed with @

2014-03-23 Thread Lennart Poettering
On Sun, 23.03.14 11:06, Dave Reisner (dreis...@archlinux.org) wrote: Also adds a few tests for the absolute cases of parse_timestamp. Suggested by: Mantas Mikulėnas graw...@gmail.com --- src/shared/time-util.c | 10 ++ src/test/test-time.c | 21 + 2 files

Re: [systemd-devel] stopping a systemd-nspwan container

2014-03-23 Thread Lennart Poettering
On Sat, 22.03.14 16:35, Kevin Wilson (wkev...@gmail.com) wrote: Hello, I had created a container according to systemd-nspwan man page and ran it by: systemd-nspawn -D/srv/mycontainer I killed it by pkill systemd-nspaw (and not by poweroff from within the container). Now, running

Re: [systemd-devel] journal handling of process title changes

2014-03-23 Thread Lennart Poettering
On Sun, 23.03.14 00:32, Patrick Donnelly (batr...@batbytes.com) wrote: It seems the journal is reading from /proc/pid/cmdline (argv[0]) for each entry. So when reading using journalctl, we don't see process title changes properly. See the below example: We are reading both /proc/$PID/comm and

Re: [systemd-devel] journal handling of process title changes

2014-03-23 Thread Patrick Donnelly
[adding message to list, sorry Lennart...] On Sun, Mar 23, 2014 at 9:25 PM, Lennart Poettering lenn...@poettering.net wrote: On Sun, 23.03.14 00:32, Patrick Donnelly (batr...@batbytes.com) wrote: It seems the journal is reading from /proc/pid/cmdline (argv[0]) for each entry. So when reading

Re: [systemd-devel] [PATCH 1/2] endpoint: free the policy_db on error path

2014-03-23 Thread Kay Sievers
On Sun, Mar 23, 2014 at 11:06 PM, Djalal Harouni tix...@opendz.org wrote: Signed-off-by: Djalal Harouni tix...@opendz.org --- endpoint.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Applied. Thanks, Kay ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH 2/2] test-kdbus: rename check bus and domain functions

2014-03-23 Thread Kay Sievers
On Sun, Mar 23, 2014 at 11:06 PM, Djalal Harouni tix...@opendz.org wrote: Signed-off-by: Djalal Harouni tix...@opendz.org --- test/test-kdbus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Applied. Thanks, Kay ___ systemd-devel