Re: [systemd-devel] systemctl preset and chkconfig

2014-08-26 Thread Colin Guthrie
Lennart Poettering wrote on 26/08/14 02:19: > On Fri, 22.08.14 15:51, Colin Guthrie (gm...@colin.guthr.ie) wrote: > >> Hi, >> >> I recently changed my %post scripts in Mageia to use systemctl preset >> rather than systemctl enable to allow for policy-based overrides of >> "enable on install" behav

Re: [systemd-devel] timesyncd: Frequent polling when no server could be reached

2014-08-26 Thread Kay Sievers
On Tue, Aug 26, 2014 at 3:37 AM, Lennart Poettering wrote: > On Fri, 22.08.14 10:13, Miroslav Lichvar (mlich...@redhat.com) wrote: > >> > Polluting my log this way. Is is possible to inhibit that behavior? Maybe >> > trying a couple of times, then giving up until next network status change. >> >>

[systemd-devel] Preventing automatic seat assignments

2014-08-26 Thread Tanu Kaskinen
Hi, If I want to designate some sound card to be shared between seats, then I suppose that sound card shouldn't be assigned to any seats. However, currently /usr/lib/udev/rules.d/71-seat.rules unconditionally tags all sound cards with the "seat" tag. How should this be solved? My current sol

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Miroslav Lichvar
On Tue, Aug 26, 2014 at 03:27:10AM +0200, Lennart Poettering wrote: > On Thu, 21.08.14 12:49, Miroslav Lichvar (mlich...@redhat.com) wrote: > > > This is useful for installations where some other service than > > systemd-timesyncd is used to synchronize the system clock. > > What's the rationale

[systemd-devel] [PATCH] Add missing short option 'i' to optstring

2014-08-26 Thread Łukasz Stelmach
--- src/network/networkd-wait-online.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/networkd-wait-online.c b/src/network/networkd-wait-online.c index 6c2fdd1..7143436 100644 --- a/src/network/networkd-wait-online.c +++ b/src/network/networkd-wait-online.c @@ -59

[systemd-devel] [PATCH] systemctl: fix broken list-unit-files with --root

2014-08-26 Thread Lukas Nykryn
--- src/shared/install.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/shared/install.c b/src/shared/install.c index 4b09a69..3ef995a 100644 --- a/src/shared/install.c +++ b/src/shared/install.c @@ -2072,6 +2072,7 @@ int unit_file_get_list( for (;;)

Re: [systemd-devel] [RFC] [PATCHv3 2/3] resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-26 Thread Ivan Shapovalov
On Tuesday 26 August 2014 at 02:59:25, Lennart Poettering wrote: > [...] > > > > This is absolutely not fatal, and arguably not an error condition at all. > > > > If a machine is simply rebooted, without hibernation image in place (but > > with > > resume= kernel parameter), this code pa

Re: [systemd-devel] [RFC] [PATCHv3 3/3] resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Ivan Shapovalov
On Tuesday 26 August 2014 at 03:03:57, Lennart Poettering wrote: > On Mon, 25.08.14 22:27, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > On Monday 25 August 2014 at 19:58:52, Lennart Poettering wrote: > > > [...] > > > > > > One more question though, regarding the terminology.

Re: [systemd-devel] [RFC] [PATCHv3 0/3] resume: implement support for resuming from hibernation

2014-08-26 Thread Ivan Shapovalov
On Tuesday 26 August 2014 at 03:00:30, Lennart Poettering wrote: > On Mon, 25.08.14 22:23, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > > So, I am pretty sure we don#t want an explicit After= order here between > > > dbus and systemd-resume@.service... > > > > > > Hmm, but yuck, I

Re: [systemd-devel] systemctl preset and chkconfig

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 08:59, Colin Guthrie (gm...@colin.guthr.ie) wrote: > >> If not, it's probably quicker and easier for me to do the work and > >> maintain it in scripts rather than systemctl itself, hence why I figured > >> I'd ask first. > > > > Currently the compat support for chkconfig is nicel

Re: [systemd-devel] Preventing automatic seat assignments

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 12:17, Tanu Kaskinen (tanu.kaski...@linux.intel.com) wrote: > Hi, > > If I want to designate some sound card to be shared between seats, > then I suppose that sound card shouldn't be assigned to any seats. > However, currently /usr/lib/udev/rules.d/71-seat.rules > unconditionally

Re: [systemd-devel] [RFC] [PATCHv3 3/3] resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Ivan Shapovalov
On Monday 25 August 2014 at 19:58:52, Lennart Poettering wrote: > On Mon, 25.08.14 02:16, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > + > > +static const char *arg_dest = "/tmp"; > > +static char *arg_resume_dev = NULL; > > + > > +static int parse_proc_cmdline_item(const char *key, const

[systemd-devel] [PATCHv4 2/3] resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-26 Thread Ivan Shapovalov
This can be used to initiate a resume from hibernation by path to a swap device containing the hibernation image. The respective templated unit is also added. It is instantiated using path to the desired resume device. --- Makefile-man.am | 7 Makefile.am

[systemd-devel] [PATCHv4 1/3] units: order systemd-fsck@.service after local-fs-pre.target.

2014-08-26 Thread Ivan Shapovalov
With this change, it becomes possible to order a unit to activate before any modifications to the file systems. This is especially useful for supporting resume from hibernation. --- units/systemd-f...@.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/units/systemd-f..

[systemd-devel] [PATCHv4 0/3] resume: implement support for resuming from hibernation

2014-08-26 Thread Ivan Shapovalov
This patchset allows systemd to parse resume= kernel command line parameter and initiate resume from the specified device. It adds: - a 'systemd-resume' tool which takes path to a device node and writes its major:minor to /sys/power/state; - a corresponding 'systemd-resume@.service' templated un

[systemd-devel] [PATCHv4 3/3] resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Ivan Shapovalov
resume-generator understands resume= kernel command line parameter and instantiates the systemd-resume@.service accordingly if it is passed. This enables resume from hibernation using device specified on the kernel command line, where the device path may point to an arbitrary udev-created symlink,

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 11:41, Miroslav Lichvar (mlich...@redhat.com) wrote: > > > This is useful for installations where some other service than > > > systemd-timesyncd is used to synchronize the system clock. > > > > What's the rationale here? > > To have timedated/timedatectl managing the right NTP

Re: [systemd-devel] systemctl preset and chkconfig

2014-08-26 Thread Andrei Borzenkov
On Tue, Aug 26, 2014 at 3:56 PM, Lennart Poettering wrote: > On Tue, 26.08.14 08:59, Colin Guthrie (gm...@colin.guthr.ie) wrote: > >> I have to say tho', I'm surprised this is something implemented in PID1. >> I hadn't looked at the code, but I thought (well assumed) "systemctl >> preset" was actu

Re: [systemd-devel] systemctl preset and chkconfig

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 16:29, Andrei Borzenkov (arvidj...@gmail.com) wrote: > >> I have to say tho', I'm surprised this is something implemented in PID1. > >> I hadn't looked at the code, but I thought (well assumed) "systemctl > >> preset" was actually implemented on the client side. I guess it's true

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Andrei Borzenkov
On Tue, Aug 26, 2014 at 4:21 PM, Lennart Poettering wrote: > On Tue, 26.08.14 11:41, Miroslav Lichvar (mlich...@redhat.com) wrote: > >> > > This is useful for installations where some other service than >> > > systemd-timesyncd is used to synchronize the system clock. >> > >> > What's the rational

Re: [systemd-devel] systemctl preset and chkconfig

2014-08-26 Thread Andrei Borzenkov
On Tue, Aug 26, 2014 at 4:34 PM, Lennart Poettering wrote: > On Tue, 26.08.14 16:29, Andrei Borzenkov (arvidj...@gmail.com) wrote: > >> >> I have to say tho', I'm surprised this is something implemented in PID1. >> >> I hadn't looked at the code, but I thought (well assumed) "systemctl >> >> prese

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 16:34, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > I don't really think that timedated should manage an NTP server like > > ntpd/chrony. timedated's primary job is to be a service to GNOME and > > other DEs. But if an admin wants to upgrade to a full NTP server, then > > he

Re: [systemd-devel] systemctl preset and chkconfig

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 16:37, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > On Tue, Aug 26, 2014 at 4:34 PM, Lennart Poettering > wrote: > > On Tue, 26.08.14 16:29, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > >> >> I have to say tho', I'm surprised this is something implemented in PID1. >

Re: [systemd-devel] Build errors with lto and compat-libs

2014-08-26 Thread Michael Olbrich
On Mon, Aug 18, 2014 at 03:48:09PM +0200, Lennart Poettering wrote: > On Sun, 17.08.14 09:54, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > With --enable-compat-libs building fails like this: > > > > CCLD libsystemd-journal.la > > [...] > > /tmp/ccISOiYU.ltrans1.ltrans.o: In function

Re: [systemd-devel] [PATCHv4 3/3] resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Dave Reisner
On Tue, Aug 26, 2014 at 04:11:05PM +0400, Ivan Shapovalov wrote: > resume-generator understands resume= kernel command line parameter and > instantiates the systemd-resume@.service accordingly if it is passed. > > This enables resume from hibernation using device specified on the kernel > command

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Miroslav Lichvar
On Tue, Aug 26, 2014 at 02:21:10PM +0200, Lennart Poettering wrote: > On Tue, 26.08.14 11:41, Miroslav Lichvar (mlich...@redhat.com) wrote: > > To have timedated/timedatectl managing the right NTP service on > > distributions like Fedora. > > I don't really think that timedated should manage an NT

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Simon Peeters
2014-08-26 14:37 GMT+02:00 Lennart Poettering : > On Tue, 26.08.14 16:34, Andrei Borzenkov (arvidj...@gmail.com) wrote: > >> > I don't really think that timedated should manage an NTP server like >> > ntpd/chrony. timedated's primary job is to be a service to GNOME and >> > other DEs. But if an adm

Re: [systemd-devel] [PATCHv4 3/3] resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Ivan Shapovalov
On Tuesday 26 August 2014 at 09:18:30, Dave Reisner wrote: > On Tue, Aug 26, 2014 at 04:11:05PM +0400, Ivan Shapovalov wrote: > > resume-generator understands resume= kernel command line parameter and > > instantiates the systemd-resume@.service accordingly if it is passed. > > > > This enab

Re: [systemd-devel] [PATCH] missing: add BPF_XOR

2014-08-26 Thread Michael Olbrich
On Thu, Aug 21, 2014 at 01:51:50PM +0200, Michal Sekletar wrote: > On Thu, Aug 21, 2014 at 12:38:08PM +0200, Michael Olbrich wrote: > > BPF_XOR was introduced in kernel 3.7 > > --- > > > > This fixes compiling systemd for me. I'm not sure about the implications of > > this. I'm not sure what happe

[systemd-devel] [PATCH] bootchart: only show printable processes

2014-08-26 Thread WaLyong Cho
This case really shouldn't be happen. (But actually sometime that was happen.) Eeven if happened we maybe want to see the bootchart exclude not printable processes. --- src/bootchart/svg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/bootchart/svg.c b/src/bootchart/svg.c index 135883

[systemd-devel] instantiated services set up

2014-08-26 Thread Jan Včelák
Hello list! I have a few questions regarding a proper way to setup and use template instantiated services. We develop an authoritative DNS server called Knot DNS. Currently, we provide knot.service unit file to start a single instance of the server. However, some of our users need multiple ins

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Marcel Holtmann
Hi Miroslav, >>> To have timedated/timedatectl managing the right NTP service on >>> distributions like Fedora. >> >> I don't really think that timedated should manage an NTP server like >> ntpd/chrony. > > I'm talking about NTP clients, not servers. Writing a good NTP client > is the difficult

Re: [systemd-devel] [PATCH] bootchart: only show printable processes

2014-08-26 Thread Mantas Mikulėnas
On Tue, Aug 26, 2014 at 5:07 PM, WaLyong Cho wrote: > > This case really shouldn't be happen. (But actually sometime that was > happen.) Eeven if happened we maybe want to see the bootchart exclude > not printable processes. > --- > src/bootchart/svg.c | 3 +++ > 1 file changed, 3 insertions(+) >

Re: [systemd-devel] instantiated services set up

2014-08-26 Thread Andrei Borzenkov
В Tue, 26 Aug 2014 16:43:47 +0200 Jan Včelák пишет: > Hello list! > > I have a few questions regarding a proper way to setup and use template > instantiated services. > > We develop an authoritative DNS server called Knot DNS. Currently, we provide > knot.service unit file to start a single i

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Miroslav Lichvar
On Tue, Aug 26, 2014 at 07:50:23AM -0700, Marcel Holtmann wrote: > and writing a good DHCP client was supposedly also really hard. > Guess what we have done that twice now and both of our clients are > better than everything else out there. And guess what, we did the > same for NTP. Are you saying

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Marcel Holtmann
Hi Miroslav, >> and writing a good DHCP client was supposedly also really hard. >> Guess what we have done that twice now and both of our clients are >> better than everything else out there. And guess what, we did the >> same for NTP. > > Are you saying timesyncd is already better than chronyd o

Re: [systemd-devel] Bug#758050: udev: ID_VENDOR_FROM_DATABASE, ID_MODEL_FROM_DATABASE for unrecognised USB device are taken from USB hub

2014-08-26 Thread Kay Sievers
On Thu, Aug 14, 2014 at 9:01 PM, Kay Sievers wrote: > On Thu, Aug 14, 2014 at 3:07 PM, Simon McVittie > wrote: >> I recently opened this Debian bug, for which I attach a >> patch that seems to work. Bug report quoted in full below. >> >> I would appreciate udev maintainers' opinions on whether th

[systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Vasiliy Tolstov
Hi. What is proper way to shutdown systemd enabled host? I can run systemctl poweroff, do glibc call shutdown or run shutdown -P now... I'm prefer glibc call, does it proper shutdown system with systemd (and other init systems like sysvinit and upstart) ? -- Vasiliy Tolstov, e-mail: v.tols...@sel

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 15:44, Miroslav Lichvar (mlich...@redhat.com) wrote: > > timedated's primary job is to be a service to GNOME and > > other DEs. But if an admin wants to upgrade to a full NTP server, then > > he should really enable/disable that with "systemctl" or a similar > > command. > > Dist

Re: [systemd-devel] dell rbu driver and FW_LOADER_USER_HELPER

2014-08-26 Thread Luis R. Rodriguez
On Tue, Aug 26, 2014 at 07:09:46PM +0200, Luis R. Rodriguez wrote: > When Christian tried removing the udev firmware loader > it was detected that the Dell rbu driver still required > use of FW_LOADER_USER_HELPER [0]. This driver needed > reworking to not be tied to the firmware loader, curious > i

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 17:45, Miroslav Lichvar (mlich...@redhat.com) wrote: > > On Tue, Aug 26, 2014 at 07:50:23AM -0700, Marcel Holtmann wrote: > > and writing a good DHCP client was supposedly also really hard. > > Guess what we have done that twice now and both of our clients are > > better than eve

Re: [systemd-devel] dell rbu driver and FW_LOADER_USER_HELPER

2014-08-26 Thread Tom Gundersen
On Tue, Aug 26, 2014 at 7:14 PM, Luis R. Rodriguez wrote: > On Tue, Aug 26, 2014 at 07:09:46PM +0200, Luis R. Rodriguez wrote: >> When Christian tried removing the udev firmware loader >> it was detected that the Dell rbu driver still required >> use of FW_LOADER_USER_HELPER [0]. This driver neede

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 15:56, Simon Peeters (peeters.si...@gmail.com) wrote: > > 2014-08-26 14:37 GMT+02:00 Lennart Poettering : > > On Tue, 26.08.14 16:34, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > >> > I don't really think that timedated should manage an NTP server like > >> > ntpd/chrony.

Re: [systemd-devel] timesyncd: Frequent polling when no server could be reached

2014-08-26 Thread Florian Lindner
>>> > Another question I have is about the NTP status output of timedatectl. >>> > >>> > Right now (with ntpd running) it says: >>> > >>> > NTP enabled: yes >>> > NTP synchronized: no >>> > >>> > I suppose it need some more uptime than the 11 minutes I have >>> > currently? >>> >>> Possibly, ntpd

Re: [systemd-devel] [PATCH] missing: add BPF_XOR

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 16:03, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > On Thu, Aug 21, 2014 at 01:51:50PM +0200, Michal Sekletar wrote: > > On Thu, Aug 21, 2014 at 12:38:08PM +0200, Michael Olbrich wrote: > > > BPF_XOR was introduced in kernel 3.7 > > > --- > > > > > > This fixes compilin

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Marco d'Itri
On Aug 26, Lennart Poettering wrote: > If it makes you happy, then I can add a big warning to configure, if > people build things and don't specify their own NTP servers... The history is full of people who got burned by using somebody's else NTP servers without permission, so unless Google will

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 20:34, Vasiliy Tolstov (v.tols...@selfip.ru) wrote: > Hi. What is proper way to shutdown systemd enabled host? > I can run systemctl poweroff, do glibc call shutdown or run shutdown -P > now... > I'm prefer glibc call, does it proper shutdown system with systemd (and > other init

Re: [systemd-devel] instantiated services set up

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 16:43, Jan Včelák (jan.vce...@nic.cz) wrote: > knot.service: > > [Unit] > > Description=Knot DNS Server > > After=syslog.target network.target > > > > [Service] > > ExecStart=/usr/sbin/knotd -c /etc/knot/knot.conf > > ExecReload=/usr/sbin/knotc -c /etc/knot/knot.conf reload > >

Re: [systemd-devel] [PATCH] timedated: add configure option to set name of controlled NTP service

2014-08-26 Thread Andrei Borzenkov
В Tue, 26 Aug 2014 19:19:01 +0200 Lennart Poettering пишет: > On Tue, 26.08.14 17:45, Miroslav Lichvar (mlich...@redhat.com) wrote: > > > > > On Tue, Aug 26, 2014 at 07:50:23AM -0700, Marcel Holtmann wrote: > > > and writing a good DHCP client was supposedly also really hard. > > > Guess what w

Re: [systemd-devel] [RFC] [PATCHv3 2/3] resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 04:45, Ivan Shapovalov (intelfx...@gmail.com) wrote: > On Tuesday 26 August 2014 at 02:59:25, Lennart Poettering wrote: > > [...] > > > > > > This is absolutely not fatal, and arguably not an error condition at all. > > > > > > If a machine is simply rebooted, without hibe

Re: [systemd-devel] [RFC] [PATCHv3 3/3] resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 15:49, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > Hmm, the fact that the kernel cmdline option is named "resume" is > > probably a strong indication we should stick to that nomenclature, after > > all that's UI already in away... > > > > But maybe call it "systemd-hibernat

Re: [systemd-devel] [PATCH] journal: grant systemd-journal group permission

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 15:43, WaLyong Cho (walyong@samsung.com) wrote: > There is no Bofore= or After= dependencies between > systemd-journald.service and systemd-tmpfiles-setup.service. So if both > "/run/log/journal" and "/var/log/journal" does not exist then those can > be make as root:root and a

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Mantas Mikulėnas
On Tue, Aug 26, 2014 at 7:34 PM, Vasiliy Tolstov wrote: > Hi. What is proper way to shutdown systemd enabled host? > I can run systemctl poweroff, do glibc call shutdown or run shutdown -P > now... > I'm prefer glibc call, does it proper shutdown system with systemd (and > other init systems like

Re: [systemd-devel] systemctl preset and chkconfig

2014-08-26 Thread Andrei Borzenkov
В Tue, 26 Aug 2014 14:38:52 +0200 Lennart Poettering пишет: > On Tue, 26.08.14 16:37, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > > > On Tue, Aug 26, 2014 at 4:34 PM, Lennart Poettering > > wrote: > > > On Tue, 26.08.14 16:29, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > > > >>

Re: [systemd-devel] systemctl preset and chkconfig

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 21:58, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > В Tue, 26 Aug 2014 14:38:52 +0200 > Lennart Poettering пишет: > > > On Tue, 26.08.14 16:37, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > > > > > > On Tue, Aug 26, 2014 at 4:34 PM, Lennart Poettering > > > wrote:

Re: [systemd-devel] [PATCH] systemctl: fix broken list-unit-files with --root

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 13:36, Lukas Nykryn (lnyk...@redhat.com) wrote: Looks good! Please commit! > --- > src/shared/install.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/shared/install.c b/src/shared/install.c > index 4b09a69..3ef995a 100644 > --- a/src/shared/

Re: [systemd-devel] [PATCH] missing: add BPF_XOR

2014-08-26 Thread Lennart Poettering
On Thu, 21.08.14 12:38, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > BPF_XOR was introduced in kernel 3.7 Applied. Thanks! Lennart -- Lennart Poettering, Red Hat ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.f

Re: [systemd-devel] [PATCH] NEWS: Fix typos.

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 00:19, Ansgar Burchardt (ans...@debian.org) wrote: > From: Ansgar Burchardt Thanks! Applied! > > --- > NEWS | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/NEWS b/NEWS > index 7dad765..2fca2cd 100644 > --- a/NEWS > +++ b/NEWS > @@ -42,8 +42,8 @

Re: [systemd-devel] [PATCH] Add missing short option 'i' to optstring

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 12:28, Łukasz Stelmach (stl...@poczta.fm) wrote: Thanks! Applied! > --- > src/network/networkd-wait-online.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/network/networkd-wait-online.c > b/src/network/networkd-wait-online.c > index 6c2fdd1..714

Re: [systemd-devel] [PATCH 0/3] Using assert_se() on actions with side effects on test cases

2014-08-26 Thread Lennart Poettering
On Mon, 25.08.14 22:05, Filipe Brandenburger (filbran...@google.com) wrote: Applied all three! Thanks! And yes, I agree, all tests should use assert_se(), never assert(). Quite a few tests snuck in though that used assert() instead. WOuld be happy to take a patch correcting this! > I bumped into

Re: [systemd-devel] [PATCH] sd-bus: kdbus: monitor connections use the KDBUS_HELLO_MONITOR flag

2014-08-26 Thread Lennart Poettering
On Fri, 22.08.14 16:40, Djalal Harouni (tix...@opendz.org) wrote: I have removed the call now, as it is indeed unused, and we already have full monitor support in the library itself, so this will never be used. Thanks for the notification. > --- > Currently this bus_kernel_create_monitor() is no

Re: [systemd-devel] [PATCH] systemctl: Correct error message printed when bus_process_wait fails

2014-08-26 Thread Lennart Poettering
On Sat, 23.08.14 21:11, Sjoerd Simons (sjoerd.sim...@collabora.co.uk) wrote: > Actually use the variable containing the return code of bus_process_wait when > printing the error message as a result of it failing. Thanks! Applied! > --- > src/systemctl/systemctl.c | 2 +- > 1 file changed, 1 ins

Re: [systemd-devel] [PATCH] shared: make container_of() use unique variable names

2014-08-26 Thread Lennart Poettering
On Fri, 22.08.14 14:54, David Herrmann (dh.herrm...@gmail.com) wrote: Looks good to me. Go ahead, commit. > If you stack container_of() macros, you will get warnings due to shadowing > variables of the parent context. To avoid this, use unique names for > variables. > > Two new helpers are added

Re: [systemd-devel] [PATCH] bootchart: only show printable processes

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 18:11, Mantas Mikulėnas (graw...@gmail.com) wrote: > On Tue, Aug 26, 2014 at 5:07 PM, WaLyong Cho wrote: > > > > This case really shouldn't be happen. (But actually sometime that was > > happen.) Eeven if happened we maybe want to see the bootchart exclude > > not printable proce

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Vasiliy Tolstov
2014-08-26 21:56 GMT+04:00 Mantas Mikulėnas : > > Which glibc call exactly are you referring to? > > reboot() tells the kernel to shut down (or reboot) immediately – it > doesn't call init, and it doesn't even as much as sync disks. > > shutdown() has nothing to do with system power state; it close

Re: [systemd-devel] [PATCH 2/2 v3] socket: introduce SELinuxContextFromNet option

2014-08-26 Thread Lennart Poettering
On Mon, 25.08.14 10:02, Michal Sekletar (msekl...@redhat.com) wrote: > +int label_get_our_label(char **label) { > +int r = 0; > +char *l = NULL; > + > +#ifdef HAVE_SELINUX > +r = getcon(&l); > +if (r < 0) > +return r; > + > +*label = l; > +#e

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Vasiliy Tolstov
2014-08-26 21:32 GMT+04:00 Lennart Poettering : > From which language? From C, I'd recommend issuing the PowerOff() method > on logind's manager object via the bus. From the shell, i'd recommend > "systemctl poweroff", which does exactly that. Thanks, but does it possible to shutdown system via r

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Thomas Suckow
On 08/26/2014 11:54 AM, Vasiliy Tolstov wrote: 2014-08-26 21:32 GMT+04:00 Lennart Poettering : From which language? From C, I'd recommend issuing the PowerOff() method on logind's manager object via the bus. From the shell, i'd recommend "systemctl poweroff", which does exactly that. Thanks,

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Vasiliy Tolstov
2014-08-26 23:06 GMT+04:00 Thomas Suckow : > No. > > http://linux.die.net/man/2/reboot > Note the repeating statement of "If not preceded by a sync(2), data will be > lost." > > I would follow Lennart's advice. What problem to run sync before that? I'm not understand. Also i can run firfreeze ioc

Re: [systemd-devel] [PATCH] tty-ask-password-agent: reset a signal handler for SIGTERM to the default

2014-08-26 Thread Lennart Poettering
On Mon, 25.08.14 12:32, HATAYAMA Daisuke (d.hatay...@jp.fujitsu.com) wrote: > Hello, Heya! > When trapping SIGTERM in a script and running systemctl from the > script, systemctl sometimes hangs with tty-ask-password agent process. Hmm, so in general, if people invoke our tools with weird signal

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Jon Stanley
On Tue, Aug 26, 2014 at 3:11 PM, Vasiliy Tolstov wrote: > What problem to run sync before that? I'm not understand. Also i can > run firfreeze ioctl to fs and run reboot. To get dirty data writed to > disk. Problem is that none of the shutdown logic of any init system (be it systemd, upstart, sys

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Mantas Mikulėnas
On Tue, Aug 26, 2014 at 10:17 PM, Jon Stanley wrote: > On Tue, Aug 26, 2014 at 3:11 PM, Vasiliy Tolstov wrote: >> What problem to run sync before that? I'm not understand. Also i can >> run firfreeze ioctl to fs and run reboot. To get dirty data writed to >> disk. > > Problem is that none of the

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 22:54, Vasiliy Tolstov (v.tols...@selfip.ru) wrote: > > 2014-08-26 21:32 GMT+04:00 Lennart Poettering : > > From which language? From C, I'd recommend issuing the PowerOff() method > > on logind's manager object via the bus. From the shell, i'd recommend > > "systemctl poweroff",

Re: [systemd-devel] [RFC] [PATCHv3 3/3] resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Ivan Shapovalov
On Tuesday 26 August 2014 at 19:49:08, Lennart Poettering wrote: > On Tue, 26.08.14 15:49, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > > Hmm, the fact that the kernel cmdline option is named "resume" is > > > probably a strong indication we should stick to that nomenclature, after

Re: [systemd-devel] Build errors with lto and compat-libs

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 15:15, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > On Mon, Aug 18, 2014 at 03:48:09PM +0200, Lennart Poettering wrote: > > On Sun, 17.08.14 09:54, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > > With --enable-compat-libs building fails like this: > > > > > >

Re: [systemd-devel] [PATCH] journalctl: verify object size in enumerate_unique

2014-08-26 Thread Lennart Poettering
On Sat, 23.08.14 22:39, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > We assumed that objects in a unique chain are good enough, > and only checked object type. But mmap code crashes when some object > has zero size. This most likely is caused by a corrupted journal > file, but we shoul

Re: [systemd-devel] [PATCH 2/2] udev: do NOT re-label smack

2014-08-26 Thread Lennart Poettering
On Thu, 21.08.14 12:58, WaLyong Cho (walyong@samsung.com) wrote: > If selinux is disabled and smack is only enabled, smack label is > relable-ed by label_fix. To avoid, make only be labeled for selinux. > --- > src/udev/udev-node.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Vasiliy Tolstov
2014-08-26 23:33 GMT+04:00 Lennart Poettering : > Hmm? What's "possible" supposed to mean? I mean, certainly you can > invoke that syscall, and "systemctl reboot -ff" will do that for > you. But I'd really recommend not ever doing that, unless your system is > seriously stuck. > > In systemd, there

[systemd-devel] [PATCHv5 1/3] units: order systemd-fsck@.service after local-fs-pre.target.

2014-08-26 Thread Ivan Shapovalov
With this change, it becomes possible to order a unit to activate before any modifications to the file systems. This is especially useful for supporting resume from hibernation. --- units/systemd-f...@.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/units/systemd-f..

[systemd-devel] [PATCHv5 3/3] hibernate-resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Ivan Shapovalov
hibernate-resume-generator understands resume= kernel command line parameter and instantiates the systemd-resume@.service accordingly if it is passed. This enables resume from hibernation using device specified on the kernel command line, and it may be specified either as "/dev/disk/by-foo/bar" or

[systemd-devel] [PATCHv5 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-26 Thread Ivan Shapovalov
This patchset allows systemd to parse resume= kernel command line parameter and initiate resume from the specified device. It adds: - a 'systemd-hibernate-resume' tool which takes path to a device node and writes its major:minor to /sys/power/resume; - a corresponding 'systemd-hibernate-resume@.

[systemd-devel] [PATCHv5 2/3] hibernate-resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-26 Thread Ivan Shapovalov
This can be used to initiate a resume from hibernation by path to a swap device containing the hibernation image. The respective templated unit is also added. It is instantiated using path to the desired resume device. --- .gitignore | 1 + Makefile-man.am

Re: [systemd-devel] [PATCH 2/2] udev: do NOT re-label smack

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 21:52, Lennart Poettering (lenn...@poettering.net) wrote: > > On Thu, 21.08.14 12:58, WaLyong Cho (walyong@samsung.com) wrote: > > > If selinux is disabled and smack is only enabled, smack label is > > relable-ed by label_fix. To avoid, make only be labeled for selinux. > >

Re: [systemd-devel] Current status wrt. realtime services (aka jackd)

2014-08-26 Thread Ivan Shapovalov
On Tuesday 26 August 2014 at 02:48:04, Lennart Poettering wrote: > On Tue, 26.08.14 02:02, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > Hello all, > > > > is there some replacement of the "ControlGroupAttribute=cpu.rt_runtime_us > > " > > tunable described at > > http://www.freed

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 23:52, Vasiliy Tolstov (v.tols...@selfip.ru) wrote: > > 2014-08-26 23:33 GMT+04:00 Lennart Poettering : > > Hmm? What's "possible" supposed to mean? I mean, certainly you can > > invoke that syscall, and "systemctl reboot -ff" will do that for > > you. But I'd really recommend no

Re: [systemd-devel] Current status wrt. realtime services (aka jackd)

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 23:55, Ivan Shapovalov (intelfx...@gmail.com) wrote: > On Tuesday 26 August 2014 at 02:48:04, Lennart Poettering wrote: > > On Tue, 26.08.14 02:02, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > > > Hello all, > > > > > > is there some replacement of the "ControlGroup

Re: [systemd-devel] [PATCHv5 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 23:53, Ivan Shapovalov (intelfx...@gmail.com) wrote: Looks great, wanted to commit. But the series doesn't apply to current git. Could you please rebase? Thanks! > This patchset allows systemd to parse resume= kernel command line parameter > and initiate resume from the specifie

Re: [systemd-devel] [PATCH 1/2] label: rearrange mandatory access control(MAC) apis

2014-08-26 Thread Lennart Poettering
On Thu, 21.08.14 12:58, WaLyong Cho (walyong@samsung.com) wrote: > move selinux label APIs to selinux-label.ch > And label_{selinxu/smack}_ prefix are changed to mac_{selinux/smack}_ > respectively. Doesn#t apply to current git. Would like to apply, but can't! Please rebase and resend! > ---

Re: [systemd-devel] proper way to shutdown/reboot host with systemd

2014-08-26 Thread Vasiliy Tolstov
2014-08-26 23:58 GMT+04:00 Lennart Poettering : > We support /usr/sbin/shutdown only for compat reasons... > > If you use it with a time spec of "now", then this is just an alias for > "systemctl poweroff". If you use it with another time spec, then it will > tell this to a "shutdownd" daemon runni

[systemd-devel] [BUG] time-sync.target reached prematurely

2014-08-26 Thread Lukasz Stelmach
Greetings. According to systemd.special(7) "all services where correct time is essential should be ordered after" time-sync.target. Implicitly this means that if systemd-timesyncd is enabled services ordered after the target should also get a usable network connection because the daemon uses the n

[systemd-devel] [PATCHv6 2/3] hibernate-resume: add a tool to write a device node's major:minor to /sys/power/resume.

2014-08-26 Thread Ivan Shapovalov
This can be used to initiate a resume from hibernation by path to a swap device containing the hibernation image. The respective templated unit is also added. It is instantiated using path to the desired resume device. --- .gitignore | 1 + Makefile-man.am

[systemd-devel] [PATCHv6 1/3] units: order systemd-fsck@.service after local-fs-pre.target.

2014-08-26 Thread Ivan Shapovalov
With this change, it becomes possible to order a unit to activate before any modifications to the file systems. This is especially useful for supporting resume from hibernation. --- units/systemd-f...@.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/units/systemd-f..

[systemd-devel] [PATCHv6 3/3] hibernate-resume-generator: add a generator for instantiating the resume unit.

2014-08-26 Thread Ivan Shapovalov
hibernate-resume-generator understands resume= kernel command line parameter and instantiates the systemd-resume@.service accordingly if it is passed. This enables resume from hibernation using device specified on the kernel command line, and it may be specified either as "/dev/disk/by-foo/bar" or

[systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-26 Thread Ivan Shapovalov
This patchset allows systemd to parse resume= kernel command line parameter and initiate resume from the specified device. It adds: - a 'systemd-hibernate-resume' tool which takes path to a device node and writes its major:minor to /sys/power/resume; - a corresponding 'systemd-hibernate-resume@.

Re: [systemd-devel] [PATCHv5 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-26 Thread Ivan Shapovalov
On Tuesday 26 August 2014 at 22:02:32, Lennart Poettering wrote: > On Tue, 26.08.14 23:53, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > Looks great, wanted to commit. But the series doesn't apply to current > git. Could you please rebase? Sorry, I've been writing against v215 which i

Re: [systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-26 Thread Lennart Poettering
On Wed, 27.08.14 00:17, Ivan Shapovalov (intelfx...@gmail.com) wrote: Applied all three! Thanks! > This patchset allows systemd to parse resume= kernel command line parameter > and initiate resume from the specified device. > > It adds: > - a 'systemd-hibernate-resume' tool which takes path to a

Re: [systemd-devel] [BUG] time-sync.target reached prematurely

2014-08-26 Thread Lennart Poettering
On Tue, 26.08.14 22:11, Lukasz Stelmach (stl...@poczta.fm) wrote: > Greetings. > > According to systemd.special(7) "all services where correct time is > essential should be ordered after" time-sync.target. Implicitly this > means that if systemd-timesyncd is enabled services ordered after the > t

Re: [systemd-devel] [PATCH] tty-ask-password-agent: reset a signal handler for SIGTERM to the default

2014-08-26 Thread HATAYAMA, Daisuke
(2014/08/27 4:17), Lennart Poettering wrote: On Mon, 25.08.14 12:32, HATAYAMA Daisuke (d.hatay...@jp.fujitsu.com) wrote: Hello, Heya! When trapping SIGTERM in a script and running systemctl from the script, systemctl sometimes hangs with tty-ask-password agent process. Hmm, so in genera

[systemd-devel] Socket based activation/deactivation

2014-08-26 Thread Gary Mort
Socket based activation for systemd is a really cool feature for my dev system. Prior to using socket based activation, on my dev system I would have 2 choices: 1) Automatically start mysql, apache, php fastcgi, memcached, mongodb and a dozen other services just in case I happen to be workin

Re: [systemd-devel] [PATCHv6 0/3] hibernate-resume: implement support for resuming from hibernation

2014-08-26 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Aug 26, 2014 at 10:21:59PM +0200, Lennart Poettering wrote: > On Wed, 27.08.14 00:17, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > This patchset allows systemd to parse resume= kernel command line parameter > > and initiate resume from the specified device. What about swap files with t

  1   2   >