[systemd-devel] [PATCH 2/3] resolved: fix CID 1237549 Unchecked return value

2014-11-11 Thread Susant Sahani
--- src/resolve/resolved-dns-scope.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/resolve/resolved-dns-scope.c b/src/resolve/resolved-dns-scope.c index 1664b13..25e0d9e 100644 --- a/src/resolve/resolved-dns-scope.c +++ b/src/resolve/resolved-dns-scope.c @@ -386,7

[systemd-devel] [PATCH 1/3] log: 1237557 Unchecked return value from library

2014-11-11 Thread Susant Sahani
fix 1237557 Unchecked return value from library --- src/shared/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/log.c b/src/shared/log.c index 1c589ac..e7237ba 100644 --- a/src/shared/log.c +++ b/src/shared/log.c @@ -122,7 +122,7 @@ static int

[systemd-devel] [PATCH 3/3] bus-socket: fix CID 996290 Unchecked return value

2014-11-11 Thread Susant Sahani
--- src/libsystemd/sd-bus/bus-socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libsystemd/sd-bus/bus-socket.c b/src/libsystemd/sd-bus/bus-socket.c index d124d9a..662bf1c 100644 --- a/src/libsystemd/sd-bus/bus-socket.c +++ b/src/libsystemd/sd-bus/bus-socket.c

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Tue, 04.11.14 12:05, Jan Synacek (jsyna...@redhat.com) wrote: diff --git a/src/locale/localectl.c b/src/locale/localectl.c index d4a2d29..8f9e4da 100644 --- a/src/locale/localectl.c +++ b/src/locale/localectl.c @@ -46,6 +46,7 @@

[systemd-devel] [PATCH 1/2] namespace:Unchecked return value from library

2014-11-11 Thread Susant Sahani
fix: CID 1237553 (#1 of 6): Unchecked return value from library (CHECKED_RETURN CID 1237553 (#3 of 6): Unchecked return value from library (CHECKED_RETURN) CID 1237553 (#4 of 6): Unchecked return value from library (CHECKED_RETURN) CID 1237553 (#5 of 6): Unchecked return value from library

[systemd-devel] [PATCH 2/2] tty-ask-password-agent: fix CID 996261

2014-11-11 Thread Susant Sahani
Unchecked return value from library --- src/tty-ask-password-agent/tty-ask-password-agent.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tty-ask-password-agent/tty-ask-password-agent.c b/src/tty-ask-password-agent/tty-ask-password-agent.c index e6dc84b..c4cd387

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Jan Synacek
Jan Synacek jsyna...@redhat.com writes: Lennart Poettering lenn...@poettering.net writes: On Tue, 04.11.14 12:05, Jan Synacek (jsyna...@redhat.com) wrote: +int xkb_validate_keymaps(const char *model, + const char *layouts_arg, + const char

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Jan Synacek
Lennart Poettering lenn...@poettering.net writes: On Tue, 04.11.14 12:05, Jan Synacek (jsyna...@redhat.com) wrote: One more addition: +} + +int xkb_get_keymaps(char ***list, enum keymap_state look_for, const char *layout_prefix) +{ +_cleanup_fclose_ FILE *f; +char

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Lennart Poettering
On Tue, 11.11.14 13:34, Jan Synacek (jsyna...@redhat.com) wrote: +r = strv_extend(list, l); +if (r 0) +return log_oom(); I think, while we are at it, this should really be reworked to use GREEDY_REALLOC. See strv_split_quoted()

[systemd-devel] syntax error in master

2014-11-11 Thread Colin Walters
See: http://build.gnome.org/continuous/buildmaster/builds/2014/11/11/23/build/log-systemd.txt Perhaps something like this? diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c index c5aeaac..afee131 100644 --- a/src/bus-proxyd/bus-proxyd.c +++ b/src/bus-proxyd/bus-proxyd.c @@

Re: [systemd-devel] syntax error in master

2014-11-11 Thread Daniel Mack
On 11/11/2014 03:31 PM, Colin Walters wrote: See: http://build.gnome.org/continuous/buildmaster/builds/2014/11/11/23/build/log-systemd.txt Perhaps something like this? My bad, sorry. I had a hunk confusion due to rebasing. It's already reverted in master. Daniel diff --git

Re: [systemd-devel] Detecting inactive sessions

2014-11-11 Thread Lennart Poettering
On Wed, 29.10.14 15:45, Bastien Nocera (had...@hadess.net) wrote: For a very specific definition of inactive. I'm looking at a way for the iio-sensor-proxy at: https://github.com/hadess/iio-sensor-proxy to suspend reading from accelerometers (or maybe to turn them off), when all the

Re: [systemd-devel] systemd and power management

2014-11-11 Thread Lennart Poettering
On Wed, 29.10.14 13:00, Daniel Hollocher (danielholloc...@gmail.com) wrote: Hey folks, I'm a not expert here, so please forgive the low quality/interest of my question. I'm curious what the ideal systemd way is to set various power management settings in the /sys tree. For me personally,

Re: [systemd-devel] systemctl show environment quoting

2014-11-11 Thread Lennart Poettering
On Wed, 29.10.14 09:40, Alexandre Detiste (alexandre.deti...@gmail.com) wrote: Hi, I stumbled on this: $ systemctl cat cron-crontab-pi-0 | grep Environment Environment=A=a a MAILTO=system-c...@mailinator.com B=b b C=c c $ systemctl show cron-crontab-pi-0 -p Environment Environment=A=a a

Re: [systemd-devel] 'systemctl poweroff' no longer shuts down system -- instead, reboots ?

2014-11-11 Thread Lennart Poettering
On Mon, 10.11.14 16:22, grantksupp...@operamail.com (grantksupp...@operamail.com) wrote: On Mon, Nov 10, 2014, at 04:07 PM, Lennart Poettering wrote: On Thu, 30.10.14 12:30, grantksupp...@operamail.com (grantksupp...@operamail.com) wrote: exec of systemctl poweroff

Re: [systemd-devel] systemd-cron: retrigger generator after /var is mounted

2014-11-11 Thread Lennart Poettering
On Thu, 30.10.14 00:27, Alexandre Detiste (alexandre.deti...@gmail.com) wrote: Is systemctl daemon-reload really synchronous, or does it return before the reload if effectively done ? (I saw the --no-block argument that make me fear this) It is synchronous. --no-block mostly applies to

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Lennart Poettering
On Tue, 11.11.14 10:03, Jan Synacek (jsyna...@redhat.com) wrote: +r = xkb_validate_keymaps(model, layout, variant, options, msg); +if (r 0) { +log_error(Failed to validate X11 keyboard layout: %s, strerror(-r)); +

Re: [systemd-devel] [PATCH] localed: validate set-x11-keymap input

2014-11-11 Thread Lennart Poettering
On Tue, 11.11.14 13:29, Jan Synacek (jsyna...@redhat.com) wrote: Hmm, reading the file over and over and over again sounds less than ideal. Maybe we should intrdouce a struct here and then make xkb_get_keymaps() return an array of structs really? That sounds ok, I'll see what I can do.

Re: [systemd-devel] [PATCH] sysusers: Preserve ownership and mode on /etc/passwd and friends

2014-11-11 Thread Lennart Poettering
On Wed, 29.10.14 14:20, Colin Guthrie (co...@mageia.org) wrote: When running sysusers we would clobber file ownership and permissions on the files /etc/passwd, /etc/group and /etc/[g]shadow. This simply preserves the ownership and mode if existing files are found. I figure turning this

[systemd-devel] systemd-service for each user

2014-11-11 Thread Jakob Schürz
Hi! I don't know, for which words I have to search to find a solution for my Problem. On my server i created a mailserver.target, on which all relevant services for the mailserver depend. So i can [re]start and stop all services (exim4, cyrus, saslauthd, amavis...) only with systemctl

Re: [systemd-devel] systemd-service for each user

2014-11-11 Thread Mantas Mikulėnas
On Tue, Nov 11, 2014 at 7:52 PM, Jakob Schürz wertsto...@nurfuerspam.de wrote: Hi! I don't know, for which words I have to search to find a solution for my Problem. On my server i created a mailserver.target, on which all relevant services for the mailserver depend. So i can [re]start and

Re: [systemd-devel] systemd-service for each user

2014-11-11 Thread Jakob Schürz
Am 2014-11-11 um 20:35 schrieb Mantas Mikulėnas: On Tue, Nov 11, 2014 at 7:52 PM, Jakob Schürz wertsto...@nurfuerspam.de wrote: Hi! I don't know, for which words I have to search to find a solution for my Problem. On my server i created a mailserver.target, on which all relevant services for

Re: [systemd-devel] systemctl show environment quoting

2014-11-11 Thread Alexandre Detiste
I made some minimal changes to git now: http://cgit.freedesktop.org/systemd/systemd/commit/?id=27e9c5af817147ea1c678769e45e83f2e4b4ae96 Thanks ! This tries to improve things a bit, but I figure it might break stuff for you. No it doesn't break anything since sendmail already forbid spaces

Re: [systemd-devel] Should systemd-logind provide a DM-independent mechanism for handling guest accounts?

2014-11-11 Thread Daniel J Walsh
It would be fairly easy to setup pam_namespace for the guest user to provide a temporary /tmp and ~/. Now, just like we do for xguest. Then you could setup the login account to use no password and the guest_u user and allow users onto the system. This would get you most of the things you want.