Re: [systemd-devel] [PATCH] Clarify effect when both calendar day and date are listed in timer

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 09:59:16PM -0500, Chris Atkinson wrote: > See bug 87859 (https://bugs.freedesktop.org/show_bug.cgi?id=87859). Bug > reporter found the language describing the effect of specifying both a > day and date unclear; hopefully the attached patch will clarify and > allow the bug to

Re: [systemd-devel] [PATCH v2] Makefile.am : Fix build issue with machines.target

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 06:02:12PM +0200, Philippe De Swert wrote: > When doing "make clean" the unit/machines.target file gets deleted. > This causes a build error later on when trying to rebuild systemd. > V2: The file probably belongs to dist_systemunit_DATA > --- Applied. Zbyszek > Makefile.

Re: [systemd-devel] [PATCH] Fix install location of systemd.pc

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 08:44:35PM +0100, Michael Biebl wrote: > Am 31.12.2014 12:54 schrieb "Simon Peeters" : > > > > 2014-12-31 11:12 GMT+00:00 Martin Pitt : > > > Simon Peeters [2014-12-29 15:01 +]: > > >> I have no preference between the 2, but moving the pc file to > > >> $libdir/pkgconfig

Re: [systemd-devel] [PATCH 1/2] machine: machinectl, remove some dead code

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 04:16:02PM +0200, Philippe De Swert wrote: > The variable r is already checked one time before and the same error returned. > So the second check is unneeded. > --- > src/machine/machinectl.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/machine/machinect

Re: [systemd-devel] [PATCH 2/2] libsystemd-network : Fix resource leaks in test-lldp

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 04:16:03PM +0200, Philippe De Swert wrote: > Fix some resources leaks in test-lldp found with coverity: > CID#1261388, CID#1261385, CID#1261383 > --- > src/libsystemd-network/test-lldp.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/li

[systemd-devel] [PATCH] Do not clear parent mount flags when setting up namespaces

2015-01-01 Thread Topi Miettinen
Copy parent directory mount flags when setting up a namespace and don't accidentally clear mount flags later. Signed-off-by: Topi Miettinen --- src/core/namespace.c | 4 ++-- src/shared/util.c| 20 ++-- src/shared/util.h| 2 ++ 3 files changed, 22 insertions(+), 4 delet

Re: [systemd-devel] [PATCH] Do not clear parent mount flags when setting up namespaces

2015-01-01 Thread Topi Miettinen
On 01/01/15 14:49, Topi Miettinen wrote: > Copy parent directory mount flags when setting up a namespace and > don't accidentally clear mount flags later. The problem here is that flags noexec, nosuid and nodev are cleared, so the mounts always have exec, suid, dev flags enabled. With the patch ap

Re: [systemd-devel] [PATCH] Fix install location of systemd.pc

2015-01-01 Thread Martin Pitt
Hey Zbyszek, Zbigniew Jędrzejewski-Szmek [2015-01-01 15:14 +0100]: > Yeah, you can find out the libdir in other ways, but having it in the .pc > file is convenient. Martin, please push the patch. Ack, done. And happy new year everyone! Martin -- Martin Pitt| http://www.p

[systemd-devel] [PATCH] po: update French translation

2015-01-01 Thread Sylvain Plantefève
--- po/fr.po | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/po/fr.po b/po/fr.po index 243465c..6b577fb 100644 --- a/po/fr.po +++ b/po/fr.po @@ -7,8 +7,8 @@ msgid "" msgstr "" "Project-Id-Version: systemd\n" "Report-Msgid-Bugs-To: \n" -"PO

Re: [systemd-devel] [PATCH] improve help/usage for some more programs

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Dec 31, 2014 at 01:18:55PM +0100, Robert Milasan wrote: > --- > src/udev/ata_id/ata_id.c | 4 ++-- > src/udev/cdrom_id/cdrom_id.c | 10 +- > src/udev/collect/collect.c | 10 ++ > src/udev/scsi_id/scsi_id.c | 2 +- > src/udev/v4l_id/v4l_id.c | 2 +- > 5 files

Re: [systemd-devel] [PATCH] improve help/usage for some more programs

2015-01-01 Thread Robert Milasan
On Thu, 1 Jan 2015 18:07:59 +0100 "Zbigniew J*drzejewski-Szmek" wrote: > Patch is wrapped. Please resend, (git send-email preferably, > as an attachment otherwise). > > Zbyszek > -- Robert Milasan L3 Support Engineer SUSE Linux (http://www.suse.com) email: rmila...@suse.com GPG fingerprint:

[systemd-devel] [PATCH] Type of mount(2) flags is unsigned long

2015-01-01 Thread Topi Miettinen
Signed-off-by: Topi Miettinen --- src/core/namespace.c | 2 +- src/core/namespace.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/namespace.c b/src/core/namespace.c index 400bc50..19a7590 100644 --- a/src/core/namespace.c +++ b/src/core/namespace.c @@ -422,7 +422

Re: [systemd-devel] systemd-sysv-generator question

2015-01-01 Thread Markus Moeller
Thank you Markus "Mantas Mikulėnas" wrote in message news:capwny8vgpomx8nfym+k84-w5sf8-5+yo2zuzuqx3__thoq2...@mail.gmail.com... On Wed, Dec 31, 2014 at 4:31 PM, Markus Moeller wrote: Hi, I am knew to systemd and wonder how to use it correctly. I have a simple /etc/init.d/squid startu

[systemd-devel] systemd coredumps

2015-01-01 Thread Markus Moeller
Hi, How can I find out why systemd core dumps and requires system reboot :-( ? I just did # systemctl status sockd-1.5.0 Failed to issue method call: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the

Re: [systemd-devel] systemd coredumps

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 05:57:43PM -, Markus Moeller wrote: > Hi, > > How can I find out why systemd core dumps and requires system > reboot :-( ? > > I just did > > # systemctl status sockd-1.5.0 > Failed to issue method call: Did not receive a reply. Possible > causes include: the remote

Re: [systemd-devel] [PATCH] Do not clear parent mount flags when setting up namespaces

2015-01-01 Thread Dave Reisner
On Thu, Jan 01, 2015 at 04:49:04PM +0200, Topi Miettinen wrote: > Copy parent directory mount flags when setting up a namespace and > don't accidentally clear mount flags later. > > Signed-off-by: Topi Miettinen > --- > src/core/namespace.c | 4 ++-- > src/shared/util.c| 20

Re: [systemd-devel] systemd coredumps

2015-01-01 Thread Dave Reisner
On Thu, Jan 01, 2015 at 07:05:04PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Jan 01, 2015 at 05:57:43PM -, Markus Moeller wrote: > > Hi, > > > > How can I find out why systemd core dumps and requires system > > reboot :-( ? > > > > I just did > > > > # systemctl status sockd-1.5.

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Dec 30, 2014 at 08:22:27PM +0100, Jouke Witteveen wrote: > --- > > This fixes #87251 This is actually important information that should be included in the commit message (i.e. above not below "---"). We usually include the full url, since we also use distribution bug trackers and having t

Re: [systemd-devel] systemd coredumps

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 01:13:30PM -0500, Dave Reisner wrote: > On Thu, Jan 01, 2015 at 07:05:04PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > > On Thu, Jan 01, 2015 at 05:57:43PM -, Markus Moeller wrote: > > > Hi, > > > > > > How can I find out why systemd core dumps and requires system > >

Re: [systemd-devel] systemd coredumps

2015-01-01 Thread Markus Moeller
OK I logged it as https://bugs.freedesktop.org/show_bug.cgi?id=87943 . I can't seem to get a core dump file. Markus "ZbigniewJędrzejewski-Szmek" wrote in message news:20150101180504.gj18...@in.waw.pl... On Thu, Jan 01, 2015 at 05:57:43PM -, Markus Moeller wrote: Hi, How can I find o

Re: [systemd-devel] systemd coredumps

2015-01-01 Thread Markus Moeller
Oh. I see I need to ask OpenSuse to fix or get a newer OpenSuse version. Thank you Markus "ZbigniewJędrzejewski-Szmek" wrote in message news:20150101181747.gl18...@in.waw.pl... On Thu, Jan 01, 2015 at 01:13:30PM -0500, Dave Reisner wrote: On Thu, Jan 01, 2015 at 07:05:04PM +0100, Zbigniew Ję

Re: [systemd-devel] [PATCH] Do not clear parent mount flags when setting up namespaces

2015-01-01 Thread Topi Miettinen
On 01/01/15 18:08, Dave Reisner wrote: > On Thu, Jan 01, 2015 at 04:49:04PM +0200, Topi Miettinen wrote: >> Copy parent directory mount flags when setting up a namespace and >> don't accidentally clear mount flags later. >> >> Signed-off-by: Topi Miettinen >> --- >> src/core/namespace.c | 4 ++--

[systemd-devel] [PATCH] Update Russian translation

2015-01-01 Thread Sergey Ptashnick
By analogy with commit 4038d7502f. >From 71095ae994209cfed8bb12821bc4ff905e90f697 Mon Sep 17 00:00:00 2001 From: Sergey Ptashnick <0comff...@inbox.ru> Date: Thu, 1 Jan 2015 21:31:29 +0300 Subject: [PATCH] po: update Russian translation --- po/ru.po | 30 +++--- 1 files c

Re: [systemd-devel] [PATCH] Update Russian translation

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 09:42:47PM +0300, Sergey Ptashnick wrote: > By analogy with commit 4038d7502f. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Re: [systemd-devel] [PATCH] po: update French translation

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 06:02:54PM +0100, Sylvain Plantefève wrote: > --- > po/fr.po | 33 - > 1 file changed, 16 insertions(+), 17 deletions(-) Applied. The strings changed in the meanwhile. I fixed up the po file, so everything should be fine, but please check.

Re: [systemd-devel] [PATCH] improve help/usage for some more programs

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 06:11:22PM +0100, Robert Milasan wrote: > From 9cd266590dbf1d22b1a7fc184ecc8c3868f280f9 Mon Sep 17 00:00:00 2001 > From: Robert Milasan > Date: Wed, 31 Dec 2014 13:17:23 +0100 > Subject: [PATCH] improve help/usage for some more programs Applied. Zbyszek ___

Re: [systemd-devel] [PATCH] Type of mount(2) flags is unsigned long

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 07:40:07PM +0200, Topi Miettinen wrote: > Signed-off-by: Topi Miettinen We don't use signed-off-by. Applied. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinf

[systemd-devel] [PATCH] util: Fix signedness error in lines(), match implementations

2015-01-01 Thread Colin Walters
From a74befe02b8a8141a2ffc5613372ef8082a2c6d2 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Thu, 1 Jan 2015 14:57:08 -0500 Subject: [PATCH] util: Fix signedness error in lines(), match implementations Regression introduced by ed757c0cb03eef50e8d9aeb4682401c3e9486f0b Mirror the implementati

Re: [systemd-devel] [PATCH] util: Fix signedness error in lines(), match implementations

2015-01-01 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Jan 01, 2015 at 03:05:15PM -0500, Colin Walters wrote: > > From a74befe02b8a8141a2ffc5613372ef8082a2c6d2 Mon Sep 17 00:00:00 2001 > From: Colin Walters > Date: Thu, 1 Jan 2015 14:57:08 -0500 > Subject: [PATCH] util: Fix signedness error in lines(), match implementations > > Regression i

Re: [systemd-devel] [PATCH] util: Fix signedness error in lines(), match implementations

2015-01-01 Thread Colin Walters
On Thu, Jan 1, 2015, at 03:21 PM, Zbigniew Jędrzejewski-Szmek wrote: > Is there an actual regression? Afaict, your patch does not change > the behaviour in any way... I can't think of an actual real world regression. I could have said "error introduced by" or something? It only fixes the case w

[systemd-devel] [PATCH v2] Do not clear parent mount flags when setting up namespaces

2015-01-01 Thread Topi Miettinen
Copy parent directory mount flags when setting up a namespace and don't accidentally clear mount flags later. --- src/core/namespace.c | 4 ++-- src/shared/util.c| 19 +-- src/shared/util.h| 2 ++ 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/src/core/na

[systemd-devel] [PATCH] Clarify path escaping and reference systemd-escape

2015-01-01 Thread Chris Atkinson
See Bug 87688 (https://bugs.freedesktop.org/show_bug.cgi?id=87688). This patch adds more detail to the description of how path escaping operates and provides a pointer to the systemd-escape program. Either would serve to answer the question raised in the bug report, so hopefully this will allow it

Re: [systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

2015-01-01 Thread Jouke Witteveen
On Thu, Jan 1, 2015 at 7:15 PM, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Dec 30, 2014 at 08:22:27PM +0100, Jouke Witteveen wrote: >> --- >> >> This fixes #87251 > > This is actually important information that should be included in the > commit message (i.e. above not below "---"). We usually i