Re: [systemd-devel] [PATCH] config_parse_exec_mount_flags: get rid of unnecessary copy

2015-02-13 Thread Maciej Wereski
Dnia środa, 11 lutego 2015 13:08:26 Lennart Poettering pisze: > This optimization is not valid. > > If 'word' is set to "sh", then l will be 2, and strneq(word, "shared", > 2) is true, but we don't actually want to allow such abbreviations! > > Lennart True, I can use strlen("shared" ) then as

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-13 Thread Kay Sievers
On Fri, Feb 13, 2015 at 8:51 AM, Martin Pitt wrote: > Martin Pitt [2015-02-12 19:52 +0100]: >> Lennart Poettering [2015-02-12 18:50 +0100]: >> > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=090d25fe224c0 >> > >> > Looks simple enough. This looks awful. We should not

Re: [systemd-devel] kdbus in d-bus project

2015-02-13 Thread Maciej Wereski
Dnia czwartek, 12 lutego 2015 18:28:45 Steven Noonan pisze: > Hi all, Hello, > Is anyone maintaining a patch series against upstream d-bus for kdbus > integration? I checked the kdbus-dev branch linked to by the kdbus > Google Code page: > > https://review.tizen.org/git/?p=platform/upstream/dbus

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-13 Thread Martin Pitt
Kay Sievers [2015-02-13 10:12 +0100]: > This looks awful. We should not litter generic rules with exotic niche > use cases like this. It will end up in a mess. Fully agreed :/ > First, what is the use-case for by-path for mmc devices? If there is > no strong one, which I suspect, please just remo

Re: [systemd-devel] [PATCH v3] Added support for Uplink Failure Detection using BindCarrier

2015-02-13 Thread Rauta, Alin
Hi Tom, Any news on this ? Best Regards, Alin -Original Message- From: Lennart Poettering [mailto:lenn...@poettering.net] Sent: Wednesday, February 11, 2015 6:03 PM To: Rauta, Alin Cc: zbys...@in.waw.pl; t...@jklm.no; systemd-devel@lists.freedesktop.org; Kinsella, Ray Subject: Re: [PAT

Re: [systemd-devel] Suspend from wireless keyboard not working

2015-02-13 Thread Lennart Poettering
On Fri, 13.02.15 00:46, Gustavo De Nardin (spuk) (gustav...@gmail.com) wrote: > Hello. > > I'm trying to make my notebook (Lenovo Thinkpad X230) suspend when pressing > the "sleep" extra key on a wireless keyboard (Logitech K270 using the > Logitech unifying receiver). > > I've been able to map

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-13 Thread Kay Sievers
On Fri, Feb 13, 2015 at 10:35 AM, Martin Pitt wrote: > Kay Sievers [2015-02-13 10:12 +0100]: >> This looks awful. We should not litter generic rules with exotic niche >> use cases like this. It will end up in a mess. > > Fully agreed :/ > >> First, what is the use-case for by-path for mmc devices?

Re: [systemd-devel] systemd-networkd mysteriously shutting down after launch

2015-02-13 Thread Lennart Poettering
On Thu, 12.02.15 22:30, Keller, Jacob E (jacob.e.kel...@intel.com) wrote: > On Thu, 2015-02-12 at 20:15 +0100, Tom Gundersen wrote: > > On Thu, Feb 12, 2015 at 7:28 PM, Keller, Jacob E > > Now I'm having an interesting issue with the current git of > systemd-networkd... It works just fine on load

Re: [systemd-devel] multi-user.target only wants network.service if I'm doing 'systemct show runlevel3.target'

2015-02-13 Thread Lennart Poettering
On Fri, 13.02.15 09:49, Andrei Borzenkov (arvidj...@gmail.com) wrote: > В Wed, 11 Feb 2015 21:19:16 +0100 > Lennart Poettering пишет: > > > > > > > But the problem is not limited to legacy initscripts. It makes it > > > generally unsafe to have aliases via symlinks. Aliases were always > > > me

Re: [systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

2015-02-13 Thread Martin Pitt
Hey Kay, Kay Sievers [2015-02-13 10:47 +0100]: > Let's remove it. There was never a reason for by-path/ to cover all > exotic device types. disk/by-path/ is for slots, chassis, ports where > swappable disks can be connected and disconnected without the > identifier to change. I doubt that applies

[systemd-devel] Running system with neither dbus, or kdbus?

2015-02-13 Thread Dimitri John Ledkov
I have a minimal system and I don't have for example policykit or graphical things. I don't have kdbus yet. However at the moment it seems that e.g. networkd & logind components require dbus system bus. Is it feasible to modify networkd/logind to operate without system dbus? E.g. similar how ini

Re: [systemd-devel] Running system with neither dbus, or kdbus?

2015-02-13 Thread David Herrmann
Hi On Fri, Feb 13, 2015 at 12:56 PM, Dimitri John Ledkov wrote: > I have a minimal system and I don't have for example policykit or > graphical things. > > I don't have kdbus yet. > > However at the moment it seems that e.g. networkd & logind components > require dbus system bus. > > Is it feasib

Re: [systemd-devel] Running system with neither dbus, or kdbus?

2015-02-13 Thread Lennart Poettering
On Fri, 13.02.15 11:56, Dimitri John Ledkov (dimitri.j.led...@intel.com) wrote: > I have a minimal system and I don't have for example policykit or > graphical things. > > I don't have kdbus yet. > > However at the moment it seems that e.g. networkd & logind components > require dbus system bus.

Re: [systemd-devel] Running system with neither dbus, or kdbus?

2015-02-13 Thread Mantas Mikulėnas
On Fri, Feb 13, 2015 at 1:56 PM, Dimitri John Ledkov < dimitri.j.led...@intel.com> wrote: > I have a minimal system and I don't have for example policykit or > graphical things. > > I don't have kdbus yet. > > However at the moment it seems that e.g. networkd & logind components > require dbus sys

Re: [systemd-devel] avahi disconnects from bus with kdbus

2015-02-13 Thread David Herrmann
Hi On Thu, Feb 12, 2015 at 11:32 PM, Daniel Buch wrote: > Hi again, > > I found another problem, again with avahi-daemon but in combination with > Telepathy haze. > feb 13 08:26:39 dbuch-laptop systemd-coredump[1211]: Process 1167 > (telepathy-haze) of user 1000 dumped core. > >

Re: [systemd-devel] [PATCH v3] Added support for Uplink Failure Detection using BindCarrier

2015-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Feb 13, 2015 at 09:53:28AM +0300, Andrei Borzenkov wrote: > В Thu, 12 Feb 2015 15:25:08 +0100 > Zbigniew Jędrzejewski-Szmek пишет: > > > On Thu, Feb 12, 2015 at 12:52:00PM +, Rauta, Alin wrote: > > > > Yes, but the updates need to be done for all links and I'm not sure > > > > adding

Re: [systemd-devel] [systemd-commits] rules/60-persistent-storage.rules

2015-02-13 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Feb 12, 2015 at 11:50:23PM -0800, Martin Pitt wrote: > rules/60-persistent-storage.rules |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > New commits: > commit b87b01cf83947f467f3c46d9831cd67955fc46b9 > Author: Martin Pitt > Date: Wed Feb 11 15:26:52 2015 +0100 > >

Re: [systemd-devel] [systemd-commits] rules/60-persistent-storage.rules

2015-02-13 Thread Martin Pitt
Hey Zbigniew, Zbigniew Jędrzejewski-Szmek [2015-02-13 15:49 +0100]: > > # by-path (parent device path) > > ENV{DEVTYPE}=="disk", DEVPATH!="*/virtual/*", IMPORT{builtin}="path_id" > > -ENV{DEVTYPE}=="disk", ENV{ID_PATH}=="?*", > > SYMLINK+="disk/by-path/$env{ID_PATH}" > > +ENV{DEVTYPE}=="disk",

[systemd-devel] [PATCH] util: Use a shared lookup function for string tables

2015-02-13 Thread Bruno Bottazzini
Macro DEFINE_STRING_TABLE_LOOKUP expands to a new function for each of the almost 120 tables throghout the code. Move the its implementation to a function (guaranteed to never be inlined), and make the macro expand to an inlined function that calls this function. This saves a few kilobytes from the

[systemd-devel] [PATCH] Use a shared lookup function for string tables

2015-02-13 Thread Bruno Bottazzini
The macro DEFINE_STRING_TABLE_LOOKUP is expanding to a new function for each tables. (I calculated it was aproximity 120 tables) With this patch we move its implementation to a function to never be inlined. This will make systemd to be a few kilobytes smaller. Bruno Bottazzini (1): util: Use a

Re: [systemd-devel] [PATCH v3] Added support for Uplink Failure Detection using BindCarrier

2015-02-13 Thread Tom Gundersen
Hi Alin, Thanks for the patch. This is starting to look pretty good now. I still have some questions/requests regarding some implementation details (below), but hopefully we can get this merged after the next release (trying to stabilize things at the moment). On Tue, Feb 10, 2015 at 12:30 PM, A

[systemd-devel] Unmount / right before reboot/shutdown/kexec

2015-02-13 Thread Lorenzo Pistone
Hello, the cloud provider I'm testing has rather strange setup. All volumes are provided through nbd, including /, and they have to be unmounted cleanly for reboot to work successfully, because the rebooted or kexec'd kernel will retry to attach them and if there host thinks there's already a

[systemd-devel] [PATCH] shutdown: avoid calling `kexec` binary unnessecarily

2015-02-13 Thread Shawn Landden
Still use helper when Xen Dom0, to avoid duplicating some hairy code. So we don't have any logic to load kexec kernels? --- TODO| 3 --- src/core/shutdown.c | 33 - 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/TODO b/TODO index 8

[systemd-devel] [PATCH] sd-rtnl: add missing IFLA_INET6_ADDR_GEN_MODE definition

2015-02-13 Thread Djalal Harouni
Add missing IFLA_INET6_ADDR_GEN_MODE definition so we can build with kernel headers < 3.17 --- configure.ac | 3 ++- src/shared/missing.h | 18 ++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 684c793..97a29d6 100644 --- a

Re: [systemd-devel] [PATCH] sd-rtnl: add missing IFLA_INET6_ADDR_GEN_MODE definition

2015-02-13 Thread Tom Gundersen
Applied. Thanks! On Fri, Feb 13, 2015 at 11:39 PM, Djalal Harouni wrote: > Add missing IFLA_INET6_ADDR_GEN_MODE definition so we can build with > kernel headers < 3.17 > --- > configure.ac | 3 ++- > src/shared/missing.h | 18 ++ > 2 files changed, 20 insertions(+), 1 de

Re: [systemd-devel] [systemd-commits] 4 commits - man/systemd.network.xml network/80-container-host0.network network/80-container-ve.network src/libsystemd src/network

2015-02-13 Thread Tom Gundersen
On Tue, Feb 10, 2015 at 9:35 PM, Lennart Poettering wrote: > On Mon, 09.02.15 03:20, Tom Gundersen (tome...@kemper.freedesktop.org) wrote: > >> >> commit 7f77697a1744f8df2089848b9d718faf7ba6c665 >> Author: Tom Gundersen >> Date: Sun Feb 8 23:20:56 2015 +0100 >> >> networkd: add support for

[systemd-devel] [PATCH] timedated: when performing "SetTime" compensate for program lag

2015-02-13 Thread Shawn Landden
--- TODO | 2 -- src/timedate/timedated.c | 14 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 68b0af6..7b93404 100644 --- a/TODO +++ b/TODO @@ -190,8 +190,6 @@ Features: * we should try harder to collapse start jobs for swaps

Re: [systemd-devel] Unmount / right before reboot/shutdown/kexec

2015-02-13 Thread Tom Gundersen
On Fri, Feb 13, 2015 at 11:15 PM, Lorenzo Pistone wrote: > the cloud provider I'm testing has rather strange setup. All volumes are > provided through nbd, including /, and they have to be unmounted cleanly for > reboot to work successfully, because the rebooted or kexec'd kernel will > retry to a

Re: [systemd-devel] [PATCH] timedated: when performing "SetTime" compensate for program lag

2015-02-13 Thread Tom Gundersen
On Sat, Feb 14, 2015 at 12:34 AM, Shawn Landden wrote: > --- > TODO | 2 -- > src/timedate/timedated.c | 14 ++ > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/TODO b/TODO > index 68b0af6..7b93404 100644 > --- a/TODO > +++ b/TODO > @@ -190,8 +

Re: [systemd-devel] persisting sriov_numvfs

2015-02-13 Thread Tom Gundersen
On Tue, Jan 27, 2015 at 5:49 PM, Lennart Poettering wrote: > On Tue, 27.01.15 08:41, Martin Polednik (mpoled...@redhat.com) wrote: > >> > b) Expose this via udev .link files. This would be appropriate if >> >adding/removing VFs is a one-time thing, when a device pops >> >up. This would be

[systemd-devel] [PATCH 2/3] network-internal: chain matches with AND in net_match_config()

2015-02-13 Thread Zbigniew Jędrzejewski-Szmek
The test would treat the first non-empty set of matches in match_paths, match_drivers, match_types, match_names as definitive (essentially chaining them with OR). Make those tests instead match like other tests and require all to pass if the set of patterns is nonempty. --- src/libsystemd-network/

[systemd-devel] [PATCH 3/3] analyze: change behaviour of combined --to/from--pattern

2015-02-13 Thread Zbigniew Jędrzejewski-Szmek
We would require a match against all three: patterns specified with --to, with --from, and as positional arguments to show an edge. This does not seem useful. Let instead the positional args behave like they were specified in both --to and --from, which is fairly intuitive and should be more useful

[systemd-devel] [PATCH 1/3] Add helper for fnmatch over strv

2015-02-13 Thread Zbigniew Jędrzejewski-Szmek
No functional change intended. --- src/analyze/analyze.c | 46 --- src/libsystemd-network/network-internal.c | 53 +-- src/shared/strv.c | 10 ++ src/shared/strv.h | 9 +

Re: [systemd-devel] Suspend from wireless keyboard not working

2015-02-13 Thread Gustavo De Nardin (spuk)
Thanks, it worked. Just had to do some debugging to learn the correct action for suspend is 'sleep', while 'suspend' is for hibernate. :] Excuse the ignorance, but why is it a problem if every keyboard would get the 'power-switch' tag (or if it wouldn't be needed)? For example, would it be a probl

Re: [systemd-devel] Suspend from wireless keyboard not working

2015-02-13 Thread Jan Alexander Steffens
On Sat, Feb 14, 2015 at 5:34 AM, Gustavo De Nardin (spuk) wrote: > Excuse the ignorance, but why is it a problem if every keyboard would get > the 'power-switch' tag (or if it wouldn't be needed)? For example, would it > be a problem if a distro adds the power-switch tag to all keyboards by > defa

[systemd-devel] Combining systemd-firstboot and systemd-sysusers

2015-02-13 Thread Ivan Shapovalov
Hi all, I'm trying to adapt systemd-{sysusers,firstboot} for creating the system users in an initramfs (at generation time). (Note: I use systemd-firstboot to set the root password.) The situation - So, I'm running firstboot before sysusers (judging from the unit files, this seems to

Re: [systemd-devel] Suspend from wireless keyboard not working

2015-02-13 Thread Gustavo De Nardin (spuk)
* Jan Alexander Steffens [2015-02-14 06:02 +0100]: > On Sat, Feb 14, 2015 at 5:34 AM, Gustavo De Nardin (spuk) > wrote: > > Excuse the ignorance, but why is it a problem if every keyboard would get > > the 'power-switch' tag (or if it wouldn't be needed)? For example, would it > > be a problem if

Re: [systemd-devel] bug 88401 / daemon-reload causes Type=oneshot services to be re-started / path_coldplug() is non-deserialization-aware

2015-02-13 Thread Ivan Shapovalov
On 2015-01-28 at 20:15 +0100, Lennart Poettering wrote: > On Sun, 18.01.15 04:21, Ivan Shapovalov (intelfx...@gmail.com) wrote: > > > Hi folks, > > > > I'm trying to fix this bug: > > https://bugs.freedesktop.org/show_bug.cgi?id=88401 > > > > The initial problem (as reported) looks following: pe