Re: [systemd-devel] [PATCH] test: Make testing work on systems without?or old systemd

On Thu, Aug 22, 2013 at 07:07:07AM +0200, Zbigniew Jędrzejewski-Szmek wrote: > Those tests everywhere are not very pretty, but I guess we don't have > much choice if we want those tests to be runnable before booting with systemd. > Applied. thanks! do you have a better idea on how to skip them?

Re: [systemd-devel] [PATCH] test: Make testing work on systems without?or old systemd

On Fri, Aug 16, 2013 at 06:42:04PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Aug 16, 2013 at 04:20:08PM +, Holger Freyther wrote: > > it appears that this has not been reviewed/merged. Anything that needs > > to be changed to apply/am it? > Just stalled. I'll have a look. Those tests

Re: [systemd-devel] [PATCH] use CAP_MKNOD ConditionCapability

On Wed, Aug 21, 2013 at 08:35:44PM -0700, Khem Raj wrote: > Fixes errors seen when booting VMs on QEMU like > > systemd[1]: kmod-static-nodes.service: main process exited, code=exited, > status=203/EXEC > systemd[1]: Failed to start Create list of required static device nodes for > the current k

Re: [systemd-devel] [PATCH 1/2] Optimize startswith() to macro

On Thu, Aug 22, 2013 at 03:52:29AM +0200, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 10:16 PM, Kay Sievers wrote: > > On Wed, Aug 21, 2013 at 8:15 PM, WANG Chao wrote: > >> Take this optimized code from Lennart[1]. Now startswith is a macro using > >> strncmp and should be fast enough. > >> > >

Re: [systemd-devel] [PATCH] remove hasprefix(), use startswith()

On Wed, Aug 21, 2013 at 06:20:55PM -0700, Shawn Landden wrote: > memcmp() could read from uninitilized memory if string is at the end > of a page boundry and shorter than prefix Applied, but without this description, since it is misleading: afaict, in all cases it was firsst checked that the string

Re: [systemd-devel] [PATCH 0/2 V2] gummiboot: Cross compile and IA32 support

On Thu, 2013-08-22 at 00:53 +0200, Kay Sievers wrote: > On Thu, Aug 22, 2013 at 12:38 AM, Darren Hart wrote: > > Updated with feedback from Kay and Colin. I've boot tested this, then > > rebased to > > use Kay's updated CPP flags, and build tested. > > It's all in git now, right? Anything missin

Re: [systemd-devel] [PATCH 2/2] configure.ac: Disable the QEMU BIOS test when cross compiling

On Thu, 2013-08-22 at 00:46 +0200, Kay Sievers wrote: > On Thu, Aug 22, 2013 at 12:38 AM, Darren Hart wrote: > > When cross-compiling, AC_CHECK_FILE aborts configure. Skip it when > > cross compiling. > > > > Signed-off-by: Darren Hart > > Cc: Colin Walters > > --- > > configure.ac | 10 ++-

[systemd-devel] [PATCH] use CAP_MKNOD ConditionCapability

Fixes errors seen when booting VMs on QEMU like systemd[1]: kmod-static-nodes.service: main process exited, code=exited, status=203/EXEC systemd[1]: Failed to start Create list of required static device nodes for the current kernel. systemd[1]: Unit kmod-static-nodes.service entered failed state

Re: [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

On 08/21/2013 06:42 PM, Eric W. Biederman wrote: > Gao feng writes: > >> right now I only take note of the unix socket /run/systemd/private, >> but there may have many similar unix sockets, they can exist in any >> path. the strange problems will still happen. > > It could just as easily have be

Re: [systemd-devel] [RFC] mount: improve DefaultDependencies and use in generator

On Wed, Aug 21, 2013 at 10:06 PM, Thomas Bächler wrote: > Am 21.08.2013 13:53, schrieb Tom Gundersen: >> I'd like to move some of the default dependency logic from the fstab >> generator >> to core. This should remove some redundancy and also improve consistency >> between mount units and fstab e

Re: [systemd-devel] [PATCH 1/2] Optimize startswith() to macro

On Wed, Aug 21, 2013 at 10:16 PM, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 8:15 PM, WANG Chao wrote: >> Take this optimized code from Lennart[1]. Now startswith is a macro using >> strncmp and should be fast enough. >> >> [1]: >> http://lists.freedesktop.org/archives/systemd-devel/2013-July/

[systemd-devel] [PATCH] remove hasprefix(), use startswith()

memcmp() could read from uninitilized memory if string is at the end of a page boundry and shorter than prefix --- TODO | 2 -- src/journal/journal-send.c | 2 +- src/journal/journald-native.c | 12 ++-- src/libsystemd-bus/bus-match.c | 26 +

[systemd-devel] [PATCH] udev: fix printf(3) type specifier

--- src/udev/udev-rules.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c index 1634812..f14158b 100644 --- a/src/udev/udev-rules.c +++ b/src/udev/udev-rules.c @@ -1076,7 +1076,7 @@ static int add_rule(struct udev_rules *rules, char

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Thu, Aug 22, 2013 at 1:12 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Aug 22, 2013 at 12:49:55AM +0200, Kay Sievers wrote: >> On Thu, Aug 22, 2013 at 12:38 AM, Zbigniew Jędrzejewski-Szmek >> wrote: >> > On Wed, Aug 21, 2013 at 03:07:24PM -0700, Darren Hart wrote: >> >> On Wed, 2013-08-21

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Thu, Aug 22, 2013 at 12:49:55AM +0200, Kay Sievers wrote: > On Thu, Aug 22, 2013 at 12:38 AM, Zbigniew Jędrzejewski-Szmek > wrote: > > On Wed, Aug 21, 2013 at 03:07:24PM -0700, Darren Hart wrote: > >> On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote: > >> > On Wed, Aug 21, 2013 at 11:34 PM,

Re: [systemd-devel] [PATCH 0/2 V2] gummiboot: Cross compile and IA32 support

On Thu, Aug 22, 2013 at 12:38 AM, Darren Hart wrote: > Updated with feedback from Kay and Colin. I've boot tested this, then rebased > to > use Kay's updated CPP flags, and build tested. It's all in git now, right? Anything missing? Kay ___ systemd-de

Re: [systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

On Thu, Aug 22, 2013 at 12:28 AM, Jan Engelhardt wrote: > > On Wednesday 2013-08-21 21:02, Kay Sievers wrote: >>On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: >>> --- a/Makefile.am >>> +++ b/Makefile.am >>> @@ -72,10 +72,11 @@ CLEANFILES += man/gummiboot.8 >>> efi_loadername = gummiboot$(MA

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Thu, Aug 22, 2013 at 12:38 AM, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Aug 21, 2013 at 03:07:24PM -0700, Darren Hart wrote: >> On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote: >> > On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart >> > wrote: >> > >> > > Hrm, actually no that fails

Re: [systemd-devel] [PATCH 1/2] Autodetect both x64 and ia32 boot*.efi payloads

On Thu, Aug 22, 2013 at 12:38 AM, Darren Hart wrote: > The EFI specification documents /EFI/BOOT/bootx64.efi for x86_64 > machines and /EFI/BOOT/bootia32.efi for ia32 machines. Update the auto > detection to allow for both. > > Add the MACHINE_TYPE_NAME define to the efi/src build so we can use it

Re: [systemd-devel] [PATCH 2/2] configure.ac: Disable the QEMU BIOS test when cross compiling

On Thu, Aug 22, 2013 at 12:38 AM, Darren Hart wrote: > When cross-compiling, AC_CHECK_FILE aborts configure. Skip it when > cross compiling. > > Signed-off-by: Darren Hart > Cc: Colin Walters > --- > configure.ac | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git

Re: [systemd-devel] [PATCH 1/5] configure.ac: Add option to disable configuring the BIOS test

On Wed, Aug 21, 2013 at 10:06 PM, Darren Hart wrote: > On Wed, 2013-08-21 at 15:57 -0400, Colin Walters wrote: >> On Wed, 2013-08-21 at 11:13 -0700, Darren Hart wrote: >> >> > +if test "x$enable_biostest" != "xno"; then >> >> Use AS_IF() please; systemd's current configure.ac is not consistent in

Re: [systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

On Thu, Aug 22, 2013 at 12:28:48AM +0200, Jan Engelhardt wrote: > > On Wednesday 2013-08-21 21:02, Kay Sievers wrote: > >On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: > >> --- a/Makefile.am > >> +++ b/Makefile.am > >> @@ -72,10 +72,11 @@ CLEANFILES += man/gummiboot.8 > >> efi_loadername =

Re: [systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

On Thu, 2013-08-22 at 00:32 +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Aug 21, 2013 at 11:13:41AM -0700, Darren Hart wrote: > > Enable cross-compiling by allowing the user to specify an alternative to > > the /usr/include directory for the EFI includes. Add a variable INCDIR > > defaulting

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, Aug 21, 2013 at 03:07:24PM -0700, Darren Hart wrote: > On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote: > > On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart > > wrote: > > > > > Hrm, actually no that fails finding VERSION ins setup.c. Did > > > you ./autogen.sh before building? > >

[systemd-devel] [PATCH 2/2] configure.ac: Disable the QEMU BIOS test when cross compiling

When cross-compiling, AC_CHECK_FILE aborts configure. Skip it when cross compiling. Signed-off-by: Darren Hart Cc: Colin Walters --- configure.ac | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 137580a..a9534be 100644 --- a/config

[systemd-devel] [PATCH 1/2] Autodetect both x64 and ia32 boot*.efi payloads

The EFI specification documents /EFI/BOOT/bootx64.efi for x86_64 machines and /EFI/BOOT/bootia32.efi for ia32 machines. Update the auto detection to allow for both. Add the MACHINE_TYPE_NAME define to the efi/src build so we can use it as the standard suffix for the EFI payloads (ia32 or x64). Si

[systemd-devel] [PATCH 0/2 V2] gummiboot: Cross compile and IA32 support

Updated with feedback from Kay and Colin. I've boot tested this, then rebased to use Kay's updated CPP flags, and build tested. I am using a laoder/* config, so I wasn't sure where the BOOTIA32.EFI string came into play. Is that only used if no loader is provided. If gummiboot is typically BOOTIA32

Re: [systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

On Wed, Aug 21, 2013 at 11:13:41AM -0700, Darren Hart wrote: > Enable cross-compiling by allowing the user to specify an alternative to > the /usr/include directory for the EFI includes. Add a variable INCDIR > defaulting to /usr/include, but still allowing the user to provide their > own value. >

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Thu, 2013-08-22 at 00:20 +0200, Kay Sievers wrote: > On Thu, Aug 22, 2013 at 12:07 AM, Darren Hart wrote: > > On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote: > >> On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart > >> wrote: > >> > >> > Hrm, actually no that fails finding VERSION ins se

Re: [systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

On Wednesday 2013-08-21 21:02, Kay Sievers wrote: >On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -72,10 +72,11 @@ CLEANFILES += man/gummiboot.8 >> efi_loadername = gummiboot$(MACHINE_TYPE_NAME).efi >> efi_sources = src/efi/gummiboot.c >> >>

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Thu, 2013-08-22 at 00:20 +0200, Kay Sievers wrote: > On Thu, Aug 22, 2013 at 12:07 AM, Darren Hart wrote: > > On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote: > >> On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart > >> wrote: > >> > >> > Hrm, actually no that fails finding VERSION ins se

Re: [systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

On Wed, Aug 21, 2013 at 9:02 PM, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: >> Enable cross-compiling by allowing the user to specify an alternative to >> the /usr/include directory for the EFI includes. Add a variable INCDIR >> defaulting to /usr/include, but still

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Thu, Aug 22, 2013 at 12:07 AM, Darren Hart wrote: > On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote: >> On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart wrote: >> >> > Hrm, actually no that fails finding VERSION ins setup.c. Did >> > you ./autogen.sh before building? >> >> Oh, sorry, it

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart wrote: > > > Hrm, actually no that fails finding VERSION ins setup.c. Did > > you ./autogen.sh before building? > > Oh, sorry, it probably just misses: > > +gummiboot_CPPFLAGS = \ > +

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart wrote: > Hrm, actually no that fails finding VERSION ins setup.c. Did > you ./autogen.sh before building? Oh, sorry, it probably just misses: +gummiboot_CPPFLAGS = \ + $(AM_CPPFLAGS) \ Kay ___ s

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, 2013-08-21 at 13:41 -0700, Darren Hart wrote: > On Wed, 2013-08-21 at 22:25 +0200, Kay Sievers wrote: > > On Wed, Aug 21, 2013 at 10:16 PM, Darren Hart > > wrote: > > > On Wed, 2013-08-21 at 21:31 +0200, Kay Sievers wrote: > > >> On Wed, Aug 21, 2013 at 9:26 PM, Darren Hart > > >> wrote

Re: [systemd-devel] Question on debugging getty 'runlevel 3' issue.

On 08/21/2013 06:40 AM, Ben Greear wrote: On 08/21/2013 02:53 AM, Kay Sievers wrote: On Wed, Aug 21, 2013 at 11:49 AM, Colin Guthrie wrote: 'Twas brillig, and Ben Greear at 20/08/13 22:46 did gyre and gimble: Does anyone know what package or thing was doing the text prompt on the serial conso

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, 2013-08-21 at 22:25 +0200, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 10:16 PM, Darren Hart wrote: > > On Wed, 2013-08-21 at 21:31 +0200, Kay Sievers wrote: > >> On Wed, Aug 21, 2013 at 9:26 PM, Darren Hart > >> wrote: > >> > On Wed, 2013-08-21 at 20:59 +0200, Kay Sievers wrote: > >> >

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, 2013-08-21 at 13:16 -0700, Darren Hart wrote: > On Wed, 2013-08-21 at 21:31 +0200, Kay Sievers wrote: > > On Wed, Aug 21, 2013 at 9:26 PM, Darren Hart wrote: > > > On Wed, 2013-08-21 at 20:59 +0200, Kay Sievers wrote: > > >> On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart > > >> wrote: > >

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, Aug 21, 2013 at 10:16 PM, Darren Hart wrote: > On Wed, 2013-08-21 at 21:31 +0200, Kay Sievers wrote: >> On Wed, Aug 21, 2013 at 9:26 PM, Darren Hart wrote: >> > On Wed, 2013-08-21 at 20:59 +0200, Kay Sievers wrote: >> >> On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart >> >> wrote: >> >> >

Re: [systemd-devel] [PATCH 1/2] Optimize startswith() to macro

On Wed, Aug 21, 2013 at 8:15 PM, WANG Chao wrote: > Take this optimized code from Lennart[1]. Now startswith is a macro using > strncmp and should be fast enough. > > [1]: http://lists.freedesktop.org/archives/systemd-devel/2013-July/011860.html > --- > src/shared/macro.h | 5 + > src/shared

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, 2013-08-21 at 21:31 +0200, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 9:26 PM, Darren Hart wrote: > > On Wed, 2013-08-21 at 20:59 +0200, Kay Sievers wrote: > >> On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart > >> wrote: > >> > The EFI specification documents /EFI/BOOT/bootx64.efi for x86

Re: [systemd-devel] [PATCH 1/5] configure.ac: Add option to disable configuring the BIOS test

On Wed, 2013-08-21 at 15:57 -0400, Colin Walters wrote: > On Wed, 2013-08-21 at 11:13 -0700, Darren Hart wrote: > > > +if test "x$enable_biostest" != "xno"; then > > Use AS_IF() please; systemd's current configure.ac is not consistent in > this respect, but it will save debugging painful m4 crap

Re: [systemd-devel] [PATCH 1/5] configure.ac: Add option to disable configuring the BIOS test

On Wed, 2013-08-21 at 11:13 -0700, Darren Hart wrote: > +if test "x$enable_biostest" != "xno"; then Use AS_IF() please; systemd's current configure.ac is not consistent in this respect, but it will save debugging painful m4 crap later: https://bugzilla.gnome.org/show_bug.cgi?id=681413

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, Aug 21, 2013 at 9:26 PM, Darren Hart wrote: > On Wed, 2013-08-21 at 20:59 +0200, Kay Sievers wrote: >> On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: >> > The EFI specification documents /EFI/BOOT/bootx64.efi for x86_64 >> > machines and /EFI/BOOT/bootia32.efi for ia32 machines. Upda

Re: [systemd-devel] [PATCH 1/5] configure.ac: Add option to disable configuring the BIOS test

On Wed, 2013-08-21 at 21:15 +0200, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: > > When cross-compiling, AC_CHECK_FILE aborts configure. Provide a means to > > avoid even attempting to configure the BIOS test. > > > > Signed-off-by: Darren Hart > > --- > > configure.

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, 2013-08-21 at 20:59 +0200, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: > > The EFI specification documents /EFI/BOOT/bootx64.efi for x86_64 > > machines and /EFI/BOOT/bootia32.efi for ia32 machines. Update the auto > > detection to allow for both. > > > > Signe

Re: [systemd-devel] [PATCH 2/5] configure.ac: Use AC_CHECK_HEADER to detect the efi includes

On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: > While cross-compiling, AC_CHECK_FILE will abort the configure. > > The gnu-efi sources don't use relative paths and require the user to > explicitly include -I/usr/include/efi/${ARCH}. I haven't found a way to > do this with AC_CHECK_HEADER. Ho

Re: [systemd-devel] [PATCH 4/5] configure.ac: Allow for more than just i686 for ia32

On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: > Expand the ARCH_I686 to include i*86* (specifically to catch i586). > Rename ARCH_I686 to ARCH_IA32 as that is more accurately what we are > testing for. Applied. Thanks, Kay ___ systemd-devel maili

Re: [systemd-devel] [PATCH 1/5] configure.ac: Add option to disable configuring the BIOS test

On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: > When cross-compiling, AC_CHECK_FILE aborts configure. Provide a means to > avoid even attempting to configure the BIOS test. > > Signed-off-by: Darren Hart > --- > configure.ac | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-

Re: [systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: > Enable cross-compiling by allowing the user to specify an alternative to > the /usr/include directory for the EFI includes. Add a variable INCDIR > defaulting to /usr/include, but still allowing the user to provide their > own value. > > Signed

Re: [systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart wrote: > The EFI specification documents /EFI/BOOT/bootx64.efi for x86_64 > machines and /EFI/BOOT/bootia32.efi for ia32 machines. Update the auto > detection to allow for both. > > Signed-off-by: Darren Hart > --- > src/efi/gummiboot.c | 5 - > 1

[systemd-devel] [PATCH 2/2] Replace hasprefix() with optimized startswith()

--- TODO | 2 -- src/journal/journal-send.c | 2 +- src/journal/journald-native.c | 12 ++-- src/libsystemd-bus/bus-match.c | 26 +- src/shared/logs-show.c | 2 +- src/shared/macro.h | 2 -- 6 files changed, 21

[systemd-devel] [PATCH 1/2] Optimize startswith() to macro

Take this optimized code from Lennart[1]. Now startswith is a macro using strncmp and should be fast enough. [1]: http://lists.freedesktop.org/archives/systemd-devel/2013-July/011860.html --- src/shared/macro.h | 5 + src/shared/util.c | 17 - 2 files changed, 5 insertions(+

[systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

The EFI specification documents /EFI/BOOT/bootx64.efi for x86_64 machines and /EFI/BOOT/bootia32.efi for ia32 machines. Update the auto detection to allow for both. Signed-off-by: Darren Hart --- src/efi/gummiboot.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/efi/

[systemd-devel] [PATCH 3/5] Makefile.am: Allow for user override of EFI include dir

Enable cross-compiling by allowing the user to specify an alternative to the /usr/include directory for the EFI includes. Add a variable INCDIR defaulting to /usr/include, but still allowing the user to provide their own value. Signed-off-by: Darren Hart --- Makefile.am | 5 +++-- 1 file changed

[systemd-devel] [PATCH 4/5] configure.ac: Allow for more than just i686 for ia32

Expand the ARCH_I686 to include i*86* (specifically to catch i586). Rename ARCH_I686 to ARCH_IA32 as that is more accurately what we are testing for. Signed-off-by: Darren Hart --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac in

[systemd-devel] [PATCH 2/5] configure.ac: Use AC_CHECK_HEADER to detect the efi includes

While cross-compiling, AC_CHECK_FILE will abort the configure. The gnu-efi sources don't use relative paths and require the user to explicitly include -I/usr/include/efi/${ARCH}. I haven't found a way to do this with AC_CHECK_HEADER. However, since the existing test was not testing for usability (

[systemd-devel] [PATCH 1/5] configure.ac: Add option to disable configuring the BIOS test

When cross-compiling, AC_CHECK_FILE aborts configure. Provide a means to avoid even attempting to configure the BIOS test. Signed-off-by: Darren Hart --- configure.ac | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index ca5a383..6ee4520

[systemd-devel] [PATCH 0/5] gummiboot: Crosscompile fixes and 32b boot target support

I was carrying these patches in my yocto project recipe for gummiboot as well. Apologies, I should have included these along with the previous ia32 tsc patch. Thanks, Darren Hart ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://

[systemd-devel] Inconsistencies in the systemd.mount documentation

In the manpage for systemd.mount(5), the following section is included: COMPATIBILITY OPTIONS The following option is also available in the "[Mount]" section, but exists purely for compatibility reasons and should not be used in newly written mount files. FsckPassNo= The

Re: [systemd-devel] [PATCH] Replace hasprefix() with startswith()

On 08/21/13 at 06:58pm, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 6:53 PM, WANG Chao wrote: > > On 08/21/13 at 12:05pm, Kay Sievers wrote: > >> On Wed, Aug 21, 2013 at 8:36 AM, WANG Chao wrote: > >> > >> > --- a/TODO > >> > +++ b/TODO > >> > @@ -96,8 +96,6 @@ Features: > >> > > >> > -* do we r

Re: [systemd-devel] [PATCH] gummiboot: Add 32 bit compatible rdtsc asm

On Wed, Aug 21, 2013 at 6:31 PM, Darren Hart wrote: > Gcc's inline asm constraints have different meanings on x86_64 and ia32. > Include a 32 bit version for the rdtsc function. Drop the empty 32 bit > version of time_usec as it and the cpuid function both function properly > when compiled for 32

[systemd-devel] [PATCH] man: make reference to bind(2) explicit

--- man/systemd.socket.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd.socket.xml b/man/systemd.socket.xml index 852010b..1fc28c5 100644 --- a/man/systemd.socket.xml +++ b/man/systemd.socket.xml @@ -510,7 +510,7 @@

Re: [systemd-devel] [PATCH] Replace hasprefix() with startswith()

On Wed, Aug 21, 2013 at 6:53 PM, WANG Chao wrote: > On 08/21/13 at 12:05pm, Kay Sievers wrote: >> On Wed, Aug 21, 2013 at 8:36 AM, WANG Chao wrote: >> >> > --- a/TODO >> > +++ b/TODO >> > @@ -96,8 +96,6 @@ Features: >> > >> > -* do we really need both hasprefix() and startswith()? >> >> It needs

Re: [systemd-devel] [PATCH] Replace hasprefix() with startswith()

Hi, Kay! On 08/21/13 at 12:05pm, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 8:36 AM, WANG Chao wrote: > > > --- a/TODO > > +++ b/TODO > > @@ -96,8 +96,6 @@ Features: > > > > -* do we really need both hasprefix() and startswith()? > > It needs a little bit more: > - the open-coded startswith

[systemd-devel] [PATCH] gummiboot: Add 32 bit compatible rdtsc asm

Gcc's inline asm constraints have different meanings on x86_64 and ia32. Include a 32 bit version for the rdtsc function. Drop the empty 32 bit version of time_usec as it and the cpuid function both function properly when compiled for 32 bit systems. Tested on the following CPU: Intel(R) Atom(TM)

Re: [systemd-devel] Please pass 'fsck.mode=force' on the kernel command line rather than creating /forcefsck on the root file system

On Thu, Aug 15, 2013 at 11:04:39PM +0200, Reindl Harald wrote: > Please pass 'fsck.mode=force' on the kernel command line rather than creating > /forcefsck on the root file system > > please drop this deprectaion, it is disturbing and useless > > if you want a forced fsck for *whatever* reason y

[systemd-devel] [PATCHv2] "-" prefix for InaccessibleDirectories and ReadOnlyDirectories

--- v2: - modify manpage --- TODO | 3 --- man/systemd.exec.xml | 6 +- src/core/namespace.c | 12 +++- src/shared/conf-parser.c | 27 +-- 4 files changed, 33 insertions(+), 15 deletions(-) diff --git a/TODO b/TODO index 9bc14fd..9

Re: [systemd-devel] [PATCH] units: disable kmod-static-nodes.service in containers

On 08/21/2013 02:02 PM, Zbigniew Jędrzejewski-Szmek wrote: Hm, Jóhann, are you saying that my ConditionCapability=CAP_MKNOD does not work, or that ConditionVirtualization=!container that I added does not work? Or that it works? I'm was confirming adding "ConditionCapability=CAP_MKNOD" to the k

[systemd-devel] [PATCH] "-" prefix for InaccessibleDirectories and ReadOnlyDirectories

--- TODO | 3 --- src/core/namespace.c | 12 +++- src/shared/conf-parser.c | 27 +-- 3 files changed, 28 insertions(+), 14 deletions(-) diff --git a/TODO b/TODO index 9bc14fd..97f2bcf 100644 --- a/TODO +++ b/TODO @@ -287,9 +287,6 @@ Feature

Re: [systemd-devel] prevent unmount of single partitions on shutdown

'Twas brillig, and Zbigniew Jędrzejewski-Szmek at 21/08/13 14:17 did gyre and gimble: > On Wed, Aug 21, 2013 at 06:03:34PM +0800, Tom Gundersen wrote: >> > On Wed, Aug 21, 2013 at 5:56 PM, Colin Guthrie >> > wrote: >>> > > 'Twas brillig, and Zbigniew Jędrzejewski-Szmek at 21/08/13 04:38 did >>> >

Re: [systemd-devel] [RFC] mount: improve DefaultDependencies and use in generator

Am 21.08.2013 13:53, schrieb Tom Gundersen: > I'd like to move some of the default dependency logic from the fstab generator > to core. This should remove some redundancy and also improve consistency > between mount units and fstab entries. > > The first patch simply enables default dependencies i

Re: [systemd-devel] [PATCH] units: disable kmod-static-nodes.service in containers

On Wed, Aug 21, 2013 at 11:03:31AM +, "Jóhann B. Guðmundsson" wrote: > On 08/21/2013 11:00 AM, Tom Gundersen wrote: > >Hi Zbyszek, > > > >Regarding > >: > > > >Would it make sense to use ConditionC

Re: [systemd-devel] [PATCH 2/3] mount: move device links handling from generator

On Wed, Aug 21, 2013 at 8:50 PM, Harald Hoyer wrote: > On 08/21/2013 01:53 PM, Tom Gundersen wrote: >> -if (!isbind && >> -!path_equal(where, "/")) { >> - >> -r = device_name(what, &device); >> -if (r < 0) >> -

Re: [systemd-devel] Question on debugging getty 'runlevel 3' issue.

On 08/21/2013 02:53 AM, Kay Sievers wrote: On Wed, Aug 21, 2013 at 11:49 AM, Colin Guthrie wrote: 'Twas brillig, and Ben Greear at 20/08/13 22:46 did gyre and gimble: Does anyone know what package or thing was doing the text prompt on the serial console? It happens automatically based on ker

Re: [systemd-devel] prevent unmount of single partitions on shutdown

On Wed, Aug 21, 2013 at 06:03:34PM +0800, Tom Gundersen wrote: > On Wed, Aug 21, 2013 at 5:56 PM, Colin Guthrie wrote: > > 'Twas brillig, and Zbigniew Jędrzejewski-Szmek at 21/08/13 04:38 did > > gyre and gimble: > >> On Wed, Aug 21, 2013 at 05:21:59AM +0200, Stephan Raue wrote: > >>> Hi, > >>> >

Re: [systemd-devel] [PATCH 2/3] mount: move device links handling from generator

On 08/21/2013 01:53 PM, Tom Gundersen wrote: > -if (!isbind && > -!path_equal(where, "/")) { > - > -r = device_name(what, &device); > -if (r < 0) > -return r; > - > -

[systemd-devel] [PATCH 3/3] mount: x-initrd.mount should not conflict with umount.target

These mounts were mounted in the initrd and should be unmounted there as well. Currently, we will still attempt to umount these in the final kill spree, but we should consider avoiding that too. --- src/core/mount.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-)

[systemd-devel] [PATCH 2/3] mount: move device links handling from generator

Now, when default dependencies are enabled for a mount unit it will be WantedBy the respective devices. --- src/core/mount.c | 13 +++- src/fstab-generator/fstab-generator.c | 40 +++ 2 files changed, 15 insertions(+), 38 deletions(-)

[systemd-devel] [PATCH 1/3] fstab-generator: use DefaultDependencies=yes

This removes some redundancy between the generator and the core mount handling. --- TODO | 2 -- src/fstab-generator/fstab-generator.c | 52 --- 2 files changed, 6 insertions(+), 48 deletions(-) diff --git a/TODO b/TODO index 9bc14

[systemd-devel] [RFC] mount: improve DefaultDependencies and use in generator

Hi guys, I'd like to move some of the default dependency logic from the fstab generator to core. This should remove some redundancy and also improve consistency between mount units and fstab entries. The first patch simply enables default dependencies in the generator, and removes some things tha

Re: [systemd-devel] [PATCH] units: disable kmod-static-nodes.service in containers

On 08/21/2013 11:00 AM, Tom Gundersen wrote: Hi Zbyszek, Regarding : Would it make sense to use ConditionCapability=CAP_MKNOD instead? This would match what is done in systemd-tmpfiles-setup-dev.se

Re: [systemd-devel] [PATCH] units: disable kmod-static-nodes.service in containers

On Wed, Aug 21, 2013 at 1:00 PM, Tom Gundersen wrote: > Regarding > : > > Would it make sense to use ConditionCapability=CAP_MKNOD instead? This > would match what is done in systemd-tmpfiles-setup-de

[systemd-devel] [PATCH] units: disable kmod-static-nodes.service in containers

Hi Zbyszek, Regarding : Would it make sense to use ConditionCapability=CAP_MKNOD instead? This would match what is done in systemd-tmpfiles-setup-dev.service. The effect is currently the same (I thin

Re: [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

Gao feng writes: > right now I only take note of the unix socket /run/systemd/private, > but there may have many similar unix sockets, they can exist in any > path. the strange problems will still happen. It could just as easily have been a fifo in the filesystem, and the result would have been

Re: [systemd-devel] [PATCH] Replace hasprefix() with startswith()

On Wed, Aug 21, 2013 at 8:36 AM, WANG Chao wrote: > --- a/TODO > +++ b/TODO > @@ -96,8 +96,6 @@ Features: > > -* do we really need both hasprefix() and startswith()? It needs a little bit more: - the open-coded startswith seems really slow, it should not get more users - hasprefix can no lon

Re: [systemd-devel] prevent unmount of single partitions on shutdown

On Wed, Aug 21, 2013 at 5:56 PM, Colin Guthrie wrote: > 'Twas brillig, and Zbigniew Jędrzejewski-Szmek at 21/08/13 04:38 did > gyre and gimble: >> On Wed, Aug 21, 2013 at 05:21:59AM +0200, Stephan Raue wrote: >>> Hi, >>> >>> i try to port systemd on a own embedded OS which is stored in a >>> squas

Re: [systemd-devel] prevent unmount of single partitions on shutdown

'Twas brillig, and Zbigniew Jędrzejewski-Szmek at 21/08/13 04:38 did gyre and gimble: > On Wed, Aug 21, 2013 at 05:21:59AM +0200, Stephan Raue wrote: >> Hi, >> >> i try to port systemd on a own embedded OS which is stored in a >> squashfs file. This file is on a fat partition (later mounted as >> /

Re: [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

On Wed, Aug 21, 2013 at 11:51:53AM +0200, Kay Sievers wrote: > On Wed, Aug 21, 2013 at 9:22 AM, Gao feng wrote: > > On 08/21/2013 03:06 PM, Eric W. Biederman wrote: > > >> I suspect libvirt should simply not share /run or any other normally > >> writable directory with the host. Sharing /run /va

Re: [systemd-devel] Question on debugging getty 'runlevel 3' issue.

On Wed, Aug 21, 2013 at 11:49 AM, Colin Guthrie wrote: > 'Twas brillig, and Ben Greear at 20/08/13 22:46 did gyre and gimble: >> Does anyone know what package or thing was doing the >> text prompt on the serial console? > > It happens automatically based on kernel command line params as far as I >

Re: [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

On Wed, Aug 21, 2013 at 9:22 AM, Gao feng wrote: > On 08/21/2013 03:06 PM, Eric W. Biederman wrote: >> I suspect libvirt should simply not share /run or any other normally >> writable directory with the host. Sharing /run /var/run or even /tmp >> seems extremely dubious if you want some kind of

Re: [systemd-devel] Question on debugging getty 'runlevel 3' issue.

'Twas brillig, and Ben Greear at 20/08/13 22:46 did gyre and gimble: > Does anyone know what package or thing was doing the > text prompt on the serial console? It happens automatically based on kernel command line params as far as I know... Col -- Colin Guthrie gmane(at)colin.guthr.ie http:/

Re: [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

On 08/21/2013 03:06 PM, Eric W. Biederman wrote: > Gao feng writes: > >> cc libvirt-list >> >> On 08/21/2013 01:30 PM, Eric W. Biederman wrote: >>> Gao feng writes: >>> Unix sockets are private resources of net namespace, allowing one net namespace to access to other netns's unix

Re: [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

Gao feng writes: > cc libvirt-list > > On 08/21/2013 01:30 PM, Eric W. Biederman wrote: >> Gao feng writes: >> >>> Unix sockets are private resources of net namespace, >>> allowing one net namespace to access to other netns's unix >>> sockets is meaningless. >> >> Allowing one net namespace to

Re: [systemd-devel] [PATCH] netns: unix: only allow to find out unix socket in same net namespace

cc libvirt-list On 08/21/2013 01:30 PM, Eric W. Biederman wrote: > Gao feng writes: > >> Unix sockets are private resources of net namespace, >> allowing one net namespace to access to other netns's unix >> sockets is meaningless. > > Allowing one net namespace to access another netns's unix so