Re: [systemd-devel] bridge vlan-aware

2022-11-19 Thread Salvatore Mazzarino
To add more info. Also br0 has to allow vlan 166 to pass through. This was my 
mistake 




Re: [systemd-devel] bridge vlan-aware

2022-11-19 Thread Salvatore Mazzarino
I've fixed the systemd configuration and now everything works as expected. The 
config was wrong. Thanks anyway to chime in 




Re: [systemd-devel] bridge vlan-aware

2022-11-19 Thread Andrei Borzenkov

On 19.11.2022 12:26, Salvatore Mazzarino wrote:

bridge vlan show

port vlan-id
enp89s0 1 PVID Egress Untagged
br0     1 PVID Egress Untagged
br166   1 PVID Egress Untagged
eth.166 1 Egress Untagged
         166 PVID Egress Untagged
virbr0  1 PVID Egress Untagged

Just to understand. I attach VMs to the br166. In this case also enp89s0 should 
allow VLAN 166?


Yes. How would otherwise packets in VLAN 166 from outside reach br166?


On 19. 11. 2022 10:17 +0100, Salvatore Mazzarino , 
wrote:

I do not think it's a switch issue.  The systemd configuration is surely wrong 
but I'm not sure where.







Re: [systemd-devel] dependent services status

2022-11-19 Thread Ted Toth
On Fri, Nov 18, 2022 at 5:33 PM Barry  wrote:
>
>
>
> > On 17 Nov 2022, at 20:03, Ted Toth  wrote:
> >
> > The comment about inotify was just an example, I understand that there
> > is a 'notify' service type but I'm not using it because of its
> > documented shortcomings.
>
> I thought using sd_notify would be all advantages.
> Service gets to set its state explicitly, no need for systemd to guess.
>
> What are the shortcomings you are referring to?

Sorry I was thinking about systemd-path which I had looked at as an
option for watching a directory for file creation. I hadn't looked at
sd_notify yet, thanks for the suggestion.

>
> Barry
> >
> >
> >> On Thu, Nov 17, 2022 at 11:34 AM Alvin Šipraga  
> >> wrote:
> >>
> >> Hi Ted,
> >>
> >>> On Thu, Nov 17, 2022 at 08:52:00AM -0600, Ted Toth wrote:
> >>> I have a set of services that depend on each other however when
> >>> services are started and considered 'active' that does not necessarily
> >>> mean they are in a state that a dependent service requires them to be
> >>> in to operate properly (for example an inotify watch has been
> >>> established). systemd services, I think,  have a substate, is there a
> >>> way I can set that to a custom value to indicate the services idea of
> >>> its own state?
> >>
> >> If you set Type=notify in the [Service] block of the service definition
> >> file, you can use the sd_notify(3) API:
> >>
> >> https://www.freedesktop.org/software/systemd/man/sd_notify.html
> >>
> >> Is that what you are looking for?
> >>
> >> Kind regards,
> >> Alvin
> >
>


Re: [systemd-devel] bridge vlan-aware

2022-11-19 Thread Salvatore Mazzarino
Also to prove that it’s not a switch issue I have launched this configuration 
and everything works. VMs get IP in the VLAN 166.

However this configuration is not very dynamic because I cannot control Libvirt 
vnet names so I need to match all the vnet interfaces.

salmazz@nux-11-i7 /e/s/network> cat br0.netdev
[NetDev]
Name=br0
Kind=bridge

[Bridge]
VLANFiltering=yes
salmazz@nux-11-i7 /e/s/network> cat br0.network
[Match]
Name=br0

[Network]
DHCP=yes

salmazz@nux-11-i7 /e/s/network> cat enp89s0.network
# This file is managed by Salt via 
salt://systemd/networkd/templates/profile.jinja

[Match]
Name=enp89s0
[Network]
Bridge=br0
[BridgeVLAN]
VLAN=166
salmazz@nux-11-i7 /e/s/network> cat vnet.network
[Match]
Name=vnet*

[Network]
Bridge=br0

[BridgeVLAN]
VLAN=166
PVID=166
EgressUntagged=166
On 19. 11. 2022 10:26 +0100, Salvatore Mazzarino , 
wrote:
> bridge vlan show
>
> port vlan-id
> enp89s0 1 PVID Egress Untagged
> br0     1 PVID Egress Untagged
> br166   1 PVID Egress Untagged
> eth.166 1 Egress Untagged
>         166 PVID Egress Untagged
> virbr0  1 PVID Egress Untagged
>
> Just to understand. I attach VMs to the br166. In this case also enp89s0 
> should allow VLAN 166?
> On 19. 11. 2022 10:17 +0100, Salvatore Mazzarino , 
> wrote:
> > I do not think it's a switch issue.  The systemd configuration is surely 
> > wrong but I'm not sure where.
> >


Re: [systemd-devel] bridge vlan-aware

2022-11-19 Thread Salvatore Mazzarino
bridge vlan show

port vlan-id
enp89s0 1 PVID Egress Untagged
br0     1 PVID Egress Untagged
br166   1 PVID Egress Untagged
eth.166 1 Egress Untagged
        166 PVID Egress Untagged
virbr0  1 PVID Egress Untagged

Just to understand. I attach VMs to the br166. In this case also enp89s0 should 
allow VLAN 166?
On 19. 11. 2022 10:17 +0100, Salvatore Mazzarino , 
wrote:
> I do not think it's a switch issue.  The systemd configuration is surely 
> wrong but I'm not sure where.
>


Re: [systemd-devel] bridge vlan-aware

2022-11-19 Thread Salvatore Mazzarino
I do not think it's a switch issue. The systemd configuration is surely wrong 
but I'm not sure where. 




Re: [systemd-devel] bridge vlan-aware

2022-11-19 Thread Andrei Borzenkov

Please reply to list

On 19.11.2022 12:05, Salvatore Mazzarino wrote:

The vlan 166 has a dhcp server. The switch port is set to accept tagged and 
untagged traffic.





I am not sure what "accept tagged and untagged" traffic does on your 
switch. But so far it sounds more like switch configuration issue.


Re: [systemd-devel] bridge vlan-aware

2022-11-19 Thread Andrei Borzenkov

On 18.11.2022 03:46, Salvatore Mazzarino wrote:

Posted a wrong config for br0.netdev. the correct one is the following
br0.netdev

[NetDev]
Name=br0
Kind=bridge

[Bridge]
DefaultPVID=1
VLANFiltering=yes


On Fri, Nov 18, 2022 at 1:43 AM Salvatore Mazzarino 
wrote:


I have a physical interface named enp89s0 on a machine which runs VM with
libvirt.These VMs have to run in a VLAN. The physical interface is attached
to the default VLAN (1).

My config

br0.dev

[NetDev]
Name=br166
Kind=bridge

br0.network

[Match]
Name=br0

[Network]
VLAN=eth.1
VLAN=eth.166

[BridgeVLAN]
VLAN=1

[BridgeVLAN]
VLAN=166

br166.netdev

[NetDev]
Name=br166
Kind=bridge

br166.network

[Match]
Name=br166
[Network]
DHCP=no

enp89s0.network

[Match]
Name=enp89s0
[Network]
Bridge=br0

eth.1.netdev

[NetDev]
Name=eth.1
Kind=vlan

[VLAN]
Id=1

eth.1.network

[Match]
Name=eth.1

[Network]
DHCP=yes

eth.166.netdev

[NetDev]
Name=eth.166
Kind=vlan
[VLAN]
Id=166

eth.166.network

[Match]
Name=eth.166
[Network]
Bridge=br166
DHCP=no

the interface eth.1 correctly gets UP and it receives the IP addr from the
primary lan. when I connect my libvirt VMs to the br166 unfortunately they
do not get any IPs from the VLAN 166 (DHCP is there so they should get it).


Did you configure switch port for tagged VLAN 166? Do you have DHCP 
server in VLAN 166?



I'm sure my networkd config is off in some parts but not sure where.
conceptually it should be correct.