On 02/24/2014 09:39 AM, Radoslaw Pajak wrote:
If e-activator wasn't released when activator connection has disconnected,
there was no possibility to open new activator connection for that name
in the case when there was another owner of that name.
Interesting. Like in the last patch you sent,
On 02/24/2014 12:30 PM, Radoslaw Pajak wrote:
Your patch works if the activator connection is still the owner of
the name, but it doesn't work if activator has lost the ownership. If
regular connection takes over the name than kdbus_name_replace_owner
calls kdbus_name_entry_remove_owner which
On 02/24/2014 01:51 PM, Radoslaw Pajak wrote:
On 02/24/2014 12:47 PM, Daniel Mack wrote:
Yes, but there's one more pointer that can dangle :)
As we're not on a fast path here, I think we can really walk the hash
of
all names in the registry of the bus, and clean up the -activator
pointer
On 02/24/2014 02:17 PM, Daniel Mack wrote:
On 02/24/2014 01:51 PM, Radoslaw Pajak wrote:
On 02/24/2014 12:47 PM, Daniel Mack wrote:
Yes, but there's one more pointer that can dangle :)
As we're not on a fast path here, I think we can really walk the hash
of
all names in the registry
On 03/02/2014 10:11 PM, Djalal Harouni wrote:
In kdbus_meta_append_*() we want to get the subjective context, so
instead of using __task_cred() which reference the objective cred,
use current_cred() to access the subjective cred.
Signed-off-by: Djalal Harouni tix...@opendz.org
---
Compile
On 03/17/2014 11:53 AM, Djalal Harouni wrote:
Use kdbus_item_validate_name() where appropriate.
Applied both, thanks!
Signed-off-by: Djalal Harouni tix...@opendz.org
---
bus.c| 11 +--
connection.c | 9 +
domain.c | 15 +--
endpoint.c | 12
On 03/19/2014 09:31 PM, Djalal Harouni wrote:
Signed-off-by: Djalal Harouni tix...@opendz.org
---
endpoint.c | 1 +
1 file changed, 1 insertion(+)
Applied, thanks!
diff --git a/endpoint.c b/endpoint.c
index 876e5e3..a6d9dfb 100644
--- a/endpoint.c
+++ b/endpoint.c
@@ -139,6 +139,7 @@
On 03/19/2014 09:24 PM, Djalal Harouni wrote:
Signed-off-by: Djalal Harouni tix...@opendz.org
---
domain.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/domain.c b/domain.c
index d27cad2..554b4fe 100644
--- a/domain.c
+++ b/domain.c
@@ -183,12 +183,13
Hi,
On 03/19/2014 09:24 PM, Djalal Harouni wrote:
Signed-off-by: Djalal Harouni tix...@opendz.org
---
domain.c | 68
+++-
1 file changed, 37 insertions(+), 31 deletions(-)
diff --git a/domain.c b/domain.c
index
On 03/21/2014 12:35 PM, Djalal Harouni wrote:
I've two questions:
1) Can we improve it in ordre to reduce the lock hold time ?
We don't consider that a very frequent operation, so we never thought
about optimizing this code path. What use case do you have in mind so
that performance would
On 04/09/2014 11:43 AM, Daniel Buch wrote:
---
connection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/connection.c b/connection.c
index 2d69f17..5e7d553 100644
--- a/connection.c
+++ b/connection.c
@@ -1024,7 +1024,7 @@ int kdbus_cmd_msg_recv(struct kdbus_conn
On 04/09/2014 02:16 PM, Hristo Venev wrote:
Change: e61734c55c24cdf11b07e52a74aec4dc4a7f4bd0.
Merged: dc5ed40686a4da95881c35d913b60f867755cbe2 in 3.15-rc1.
task_cgroup_name returns a pointer to the path or NULL if there is not
enough space in the buffer (used to return nonnegative or
On 04/09/2014 07:20 PM, Hristo Venev wrote:
On Wed, 2014-04-09 at 15:04 +0200, Daniel Mack wrote:
Eh. Thanks for spotting this. However, I think we should have a compat
workaround for 3.14, for at least a couple of weeks. We can drop it
after that. Could you amend your patch for that?
How
On 06/07/2014 06:26 PM, Djalal Harouni wrote:
Signed-off-by: Djalal Harouni tix...@opendz.org
Applied, thanks!
---
policy.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/policy.c b/policy.c
index 5a9770d..6f2bb1f 100644
--- a/policy.c
+++ b/policy.c
@@
Hi Djalal,
On 06/07/2014 06:47 PM, Djalal Harouni wrote:
I'm sending this to have some updates on the policy!
I did notice some issues and others still *to confirm*, so first I'm
writing some policy tests to make sure we don't break. I'll clean what
I've and get get back to you.
Sure,
Hi Djalal,
On 06/20/2014 06:49 PM, Djalal Harouni wrote:
This series adds the test-kdbus-policy test. The first patches are
prepration then you have the test.
Later there are several fixes and improvments, I've performed all the
tests with success.
Very nice, thanks a lot for doing this!
On 06/20/2014 06:50 PM, Djalal Harouni wrote:
Fix a bug introcuded in commit d92d68414fab which fixed another bug.
conn-attach_flags should only be update if KDBUS_ITEM_ATTACH_FLAGS was
provided.
Yes, you're right of course.
Applied, thanks!
Daniel
Signed-off-by: Djalal Harouni
On 06/20/2014 06:50 PM, Djalal Harouni wrote:
Use the db-entries_hash to access the policy db entries instead of the
db-send_access_hash which is just a cache for send entries.
Signed-off-by: Djalal Harouni tix...@opendz.org
---
policy.c | 7 ---
1 file changed, 4 insertions(+), 3
On 06/20/2014 06:50 PM, Djalal Harouni wrote:
If kdbus_policy_set() fails we try to restore the entries that were
previously saved in a list, however due to a typo that logic was trying
to access a previously freed entry which will just break things...
So fix the typo 'l-e' instead of 'e'.
On 06/20/2014 06:50 PM, Djalal Harouni wrote:
If we try to register the same name twice then kdbus_policy_add_one()
will fail with -EEXIST
In kdbus_policy_set() we have two calls to kdbus_policy_add_one() if
they fail we clean things up with kdbus_policy_entry_free(), but since
we failed
On 06/20/2014 06:50 PM, Djalal Harouni wrote:
kdbus_policy_check_own_access() returns 0 if access is granted,
otherwise a negative errno.
So fix this by returning 0. We did not hit this since callers were
checking negative values for errors.
Applied, thanks.
Daniel
Signed-off-by:
On 06/20/2014 06:50 PM, Djalal Harouni wrote:
When freeing a connection remove also all the cached entries related
to this connection, otherwise if we access this cached entry through
another valid connection, we will hit memory corruption bugs.
Applied, thanks.
Daniel
Signed-off-by:
On 06/20/2014 06:49 PM, Djalal Harouni wrote:
Export this function since we will use it to register policy holders
connections.
Applied all the test-related patches as well.
However, we should probably integrate all these tests in the already
existing test framework, so the're all in one place
On 06/20/2014 06:50 PM, Djalal Harouni wrote:
In kdbus_policy_set() function, we use the 'e' variable to reference
each entry of the 'db-entries_hash', so at the end the variable 'e' will
for sure point to a valid one.
Next in the KDBUS_ITEMS_FOREACH() iterator and if we fail at the first
On 06/20/2014 07:28 PM, Daniel Mack wrote:
On 06/20/2014 06:50 PM, Djalal Harouni wrote:
Use the db-entries_hash to access the policy db entries instead of the
db-send_access_hash which is just a cache for send entries.
Ah, you're purging the other entries in patch #12. Alright then, now
On 06/25/2014 11:13 AM, AKASHI Takahiro wrote:
Signed-off-by: AKASHI Takahiro takahiro.aka...@linaro.org
---
pool.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pool.c b/pool.c
index d896d9b..4267c54 100644
--- a/pool.c
+++ b/pool.c
@@ -623,7 +623,7 @@ void
Hi,
On 06/25/2014 11:13 AM, AKASHI Takahiro wrote:
My ftrace log shows that kdbus_meta_append(), is one of dominant functions
in sending a message, while the other is kdbus_conn_queue_alloc().
This patch adds an extra argument to kdbus_hello() utility function and
allows us to explicitly
On 06/25/2014 11:13 AM, AKASHI Takahiro wrote:
Current ioctl(CMD_MSG_RECV) contains an expensive cache operation. Even if
the data is quite small, it always executes D-Cache flush on a buffer
at minimum unit of one page in kdbus_conn_msg_install() /
kdbus_pool_slice_flush() .
In fact,
Hi,
I now booted an ARM board and tried your change, but it doesn't work.
On 06/25/2014 11:13 AM, AKASHI Takahiro wrote:
void kdbus_pool_slice_flush(const struct kdbus_pool_slice *slice)
{
+#if KDBUS_HACK3
+ flush_kernel_vmap_range((void *)slice-off, slice-size);
slice-off is the
Hi,
On 06/26/2014 12:33 PM, AKASHI Takahiro wrote:
On 06/25/2014 06:56 PM, Daniel Mack wrote:
On 06/25/2014 11:13 AM, AKASHI Takahiro wrote:
Note that the kernel features of kdbus are defined by the kernel code,
not by the convenience wrappers for ioctl() that live in test/. As soon
as you
On 06/27/2014 10:50 AM, AKASHI Takahiro wrote:
On 06/27/2014 01:17 AM, Daniel Mack wrote:
Your Pandaboard features an OMAP4430 MCU with VIPT/PIPT data cache that
doesn't suffer from aliasing, and both cache_is_vivt() and
cache_is_vipt_aliasing() will validate to false on your platform. Hence
On 06/27/2014 11:06 AM, AKASHI Takahiro wrote:
On 06/27/2014 01:32 AM, Daniel Mack wrote:
On 06/26/2014 12:33 PM, AKASHI Takahiro wrote:
Assuming that attaching meta is necessary but its also expensive, it might
be a good idea
to have and check meta info not per message, but per connection
On 06/27/2014 11:33 AM, Djalal Harouni wrote:
On Fri, Jun 27, 2014 at 11:24:48AM +0200, Daniel Mack wrote:
No, that's what I'm saying. We cannot cache anything as any information
may change at any time. The rule here is simple: if you want metadata,
you have to be aware that they come
On 06/27/2014 12:46 PM, Kay Sievers wrote:
On Fri, Jun 27, 2014 at 12:32 PM, Djalal Harouni tix...@opendz.org wrote:
For connections with the KDBUS_HELLO_CACHE_META flag dup the
metadata/credentials from handle or from the HELLO cmd, and use it to
construct kdbus kmsg object, this improves
On 06/27/2014 12:51 PM, Djalal Harouni wrote:
Just to let you know that I did notice a regression by ~70% when running
test-kdbus-benchmark on a kvm guest (that's what I've under hands now)
I know sorry, but still a kdbus on kvm is a valid case, I don't know if
this affects real machine or
On 08/14/2014 01:13 PM, Alban Crequy wrote:
Symptoms:
kdbus/bus.h:56:14: error: field ‘kref’ has incomplete type
struct kref kref;
Signed-off-by: Alban Crequy alban.cre...@collabora.co.uk
Strange I don't see this error here.
Anyway, applied. Thanks!
---
bus.h | 1 +
1 file
Hi,
On 08/15/2014 09:43 PM, Marcel Holtmann wrote:
To facility the feature of doing an asynchronous sending of messages
when the bus is idle, make sure to return POLLOUT | POLLWRNORM from
kdbus_handle_poll.
Signed-off-by: Marcel Holtmann mar...@holtmann.org
---
handle.c | 2 ++
1 file
On 08/18/2014 04:02 PM, Lennart Poettering wrote:
On Fri, 15.08.14 14:16, Marcel Holtmann (mar...@holtmann.org) wrote:
Blindly sending messages is never a good idea. You want to poll for
POLLOUT first. This does not make a big difference for current kernel,
but it allows future extensions
On 08/19/2014 03:43 AM, Djalal Harouni wrote:
Signed-off-by: Djalal Harouni tix...@opendz.org
---
metadata.c | 3 ++-
metadata.h | 8 +++-
2 files changed, 9 insertions(+), 2 deletions(-)
Applied, thanks!
diff --git a/metadata.c b/metadata.c
index eb286aa..3dff9ac 100644
---
Hi Djalal,
On 08/19/2014 03:43 AM, Djalal Harouni wrote:
Some creds can be gathered during kdbus_meta_append() instead of
kdbus_conn_queue_alloc() where they will be gathered for all the
receivers and saved into each receivers queue before installing
on the slices.
By moving to
On 08/19/2014 01:39 PM, David Herrmann wrote:
Hi Greg
On Tue, Aug 19, 2014 at 1:29 PM, Greg KH gre...@linuxfoundation.org wrote:
Hi all,
Now that memfd is merged into 3.17-rc1, should we merge the 3.17 branch
in the kdbus tree into master as well? Right now, the test directory on
master
On 08/19/2014 02:37 PM, Greg KH wrote:
$ KERNELDIR=../gregkh/ make
make -C ../gregkh/ M=/home/gregkh/linux/kdbus
make[1]: Entering directory '/home/gregkh/linux/gregkh'
Building modules, stage 2.
MODPOST 1 modules
make[1]: Leaving directory '/home/gregkh/linux/gregkh'
make -C test
On 08/19/2014 02:47 PM, Greg KH wrote:
In file included from
/lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0,
from
/lib/modules/3.17.0-rc1+/build/include/uapi/linux/types.h:13,
from ../kdbus.h:23,
Ok, got it now. No idea why it worked
On 08/19/2014 03:56 PM, Greg KH wrote:
On Tue, Aug 19, 2014 at 03:24:39PM +0200, Daniel Mack wrote:
On 08/19/2014 02:47 PM, Greg KH wrote:
In file included from
/lib/modules/3.17.0-rc1+/build/include/uapi/linux/posix_types.h:4:0,
from
/lib/modules/3.17.0-rc1+/build/include
On 08/19/2014 04:21 PM, Greg KH wrote:
On Tue, Aug 19, 2014 at 04:08:15PM +0200, Daniel Mack wrote:
Could you please try if temporarily reverting my top-most commit and
then doing a 'make headers_install' in your kernel repo (before you
build kdbus) fixes it?
Yes, that works. And we can
On 08/19/2014 11:21 PM, Ronny Chevalier wrote:
---
man/journalctl.xml| 6 +++---
man/systemctl.xml | 2 +-
man/systemd-firstboot.xml | 4 ++--
man/systemd.network.xml | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
Applied, thanks!
diff --git
On 08/20/2014 05:58 PM, Djalal Harouni wrote:
Do the namespace translation just before pushing into the receiver's
slice, so we map to the receiver's user namespace.
Patch tested.
Signed-off-by: Djalal Harouni tix...@opendz.org
Applied, thanks!
---
connection.c | 37
On 08/20/2014 05:58 PM, Djalal Harouni wrote:
case KDBUS_ITEM_AUDIT:
- printf( +%s (%llu bytes) loginuid=%llu
sessionid=%llu\n,
+ printf( +%s (%llu bytes) sessionid=%llu
loginuid=%llu\n,
On 08/20/2014 06:41 PM, Djalal Harouni wrote:
Signed-off-by: Djalal Harouni tix...@opendz.org
---
test/kdbus-util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks!
diff --git a/test/kdbus-util.c b/test/kdbus-util.c
index f79d7ec..5b3df7d 100644
---
On 08/20/2014 06:16 PM, Djalal Harouni wrote:
On Tue, Aug 19, 2014 at 09:15:35AM +0200, Daniel Mack wrote:
Hmm, I'm not convinced this buys us anything really. After all, that
struct has a single user only, and factoring out these fields doesn't
necessarily lead to more readability.
Hmm
Hi,
On 08/22/2014 03:26 PM, Umut Tezduyar Lindskog wrote:
I am having __NR_memfd_create not defined error on mips on systemd
216. I wanted to see the syscall numbers in 3.17 RC1 to patch
missing.h but couldn't find them. What am I missing?
We don't know the final syscall number yet, as it's
On 10/30/2013 03:48 AM, Kay Sievers wrote:
On Wed, Oct 23, 2013 at 1:22 AM, Kay Sievers k...@vrfy.org wrote:
[update]
To avoid any duplication of work, here are the tools which still need
conversion. Please reply to this mail, in case you decide to work on
anything in that area.
-
On 11/03/2013 03:12 PM, Marc-Antoine Perennou wrote:
On Sunday, November 3, 2013, Daniel Mack wrote:
On 10/30/2013 03:48 AM, Kay Sievers wrote:
On Wed, Oct 23, 2013 at 1:22 AM, Kay Sievers k...@vrfy.org
javascript:; wrote:
[update]
To avoid any
Introduce kdbus_name_info as internal helper to make the actual ioctl()
to kdbus.
---
src/libsystemd-bus/bus-control.c | 153 +++
1 file changed, 107 insertions(+), 46 deletions(-)
diff --git a/src/libsystemd-bus/bus-control.c
When starting in kernel mode, determine the minimum buffer size for
subsequent KDBUS_CMD_NAME_QUERY calls. The value returned by kdbus is
dependant on kernel config settings and may vary from system to system
and also in the future, but it is fix for a bus lifetime.
---
In particular, KDBUS_ITEM_NEXT is now called KDBUS_PART_NEXT, and
KDBUS_ITEM_FOREACH was renamed to KDBUS_PART_FOREACH and takes one more
argument to make it more flexible.
---
src/libsystemd-bus/bus-control.c | 2 +-
src/libsystemd-bus/bus-kernel.c | 12 ++--
Implementations for both org.freedesktop.DBus and kdbus are available
---
src/libsystemd-bus/bus-control.c | 116 ++
src/libsystemd-bus/libsystemd-bus.sym | 2 +
src/systemd/sd-bus.h | 2 +
3 files changed, 120 insertions(+)
diff --git
Augment systemd-stdio-bridge a bit to make it a 1:1 bridge from legacy
DBus clients to kdbus. In particular,
* allow setting the bus path of the upstream bus as command line
argument
* use sd_listen_fds() for systemd's socket activation
* omit calling sd_bus_negotiate_fds() when upstream
. This almost works now, but there are some
missing pieces in libsystemd-bus which need to be done first.
The actual socket connection is surprisingly simple, and can be done
with the sdio-bridge which I augmented a bit for that use case.
Thanks,
Daniel
Daniel Mack (7):
libsystemd-bus: bring
Such messages arise when 1:1-bridging legacy clients to kdbus.
---
src/libsystemd-bus/bus-kernel.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/libsystemd-bus/bus-kernel.c b/src/libsystemd-bus/bus-kernel.c
index 94eabfc..6626db1 100644
---
kdbus will tell us the minimum buffer size it needs in case the default
8kb buffer doesn't suffice.
---
src/libsystemd-bus/bus-control.c | 100 ++-
1 file changed, 68 insertions(+), 32 deletions(-)
diff --git a/src/libsystemd-bus/bus-control.c
On 11/15/2013 08:38 PM, Tom Gundersen wrote:
On Fri, Nov 15, 2013 at 7:32 PM, Daniel Mack zon...@gmail.com wrote:
Augment systemd-stdio-bridge a bit to make it a 1:1 bridge from legacy
DBus clients to kdbus. In particular,
* allow setting the bus path of the upstream bus as command line
On Sun, Nov 24, 2013 at 12:31:17PM +0100, Umut Tezduyar Lindskog wrote:
If we needed to keep dbus-daemon but take advantages of kdbus, will we be
able to run them together?
In theory yes, but it wouldn't make any sense, as dbus-daemon connected
clients wouldn't be able to see kdbus clients,
On 11/27/2013 04:59 PM, Lukasz Skalski wrote:
My 2 cents inline.
On 11/15/2013 07:32 PM, Daniel Mack wrote:
kdbus will tell us the minimum buffer size it needs in case the default
8kb buffer doesn't suffice.
---
src/libsystemd-bus/bus-control.c | 100
On 12/04/2013 03:31 AM, Yin Kangkai wrote:
On 2013-11-15, 19:32 +0100, Daniel Mack wrote:
diff --git a/src/libsystemd-bus/bus-kernel.h
b/src/libsystemd-bus/bus-kernel.h
index c4573c9..69df4f4 100644
--- a/src/libsystemd-bus/bus-kernel.h
+++ b/src/libsystemd-bus/bus-kernel.h
@@ -23,16
On 12/04/2013 09:13 AM, Yin Kangkai wrote:
On 2013-12-04, 08:49 +0100, Daniel Mack wrote:
Actually, I have a stupid question, do we have any particular reason
to use part/PART? giving the fact that we already have term item
everywhere in the code...
struct kdbus_item, items, kdbus_msg.items
On Tue, Dec 17, 2013 at 09:50:16AM +0100, Lukasz Skalski wrote:
---
src/bus-driverd/bus-driverd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bus-driverd/bus-driverd.c b/src/bus-driverd/bus-driverd.c
index ce2e1b2..d2b3e08 100644
---
On 02/14/2014 10:47 AM, Radoslaw Pajak wrote:
Signed-off-by: Radoslaw Pajak r.pa...@samsung.com
---
match.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/match.c b/match.c
index d619bef..4c51327 100644
--- a/match.c
+++ b/match.c
@@ -121,6 +121,9 @@ static void
On 02/20/2014 12:33 PM, Michal Eljasiewicz wrote:
This fix allows to register activator connection when
normal connection already exists for that name.
Also, when activator connection registers for a second name
(different than first one) name lookup will
result in no entry found and checking
This brings journalctl's built-in usage output in sync with the man page.
There are no commands to pass, and the help screen should not confuse
users.
Signed-off-by: Daniel Mack zon...@gmail.com
---
src/journal/journalctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 09/08/2014 03:18 PM, Djalal Harouni wrote:
* This is the internal version of struct kdbus_policy_db_access.
@@ -51,7 +52,8 @@ struct kdbus_policy_db_cache_entry {
struct kdbus_policy_db_entry_access {
u8 type;/* USER, GROUP, WORLD */
u8 access; /* OWN, TALK, SEE
On 09/08/2014 03:18 PM, Djalal Harouni wrote:
Upstream kernels allow unprivileged users to create user namespaces
and change their uid/gid.
These patches update kdbus policy logic to handle this case and
improve our current checks across user namespaces.
So this patch adds:
*
On 09/08/2014 03:50 PM, Djalal Harouni wrote:
Yes there are compile time checks, and it is perhaps easier/consistent
to read this way! but yes a union is also good. OK I'll update it.
Nevermind - I amended the your patch accordingly and pushed it.
Thanks!
Daniel
Hi Alban,
Sorry for the long delay on this.
On 08/14/2014 01:21 PM, Alban Crequy wrote:
Before Linux commit 25888e (from 2.6.37-rc4, Nov 2010), fd-passing on Unix
sockets could recursively be stacked, allowing a process to exhaust the open
files limit (/proc/sys/fs/file-max) on the system
On 09/16/2014 07:17 PM, Cristian Rodríguez wrote:
---
src/shared/missing.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/shared/missing.h b/src/shared/missing.h
index 023c680..b441149 100644
--- a/src/shared/missing.h
+++ b/src/shared/missing.h
@@ -209,7 +209,7
On 09/16/2014 09:11 PM, Andreas Henriksson wrote:
Second error path must free the (potentially) allocated memory in the
first code chunk before returning.
Found by coverity. Fixes: CID#1237750
---
src/core/manager.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
On 09/16/2014 09:36 PM, Andreas Henriksson wrote:
The recently allocated printed is not freed on error path.
Found by coverity. Fixes: CID#1237745
---
src/shared/install.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/shared/install.c b/src/shared/install.c
On 09/16/2014 09:22 PM, Andreas Henriksson wrote:
The unit string allocation is not freed on either error or success path.
Found by coverity. Fixes: CID#1237755
---
src/sysv-generator/sysv-generator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 09/17/2014 04:12 AM, Djalal Harouni wrote:
Signed-off-by: Djalal Harouni tix...@opendz.org
---
test/kdbus-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/kdbus-util.c b/test/kdbus-util.c
index fe4565c..b1c5864 100644
--- a/test/kdbus-util.c
+++
On 09/17/2014 11:10 PM, Cristian Rodríguez wrote:
---
src/libsystemd/sd-bus/bus-kernel.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/libsystemd/sd-bus/bus-kernel.c
b/src/libsystemd/sd-bus/bus-kernel.c
index 505f335..b3cc996 100644
---
On 09/18/2014 02:56 AM, Cristian Rodríguez wrote:
..by simply moving the declaration of unit into the STRV_FOREACH
loop as suggested by Andreas.
---
src/systemctl/systemctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/systemctl/systemctl.c
On 09/26/2014 05:05 AM, Zbigniew Jędrzejewski-Szmek wrote:
Hi,
test-bus-policy fails intermittently in 'make distcheck'
FAIL: test-bus-policy
=
Assertion 'policy_check_own(p, ucred, org.test.test1) == true' failed at
../src/bus-proxyd/test-bus-policy.c:58,
function
On 09/26/2014 01:16 PM, Zbigniew Jędrzejewski-Szmek wrote:
On Fri, Sep 26, 2014 at 10:24:25AM +0200, Daniel Mack wrote:
On 09/26/2014 05:05 AM, Zbigniew Jędrzejewski-Szmek wrote:
Hi,
test-bus-policy fails intermittently in 'make distcheck'
FAIL: test-bus-policy
On 09/27/2014 02:48 PM, Eric Cook wrote:
removed pointless index sort of bootids.
use `compadd -a' to add each array, instead of expanding possibly hundreds of
words needlessly.
optional completion of -b
Applied, thanks.
---
shell-completion/zsh/_journalctl | 8
1 file
Hi Simon,
On 10/01/2014 03:33 PM, Simon McVittie wrote:
(Cc'd to the systemd mailing list because sd-bus is the reference
implementation of the user-space side of kdbus, but please join the dbus
list and follow-up there if you are interested in D-Bus.)
I've recently been looking at kdbus as
On 10/10/2014 12:29 PM, Lukasz Skalski wrote:
Commit 710fc9779b7c (kdbus repo) introduced attaching items[]
instead of name[] in kdbus_cmd_conn_info struct. Commit 581fe6c81
(systemd repo) caught up with this change, but item size was not
properly calculated.
Thanks for spotting this!
On 10/10/2014 04:42 PM, Lukasz Skalski wrote:
'ListQueuedOwners' method should return 'NameHasNoOwner' error
if chosen name is not available on bus.
Applied, thanks!
---
src/bus-proxyd/bus-proxyd.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/bus-proxyd/bus-proxyd.c
On 10/13/2014 03:29 PM, Lukasz Skalski wrote:
'GetConnectionUnixProcessID', 'GetConnectionUnixUser' and
'GetConnectionSELinuxSecurityContext' methods should return
'NameHasNoOwner' error (if chosen name is not available on bus)
with more detailed description - like dbus-1:
Could not get PID
On 10/14/2014 04:13 PM, Lukasz Skalski wrote:
---
src/bus-proxyd/bus-proxyd.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
Applied, thanks!
diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c
index 52498f3..6ff0e8c 100644
---
On 10/15/2014 10:46 AM, Jan Synacek wrote:
---
man/systemd.service.xml | 6 +++---
man/systemd.socket.xml | 2 +-
man/systemd.swap.xml| 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
Applied, thanks!
diff --git a/man/systemd.service.xml b/man/systemd.service.xml
index
On 10/24/2014 03:40 AM, Chris Bell wrote:
On Thu, Oct 23, 2014 at 8:53 PM, Lennart Poettering
-all processes of the session are terminated. If
-the last concurrent session of a user ends, his
-user systemd instance will be
On 11/11/2014 03:31 PM, Colin Walters wrote:
See:
http://build.gnome.org/continuous/buildmaster/builds/2014/11/11/23/build/log-systemd.txt
Perhaps something like this?
My bad, sorry. I had a hunk confusion due to rebasing.
It's already reverted in master.
Daniel
diff --git
On 02/06/2015 05:08 PM, Lukasz Skalski wrote:
Set proper kdbus_cmd_list object size, otherwise:
Applied, thanks!
dbus-send --system --dest=org.freedesktop.DBus --type=method_call \
print-reply / org.freedesktop.DBus.ListQueuedOwners
string:org.freedesktop.systemd1
Error
On 01/20/2015 12:56 PM, Rami Rosen wrote:
subscibe-subscribe
Applied, thanks!
---
src/network/networkd-wait-online-manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/network/networkd-wait-online-manager.c
b/src/network/networkd-wait-online-manager.c
Hi Shawn,
On 02/19/2015 02:15 AM, Shawn Landden wrote:
---
fs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs.c b/fs.c
index 22ca62b..f751392 100644
--- a/fs.c
+++ b/fs.c
@@ -208,7 +208,6 @@ static struct inode *fs_inode_get(struct super_block *sb,
inode-i_private =
On 01/29/2015 05:42 AM, Bryan Hundven wrote:
During the 3.19 merge window, two commits in Linus's tree:
b5ae6b15bd73e35b129408755a0804287a87e041
=
merge d_materialise_unique() into d_splice_alias()
=
and
41d28bca2da4bd75a8915c1ccf2cacf7f4a2e531
=
switch d_materialise_unique()
On 02/09/2015 10:53 AM, Lukasz Skalski wrote:
This patch fixes also problem with ReleaseName call in
systemd-bus-proxyd.
Applied, thanks!
diff --git a/names.c b/names.c
index 5f57aa3..e85ba45 100644
--- a/names.c
+++ b/names.c
@@ -266,6 +266,7 @@ static int kdbus_name_release(struct
On 01/05/2015 02:45 PM, Lukasz Skalski wrote:
---
src/bus-proxyd/bus-proxyd.c | 4
1 file changed, 4 insertions(+)
Applied, thanks!
diff --git a/src/bus-proxyd/bus-proxyd.c b/src/bus-proxyd/bus-proxyd.c
index a7818f5..fc70cce 100644
--- a/src/bus-proxyd/bus-proxyd.c
+++
Applied, thanks!
On 03/09/2015 01:02 PM, Torstein Husebø wrote:
---
man/systemd.network.xml | 2 +-
src/systemd/sd-daemon.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/man/systemd.network.xml b/man/systemd.network.xml
index 3522551293..5d7518b348 100644
---
On 03/29/2015 08:46 PM, Alexander Sverdlin wrote:
Entropy Graph code doesn't handle the error condition if open() of /proc entry
fails. Moreover, the file is only opened once and only first sample will
contain
the correct value because the return value of pread() is also not handled
properly
1 - 100 of 172 matches
Mail list logo
