Running make dist requires Python support since some of the man page sources
(such as man/systemd.index.xml and man/systemd.directives.xml) are generated by
Python scripts, so break make dist and give an useful error message when
Python or the Python lxml module is not available.
Tested:
$
This fixes the footer where 7 spaces were used on the first line of EXTRA_DIST,
but a Tab was clearly intended.
---
tools/make-man-rules.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/make-man-rules.py b/tools/make-man-rules.py
index 9f46f7b889c6..e75bfffba140 100644
If --with-python is passed explicitly, configure should break if it can not
find a usable Python or lxml library. The error message should be explicit
about the configuration problem.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=80005
Tested:
- $ ./configure --with-python
checking for
Python support is pretty much essential to create man pages, so we should make
sure that distcheck will request it during configure.
Tested: Successfully ran make distcheck and confirmed --with-python was
present in the ./configure run inside the unpacked distribution directory.
---
Makefile.am
Running make dist requires --enable-compat-libs since DIST_SOURCES will list
generated files such as libsystemd-daemon.c.
Tested:
$ ./configure make make dist
*** compat-libs must be enabled in order to make dist
make: *** [dist-check-compat-libs] Error 1
---
Makefile.am | 8 +++-
1
Be verbose when checking if Python module lxml is available. Also warn that
Python support will be disabled when the lxml module is not present.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=80005
Tested:
- Without python-lxml package installed:
$ ./configure
checking for python
This includes the new systemd-journald-dev-log.socket man page introduced in
commit 03ee5c38cb0da and also fixes indentation of EXTRA_DIST with the fix to
make-man-rules.py.
---
Makefile-man.am | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Makefile-man.am
The sysusers.d/systemd.conf configuration file was originally introduced in
commit 1b99214789101, but it was not marked for cleanup. This caused distcheck
to complain about the file not being removed by distcleam.
Tested: Successfully ran make distcheck with this patchset.
---
Makefile.am | 3
Hi,
This patchset fixes some issues I found with the build system of systemd,
particularly breaking runs of make dist and make distcheck.
Also some general cleanup.
Cheers,
Filipe
Filipe Brandenburger (9):
build-sys: add sysusers.d/systemd.conf to CLEANFILES
build-sys: do not include
On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek
zbys...@in.waw.pl wrote:
+if (client-fd 0)
+safe_close(client-fd);
+client-fd = -1;
client-fd = safe_close(client-fd);
That's what safe_close is for :)
And shouldn't the check be for client-fd = 0?
Makefile.am had a reference to it but it none of the sources included it.
Tested: make dist works again after this patchset is applied.
Fixes: 2ea8857effb833615b16d10fc7a19a7104c19e13
---
Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index
If the file is not listed, then make dist will not include it.
Tested: make distcheck works after this fix is applied.
Fixes: 139b011ab81ccea1d51f09e0261a1c390115c6ff
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index d93b64e69d85..2427b24f59fd
It was incorrectly looking for a file in src/libsystemd-network/ when the file
was actually deployed to src/systemd/ instead. This broke make dist.
Tested: make dist works again after this patchset is applied.
Fixes: f20a35cc0d537dd4cfc1054cf7936b04a1700f3a
---
Makefile.am | 2 +-
1 file
On Thu, Jun 19, 2014 at 3:25 PM, Lennart Poettering
lenn...@poettering.net wrote:
On Thu, 19.06.14 11:59, Filipe Brandenburger (filbran...@google.com) wrote:
If the file is not listed, then make dist will not include it.
Tested: make distcheck works after this fix is applied.
Fixes
an archive without having intltool
installed, as the systemd README implies (intltool is only listed under When
building from git, you need the following additional dependencies.)
Please take a look and let me know what you think of these.
Cheers,
Filipe
Filipe Brandenburger (3):
build-sys: add
IT_PROG_INTLTOOL makes configure fail if intltool is not present. If we can
not find intltool, then disable NLS (otherwise make in po/ fails since MSGFMT
will not be defined.)
Tested: Built it on a host without intltool.
$ ./configure --enable-nls
...
checking for intltool-merge... no
So that building from an archive works even if intltool is not present.
The README file already mentioned that intltool should only be required
when building from git.
Tested: Built it from the distribution archive on a host without intltool.
$ ./configure --enable-polkit
$ make
---
In particular, disable intltool when --disable-nls is passed to configure.
Tested: Built it on a host without intltool or gettext.
$ ./configure --disable-nls --disable-polkit
$ make
---
configure.ac | 10 ++
1 file changed, 10 insertions(+)
diff --git a/configure.ac b/configure.ac
On Thu, Jun 26, 2014 at 4:54 PM, David Härdeman da...@hardeman.nu wrote:
Add binary string handling functions and extend the password agent
protocol to support binary strings (using = as a string prefix
instead of +).
Please also add /test-bstrv to .gitignore.
On Mon, Jun 30, 2014 at 2:38 PM, Lennart Poettering
lenn...@poettering.net wrote:
Maybe it should try both and figure out which one of them exists?
Or default to $libdir and allow an override for the cross-distro cases.
Hmm, I am tempted to say that we should add a logic to this that just
---
src/network/networkd-network-gperf.gperf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/network/networkd-network-gperf.gperf
b/src/network/networkd-network-gperf.gperf
index 3aaae4c94bff..ce9047cd06c4 100644
--- a/src/network/networkd-network-gperf.gperf
+++
+Zbigniew who committed the original patch.
On Fri, Jul 4, 2014 at 11:43 AM, Mike Gilbert flop...@gentoo.org wrote:
This reverts commit 0c26bfc3d21fdb3963f1248c237e2f1a33b5566d.
src/core/org.freedesktop.systemd1.policy.in.in depends on values which
are specified at configure time, so we
Otherwise the test fails when built with CPPFLAGS='-DNDEBUG' which disables
assertions.
Tested:
- make check TESTS='test-compress' CPPFLAGS='-DNDEBUG'
---
src/journal/test-compress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/journal/test-compress.c
Otherwise they get optimized out when CPPFLAGS='-DNDEBUG' is used, and that
causes the tests to fail.
Tested:
- make check TESTS='test-path-util' CPPFLAGS='-DNDEBUG'
---
src/test/test-path-util.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git
Otherwise it gets optimized out when CPPFLAGS='-DNDEBUG' is used.
Tested:
- make check TESTS='test-util' CPPFLAGS='-DNDEBUG'
---
src/test/test-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/test-util.c b/src/test/test-util.c
index 34d5f2ed7d23..4d9b28f9c8e7
On Wed, Dec 10, 2014 at 4:11 AM, Lennart Poettering
lenn...@poettering.net wrote:
In fact, I think we should drop the
libcap dependency altogether and just do the two syscalls it offers to
us natively in systemd code. Neither is libcap a particularly nice
library, nor is the stuff it does
Hi,
Commit 6573ef05a3cbe1 (journal: keep per-JournalFile location info
during iteration) breaks tests test-journal-stream and
test-journal-interleaving.
It seems that the logic of overriding f-current_offset in
journal_file_save_location has other unintended side effects, checking
out that
that seems to solve this problem...
Cheers,
Filipe
On Thu, Dec 18, 2014 at 2:34 PM, Filipe Brandenburger
filbran...@google.com wrote:
Hi,
Commit 6573ef05a3cbe1 (journal: keep per-JournalFile location info
during iteration) breaks tests test-journal-stream and
test-journal-interleaving.
It seems
On Thu, Dec 18, 2014 at 4:39 PM, Filipe Brandenburger
filbran...@google.com wrote:
Not sure what's the correct solution, maybe journal_file_save_location
needs to happen only in real_journal_next() outside the
ORDERED_HASHMAP_FOREACH loop? I'll try that and report if I find
something
On Thu, Dec 18, 2014 at 4:58 PM, Filipe Brandenburger
filbran...@google.com wrote:
But this does not work on trunk head, even after adapting it, the
tests start to fail in a different location, probably because of the
changes that come after it, so I think we'll need this and further
changes
Hi,
This seems to have fixed test-journal-stream but
test-journal-interleaving is still broken for me, it fails with:
NUMBER=1
NUMBER=2
Assertion 'r == 1' failed at
src/journal/test-journal-interleaving.c:101, function
test_check_numbers_down(). Aborting.
Aborted (core dumped)
Can you please
On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl mbi...@gmail.com wrote:
This also removed the HAVE_PYTHON section from Makefile-man.am. Why it
did that is unclear to me.
This happened to me before and when it did it was because ./configure
didn't detect a working Python, so make update-man-list
On Fri, Dec 19, 2014 at 8:31 AM, Michael Biebl mbi...@gmail.com wrote:
2014-12-19 17:10 GMT+01:00 Filipe Brandenburger filbran...@google.com:
On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl mbi...@gmail.com wrote:
This also removed the HAVE_PYTHON section from Makefile-man.am. Why it
did
On Fri, Dec 19, 2014 at 8:30 AM, Michal Schmidt mschm...@redhat.com wrote:
On 12/19/2014 04:49 PM, Filipe Brandenburger wrote:
This seems to have fixed test-journal-stream but
test-journal-interleaving is still broken for me, it fails with:
NUMBER=1
NUMBER=2
Assertion 'r == 1' failed
Hi,
On Sat, Dec 20, 2014 at 8:19 AM, Dave Reisner dreis...@archlinux.org wrote:
---
Makefile.am | 9 +-
src/test/test-verbs.c | 78
+++
2 files changed, 86 insertions(+), 1 deletion(-)
create mode 100644 src/test/test-verbs.c
we start
with these and go from here.)
Cheers,
Filipe
On Fri, Dec 12, 2014 at 4:55 PM, Filipe Brandenburger
filbran...@google.com wrote:
Do not use the dbus-1.pc pkgconfig settings to determine dbus directories. Use
directories relative to ${sysconfdir} and ${datadir} instead.
This approach
come from kernel headers (or
missing.h), it makes sense to have more of our own routines...
Cheers,
Filipe
On Tue, Dec 16, 2014 at 5:18 PM, Filipe Brandenburger
filbran...@google.com wrote:
This is a first cleanup step towards removing the dependency on libcap.
The idea of removing the libcap
Ping?
On Fri, Dec 19, 2014 at 9:45 AM, Filipe Brandenburger
filbran...@google.com wrote:
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 1b5d60f..078fd9a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -207,6 +207,7 @@
/test-libudev-sym
Ping?
On Fri, Dec 12, 2014 at 10:47 AM, Filipe Brandenburger
filbran...@google.com wrote:
The new test-cap-list introduced in commit 2822da4fb7f891 uses the included
table of capabilities. However, it uses cap_last_cap() which probes the kernel
for the last available capability. On an older
The asserts used in the tests should never be allowed to be optimized away.
---
src/test/test-util.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/test-util.c b/src/test/test-util.c
index 222af9a..57fd19b 100644
--- a/src/test/test-util.c
+++
In test_raw_clone, make sure the cloned thread calls _exit() and in the parent
thread call waitpid(..., __WCLONE) to wait for the child thread to terminate,
otherwise there is a race condition where the child thread will log to the
console after the test process has already exited and the
Hi,
On Tue, Dec 23, 2014 at 6:43 AM, Lennart Poettering
lenn...@poettering.net wrote:
On Mon, 22.12.14 11:57, Filipe Brandenburger (filbran...@google.com) wrote:
Ping?
I got none of these emails, and they are neither shown in the mailing
list archives. There must be something wrong
capability-related information used is the CAP_* constants which are actually
coming from linux/capability.h (kernel headers) or from missing.h (for
compatibility with older kernel headers.)
Filipe Brandenburger (9):
capabilities: remove spurious include of sys/capability.h from nspawn.c
It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by this file comes from linux/capability.h imported through
missing.h.
Tested that systemd-hostnamed builds cleanly and works after this change.
---
src/hostname/hostnamed.c | 1 -
1 file changed, 1
It does not use any functions from libcap directly. The CAP_MKNOD constant in
use by this file comes from linux/capability.h imported through missing.h.
Tested that systemd-tmpfiles builds cleanly and works after this change.
---
src/tmpfiles/tmpfiles.c | 1 -
1 file changed, 1 deletion(-)
diff
It does not use any functions or constants from libcap directly.
Tested that pam_systemd.la builds cleanly and works after this change.
---
src/login/pam_systemd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c
index 111e2b7..d5b29c8 100644
It does not use any functions from libcap directly. The CAP_SYS_TIME constant
in use by this file comes from linux/capability.h imported through
missing.h.
Tested that systemd-timedated builds cleanly and works after this change.
---
src/timedate/timedated.c | 1 -
1 file changed, 1 deletion(-)
It does not use any functions from libcap directly. The CAP_* constants in use
through this file come from missing.h which will import linux/capability.h
and complement it with CAP_* constants not defined by the current kernel
headers.
Add an explicit import of our capability.h since it does use
They do not use any functions from libcap directly. The CAP_KILL constant in
use by these files comes from linux/capability.h imported through
missing.h.
Tested that systemd-machined builds cleanly and works after this change.
---
src/machine/machine-dbus.c | 1 -
src/machine/machined-dbus.c |
It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by this file comes from linux/capability.h imported through
missing.h.
Tested that systemd-localed builds cleanly and works after this change.
---
src/locale/localed.c | 1 -
1 file changed, 1 deletion(-)
They do not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by bus-objects.c comes from linux/capability.h imported through
missing.h. The missing.h header is imported through util.h which gets
imported in bus-util.h.
Tested that everything builds cleanly after this
On Tue, Dec 23, 2014 at 5:23 AM, David Herrmann dh.herrm...@gmail.com wrote:
I cannot find these patches on systemd-devel@lists.freedesktop.org.
This might be due to fdo mail-server issues, or me just being
incapable of searching through my emails... Anyway, would you mind
resending those?
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 1b5d60f..078fd9a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -207,6 +207,7 @@
/test-libudev-sym*
/test-list
/test-unaligned
+/test-lldp
/test-locale-util
/test-local-addresses
/test-log
--
Do not use the dbus-1.pc pkgconfig settings to determine dbus directories. Use
directories relative to ${sysconfdir} and ${datadir} instead.
This approach was suggested by Simon McVittie in:
http://lists.freedesktop.org/archives/systemd-devel/2014-October/024388.html
Tested by building and
This directory is not used by systemd.
Tested by running a full build, running `make install` and comparing the file
list in the target trees and making sure that `make distcheck` still works.
---
configure.ac | 7 ---
1 file changed, 7 deletions(-)
diff --git a/configure.ac b/configure.ac
Hi,
On Tue, Dec 23, 2014 at 10:15 AM, Lennart Poettering
lenn...@kemper.freedesktop.org wrote:
commit 3c70e3bb022f0de3317f3600c9366a2f4597339e
Author: Lennart Poettering lenn...@poettering.net
Date: Tue Dec 23 18:36:04 2014 +0100
core: rearrange code so that libsystemd/sd-bus/ does not
The new test-cap-list introduced in commit 2822da4fb7f891 uses the included
table of capabilities. However, it uses cap_last_cap() which probes the kernel
for the last available capability. On an older kernel (e.g. 3.10 from RHEL 7)
that causes the test to fail with the following message:
The new polkit file was introduced in commit d04c1fb8e21560 (machined:
introduce polkit for OpenLogin() call).
---
po/POTFILES.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 2829c87..344c307 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -1,5
The file was moved from src/libsystemd-network to src/systemd in commit
7a6f1457462840 (sd-lldp: minor header cleanup).
This fixes make distcheck.
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 4173147..8446469 100644
---
Move units/machines.target from nodist_systemunit_DATA to dist_systemunit_DATA,
since it's not a generated file. Otherwise, `make clean` would remove the
committed copy of the file.
Tested that `./autogen.sh c` will not remove it and that `make distcheck` works
after this fix.
---
Makefile.am |
Commit 003dffde2c1b93 (machined: Move image discovery logic into src/shared,
so that we can make use of it from nspawn) moved some definitions from
machine.h to a new machine-dbus.h, but did not include it in Makefile.am
Tested that `make distcheck` works after this fix.
---
Makefile.am | 1 +
1
Ping?
distcheck is still failing due to the lack of reference to this header
file in Makefile.am
Cheers,
Filipe
On Mon, Dec 29, 2014 at 3:22 PM, Filipe Brandenburger
filbran...@google.com wrote:
Commit 003dffde2c1b93 (machined: Move image discovery logic into src/shared,
so that we can make
Hi,
On Mon, May 18, 2015 at 7:26 AM, Krzysztof Opasiak
k.opas...@samsung.com wrote:
Matching between fds and list of expected paths is done in n^2
I don't think that's the case, because you can just stat() all the
names and fstat() all the fds, then sort both lists on inode numbers
and then
Hi,
On Tue, Jun 2, 2015 at 7:58 AM, Dimitri John Ledkov
dimitri.j.led...@intel.com wrote:
And I think this is _good_, because the submitter's commit ids will be
preserved (together with the signed gpg commits) [...]
This, signed gpg commits, is actually the first reasonable argument I
see for
Pull Request created:
https://github.com/systemd/systemd/pull/44
If you could test it and confirm your sudo case with \073 works now,
and your regexp case isn't broken, I'd appreciate it.
Cheers,
Filipe
On Tue, Jun 2, 2015 at 2:53 PM, Filipe Brandenburger
filbran...@google.com wrote:
Hi
Hi Michael,
On Tue, Jun 2, 2015 at 2:50 PM, Michael Biebl mbi...@gmail.com wrote:
2015-06-02 12:55 GMT+02:00 Daniel Mack dan...@zonque.org:
So, my primary motivation was to fix the obvious regression at hand
first, but I agree the actual problem goes deeper.
Looks like even with this patch
Moving from #88 to this thread:
On Tue, Jun 9, 2015 at 12:41 PM, Lennart Poettering
lenn...@poettering.net wrote:
So I think updating the PR (by force-pushing) is really nasty, and we
shouldn't do it. Instead, please push a new PR, mention that it
obsoletes the old one. (of course, I wished
On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering
lenn...@poettering.net wrote:
[...] so we comment and ask for a new PR, and close the old one.
See my previous comment, I think this cure is worse than the disease :-)
Instead, just reuse the same PR and use `git push -f` to ship new
versions
I don't think it should be there...
https://github.com/systemd/systemd/branches
Otherwise everyone doing git fetch will get a copy of this branch...
I think the main git should only expose a single master branch.
Would you care to delete it and be careful not to push extraneous
branches to the
Hi,
This commit was not moved to GitHub, it's under review here:
https://github.com/systemd/systemd/pull/44
On Sun, May 31, 2015 at 12:06 AM, Andrei Borzenkov arvidj...@gmail.com wrote:
В Sat, 30 May 2015 23:29:29 -0700 Filipe Brandenburger
filbran...@google.com пишет:
- Handling
On Tue, Jun 9, 2015 at 2:37 PM, Lennart Poettering
lenn...@poettering.net wrote:
On Tue, 09.06.15 13:04, Filipe Brandenburger (filbran...@google.com) wrote:
On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering lenn...@poettering.net
wrote:
[...] so we comment and ask for a new PR, and close
Guys let's try to be constructive here...
This time it shouldn't be too painful for downstreams since the revert
was the last patch to the man subtree so just a git revert of that
should get your trees to the state you need to get v221 packages for
Debian and Ubuntu. In that sense, I think we're
On Thu, Jun 18, 2015 at 11:54 AM, Lennart Poettering
lenn...@poettering.net wrote:
On Tue, 02.06.15 12:18, Chris Morgan (chmor...@gmail.com) wrote:
systemd 216 here on an embedded arm system, 1ghz with a load of 60% or
more. I enabled tab completion, because I really don't like to type,
and
On Wed, Jun 10, 2015 at 5:04 AM, Martin Jansa martin.ja...@gmail.com wrote:
If you want good review tool, why not use gerrit?
+1 for Gerrit as a code review tool.
It's not perfect, but from all of them that I've used it seems to get
the most right:
- Review *commits* and not PRs (tends to
On Wed, Jun 10, 2015 at 9:52 AM, Lennart Poettering
lenn...@poettering.net wrote:
On Wed, 10.06.15 08:25, Filipe Brandenburger (filbran...@google.com) wrote:
On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy al...@endocode.com wrote:
FWIW it only loses the comments if people comment on individual
On Wed, Jun 10, 2015 at 12:23 AM, Jan Synáček jsyna...@redhat.com wrote:
See https://github.com/systemd/systemd/pull/5. There are multiple
references to this PR that say user referenced this pull request from
a commit in commit, which is hilarious, as those clearly are not
references to this
On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy al...@endocode.com wrote:
Instead, just reuse the same PR and use `git push -f` to ship new
versions of the commits to the same branch... Yes it's awful but
unfortunately that's how GitHub works...
Yeah, it is awful, and loses all the comments, as
On Thu, Jun 11, 2015 at 12:31 PM, Ronny Chevalier
chevalier.ro...@gmail.com wrote:
On Thu, Jun 11, 2015 at 6:31 PM, Filipe Brandenburger filbran...@google.com
wrote:
Another downside of adding comments to the commits is that e-mail
notifications are not sent for them (I just noticed
Export the MOUNT_PATH and UMOUNT_PATH variables as XML entities and use them in
the systemctl.1 manpage instead of hardcoding the path in /usr/bin.
Tested:
- Ran ./configure ac_cv_path_MOUNT_PATH=/bin/mount (same for umount) and
rebuilt the manpages, confirmed that the correct path was in
On Thu, May 28, 2015 at 10:44 AM, Michael Biebl mbi...@gmail.com wrote:
2015-05-28 19:41 GMT+02:00 Martin Pitt martin.p...@ubuntu.com:
\o/ Many thanks Filipe, that's great! Biggest patch gone :)
A huge thanks from me as well to everyone involved!
Lennart: Thanks for applying it.
Martin and
Hi,
I was thinking about this one recently...
I really think the correct solution is for man/custom-entities.ent
to be generated by configure from a man/custom-entities.ent.in
template instead. I haven't really checked if that's viable though, if
configure knows about every variable it will
Hi,
On Sun, May 31, 2015 at 12:06 AM, Andrei Borzenkov arvidj...@gmail.com wrote:
В Sat, 30 May 2015 23:29:29 -0700 Filipe Brandenburger
filbran...@google.com пишет:
- Handling a \; is ugly, it looks like a hack... unquote_first_word is
not equipped to recognize that sequence, so I had
Hi Tom,
On Wed, May 27, 2015 at 8:45 AM, Tom Gundersen t...@jklm.no wrote:
It appears a few people see this, but I was not able to reproduce. If
anyone could reproduce with this patch applied [0], it would be most
helpful (and post the output of journalctl -b -u systemd-udevd).
Done.
Console
Hi,
On Wed, May 27, 2015 at 6:04 AM, Lennart Poettering
lenn...@poettering.net wrote:
Hmm, any chance we can somehow define those entities without having to
add
!ENTITY % entities SYSTEM custom-entities.ent
%entities;
]
To each file? Can't we tell xsltproc about this via some command
On Wed, May 27, 2015 at 10:08 AM, Tom Gundersen t...@jklm.no wrote:
This should be fixed by 86c3bece38bcf55da6387d20c6f01da9ad0284dc.
Thanks for the help in debugging this, and sorry for the
inconvenience.
And I can confirm the timeout is gone.
Thanks for fixing it quickly Tom! Glad to help
Hi Daniel,
I haven't tested it, but I do have a few comments.
First, why not use rootlibdir instead of rootprefixlibdir? There's
already similar rootbindir and rootlibexecdir defined there, so I
think we could stick to the same convention.
From a few lines down in Makefile.am:
# And these
On Fri, May 29, 2015 at 5:21 PM, Michael Biebl mbi...@gmail.com wrote:
autoconf already strips trailing slashes for all default directory
variables [1].
How does it handle --prefix=/ though? Does it turn it into an empty string?
I think we should do the same for *all* our custom
From: Michael Biebl bi...@debian.org
Strip trailing slashes from options such as --with-rootprefix, so that building
with rootprefix=/ results in paths like /lib instead of //lib.
Also handle paths such as /usr/ gracefully.
Use m4/ax_normalize_path.m4 from the autoconf-archive project, which is
Hi,
On Fri, May 29, 2015 at 6:04 PM, Michael Biebl mbi...@gmail.com wrote:
I we assume, autconf-archive is installed, the resulting patch would
look like the attached diff.
For convenience sake, we could also ship a copy of
/usr/share/aclocal/ax_normalize_path.m4 in our m4/ directory.
Yep...
Get rid of code duplication here.
---
Some alternatives I considered:
1) Keep a separate bool escape and set it when we see a backslash, still
keeping state set to VALUE or SINGLE_QUOTE or DOUBLE_QUOTE.
2) Create the enum so that ESCAPE has a bit value like 0x100 or similar, so
that we
This is an attempt to convert it from using FOREACH_WORD_QUOTED into a
loop using unquote_first_word repeatedly.
Additionally, we're looping through the arguments only once and using
_cleanup_ functions to manage objects owned by this function.
Some notes:
- There is some difference in how
Hi,
On Wed, May 27, 2015 at 3:40 PM, Charles Duffy char...@dyfis.net wrote:
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored -Wformat-nonliteral
+time_len = strftime(buf, l, arg_time_format, curr_time);
+if (time_len = 0)
+return;
+#pragma GCC
On Tue, Jun 2, 2015 at 3:55 AM, Daniel Mack dan...@zonque.org wrote:
The problem here is that cunescape() wasn't as strict in the past as it
should have been, and now there are unit files in the wild which contain
escape sequences that slip through the C unescaping mechanism.
So, my primary
Hi Daniel,
On Tue, Jun 2, 2015 at 3:04 AM, Daniel Mack dan...@zonque.org wrote:
On 06/02/2015 11:25 AM, Martin Pitt wrote:
FTR, this works fine here, using --with-rootprefix= (to avoid the
extra slashes). This spawned a long thread and multiple followup
patches, and TBH I lost track which
On Tue, Jun 2, 2015 at 7:24 AM, Daniel Mack dan...@zonque.org wrote:
I could create a PR in systemd-devs GitHub if you'd like, otherwise
feel free to just push it straight upstream if you prefer.
Nope, let's try to get used to the new workflow. Just create the PR :)
Good call... we were
Hi,
Not sure I agree with the commit below. (In particular as I'm looking
at converting this code into using unquote_first_word.)
On Mon, Jun 1, 2015 at 9:10 AM, Daniel Mack
zon...@kemper.freedesktop.org wrote:
commit 22874a348fb1540c1a2b7907748fc57c9756a7ed
Author: Daniel Mack
Hi,
On Sun, May 24, 2015 at 8:41 PM, cee1 fykc...@gmail.com wrote:
I tried ureadahead, but got following error:
write(2, ureadahead: Error while tracing:..., 59ureadahead: Error
while tracing: No such file or directory
Needs an out-of-tree kernel patch?
Yes, ureadahead needs an out-of-tree
Hi Tom,
On Sun, May 24, 2015 at 6:30 AM, Tom Gundersen t...@jklm.no wrote:
On Sun, May 24, 2015 at 11:40 AM, Mantas Mikulėnas graw...@gmail.com wrote:
So, udev v220 crashes in my initramfs with the following message:
starting version v220
Assertion 'manager-pid == getpid()' failed at
On Thu, Nov 12, 2015 at 10:13 AM, Matthew Hall wrote:
> On Thu, Nov 12, 2015 at 10:37:56AM +0100, Lennart Poettering wrote:
>> Since time began eth* is where the kernel automatically picked iface
>> names from. If you want to assign your own names go for some other
>>
Hi,
On Thu, Sep 10, 2015 at 10:10 AM, Michael Biebl wrote:
> reading https://wiki.gnome.org/Projects/GnomeCommon/Migration, it says
> that intltool is practically dead and one should use gettext directly.
>
> Do we still need intltool in systemd? Does gettext have support for
>
1 - 100 of 113 matches
Mail list logo