On Thu, Jun 11, 2015 at 12:31 PM, Ronny Chevalier
<chevalier.ro...@gmail.com> wrote:
> On Thu, Jun 11, 2015 at 6:31 PM, Filipe Brandenburger <filbran...@google.com>
> wrote:
>> Another downside of adding comments to the commits is that e-mail
>> notifications are not sent for them (I just noticed that while lurking
>> on #164, I got e-mails for the main thread but not for Lennart's
>> comments on commit 5f33680.)
>
> Yes you need to specify for each PR you are interested in that you
> want to receive mail notifications for the PR... (I think it's the
> subscribe button at the bottom)
Sorry I should have explained myself better...
I "watch" systemd/systemd as a whole, so I get all notifications
without having to ask for them individually...
On #164, I *did* get an e-mail for @zonque's comment ("Also, you
forgot to add the new files to Makefile.am and po/LINGUAS...") but I
did *not* get e-mails for @poettering's comments on commit 5f33680
("Hmm, can you please change the commit msg to say this is the catalog
translation? ...") and the replies on that thread (@s8321414 replied
"@poettering How can I do this using git?" etc.)
I think that's one more symptom of the fact that, for GitHub, the
commit itself doesn't directly belong to the PR, and so does not
belong to the project either...
The e-mail notifications are not really a great big deal (still, they
are annoying), but I think it's just one more sign that adding
comments to the commits will end up causing trouble in the future...
Cheers,
Filipe
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
