Hi,
I've been trying to get sd-boot to work on Fedora 30, made some progress
but not fully there yet...
First I found my partition GPT type in /boot was incorrect and bootctl was
trying to use /boot/efi instead. Ok, that fixed, now I get a list of
kernels.
But whenever I boot, I only get the "Re
Hey Lennart,
Thanks for the clarification.
On Tue, Feb 12, 2019 at 2:17 AM Lennart Poettering
wrote:
> On Mo, 11.02.19 16:39, Filipe Brandenburger (filbran...@google.com) wrote:
> > Before systemd v237 (when Delegate= was no longer allowed on slice
> > units)... Did setting De
If you want to run it early in the shutdown process, then keep
DefaultDependencies=yes, in which case it will run before the base
dependencies start to get stopped.
If you need some other resources to be up, for instance network, then add
After=network.target, etc.
Remember that when shutting dow
So I think all the bits already exist somewhere and perhaps a small
change in naming would go a long way to make these pushes smoother.
If when we cut v240 from the master branch, we had called it v240-rc1
instead, perhaps it was clear that it could take some more testing
before it was made offici
On Thu, Jul 12, 2018 at 2:06 PM Matt Zagrabelny wrote:
> On Thu, Jul 12, 2018 at 3:07 PM, Filipe Brandenburger
> wrote:
>> Take a look at systemd-run and, in particular, options such as
>> --on-active=, --on-calendar= and --timer-property=, which allow you to
>> set a
Hi,
On Thu, Jul 12, 2018 at 12:04 PM Matt Zagrabelny wrote:
> I know systemd can replace cron. Do folks use it to replace "at", too?
>
> I know it *can* - with two files per "at" entry and then enabling and
> starting the timer.
>
> Is there an easier with to replace "at" with systemd than creat
Hey Daniel!
On Wed, Jul 11, 2018 at 5:16 PM Daniel Wang wrote:
> I have a unit, say foo.service, on my system that's in
> /usr/lib/systemd/system, but disabled by preset.
Not that it matters, but presets don't really matter here. The unit is
disabled, period.
> On system boot, it doesn't show
Hi,
Actually, it seems AppArmor has support for containers and can have a
specific profile for inside the containers only.
Docker does support it:
https://docs.docker.com/engine/security/apparmor/
Agree it shouldn't be too hard to hook this into nspawn... I don't really
use AppArmor or know it w
Hi Florian,
On Sun, Mar 25, 2018 at 9:36 AM, Florian Held wrote:
> how is it possible to log in into a container booting a minimal unstable
> debian distro via nspawn. After running:
>
> # debootstrap --arch=amd64 unstable ~/debian-tree/
> # systemd-nspawn -bD ~/debian-tree/
>
> prompts username
Hi!
So I'm testing a program repeatedly and using `systemd-run` to start a
service with it, passing it a specific unit name.
When the test finishes and I bring down the service, I want to be able to
collect the journald logs for that execution of the test alone.
Right now what I'm doing is namin
Hi,
I found it's possible to halt a VM after a service has stopped by
using something like this:
ExecStopPost=/sbin/halt -p
Is this the cleanest approach? Or would anyone have a better
recommendation (perhaps using systemd-halt.service or similar)?
Thanks!
Filipe
smime.p7s
Description: S/MIME
Hi,
On Wed, Dec 30, 2015 at 2:52 AM, Michael Chapman wrote:
> On Wed, 30 Dec 2015, Reindl Harald wrote:
>>> > i am asking for StandardOutput=console get piped to the terminal
>>> > systemctl was called - the rest is done by crond as all the years
>>> > before
>>>
>>> That isn't possible at the
Hi,
On Thu, Nov 19, 2015 at 7:42 AM, von Thadden, Joachim, SEVEN
PRINCIPLES wrote:
> using systemd 219-25 on Fedora 22 on a freshly created container I can not
> make any
> device. Usage of --capability=CAP_MKNOD makes no difference.
>
> Steps to reproduce:
> [root@nbl ~]# machinectl pull-raw --
On Fri, Nov 13, 2015 at 10:55 AM, Lennart Poettering
wrote:
>> I accidentally pushed this directly
>> into master unfortunately. Sorry for that! Was supposed to become a
>> PR, but I was on the wrong branch.
>
> So, actually I was too dumb to use git, and thus git saved me from
> actually making t
On Thu, Nov 12, 2015 at 10:13 AM, Matthew Hall wrote:
> On Thu, Nov 12, 2015 at 10:37:56AM +0100, Lennart Poettering wrote:
>> Since time began eth* is where the kernel automatically picked iface
>> names from. If you want to assign your own names go for some other
>> namespace, or be prepared to
Hi,
On Thu, Sep 10, 2015 at 10:10 AM, Michael Biebl wrote:
> reading https://wiki.gnome.org/Projects/GnomeCommon/Migration, it says
> that intltool is practically dead and one should use gettext directly.
>
> Do we still need intltool in systemd? Does gettext have support for
> translating Policy
Guys let's try to be constructive here...
This time it shouldn't be too painful for downstreams since the revert
was the last patch to the man subtree so just a git revert of that
should get your trees to the state you need to get v221 packages for
Debian and Ubuntu. In that sense, I think we're s
On Thu, Jun 18, 2015 at 11:54 AM, Lennart Poettering
wrote:
> On Tue, 02.06.15 12:18, Chris Morgan (chmor...@gmail.com) wrote:
>> systemd 216 here on an embedded arm system, 1ghz with a load of 60% or
>> more. I enabled tab completion, because I really don't like to type,
>> and quickly found out
On Thu, Jun 11, 2015 at 12:31 PM, Ronny Chevalier
wrote:
> On Thu, Jun 11, 2015 at 6:31 PM, Filipe Brandenburger
> wrote:
>> Another downside of adding comments to the commits is that e-mail
>> notifications are not sent for them (I just noticed that while lurking
>> on
On Wed, Jun 10, 2015 at 9:52 AM, Lennart Poettering
wrote:
> On Wed, 10.06.15 08:25, Filipe Brandenburger (filbran...@google.com) wrote:
>> On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy wrote:
>> > FWIW it only loses the comments if people comment on individual
>> > co
On Wed, Jun 10, 2015 at 12:23 AM, Jan Synáček wrote:
> See https://github.com/systemd/systemd/pull/5. There are multiple
> references to this PR that say " referenced this pull request from
> a commit in ", which is hilarious, as those clearly are not
> references to this PR. Their commit messages
On Wed, Jun 10, 2015 at 5:04 AM, Martin Jansa wrote:
> If you want good review tool, why not use gerrit?
+1 for Gerrit as a code review tool.
It's not perfect, but from all of them that I've used it seems to get
the most right:
- Review *commits* and not PRs (tends to drives up the quality of
in
On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy wrote:
>>> Instead, just reuse the same PR and use `git push -f` to ship new
>>> versions of the commits to the same branch... Yes it's awful but
>>> unfortunately that's how GitHub works...
>>
>> Yeah, it is awful, and loses all the comments, as well
On Tue, Jun 9, 2015 at 2:37 PM, Lennart Poettering
wrote:
> On Tue, 09.06.15 13:04, Filipe Brandenburger (filbran...@google.com) wrote:
>> On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering
>> wrote:
>> > [...] so we comment and ask for a new PR, and close the old on
On Tue, Jun 9, 2015 at 12:59 PM, Lennart Poettering
wrote:
> [...] so we comment and ask for a new PR, and close the old one.
See my previous comment, I think this "cure" is worse than the "disease" :-)
Instead, just reuse the same PR and use `git push -f` to ship new
versions of the commits to
Moving from #88 to this thread:
On Tue, Jun 9, 2015 at 12:41 PM, Lennart Poettering
wrote:
> So I think updating the PR (by force-pushing) is really nasty, and we
> shouldn't do it. Instead, please push a new PR, mention that it
> obsoletes the old one. (of course, I wished that github would know
Hi,
This commit was not moved to GitHub, it's under review here:
https://github.com/systemd/systemd/pull/44
On Sun, May 31, 2015 at 12:06 AM, Andrei Borzenkov wrote:
> В Sat, 30 May 2015 23:29:29 -0700 Filipe Brandenburger
> пишет:
>> - Handling a \; is ugly, it
I don't think it should be there...
https://github.com/systemd/systemd/branches
Otherwise everyone doing "git fetch" will get a copy of this branch...
I think the main git should only expose a single "master" branch.
Would you care to delete it and be careful not to push extraneous
branches to
Hi,
On Tue, Jun 2, 2015 at 7:58 AM, Dimitri John Ledkov
wrote:
> And I think this is _good_, because the submitter's commit ids will be
> preserved (together with the signed gpg commits) [...]
This, signed gpg commits, is actually the first reasonable argument I
see for merging and not rebasing
Pull Request created:
https://github.com/systemd/systemd/pull/44
If you could test it and confirm your "sudo" case with \073 works now,
and your regexp case isn't broken, I'd appreciate it.
Cheers,
Filipe
On Tue, Jun 2, 2015 at 2:53 PM, Filipe Brandenburger
wrote:
>
Hi Michael,
On Tue, Jun 2, 2015 at 2:50 PM, Michael Biebl wrote:
> 2015-06-02 12:55 GMT+02:00 Daniel Mack :
>> So, my primary motivation was to fix the obvious regression at hand
>> first, but I agree the actual problem goes deeper.
>
> Looks like even with this patch applied, we have regressions
On Tue, Jun 2, 2015 at 7:24 AM, Daniel Mack wrote:
>> I could create a PR in systemd-devs GitHub if you'd like, otherwise
>> feel free to just push it straight upstream if you prefer.
>
> Nope, let's try to get used to the new workflow. Just create the PR :)
Good call... we were actually missing
On Tue, Jun 2, 2015 at 3:55 AM, Daniel Mack wrote:
> The problem here is that cunescape() wasn't as strict in the past as it
> should have been, and now there are unit files in the wild which contain
> escape sequences that slip through the C unescaping mechanism.
>
> So, my primary motivation was
Hi Daniel,
On Tue, Jun 2, 2015 at 3:04 AM, Daniel Mack wrote:
> On 06/02/2015 11:25 AM, Martin Pitt wrote:
>> FTR, this works fine here, using --with-rootprefix= (to avoid the
>> extra slashes). This spawned a long thread and multiple followup
>> patches, and TBH I lost track which patches got pr
Hi,
Not sure I agree with the commit below. (In particular as I'm looking
at converting this code into using unquote_first_word.)
On Mon, Jun 1, 2015 at 9:10 AM, Daniel Mack
wrote:
> commit 22874a348fb1540c1a2b7907748fc57c9756a7ed
> Author: Daniel Mack
> Date: Mon Jun 1 17:49:04 2015 +0200
>
Hi,
On Sun, May 31, 2015 at 12:06 AM, Andrei Borzenkov wrote:
> В Sat, 30 May 2015 23:29:29 -0700 Filipe Brandenburger
> пишет:
>> - Handling a \; is ugly, it looks like a hack... unquote_first_word is
>> not equipped to recognize that sequence, so I had
This is an attempt to convert it from using FOREACH_WORD_QUOTED into a
loop using unquote_first_word repeatedly.
Additionally, we're looping through the arguments only once and using
_cleanup_ functions to manage objects owned by this function.
Some notes:
- There is some difference in how unquot
Get rid of code duplication here.
---
Some alternatives I considered:
1) Keep a separate bool escape and set it when we see a backslash, still
keeping state set to VALUE or SINGLE_QUOTE or DOUBLE_QUOTE.
2) Create the enum so that ESCAPE has a bit value like 0x100 or similar, so
that we can
From: Michael Biebl
Strip trailing slashes from options such as --with-rootprefix, so that building
with rootprefix="/" results in paths like "/lib" instead of "//lib".
Also handle paths such as "/usr/" gracefully.
Use m4/ax_normalize_path.m4 from the autoconf-archive project, which is now
incl
Hi,
On Fri, May 29, 2015 at 6:04 PM, Michael Biebl wrote:
> I we assume, autconf-archive is installed, the resulting patch would
> look like the attached diff.
> For convenience sake, we could also ship a copy of
> /usr/share/aclocal/ax_normalize_path.m4 in our m4/ directory.
Yep... indeed autoc
On Fri, May 29, 2015 at 5:21 PM, Michael Biebl wrote:
> autoconf already strips trailing slashes for all default directory
> variables [1].
How does it handle --prefix=/ though? Does it turn it into an empty string?
> I think we should do the same for *all* our custom --with-$foo-dir
> variables
Hi Daniel,
I haven't tested it, but I do have a few comments.
First, why not use "rootlibdir" instead of "rootprefixlibdir"? There's
already similar "rootbindir" and "rootlibexecdir" defined there, so I
think we could stick to the same convention.
From a few lines down in Makefile.am:
# And t
Hi,
I was thinking about this one recently...
I really think the "correct" solution is for man/custom-entities.ent
to be generated by configure from a man/custom-entities.ent.in
template instead. I haven't really checked if that's viable though, if
configure knows about every variable it will nee
On Thu, May 28, 2015 at 10:44 AM, Michael Biebl wrote:
> 2015-05-28 19:41 GMT+02:00 Martin Pitt :
>> \o/ Many thanks Filipe, that's great! Biggest patch gone :)
>
> A huge thanks from me as well to everyone involved!
Lennart: Thanks for applying it.
Martin and Michael: You're welcome, glad to he
Hi,
On Wed, May 27, 2015 at 3:40 PM, Charles Duffy wrote:
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wformat-nonliteral"
> +time_len = strftime(buf, l, arg_time_format, curr_time);
> +if (time_len <= 0)
> +return;
> +#pragma GCC diagnostic p
On Wed, May 27, 2015 at 10:08 AM, Tom Gundersen wrote:
> This should be fixed by 86c3bece38bcf55da6387d20c6f01da9ad0284dc.
> Thanks for the help in debugging this, and sorry for the
> inconvenience.
And I can confirm the timeout is gone.
Thanks for fixing it quickly Tom! Glad to help you isolate
Hi Tom,
On Wed, May 27, 2015 at 8:45 AM, Tom Gundersen wrote:
> It appears a few people see this, but I was not able to reproduce. If
> anyone could reproduce with this patch applied [0], it would be most
> helpful (and post the output of "journalctl -b -u systemd-udevd").
Done.
Console output
Hi,
On Wed, May 27, 2015 at 6:04 AM, Lennart Poettering
wrote:
> Hmm, any chance we can somehow define those entities without having to
> add
>
>
> %entities;
> ]>
>
> To each file? Can't we tell xsltproc about this via some command line
> switch or so?
I don't think that's possible, in part
Export the MOUNT_PATH and UMOUNT_PATH variables as XML entities and use them in
the systemctl.1 manpage instead of hardcoding the path in /usr/bin.
Tested:
- Ran ./configure ac_cv_path_MOUNT_PATH=/bin/mount (same for umount) and
rebuilt the manpages, confirmed that the correct path was in man/sy
d like to think a little further on how to
solve that particular one...
I hope that's helpful!
Cheers,
Filipe
Filipe Brandenburger (2):
man: generate configured paths in manpages
man: use configured path for mount and umount binaries in manpages
Makefile.am
Hi,
On Sun, May 24, 2015 at 8:41 PM, cee1 wrote:
> I tried ureadahead, but got following error:
>
> """write(2, "ureadahead: Error while tracing:"..., 59ureadahead: Error
> while tracing: No such file or directory"""
>
> Needs an out-of-tree kernel patch?
Yes, ureadahead needs an out-of-tree ker
Hi Tom,
On Sun, May 24, 2015 at 6:30 AM, Tom Gundersen wrote:
> On Sun, May 24, 2015 at 11:40 AM, Mantas Mikulėnas wrote:
>> So, udev v220 crashes in my initramfs with the following message:
>>
>>> starting version v220
>>> Assertion 'manager->pid == getpid()' failed at src/udev/udevd.c:568,
>>>
Hi,
On Mon, May 18, 2015 at 7:26 AM, Krzysztof Opasiak
wrote:
> Matching between fds and list of expected paths is done in n^2
I don't think that's the case, because you can just stat() all the
names and fstat() all the fds, then sort both lists on inode numbers
and then traverse both in order m
Ping?
distcheck is still failing due to the lack of reference to this header
file in Makefile.am
Cheers,
Filipe
On Mon, Dec 29, 2014 at 3:22 PM, Filipe Brandenburger
wrote:
> Commit 003dffde2c1b93 ("machined: Move image discovery logic into src/shared,
> so that we can make use
Commit 003dffde2c1b93 ("machined: Move image discovery logic into src/shared,
so that we can make use of it from nspawn") moved some definitions from
machine.h to a new machine-dbus.h, but did not include it in Makefile.am
Tested that `make distcheck` works after this fix.
---
Makefile.am | 1 +
Move units/machines.target from nodist_systemunit_DATA to dist_systemunit_DATA,
since it's not a generated file. Otherwise, `make clean` would remove the
committed copy of the file.
Tested that `./autogen.sh c` will not remove it and that `make distcheck` works
after this fix.
---
Makefile.am | 2
The file was moved from src/libsystemd-network to src/systemd in commit
7a6f1457462840 ("sd-lldp: minor header cleanup").
This fixes "make distcheck".
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 4173147..8446469 100644
--- a/
The new polkit file was introduced in commit d04c1fb8e21560 ("machined:
introduce polkit for OpenLogin() call").
---
po/POTFILES.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 2829c87..344c307 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -1,5 +1
The new test-cap-list introduced in commit 2822da4fb7f891 uses the included
table of capabilities. However, it uses cap_last_cap() which probes the kernel
for the last available capability. On an older kernel (e.g. 3.10 from RHEL 7)
that causes the test to fail with the following message:
Asse
Hi,
On Tue, Dec 23, 2014 at 10:15 AM, Lennart Poettering
wrote:
> commit 3c70e3bb022f0de3317f3600c9366a2f4597339e
> Author: Lennart Poettering
> Date: Tue Dec 23 18:36:04 2014 +0100
>
> core: rearrange code so that libsystemd/sd-bus/ does not include header
> files from core
>
> Stuff
This directory is not used by systemd.
Tested by running a full build, running `make install` and comparing the file
list in the target trees and making sure that `make distcheck` still works.
---
configure.ac | 7 ---
1 file changed, 7 deletions(-)
diff --git a/configure.ac b/configure.ac
i
Do not use the dbus-1.pc pkgconfig settings to determine dbus directories. Use
directories relative to ${sysconfdir} and ${datadir} instead.
This approach was suggested by Simon McVittie in:
http://lists.freedesktop.org/archives/systemd-devel/2014-October/024388.html
Tested by building and instal
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 1b5d60f..078fd9a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -207,6 +207,7 @@
/test-libudev-sym*
/test-list
/test-unaligned
+/test-lldp
/test-locale-util
/test-local-addresses
/test-log
--
1.8.3
On Tue, Dec 23, 2014 at 5:23 AM, David Herrmann wrote:
> I cannot find these patches on systemd-devel@lists.freedesktop.org.
> This might be due to fdo mail-server issues, or me just being
> incapable of searching through my emails... Anyway, would you mind
> resending those?
Yeah, it seems I was
They do not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by bus-objects.c comes from imported through
"missing.h". The "missing.h" header is imported through "util.h" which gets
imported in "bus-util.h".
Tested that everything builds cleanly after this change.
---
sr
It does not use any functions from libcap directly. The CAP_* constants in use
through this file come from "missing.h" which will import
and complement it with CAP_* constants not defined by the current kernel
headers.
Add an explicit import of our "capability.h" since it does use the function
ca
They do not use any functions from libcap directly. The CAP_* constants in use
through these files come from "missing.h" which will import
and complement it with CAP_* constants not defined by the current kernel
headers. The "missing.h" header is imported through "util.h" which gets
imported in "l
They do not use any functions from libcap directly. The CAP_KILL constant in
use by these files comes from imported through
"missing.h".
Tested that "systemd-machined" builds cleanly and works after this change.
---
src/machine/machine-dbus.c | 1 -
src/machine/machined-dbus.c | 1 -
2 files ch
It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by this file comes from imported through
"missing.h".
Tested that "systemd-localed" builds cleanly and works after this change.
---
src/locale/localed.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/l
It does not use any functions or constants from libcap directly.
Tested that "pam_systemd.la" builds cleanly and works after this change.
---
src/login/pam_systemd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c
index 111e2b7..d5b29c8 100644
It does not use any functions from libcap directly. The CAP_SYS_TIME constant
in use by this file comes from imported through
"missing.h".
Tested that "systemd-timedated" builds cleanly and works after this change.
---
src/timedate/timedated.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/
It does not use any functions from libcap directly. The CAP_SYS_ADMIN constant
in use by this file comes from imported through
"missing.h".
Tested that "systemd-hostnamed" builds cleanly and works after this change.
---
src/hostname/hostnamed.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
It does not use any functions from libcap directly. The CAP_MKNOD constant in
use by this file comes from imported through "missing.h".
Tested that "systemd-tmpfiles" builds cleanly and works after this change.
---
src/tmpfiles/tmpfiles.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/tm
information used is the CAP_* constants which are actually
coming from (kernel headers) or from "missing.h" (for
compatibility with older kernel headers.)
Filipe Brandenburger (9):
capabilities: remove spurious include of from nspawn.c
capabilities: remove spurious include of f
Hi,
On Tue, Dec 23, 2014 at 6:43 AM, Lennart Poettering
wrote:
> On Mon, 22.12.14 11:57, Filipe Brandenburger (filbran...@google.com) wrote:
>> Ping?
>
> I got none of these emails, and they are neither shown in the mailing
> list archives. There must be something wrong in
In test_raw_clone, make sure the cloned thread calls _exit() and in the parent
thread call waitpid(..., __WCLONE) to wait for the child thread to terminate,
otherwise there is a race condition where the child thread will log to the
console after the test process has already exited and the assertion
The asserts used in the tests should never be allowed to be optimized away.
---
src/test/test-util.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/test-util.c b/src/test/test-util.c
index 222af9a..57fd19b 100644
--- a/src/test/test-util.c
+++ b/src/test/test-
Ping?
On Fri, Dec 12, 2014 at 10:47 AM, Filipe Brandenburger
wrote:
> The new test-cap-list introduced in commit 2822da4fb7f891 uses the included
> table of capabilities. However, it uses cap_last_cap() which probes the kernel
> for the last available capability. On an older kernel (
Ping?
On Thu, Dec 18, 2014 at 11:24 AM, Filipe Brandenburger
wrote:
> In test_raw_clone, make sure the cloned thread calls _exit() and in the parent
> thread call waitpid(..., __WCLONE) to wait for the child thread to terminate,
> otherwise there is a race condition where the child th
Ping?
On Fri, Dec 19, 2014 at 9:45 AM, Filipe Brandenburger
wrote:
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index 1b5d60f..078fd9a 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -207,6 +207,7 @@
> /t
capabilities and the constants come from kernel headers (or
missing.h), it makes sense to have more of our own routines...
Cheers,
Filipe
On Tue, Dec 16, 2014 at 5:18 PM, Filipe Brandenburger
wrote:
> This is a first cleanup step towards removing the dependency on libcap.
>
> The idea of remov
#x27;d say we start
with these and go from here.)
Cheers,
Filipe
On Fri, Dec 12, 2014 at 4:55 PM, Filipe Brandenburger
wrote:
> Do not use the dbus-1.pc pkgconfig settings to determine dbus directories. Use
> directories relative to ${sysconfdir} and ${datadir} instead.
>
> This app
Hi,
On Sat, Dec 20, 2014 at 8:19 AM, Dave Reisner wrote:
> ---
> Makefile.am | 9 +-
> src/test/test-verbs.c | 78
> +++
> 2 files changed, 86 insertions(+), 1 deletion(-)
> create mode 100644 src/test/test-verbs.c
>
> diff --git a
On Fri, Dec 19, 2014 at 8:30 AM, Michal Schmidt wrote:
> On 12/19/2014 04:49 PM, Filipe Brandenburger wrote:
>> This seems to have fixed "test-journal-stream" but
>> "test-journal-interleaving" is still broken for me, it fails with:
>>
>> NUMBE
On Fri, Dec 19, 2014 at 8:31 AM, Michael Biebl wrote:
> 2014-12-19 17:10 GMT+01:00 Filipe Brandenburger :
>> On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl wrote:
>>> This also removed the HAVE_PYTHON section from Makefile-man.am. Why it
>>> did that is unclear to me
On Fri, Dec 19, 2014 at 6:32 AM, Michael Biebl wrote:
> This also removed the HAVE_PYTHON section from Makefile-man.am. Why it
> did that is unclear to me.
This happened to me before and when it did it was because ./configure
didn't detect a working Python, so "make update-man-list" didn't use
on
Hi,
This seems to have fixed "test-journal-stream" but
"test-journal-interleaving" is still broken for me, it fails with:
NUMBER=1
NUMBER=2
Assertion 'r == 1' failed at
src/journal/test-journal-interleaving.c:101, function
test_check_numbers_down(). Aborting.
Aborted (core dumped)
Can you please
On Thu, Dec 18, 2014 at 4:58 PM, Filipe Brandenburger
wrote:
> But this does not work on trunk head, even after adapting it, the
> tests start to fail in a different location, probably because of the
> changes that come after it, so I think we'll need this and further
> changes
On Thu, Dec 18, 2014 at 4:39 PM, Filipe Brandenburger
wrote:
> Not sure what's the correct solution, maybe journal_file_save_location
> needs to happen only in real_journal_next() outside the
> ORDERED_HASHMAP_FOREACH loop? I'll try that and report if I find
> something th
at and report if I find
something that seems to solve this problem...
Cheers,
Filipe
On Thu, Dec 18, 2014 at 2:34 PM, Filipe Brandenburger
wrote:
> Hi,
>
> Commit 6573ef05a3cbe1 ("journal: keep per-JournalFile location info
> during iteration") breaks tests "test-jou
Hi,
Commit 6573ef05a3cbe1 ("journal: keep per-JournalFile location info
during iteration") breaks tests "test-journal-stream" and
"test-journal-interleaving".
It seems that the logic of overriding f->current_offset in
journal_file_save_location has other unintended side effects, checking
out that
On Wed, Dec 10, 2014 at 4:11 AM, Lennart Poettering
wrote:
> In fact, I think we should drop the
> libcap dependency altogether and just do the two syscalls it offers to
> us natively in systemd code. Neither is libcap a particularly nice
> library, nor is the stuff it does particularly complex, h
Otherwise it gets optimized out when CPPFLAGS='-DNDEBUG' is used.
Tested:
- make check TESTS='test-util' CPPFLAGS='-DNDEBUG'
---
src/test/test-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/test-util.c b/src/test/test-util.c
index 34d5f2ed7d23..4d9b28f9c8e7 10
Otherwise the test fails when built with CPPFLAGS='-DNDEBUG' which disables
assertions.
Tested:
- make check TESTS='test-compress' CPPFLAGS='-DNDEBUG'
---
src/journal/test-compress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/journal/test-compress.c b/src/journal/
Otherwise they get optimized out when CPPFLAGS='-DNDEBUG' is used, and that
causes the tests to fail.
Tested:
- make check TESTS='test-path-util' CPPFLAGS='-DNDEBUG'
---
src/test/test-path-util.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/
+Zbigniew who committed the original patch.
On Fri, Jul 4, 2014 at 11:43 AM, Mike Gilbert wrote:
> This reverts commit 0c26bfc3d21fdb3963f1248c237e2f1a33b5566d.
>
> src/core/org.freedesktop.systemd1.policy.in.in depends on values which
> are specified at configure time, so we cannot ship the corr
---
src/network/networkd-network-gperf.gperf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/network/networkd-network-gperf.gperf
b/src/network/networkd-network-gperf.gperf
index 3aaae4c94bff..ce9047cd06c4 100644
--- a/src/network/networkd-network-gperf.gperf
+++ b/src
On Mon, Jun 30, 2014 at 2:38 PM, Lennart Poettering
wrote:
>> Maybe it should try both and figure out which one of them exists?
>>
>> Or default to $libdir and allow an override for the cross-distro cases.
>
> Hmm, I am tempted to say that we should add a logic to this that just
> checks the few d
On Thu, Jun 26, 2014 at 4:54 PM, David Härdeman wrote:
> Add binary string handling functions and extend the password agent
> protocol to support binary strings (using "=" as a string prefix
> instead of "+").
Please also add /test-bstrv to .gitignore.
In particular, disable intltool when --disable-nls is passed to configure.
Tested: Built it on a host without intltool or gettext.
$ ./configure --disable-nls --disable-polkit
$ make
---
configure.ac | 10 ++
1 file changed, 10 insertions(+)
diff --git a/configure.ac b/configure.ac
i
1 - 100 of 117 matches
Mail list logo
