...@poettering.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
units/sys-kernel-debug.mount | 1 +
1 file changed, 1 insertion(+)
diff --git a/units/sys-kernel-debug.mount b/units/sys-kernel-debug.mount
index 5369728..f90bfc1 100644
--- a/units/sys-kernel-debug.mount
+++ b/units/sys-kernel
Lennart Poettering wrote:
So please, ask the UML guys to somehow cleanup their VT mess. It's their
broken code, and their job to fix it.
The question is how? Just tell me what to do, and I'll do it myself.
I can understand if you are disappointed by this, but please try to see
it from out
Ramkumar Ramachandra wrote:
Got it. So, it should have provided /dev/tum* (or something) instead
of /dev/tty*. But what can we do about it now? I certainly cannot
remove /dev/tty* and murder the users.
Wait, I think I have an idea to preserve backward compatibility. I'll
remove the /dev
Kay Sievers wrote:
No, sorry, the same rule applies to C code as it does to unit files:
We do not collect specific exceptions for broken hacks in exotic
tools. Means: there will be _zero_ matches on UML strings in systemd
Um, then why do we have a detect-virt at all? A quick grep tells me
Kay Sievers wrote:
Where do you see any specific exceptions for broken hacks?
We surely support different forms of virtualizations, and support
reasonable custom behavior. But we do not support providing a tty0 and
have no working VT. It's just madness we don't want to see anywhere,
and we
Kay Sievers wrote:
You meant to provide a patch against git, not your earlier patches?
Ofcourse; I was just asking if this is what you meant before
submitting another iteration for inclusion.
___
systemd-devel mailing list
Kay Sievers wrote:
[...]
Fwiw, I more-or-less agree with the principle don't accumulate
specific workarounds when it's not scalable or maintainable.
Hacks like the UML tty0 hack is just a too broken idea, to
get any support or an exception in a generic tool like systemd.
I think of it as
Kay Sievers wrote:
I would rather see vconsole to detect the mess and silently give up,
instead of adding exotic options for really weird faked and wrong tty0
setups.
um Linux lacks VT102 emulation, and this is a documented fact.
Therefore, your code:
unsigned char data[1];
Kay Sievers wrote:
It's not about failing it, that would be ugly, sure. Vconsole can just
give up and return 0 if it finds a tt0 that actually isn't a tty0.
Hm, how can I tell if vconsole-setup actually did something or not
then? Doesn't it matter for curses apps, which require VT102
emulation
Kay Sievers wrote:
Oh, I meant turning is_vconsole() into returning success when it is
called for a tty0 that in fact doesn't work like tty0. :)
We might as well remove is_vconsole() then. Does it make sense to
execute the rest of the code in vconsole-setup.c (fontmap, utf8 etc.)
on a non-VT
Kay Sievers wrote:
such work-arounds need to
be a generic as possible
I disagree with this. I specifically asked Lennart about a /dev/tty0
being created by hand using mknod earlier: his answer was that systemd
does not support it. In the most generic scenario, you cannot rely on
the sanity of
Kay Sievers wrote:
If you're so particular about keeping primary unit files clean, may
I suggest moving the exception code to vconsole-setup.c?
That's what I meant, yeah, sorry for the confusion.
Cool, I understand that your desire to keep primary units clean: I'll
write a patch for this.
In
will indicate
that /dev/tty0 is not a virtual console.
Cc: Kay Sievers k...@vrfy.org
Cc: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl
Cc: Lennart Poettering lenn...@poettering.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
I didn't cut corners: I built it with abs, and tested it properly
Hi,
I noticed that my TERM is set to linux, even when I boot the
console-getty.service. Isn't it supposed to be console instead,
since VT emulation is not guaranteed? Should we explicitly pass the
term argument to agetty?
Thanks.
___
systemd-devel
Lennart Poettering wrote:
/dev/tty0 always points to the foreground VC tty. Are you saying UML
provides /dev/tty0 but not /dev/tty1, /dev/tty2, ...? I am pretty sure
that UML should be fixed to provide neither or both, evertyhing else is
broken.
Thanks for all the information. With some help
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
units/systemd-vconsole-setup.service.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/units/systemd-vconsole-setup.service.in
b/units/systemd-vconsole-setup.service.in
index 18faa63..3dc3153 100644
--- a/units/systemd-vconsole
Hi,
These are the finishing touches required to make User-Mode Linux work
out-of-the-box. Sorry it took so long: I had to build with abs and
test it for good.
Thanks again, for all the help.
Ramkumar Ramachandra (2):
getty-generator: run console shell for uml
vconsole-setup: setup negative
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
src/getty-generator/getty-generator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/getty-generator/getty-generator.c
b/src/getty-generator/getty-generator.c
index 4b7a60a..9c7ed1a 100644
--- a/src/getty
-9-ge5fd680 (...)
bogomips: 7007.43
So, grep for the string vendor_id\t: User Mode Linux\n in
/proc/cpuinfo, and say uml when asked.
Cc: Lennart Poettering lenn...@poettering.net
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
See arch/um/kernel/um_arch.c:75, where it writes
Ramkumar Ramachandra wrote:
It seems that UM does not have a proper tty system; I force
systemd to use the /dev/console by doing:
$ mv
/etc/systemd/system/getty.target.wants/{getty@tty1.service,getty@console.service}
Where should the exception for um linux go? When does the code
David Strauss wrote:
Would it be possible, for testing purposes, to generate a machine ID
on the fly if one is not present on disk?
Hard, as /etc/machine-id is hardcoded in
src/libsystemd-id128/sd-id128.c. I don't think it's worth the effort.
Ram
Zbigniew Jędrzejewski-Szmek wrote:
I started munging your patch to apply it, but on second thought it is
totally the wrong direction to take. The purpose of tests is to check
if systemd will function after installation. And as mentioned
elsewhere in the thread, journald will break badly, and
Hi Michael,
Michael Biebl wrote:
2012/12/2 Ramkumar Ramachandra artag...@gmail.com:
Hm, you have a point. On Debian, /etc/machine-id is created when
the systemd package is installed -- I'm not sure if it's in the source
code or if it's a custom Debian patch.
We run systemd-machine-id-setup
David Strauss wrote:
We could also move more tools outside the main systemd package and
into PIP.
Er, you want to move some essential systemd scripts out from the source tree?
Ram
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
Michael Biebl wrote:
2012/11/30 Ramkumar Ramachandra artag...@gmail.com:
Execute python using /usr/bin/env python instead of hard-coding the
I'm not really a fan of using /usr/bin/env, as you can pick up a
random python version depending on how your PATH is setup.
Besides, you need to spawn
David Strauss wrote:
Please fix the spelling of present.
The number -128, if used, should get #define'd instead of being a magic
number dropped in a bunch of places.
Thanks. Will fix in the next iteration.
It's not good to mask all errors opening the machine-id with the -128
response code.
Hi,
I booted up my Debian machine with systemd, and removed systemd after
bootup. Now it refuses to halt with:
init: timeout opening/writing control channel /dev/initctl
I don't know if it's systemd's fault or the Debian package manager's
fault- investigating.
Ram
Ramkumar Ramachandra wrote:
I booted up my Debian machine with systemd, and removed systemd after
bootup. Now it refuses to halt with:
init: timeout opening/writing control channel /dev/initctl
Correction: I can't halt a Debian systemd machine at all (even when
the package isn't removed
The following tests fail if /etc/machine-id is not present:
$ ./test-id128
random: a08ea8ed34594d4bbd953dd182ec86f9
Assertion 'sd_id128_get_machine(id) == 0' failed at
src/test/test-id128.c:41, function main(). Aborting.
[1]8017 abort (core dumped) ./test-id128
$ ./test-journal
Ramachandra artag...@gmail.com
---
Ramkumar Ramachandra wrote:
$ ./test-id128
random: a08ea8ed34594d4bbd953dd182ec86f9
Assertion 'sd_id128_get_machine(id) == 0' failed at
src/test/test-id128.c:41, function main(). Aborting.
[1]8017 abort (core dumped) ./test-id128
Okay, this test
Ramkumar Ramachandra wrote:
$ ./test-journal
Assertion 'journal_file_open(test.journal, O_RDWR|O_CREAT, 0666,
true, true, NULL, NULL, NULL, f) == 0' failed at
src/journal/test-journal.c:46, function main(). Aborting.
[1]8059 abort (core dumped) ./test-journal
$ ./test-journal-stream
Kay Sievers wrote:
On Fri, Nov 30, 2012 at 1:28 PM, Zbigniew Jędrzejewski-Szmek
zbys...@in.waw.pl wrote:
It'll be created by systemd during init if not present. So we _do_ a
kind of around.
Where is the creation code? The systemd-machine-id-setup binary does
_not_ create it, and my patch
Kay Sievers wrote:
It is mandatory for systemd systems. We just require it to be around,
and do not work around it.
Specifically, which package installs /etc/machine-id? Is it a build
dependency for systemd?
Ram
___
systemd-devel mailing list
. Treat this as a special case and
skip the dependent tests instead of failing them.
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
Ramkumar Ramachandra wrote:
Kay Sievers wrote:
On Fri, Nov 30, 2012 at 1:28 PM, Zbigniew Jędrzejewski-Szmek
zbys...@in.waw.pl wrote:
I haven't
Kay Sievers wrote:
On Thu, Nov 29, 2012 at 8:06 PM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Update the license with the copy found on
http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt
Applied.
Thanks. I noticed that you dropped the signoff on all three patches.
Should I send
. Treat this as a special case and
skip the dependent tests instead of failing them.
---
Zbigniew Jędrzejewski-Szmek wrote:
On Fri, Nov 30, 2012 at 06:47:42PM +0530, Ramkumar Ramachandra wrote:
The following tests fail if /etc/machine-id is not present:
+if (journal_file_open
The following tests fail if /etc/machine-id is not present:
$ ./test-id128
random: a08ea8ed34594d4bbd953dd182ec86f9
Assertion 'sd_id128_get_machine(id) == 0' failed at
src/test/test-id128.c:41, function main(). Aborting.
[1]8017 abort (core dumped) ./test-id128
$ ./test-journal
Hi,
The following tests fail. Is it just me, or does this indicate work
in progress?
$ ./test-id128
random: a08ea8ed34594d4bbd953dd182ec86f9
Assertion 'sd_id128_get_machine(id) == 0' failed at
src/test/test-id128.c:41, function main(). Aborting.
[1]8017 abort (core dumped) ./test-id128
$
Hi,
This evening, I was curious to know whether I could install systemd on
my Ubuntu laptop. Incidentally, I got a chance to look at the code
and fixed up a few minor things. Hope it's useful.
Ram
Ramkumar Ramachandra (3):
LICENSE.LGPL2.1: update license
DISTRO_PORTING: correct location
Update the license with the copy found on
http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
LICENSE.LGPL2.1 | 81 +-
1 files changed, 38 insertions(+), 43 deletions(-)
diff --git
f33d3ec1 (move more common files to shared/ and add them to shared.la,
2012-04-12) moved src/hostname-setup.c to src/shared/hostname-setup.c,
but did not update DISTRO_PORTING accordingly. Fix this.
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
DISTRO_PORTING |6 +++---
1 files
Fix some minor spelling mistakes in the manpages.
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
man/daemon.xml |2 +-
man/journalctl.xml |2 +-
man/journald.conf.xml |4 ++--
man/kernel-command-line.xml |2 +-
4 files changed, 5 insertions
Zbigniew Jędrzejewski-Szmek wrote:
On Wed, Dec 14, 2011 at 11:19:13PM +0530, Ramkumar Ramachandra wrote:
Hi,
On Dec 2, 2011, Ramkumar Ramachandra wrote:
Ramkumar Ramachandra (3):
Debian: update m4 scripts in units/
completion: fix typo in accessing array index
completion: add ZSH
Teach systemd about the location of the hostname, distribution version
file, and tweak the various m4 scripts in units/.
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
Started using systemd on my Debian machine yesterday- here's a quick
patch for starters.
Thanks for reading
Hi Tollef,
Tollef Fog Heen wrote:
| diff --git a/src/hostname-setup.c b/src/hostname-setup.c
| index 2c2f10c..918525d 100644
| --- a/src/hostname-setup.c
| +++ b/src/hostname-setup.c
| @@ -32,6 +32,8 @@
[...]
Not needed, the top of read_hostname from the same file.
and
| diff --git
Ramkumar Ramachandra (3):
Debian: update m4 scripts in units/
completion: fix typo in accessing array index
completion: add ZSH support
src/systemd-bash-completion.sh | 54 ---
units/console-shell.service.m4 |3 ++
units/getty@.service.m4|3
Teach the console, getty, and serial m4 scripts about Debian.
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
units/console-shell.service.m4 |3 +++
units/getty@.service.m4|3 +++
units/serial-getty@.service.m4 |3 +++
3 files changed, 9 insertions(+), 0 deletions
Remove spurious '}'. This error went unnoticed so far because Bash
doesn't complain.
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
src/systemd-bash-completion.sh |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/systemd-bash-completion.sh b/src/systemd
48 matches
Mail list logo
