Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-09 Thread Christian Hesse
Mantas Mikulėnas on Wed, 2015/11/04 15:55: > On Wed, Nov 4, 2015 at 3:52 PM, Lennart Poettering > wrote: > > > On Wed, 04.11.15 15:54, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > > > 04.11.2015 00:04, Andrew Jones пишет: > > > >afaict, this

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-05 Thread poma
On 04.11.2015 14:52, Lennart Poettering wrote: > On Wed, 04.11.15 15:54, Andrei Borzenkov (arvidj...@gmail.com) wrote: > >> 04.11.2015 00:04, Andrew Jones пишет: >>> afaict, this will fix a regression caused by commit 75f86906c5. >>> Where we used to report "kvm" before that patch, without this

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-04 Thread Andrei Borzenkov
04.11.2015 00:04, Andrew Jones пишет: afaict, this will fix a regression caused by commit 75f86906c5. Where we used to report "kvm" before that patch, without this patch, we would only report "qemu". Are you sure it is regression? QEMU is a program (platform) while KVM is technology. Modern

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-04 Thread Andrew Jones
On Wed, Nov 04, 2015 at 03:54:45PM +0300, Andrei Borzenkov wrote: > 04.11.2015 00:04, Andrew Jones пишет: > >afaict, this will fix a regression caused by commit 75f86906c5. > >Where we used to report "kvm" before that patch, without this patch, > >we would only report "qemu". > > Are you sure it

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-04 Thread Lennart Poettering
On Wed, 04.11.15 15:54, Andrei Borzenkov (arvidj...@gmail.com) wrote: > 04.11.2015 00:04, Andrew Jones пишет: > >afaict, this will fix a regression caused by commit 75f86906c5. > >Where we used to report "kvm" before that patch, without this patch, > >we would only report "qemu". > > Are you

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-04 Thread Mantas Mikulėnas
On Wed, Nov 4, 2015 at 3:52 PM, Lennart Poettering wrote: > On Wed, 04.11.15 15:54, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > 04.11.2015 00:04, Andrew Jones пишет: > > >afaict, this will fix a regression caused by commit 75f86906c5. > > >Where we used to report

[systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-03 Thread Andrew Jones
afaict, this will fix a regression caused by commit 75f86906c5. Where we used to report "kvm" before that patch, without this patch, we would only report "qemu". The reason is because cpuid detection must come before dmi detection. Also, both can safely come before other xen heuristics. ---