Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-28 Thread Jóhann B. Guðmundsson
On 05/27/2015 04:00 PM, Lennart Poettering wrote: On Wed, 27.05.15 13:39, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 05/27/2015 01:07 PM, Martin Pitt wrote: Hello, as discussed in the get some distro patches upstream thread, this is the generalization for supporting different

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Lennart Poettering
On Wed, 27.05.15 15:07, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello, as discussed in the get some distro patches upstream thread, this is the generalization for supporting different chkconfig/update-rc.d/whatnot distro implementations of enabling init.d scripts, as per LSB

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Lennart Poettering
On Wed, 27.05.15 15:26, Martin Pitt (martin.p...@ubuntu.com) wrote: Lennart Poettering [2015-05-27 15:18 +0200]: If we do this, then I'd like to go all the way right-away: strip chkconfig support if we add support for the new hook. OK. +if (!isempty(arg_root)

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Jóhann B. Guðmundsson
On 05/27/2015 01:07 PM, Martin Pitt wrote: Hello, as discussed in the get some distro patches upstream thread, this is the generalization for supporting different chkconfig/update-rc.d/whatnot distro implementations of enabling init.d scripts, as per LSB specification. Is this not

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Lennart Poettering
On Wed, 27.05.15 15:30, Martin Pitt (martin.p...@ubuntu.com) wrote: Lennart Poettering [2015-05-27 15:18 +0200]: Maybe introducing a new tool for this that covers all options is the better idea. Let's call it /usr/lib/systemd/systemd-sysv-install or so, taking the --root= switch as

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
Lennart Poettering [2015-05-27 15:18 +0200]: Maybe introducing a new tool for this that covers all options is the better idea. Let's call it /usr/lib/systemd/systemd-sysv-install or so, taking the --root= switch as before, plus enable, disable, is-enabled plus one or more LSB init script

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Martin Pitt
Lennart Poettering [2015-05-27 15:18 +0200]: If we do this, then I'd like to go all the way right-away: strip chkconfig support if we add support for the new hook. OK. +if (!isempty(arg_root) !streq(arg_root, /)) { +log_error(Can not %s SysV init

Re: [systemd-devel] [PATCH 1/2] systemctl: Don't skip native units when enabling/disabling SysV init.d scripts

2015-05-27 Thread Lennart Poettering
On Wed, 27.05.15 13:39, Jóhann B. Guðmundsson (johan...@gmail.com) wrote: On 05/27/2015 01:07 PM, Martin Pitt wrote: Hello, as discussed in the get some distro patches upstream thread, this is the generalization for supporting different chkconfig/update-rc.d/whatnot distro