Re: [systemd-devel] [PATCH] Stop crashing on empty TXT

2014-11-30 Thread Lennart Poettering
On Tue, 18.11.14 14:52, Stanisław Pitucha (virap...@gmail.com) wrote: TXT records should have at least one character, so enforce this. Previously parser SIGSEGV'd on -txt.strings being NULL. --- src/resolve/resolved-dns-packet.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [systemd-devel] [PATCH] Stop crashing on empty TXT

2014-11-27 Thread David Herrmann
Hi On Tue, Nov 18, 2014 at 4:52 AM, Stanisław Pitucha virap...@gmail.com wrote: TXT records should have at least one character, so enforce this. Previously parser SIGSEGV'd on -txt.strings being NULL. Your patch fixes the issue, indeed. However, I didn't have the time to look this up in the

Re: [systemd-devel] [PATCH] Stop crashing on empty TXT

2014-11-27 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Nov 27, 2014 at 04:12:20PM +0100, David Herrmann wrote: Hi On Tue, Nov 18, 2014 at 4:52 AM, Stanisław Pitucha virap...@gmail.com wrote: TXT records should have at least one character, so enforce this. Previously parser SIGSEGV'd on -txt.strings being NULL. Your patch fixes the

Re: [systemd-devel] [PATCH] Stop crashing on empty TXT

2014-11-27 Thread David Herrmann
Hi On Thu, Nov 27, 2014 at 5:09 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Nov 27, 2014 at 04:12:20PM +0100, David Herrmann wrote: Hi On Tue, Nov 18, 2014 at 4:52 AM, Stanisław Pitucha virap...@gmail.com wrote: TXT records should have at least one character, so

Re: [systemd-devel] [PATCH] Stop crashing on empty TXT

2014-11-27 Thread Zbigniew Jędrzejewski-Szmek
On Thu, Nov 27, 2014 at 05:13:00PM +0100, David Herrmann wrote: Hi On Thu, Nov 27, 2014 at 5:09 PM, Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl wrote: On Thu, Nov 27, 2014 at 04:12:20PM +0100, David Herrmann wrote: Hi On Tue, Nov 18, 2014 at 4:52 AM, Stanisław Pitucha

[systemd-devel] [PATCH] Stop crashing on empty TXT

2014-11-17 Thread Stanisław Pitucha
TXT records should have at least one character, so enforce this. Previously parser SIGSEGV'd on -txt.strings being NULL. --- src/resolve/resolved-dns-packet.c | 4 1 file changed, 4 insertions(+) diff --git a/src/resolve/resolved-dns-packet.c b/src/resolve/resolved-dns-packet.c index