Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

On Fri, Nov 07, 2014 at 03:25:11PM +0100, Jan Synacek wrote: > Zbigniew Jędrzejewski-Szmek writes: > > On Fri, Nov 07, 2014 at 01:06:41PM +0100, Lennart Poettering wrote: > >> On Fri, 07.11.14 09:49, Jan Synacek (jsyna...@redhat.com) wrote: > >> > >> > Lennart Poettering writes: > >> > > On Thu,

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

On Fri, 07.11.14 14:24, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > On Fri, Nov 07, 2014 at 01:06:41PM +0100, Lennart Poettering wrote: > > On Fri, 07.11.14 09:49, Jan Synacek (jsyna...@redhat.com) wrote: > > > > > Lennart Poettering writes: > > > > On Thu, 06.11.14 10:49, Jan Synac

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

Lennart Poettering writes: > On Fri, 07.11.14 09:49, Jan Synacek (jsyna...@redhat.com) wrote: > >> Lennart Poettering writes: >> > On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: >> > >> >> I think that this patch might be a bit ineffective, as it calls >> >> unit_file_load() aga

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

Zbigniew Jędrzejewski-Szmek writes: > On Fri, Nov 07, 2014 at 01:06:41PM +0100, Lennart Poettering wrote: >> On Fri, 07.11.14 09:49, Jan Synacek (jsyna...@redhat.com) wrote: >> >> > Lennart Poettering writes: >> > > On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: >> > > >> > >>

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

On Fri, Nov 07, 2014 at 01:06:41PM +0100, Lennart Poettering wrote: > On Fri, 07.11.14 09:49, Jan Synacek (jsyna...@redhat.com) wrote: > > > Lennart Poettering writes: > > > On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: > > > > > >> I think that this patch might be a bit ineffe

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

On Fri, 07.11.14 09:49, Jan Synacek (jsyna...@redhat.com) wrote: > Lennart Poettering writes: > > On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: > > > >> I think that this patch might be a bit ineffective, as it calls > >> unit_file_load() again just to get an InstallContext. I

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

Lennart Poettering writes: > On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: > >> I think that this patch might be a bit ineffective, as it calls >> unit_file_load() again just to get an InstallContext. I wasn't sure >> how to get Also= targets in any other way. >> >> If such cha

Re: [systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

On Thu, 06.11.14 10:49, Jan Synacek (jsyna...@redhat.com) wrote: > I think that this patch might be a bit ineffective, as it calls > unit_file_load() again just to get an InstallContext. I wasn't sure > how to get Also= targets in any other way. > > If such change makes sense, this patch should p

[systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

If a unit contains only Also=, with no Alias= or WantedBy=, it shouldn't be reported as static. If any target unit specified in Also= is enabled or disabled, report this unit as enabled or disabled as well. https://bugzilla.redhat.com/show_bug.cgi?id=864298 --- src/shared/install.c | 23 +

[systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

I think that this patch might be a bit ineffective, as it calls unit_file_load() again just to get an InstallContext. I wasn't sure how to get Also= targets in any other way. If such change makes sense, this patch should probably be considered a preview rather than something to be committed right