Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-22 Thread Ramkumar Ramachandra
Lennart Poettering wrote: So please, ask the UML guys to somehow cleanup their VT mess. It's their broken code, and their job to fix it. The question is how? Just tell me what to do, and I'll do it myself. I can understand if you are disappointed by this, but please try to see it from out

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-22 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: Got it. So, it should have provided /dev/tum* (or something) instead of /dev/tty*. But what can we do about it now? I certainly cannot remove /dev/tty* and murder the users. Wait, I think I have an idea to preserve backward compatibility. I'll remove the

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-22 Thread Lennart Poettering
On Mon, 22.07.13 13:31, Ramkumar Ramachandra (artag...@gmail.com) wrote: Lennart Poettering wrote: They can call their ttys any way they want. If the call them /dev/tty[1..64] however, then they need to implement the VC interfaces. All of them. Also note that some hypervisors

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Kay Sievers
On Sat, Jul 20, 2013 at 7:03 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Kay Sievers wrote: If you're so particular about keeping primary unit files clean, may I suggest moving the exception code to vconsole-setup.c? That's what I meant, yeah, sorry for the confusion. Cool, I

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Ramkumar Ramachandra
Kay Sievers wrote: No, sorry, the same rule applies to C code as it does to unit files: We do not collect specific exceptions for broken hacks in exotic tools. Means: there will be _zero_ matches on UML strings in systemd Um, then why do we have a detect-virt at all? A quick grep tells me

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Kay Sievers
On Sun, Jul 21, 2013 at 2:44 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Kay Sievers wrote: No, sorry, the same rule applies to C code as it does to unit files: We do not collect specific exceptions for broken hacks in exotic tools. Means: there will be _zero_ matches on UML strings in

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Ramkumar Ramachandra
Kay Sievers wrote: Where do you see any specific exceptions for broken hacks? We surely support different forms of virtualizations, and support reasonable custom behavior. But we do not support providing a tty0 and have no working VT. It's just madness we don't want to see anywhere, and we

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Kay Sievers
On Sun, Jul 21, 2013 at 3:13 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Kay Sievers wrote: Where do you see any specific exceptions for broken hacks? We surely support different forms of virtualizations, and support reasonable custom behavior. But we do not support providing a tty0

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Ramkumar Ramachandra
Kay Sievers wrote: You meant to provide a patch against git, not your earlier patches? Ofcourse; I was just asking if this is what you meant before submitting another iteration for inclusion. ___ systemd-devel mailing list

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Ramkumar Ramachandra
Kay Sievers wrote: [...] Fwiw, I more-or-less agree with the principle don't accumulate specific workarounds when it's not scalable or maintainable. Hacks like the UML tty0 hack is just a too broken idea, to get any support or an exception in a generic tool like systemd. I think of it as

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Kay Sievers
On Sun, Jul 21, 2013 at 6:02 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Hacks like the UML tty0 hack is just a too broken idea, to get any support or an exception in a generic tool like systemd. I think of it as less of a hack, and more of a deficiency. Nobody stayed up all night

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Lennart Poettering
On Sat, 20.07.13 15:55, Ramkumar Ramachandra (artag...@gmail.com) wrote: Kay Sievers wrote: I would rather see vconsole to detect the mess and silently give up, instead of adding exotic options for really weird faked and wrong tty0 setups. um Linux lacks VT102 emulation, and this is a

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Lennart Poettering
On Sat, 20.07.13 15:55, Ramkumar Ramachandra (artag...@gmail.com) wrote: Kay Sievers wrote: I would rather see vconsole to detect the mess and silently give up, instead of adding exotic options for really weird faked and wrong tty0 setups. um Linux lacks VT102 emulation, and this is a

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-21 Thread Lennart Poettering
On Sun, 21.07.13 18:14, Ramkumar Ramachandra (artag...@gmail.com) wrote: Kay Sievers wrote: No, sorry, the same rule applies to C code as it does to unit files: We do not collect specific exceptions for broken hacks in exotic tools. Means: there will be _zero_ matches on UML strings in

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-20 Thread Kay Sievers
On Fri, Jul 19, 2013 at 9:36 PM, Ramkumar Ramachandra artag...@gmail.com wrote: User-Mode Linux does not do VT102 emulation, and $ vconsole-setup /dev/tty0 will always fail on it. In order to prevent vconsole-setup.service from always failing, disable it when uml is detected.

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-20 Thread Ramkumar Ramachandra
Kay Sievers wrote: I would rather see vconsole to detect the mess and silently give up, instead of adding exotic options for really weird faked and wrong tty0 setups. um Linux lacks VT102 emulation, and this is a documented fact. Therefore, your code: unsigned char data[1];

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-20 Thread Kay Sievers
On Sat, Jul 20, 2013 at 12:25 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Kay Sievers wrote: I would rather see vconsole to detect the mess and silently give up, instead of adding exotic options for really weird faked and wrong tty0 setups. um Linux lacks VT102 emulation, and this is

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-20 Thread Ramkumar Ramachandra
Kay Sievers wrote: It's not about failing it, that would be ugly, sure. Vconsole can just give up and return 0 if it finds a tt0 that actually isn't a tty0. Hm, how can I tell if vconsole-setup actually did something or not then? Doesn't it matter for curses apps, which require VT102 emulation

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-20 Thread Kay Sievers
On Sat, Jul 20, 2013 at 12:38 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Kay Sievers wrote: It's not about failing it, that would be ugly, sure. Vconsole can just give up and return 0 if it finds a tt0 that actually isn't a tty0. Hm, how can I tell if vconsole-setup actually did

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-20 Thread Ramkumar Ramachandra
Kay Sievers wrote: Oh, I meant turning is_vconsole() into returning success when it is called for a tty0 that in fact doesn't work like tty0. :) We might as well remove is_vconsole() then. Does it make sense to execute the rest of the code in vconsole-setup.c (fontmap, utf8 etc.) on a non-VT

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-20 Thread Kay Sievers
On Sat, Jul 20, 2013 at 6:34 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Kay Sievers wrote: Oh, I meant turning is_vconsole() into returning success when it is called for a tty0 that in fact doesn't work like tty0. :) We might as well remove is_vconsole() then. Does it make sense to

Re: [systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-20 Thread Ramkumar Ramachandra
Kay Sievers wrote: If you're so particular about keeping primary unit files clean, may I suggest moving the exception code to vconsole-setup.c? That's what I meant, yeah, sorry for the confusion. Cool, I understand that your desire to keep primary units clean: I'll write a patch for this. In

[systemd-devel] [PATCH 2/2] vconsole-setup: setup negative conditional on uml

2013-07-19 Thread Ramkumar Ramachandra
User-Mode Linux does not do VT102 emulation, and $ vconsole-setup /dev/tty0 will always fail on it. In order to prevent vconsole-setup.service from always failing, disable it when uml is detected. Cc: Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl Cc: Lennart Poettering lenn...@poettering.net