Re: [systemd-devel] Broken build and CI strategy

2013-07-08 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 10:06:11AM +0200, Holger Hans Peter Freyther wrote: On Fri, Jun 28, 2013 at 09:43:08AM +0200, Peter Sztanojev wrote: So this issue is about tweaking how jenkins does its job? I have added David Strauss to the CC, hopefully he won't mind. Well, that is one part.

Re: [systemd-devel] Broken build and CI strategy

2013-07-02 Thread William Giokas
On Fri, Jun 28, 2013 at 09:18:24AM +0200, Holger Hans Peter Freyther wrote: On Fri, Jun 28, 2013 at 09:05:40AM +0200, Peter Sztanojev wrote: there already is a jenkins ci for systemd kindly provided by Pantheon: http://systemd.getpantheon.com:8080/jenkins/ The jenkins script is still using

Re: [systemd-devel] Broken build and CI strategy

2013-06-29 Thread Cristian Rodríguez
El 28/06/13 09:14, Lennart Poettering escribió: We use the normal Fedora linker, which I think is normal ld, not gold. I use gold to build systemd all the time, it works just fine. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org

[systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
Dear Lennart, the systemd build is currently broken[1] and judging from the commit history it appears that this happened more than once. Besides fixing the build you might want to consider adopting another strategy. In mature software projects the following is quite common: a.) Create a

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Peter Sztanojev
On Fri, Jun 28, 2013 at 8:50 AM, Holger Hans Peter Freyther hol...@freyther.de wrote: Dear Lennart, the systemd build is currently broken[1] and judging from the commit history it appears that this happened more than once. Besides fixing the build you might want to consider adopting another

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 09:05:40AM +0200, Peter Sztanojev wrote: On Fri, Jun 28, 2013 at 8:50 AM, Holger Hans Peter Freyther there already is a jenkins ci for systemd kindly provided by Pantheon: http://systemd.getpantheon.com:8080/jenkins/ The jenkins script is still using make test (which

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Peter Sztanojev
On Fri, Jun 28, 2013 at 9:18 AM, Holger Hans Peter Freyther hol...@freyther.de wrote: On Fri, Jun 28, 2013 at 09:05:40AM +0200, Peter Sztanojev wrote: On Fri, Jun 28, 2013 at 8:50 AM, Holger Hans Peter Freyther there already is a jenkins ci for systemd kindly provided by Pantheon:

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 09:43:08AM +0200, Peter Sztanojev wrote: So this issue is about tweaking how jenkins does its job? I have added David Strauss to the CC, hopefully he won't mind. Well, that is one part. make test really just checks if the test/ directory exists, it doesn't really

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Lennart Poettering
On Fri, 28.06.13 08:50, Holger Hans Peter Freyther (hol...@freyther.de) wrote: Heya, Dear Lennart, the systemd build is currently broken[1] and judging from the commit So, it builds fine (make check) on Fedora 18/19, which is what I check against. It also builds fine on Pantheon's Jenkins

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Lennart Poettering
On Fri, 28.06.13 10:06, Holger Hans Peter Freyther (hol...@freyther.de) wrote: Well, that is one part. make test really just checks if the test/ directory exists, it doesn't really contribute to the quality control. The other thing with make check is that it is failing if the build system

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Lennart Poettering lenn...@poettering.net: On Fri, 28.06.13 10:06, Holger Hans Peter Freyther (hol...@freyther.de) wrote: Well, that is one part. make test really just checks if the test/ directory exists, it doesn't really contribute to the quality control. The other thing with

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Holger Hans Peter Freyther hol...@freyther.de: systemd currently does not link on default Debian/Ubuntu systems. v44, v204 and git master all build and link fine on my pretty standard Debian sid system, so I can't reproduce the problem, at least not on Debian. Cheers, Michael

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 03:44:35PM +0200, Michael Biebl wrote: v44, v204 and git master all build and link fine on my pretty standard Debian sid system, so I can't reproduce the problem, at least not on Debian. Which linker and which system do you run it on? A clean build on my Debian Testing

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Holger Hans Peter Freyther hol...@freyther.de: On Fri, Jun 28, 2013 at 03:44:35PM +0200, Michael Biebl wrote: v44, v204 and git master all build and link fine on my pretty standard Debian sid system, so I can't reproduce the problem, at least not on Debian. Which linker and which

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 04:01:08PM +0200, Lennart Poettering wrote: Maybe this is simply broken automake dependency info somewhere left in your tree? I did the git clean but I still wondered, this is why I created the .travis.yml. Before I was building a branch that contained some of my RFC

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Michael Biebl
2013/6/28 Michael Biebl mbi...@gmail.com: 2013/6/28 Holger Hans Peter Freyther hol...@freyther.de: On Fri, Jun 28, 2013 at 04:01:08PM +0200, Lennart Poettering wrote: Maybe this is simply broken automake dependency info somewhere left in your tree? I did the git clean but I still wondered,

Re: [systemd-devel] Broken build and CI strategy

2013-06-28 Thread Holger Hans Peter Freyther
On Fri, Jun 28, 2013 at 07:05:35PM +0200, Michael Biebl wrote: That said, I don't understand, why this commit breaks the build with that (older) toolchain. Neither bootctl nor libsystemd-id128.so is using cg_create(). at the same time it has an undefined reference... $ nm -D