Re: [systemd-devel] [RFC 25/25] add -z muldefs to linker flags

2014-09-19 Thread Michael Biebl
2014-09-19 0:34 GMT+02:00 David Herrmann dh.herrm...@gmail.com: -Wl,-fuse-ld=gold]) The reason to use gold was that the compat libraries require the ifunc functionality. This is no longer the case, so I'd suggest to not override the default linker and simply use the system default

[systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c index ff2b24f..7b0714d 100644 ---

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 9:57 AM, Susant Sahani sus...@redhat.com wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 01:35 PM, David Herrmann wrote: Hi Hi, On Fri, Sep 19, 2014 at 9:57 AM, Susant Sahani sus...@redhat.com wrote: CID 1237543 (#1 of 1): Unchecked return value from library (CHECKED_RETURN) --- src/socket-proxy/socket-proxyd.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann wrote: I don't think that's right. Ignoring the return value of that fcntl is just fine. We read the buffer-size afterwards, so if it failed, we still continue properly. See

Re: [systemd-devel] [PATCH] ask-password: Add --do-echo to enable echoing the user input

2014-09-19 Thread David Sommerseth
On 18/09/14 18:02, Colin Guthrie wrote: I'd rather the ability to make a single request and have the agent ask for all credentials and reply once rather than looping over both separately however. +1 ... But I'll have to say that this will require a bit of re-designing old cold paths in

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann wrote: I don't think that's right. Ignoring the return value of that fcntl is just fine. We read the buffer-size afterwards, so if

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Alexander E. Patrakov
19.09.2014 14:35, Susant Sahani wrote: On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann wrote: I don't think that's right. Ignoring the return value of that fcntl is just fine. We

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 10:39 AM, Alexander E. Patrakov patra...@gmail.com wrote: 19.09.2014 14:35, Susant Sahani wrote: On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com wrote: On 09/19/2014 01:35 PM, David Herrmann

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Susant Sahani
On 09/19/2014 02:11 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:39 AM, Alexander E. Patrakov patra...@gmail.com wrote: 19.09.2014 14:35, Susant Sahani wrote: On 09/19/2014 02:00 PM, David Herrmann wrote: Hi On Fri, Sep 19, 2014 at 10:28 AM, Susant Sahani sus...@redhat.com

Re: [systemd-devel] [RFC 25/25] add -z muldefs to linker flags

2014-09-19 Thread Emil Renner Berthing
On 19 September 2014 08:42, Michael Biebl mbi...@gmail.com wrote: 2014-09-19 0:34 GMT+02:00 David Herrmann dh.herrm...@gmail.com: -Wl,-fuse-ld=gold]) The reason to use gold was that the compat libraries require the ifunc functionality. This is no longer the case, so I'd suggest to

Re: [systemd-devel] [RFC 25/25] add -z muldefs to linker flags

2014-09-19 Thread Dan Horák
On Fri, 19 Sep 2014 11:24:14 +0200 Emil Renner Berthing syst...@esmil.dk wrote: On 19 September 2014 08:42, Michael Biebl mbi...@gmail.com wrote: 2014-09-19 0:34 GMT+02:00 David Herrmann dh.herrm...@gmail.com: -Wl,-fuse-ld=gold]) The reason to use gold was that the compat

[systemd-devel] percentage values in journald.conf

2014-09-19 Thread Christian Hesse
Hello everybody, I am just trying to give journald some useful configuration on my system with a dedicated log partition. The man page speaks about default values in percent, so I tried: SystemMaxUse=75% SystemKeepFree=25% However this is ignored. Are values in percent supposed to work? Either

[systemd-devel] journal repair

2014-09-19 Thread Jóhann B. Guðmundsson
Is the plan to introduce an repair switch or is the plan to inform the users how they should proceed if that is not the case since users are getting confused when they encounter journal errors like these Data object missing from hash at entry... Data object references invalid entry at...

Re: [systemd-devel] [PATCH v5] socket: introduce SELinuxContextFromNet option

2014-09-19 Thread Tom Gundersen
On Mon, Sep 8, 2014 at 3:42 PM, Michal Sekletar msekl...@redhat.com wrote: This makes possible to spawn service instances triggered by socket with MLS/MCS SELinux labels which are created based on information provided by connected peer. Implementation of label_get_child_mls_label derived from

[systemd-devel] [PATCH] tty-ask-password-agent: Allow user input to be echoed

2014-09-19 Thread David Sommerseth
This is a continuation of the patch ask-password: Add --do-echo to enable echoing the user input. This allows user input going via the ask-password-agent to be echoed as well, if the --do-echo argument is provided to systemd-ask-password. Again it was preferred to add a new function,

Re: [systemd-devel] [RFC 00/25] Compile against the musl libc

2014-09-19 Thread Tom Gundersen
On Thu, Sep 18, 2014 at 9:21 PM, Emil Renner Berthing syst...@esmil.dk wrote: On 18 September 2014 18:29, Tom Gundersen t...@jklm.no wrote: In general, I don't think we should add patches for the sole purpose of non-glibc compatibility. You would in most cases be much better served by adding

Re: [systemd-devel] [RFC 25/25] add -z muldefs to linker flags

2014-09-19 Thread Michael Biebl
2014-09-19 11:31 GMT+02:00 Dan Horák d...@danny.cz: On Fri, 19 Sep 2014 11:24:14 +0200 Emil Renner Berthing syst...@esmil.dk wrote: On 19 September 2014 08:42, Michael Biebl mbi...@gmail.com wrote: 2014-09-19 0:34 GMT+02:00 David Herrmann dh.herrm...@gmail.com: -Wl,-fuse-ld=gold])

Re: [systemd-devel] [PATCH v5] socket: introduce SELinuxContextFromNet option

2014-09-19 Thread Michal Sekletar
On Fri, Sep 19, 2014 at 12:13:18PM +0200, Tom Gundersen wrote: On Mon, Sep 8, 2014 at 3:42 PM, Michal Sekletar msekl...@redhat.com wrote: This makes possible to spawn service instances triggered by socket with MLS/MCS SELinux labels which are created based on information provided by

Re: [systemd-devel] [RFC 00/25] Compile against the musl libc

2014-09-19 Thread Umut Tezduyar Lindskog
Axis Communications is running fairly compact version of systemd with some properties disabled with --disable--xyz. Files are a bit over 10 mb on MIPS ISA (stripped of binaries and conf files). Top 10 large files are (in kb) 276 ./Root/usr/lib/systemd/systemd-udevd 280 ./Root/usr/bin/udevadm

Re: [systemd-devel] [RFC 18/25] sd-ipv4all: fall back to random if no random_r

2014-09-19 Thread Umut Tezduyar Lindskog
As Tom stated this is changing the behaviour. Maybe not when you only have 1 interface but if we are talking about multiple interfaces, then they will share common entropy. Umut On Thu, Sep 18, 2014 at 5:43 PM, Tom Gundersen t...@jklm.no wrote: No, this actually breaks the behaviour, so we

Re: [systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

2014-09-19 Thread Simon McVittie
On 19/09/14 09:05, David Herrmann wrote: -fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE); +r = fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE); +if (r 0) { +log_error(Failed to set pipe buffer size: %m); +return -errno; +} I don't

Re: [systemd-devel] journal repair

2014-09-19 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Sep 19, 2014 at 10:00:02AM +, Jóhann B. Guðmundsson wrote: Is the plan to introduce an repair switch or is the plan to inform the users how they should proceed if that is not the case since users are getting confused when they encounter journal errors like these Data object

Re: [systemd-devel] journal repair

2014-09-19 Thread Jóhann B. Guðmundsson
On 09/19/2014 02:10 PM, Zbigniew Jędrzejewski-Szmek wrote: journalctl --file /var/log/xxx.journal | systemd-journal-remote --file /tmp/xxx.journal - mv /tmp/xxx.journal /var/log/xxx.journal We could easily provide the functionality to do this automatically, but I don't know how useful

[systemd-devel] [PATCH] systemctl: add add-wants and add-requires verbs

2014-09-19 Thread Lukas Nykryn
--- TODO | 1 - man/systemctl.xml | 27 ++ src/core/dbus-manager.c| 85 + src/core/org.freedesktop.systemd1.conf | 8 +++ src/shared/install.c | 87

Re: [systemd-devel] [PATCH 1/3] journal: Do not count on the compiler initializing found_last to false

2014-09-19 Thread Dale R. Worley
From: Philippe De Swert philippedesw...@gmail.com There is a very unlikely case where this can happen since gcc usually does the sane thing. But let's make sure found_last is initialized anyway. You'd better -- the C standard does *not* require the compiler to intialize local (auto)

[systemd-devel] [RFC] [PATCH] cgroup: don't trim cgroup trees created by someone else

2014-09-19 Thread Michal Sekletar
In cases when there is a cgroup tree in a controller hierarchy which was not created by us, but it looks like it was (i.e. cgroup path is the same as the one in systemd's named hierarchy) we shouldn't delete it. --- Reproducer: 1) start qemu-kvm VM via virsh/virt-manager 2) ls

[systemd-devel] Systemd-nspawn -- Unable to initialize virtual ethernet connection

2014-09-19 Thread James Lott
Hello! I am trying to setup and play around with some of the private networking features of systemd, and one of the big thinks I'm trying to get working is the virtual ethernet links. For some reason though, I am unable to start a containder using a virtual ethernet link. My attempt is

[systemd-devel] systemd-networkd -- Unable to create VLAN device

2014-09-19 Thread James Lott
Hello again! I've been eager to play with networking features, in case you couldn't tell ;) This patricular issue seems separate from my first one though, so I thought it would be best to discuss separately. I am trying to use systemd-networkd to essentially replace vconfig. I am using eth0

[systemd-devel] [PATCH] shared/util.h: portable sizeof(long) == sizeof(int) test

2014-09-19 Thread Emil Renner Berthing
Don't rely on __WORDSIZE, but just standard LONG_MAX and INT_MAX from limits.h. --- src/shared/util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/util.h b/src/shared/util.h index 08d556f..00068c6 100644 --- a/src/shared/util.h +++ b/src/shared/util.h @@ -205,7

Re: [systemd-devel] [PATCH] shared/util.h: portable sizeof(long) == sizeof(int) test

2014-09-19 Thread David Herrmann
Hi On Fri, Sep 19, 2014 at 8:26 PM, Emil Renner Berthing syst...@esmil.dk wrote: Don't rely on __WORDSIZE, but just standard LONG_MAX and INT_MAX from limits.h. Why? The commit message lacks any explanation of that change. Thanks David --- src/shared/util.h | 2 +- 1 file changed, 1

Re: [systemd-devel] systemd-networkd -- Unable to create VLAN device

2014-09-19 Thread Tom Gundersen
On Fri, Sep 19, 2014 at 6:59 PM, James Lott ja...@lottspot.com wrote: Hello again! I've been eager to play with networking features, in case you couldn't tell ;) This patricular issue seems separate from my first one though, so I thought it would be best to discuss separately. I am trying

Re: [systemd-devel] [PATCH] shared/util.h: portable sizeof(long) == sizeof(int) test

2014-09-19 Thread Emil Renner Berthing
On 19 September 2014 22:19, David Herrmann dh.herrm...@gmail.com wrote: On Fri, Sep 19, 2014 at 8:26 PM, Emil Renner Berthing syst...@esmil.dk wrote: Don't rely on __WORDSIZE, but just standard LONG_MAX and INT_MAX from limits.h. Why? The commit message lacks any explanation of that change.

Re: [systemd-devel] systemd-networkd -- Unable to create VLAN device

2014-09-19 Thread James Lott
Holy smokes, that did it! Many thanks for taking time out of your day to help me find my silly mistake :) On Friday 19 September 2014 22:51:41 Tom Gundersen wrote: On Fri, Sep 19, 2014 at 6:59 PM, James Lott ja...@lottspot.com wrote: Hello again! I've been eager to play with networking

Re: [systemd-devel] Systemd-nspawn -- Unable to initialize virtual ethernet connection

2014-09-19 Thread Tom Gundersen
On Fri, Sep 19, 2014 at 6:37 PM, James Lott ja...@lottspot.com wrote: I am trying to setup and play around with some of the private networking features of systemd, and one of the big thinks I'm trying to get working is the virtual ethernet links. For some reason though, I am unable to start a

Re: [systemd-devel] Systemd-nspawn -- Unable to initialize virtual ethernet connection

2014-09-19 Thread James Lott
Thanks so much for debugging that! Your recommended work around, of course, works perfectly for me until the release hits the Arch repos (although my gentoo machines will happily and impatiently pull in the git snapshot ). Do you know what the version number for the next systemd release will

Re: [systemd-devel] Systemd-nspawn -- Unable to initialize virtual ethernet connection

2014-09-19 Thread Tom Gundersen
On Fri, Sep 19, 2014 at 11:24 PM, James Lott ja...@lottspot.com wrote: Do you know what the version number for the next systemd release will be? I want to make sure I keep my eyes peeled for it! We are currently at 216, so the next one will be 217 (I guess in a month or so from now). Cheers,