Re: [systemd-devel] Service not restarting after Condition failed

2014-11-30 Thread Umut Tezduyar Lindskog
On Tue, Nov 25, 2014 at 2:38 PM, D.S. Ljungmark spi...@aanstoot.se wrote: On 24/11/14 20:30, Umut Tezduyar Lindskog wrote: Hi On Monday, November 24, 2014, D.S. Ljungmark spi...@aanstoot.se mailto:spi...@aanstoot.se wrote: On 10/11/14 23:09, Lennart Poettering wrote: On Thu,

[systemd-devel] [PATCH] man: BusName= is not optional for Type!=bus

2014-11-30 Thread Umut Tezduyar Lindskog
http://lists.freedesktop.org/archives/systemd-devel/2014-November/025492.html --- man/systemd.service.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/man/systemd.service.xml b/man/systemd.service.xml index e563b19..f99e4d5 100644 --- a/man/systemd.service.xml +++

[systemd-devel] [PATCH] delta: Fix broken separator support

2014-11-30 Thread alison
From: Alison Chaiken alison_chai...@mentor.com systemd-delta man page promises that multiple types of deltas will be concatenated if they are listed with a comma as separator. Replace FOREACH_WORD() with FOREACH_WORD_SEPARATOR() to restore the functionality. Signed-off-by: Alison Chaiken

Re: [systemd-devel] [PATCH] delta: Fix broken separator support

2014-11-30 Thread Tom Gundersen
Applied. Thanks! On Sun, Nov 30, 2014 at 12:14 PM, ali...@she-devel.com wrote: From: Alison Chaiken alison_chai...@mentor.com systemd-delta man page promises that multiple types of deltas will be concatenated if they are listed with a comma as separator. Replace FOREACH_WORD() with

[systemd-devel] forever loop during garbage collection

2014-11-30 Thread Umut Tezduyar Lindskog
Hi, We are experiencing an unbreakable loop in manager_dispatch_gc_queue. Problem happens when systemd runs in sysV compatibility mode (Porky enables this). Seems like manager_dispatch_gc_queue's while loop gets stuck and seems like unit_gc_sweep cannot make a decision about the unit. As a

[systemd-devel] [PATCH] man: fix link to systemd-networkd-wait-online.service in systemd-networkd.service(8)

2014-11-30 Thread Chris Mayo
--- man/systemd-networkd.service.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/systemd-networkd.service.xml b/man/systemd-networkd.service.xml index 0570798..7c20fa4 100644 --- a/man/systemd-networkd.service.xml +++ b/man/systemd-networkd.service.xml @@ -95,7 +95,7

[systemd-devel] [PATCH] man: add a link to systemd-coredump(8) in Description of coredump.conf(5)

2014-11-30 Thread Chris Mayo
--- man/coredump.conf.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/coredump.conf.xml b/man/coredump.conf.xml index 37916f0..fe7479f 100644 --- a/man/coredump.conf.xml +++ b/man/coredump.conf.xml @@ -59,7 +59,7 @@ refsect1 titleDescription/title -

Re: [systemd-devel] [PATCH] man: add a link to systemd-coredump(8) in Description of coredump.conf(5)

2014-11-30 Thread Ronny Chevalier
2014-11-30 15:45 GMT+01:00 Chris Mayo aklh...@gmail.com: --- man/coredump.conf.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/coredump.conf.xml b/man/coredump.conf.xml index 37916f0..fe7479f 100644 --- a/man/coredump.conf.xml +++ b/man/coredump.conf.xml @@

[systemd-devel] [PATCH 1/2] When warning about unsupported options, be more detailed

2014-11-30 Thread Zbigniew Jędrzejewski-Szmek
--- I think this would be useful. Comments? src/core/load-fragment-gperf.gperf.m4 | 28 ++-- src/core/load-fragment.c | 15 --- src/core/load-fragment.h | 5 + 3 files changed, 31 insertions(+), 17 deletions(-) diff --git

Re: [systemd-devel] [RFC PATCH] proc, pidns: Add highpid

2014-11-30 Thread David Herrmann
Hi Andy On Sat, Nov 29, 2014 at 12:05 AM, Andy Lutomirski l...@amacapital.net wrote: Pid reuse is common, which means that it's difficult or impossible to read information about a pid from /proc without races. This introduces a second number associated with each (task, pidns) pair called

Re: [systemd-devel] [PATCH 2/2] core: warn and ignore SysVStartPriority=

2014-11-30 Thread Lennart Poettering
On Sun, 30.11.14 16:55, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Option was parsed but was not being used for anything. Maybe call this DISABLED_LEGACY then? --- src/core/load-fragment-gperf.gperf.m4 | 4 +--- src/core/load-fragment.c | 4

Re: [systemd-devel] [systemd-commits] 4 commits - man/systemd.mount.xml man/systemd.swap.xml src/core src/fstab-generator src/journal src/shared

2014-11-30 Thread Lennart Poettering
On Sun, 30.11.14 01:09, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: I think we really should close the fd here. audit is actually really a good example why: the audit kernel side has a logic to pass audit msgs to kmsg if no client is listening¹. If we keep the audit fd open, but

Re: [systemd-devel] [PATCH] cgroup-util: Don't send SIGCONT after SIGKILL

2014-11-30 Thread Lennart Poettering
On Sat, 29.11.14 11:31, Ross Lagerwall (rosslagerw...@gmail.com) wrote: Applied! Thanks! --- src/shared/cgroup-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/cgroup-util.c b/src/shared/cgroup-util.c index bc5030e..e595d89 100644 ---

Re: [systemd-devel] [RFC PATCH] proc, pidns: Add highpid

2014-11-30 Thread Andy Lutomirski
On Nov 30, 2014 9:45 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi Andy On Sat, Nov 29, 2014 at 12:05 AM, Andy Lutomirski l...@amacapital.net wrote: Pid reuse is common, which means that it's difficult or impossible to read information about a pid from /proc without races. This

Re: [systemd-devel] [RFC PATCH] proc, pidns: Add highpid

2014-11-30 Thread Andy Lutomirski
On Nov 30, 2014 1:47 AM, Florian Weimer f...@deneb.enyo.de wrote: * Andy Lutomirski: The initial implementation is straightforward: highpid is simply a 64-bit counter. If a high-end system can fork every 3 ns (which would be amazing, given that just allocating a pid requires at atomic

Re: [systemd-devel] systemd-cgroups-agent not working in containers

2014-11-30 Thread Lennart Poettering
On Wed, 26.11.14 22:29, Richard Weinberger (rich...@nod.at) wrote: Hi! I run a Linux container setup with openSUSE 13.1/2 as guest distro. After some time containers slow down. An investigation showed that the containers slow down because a lot of stale user sessions slow down almost all

Re: [systemd-devel] systemd-cgroups-agent not working in containers

2014-11-30 Thread Lennart Poettering
On Fri, 28.11.14 15:52, Richard Weinberger (rich...@nod.at) wrote: Am 28.11.2014 um 06:33 schrieb Martin Pitt: Hello all, Cameron Norman [2014-11-27 12:26 -0800]: On Wed, Nov 26, 2014 at 1:29 PM, Richard Weinberger rich...@nod.at wrote: Hi! I run a Linux container setup with

Re: [systemd-devel] Scope units get SIGKILL when stopped, not SIGTERM

2014-11-30 Thread Lennart Poettering
On Wed, 26.11.14 11:55, Michael Chapman (m...@very.puzzling.org) wrote: Heya, When I stop a scope unit, it looks like all processes in it get a SIGKILL immediately, not a SIGTERM. I believe this issue has been brought up before in

Re: [systemd-devel] Native Journal source vs syslog forwarding

2014-11-30 Thread Lennart Poettering
On Wed, 26.11.14 11:04, Gergely Nagy (alger...@madhouse-project.org) wrote: Hi! I have an interesting situation here, which I'm trying to wrap my head around and solve. The problem is that I have a syslog daemon (syslog-ng 3.6.1) that has a native Journal source, meaning it can pull entries

Re: [systemd-devel] Native Journal source vs syslog forwarding

2014-11-30 Thread Lennart Poettering
On Wed, 26.11.14 13:08, Gergely Nagy (alger...@madhouse-project.org) wrote: Colin == Colin Guthrie gm...@colin.guthr.ie writes: Colin Gergely Nagy wrote on 26/11/14 10:04: 3) Disable syslog forwarding if syslog-ng is installed Not sure how this could be achieved,

Re: [systemd-devel] Native Journal source vs syslog forwarding

2014-11-30 Thread Lennart Poettering
On Wed, 26.11.14 13:07, Gergely Nagy (alger...@madhouse-project.org) wrote: Jóhann == Jóhann B Guðmundsson johan...@gmail.com writes: Jóhann On 11/26/2014 10:04 AM, Gergely Nagy wrote: On Debian, syslog forwarding is enabled by default, and since syslog-ng reads from the

Re: [systemd-devel] Native Journal source vs syslog forwarding

2014-11-30 Thread Lennart Poettering
On Fri, 28.11.14 14:53, Martin Pitt (martin.p...@ubuntu.com) wrote: Hey Gergely, Gergely Nagy [2014-11-26 13:07 +0100]: Forwarding is enabled by default on Debian, as I wrote in my original mail. I have no control over the default, and I have no desire to argue for changing it. I'm

Re: [systemd-devel] Native Journal source vs syslog forwarding

2014-11-30 Thread Lennart Poettering
On Fri, 28.11.14 15:13, Gergely Nagy (alger...@madhouse-project.org) wrote: Martin == Martin Pitt martin.p...@ubuntu.com writes: Martin So we either need the journal.conf.d/ feature and have journal-pulling Martin sysloggers disable forwarding along the way, or we need to wait

Re: [systemd-devel] Native Journal source vs syslog forwarding

2014-11-30 Thread Gergely Nagy
Lennart == Lennart Poettering lenn...@poettering.net writes: Lennart On Wed, 26.11.14 11:04, Gergely Nagy (alger...@madhouse-project.org) wrote: This works beautifully, except there's one problem: Nov 26 10:41:05 eowyn systemd-journal[14843]: Forwarding to syslog missed

Re: [systemd-devel] Native Journal source vs syslog forwarding

2014-11-30 Thread Gergely Nagy
Lennart == Lennart Poettering lenn...@poettering.net writes: Forwarding is enabled by default on Debian, as I wrote in my original mail. I have no control over the default, and I have no desire to argue for changing it. There are other syslogds in Debian (including the

Re: [systemd-devel] Native Journal source vs syslog forwarding

2014-11-30 Thread Lennart Poettering
On Mon, 01.12.14 00:30, Gergely Nagy (alger...@madhouse-project.org) wrote: Lennart == Lennart Poettering lenn...@poettering.net writes: Forwarding is enabled by default on Debian, as I wrote in my original mail. I have no control over the default, and I have no desire to argue

Re: [systemd-devel] [PATCH] cgroup-util: Add more well-known controller names

2014-11-30 Thread Lennart Poettering
On Wed, 26.11.14 15:55, Martin Pitt (martin.p...@ubuntu.com) wrote: Hello all, some weeks ago I mentioned [1] that I'm working on making per-user (unprivileged) LXC containers work under systemd. Lennart made it quite clear [2] that he doesn't want to support this upstream until the kernel

Re: [systemd-devel] how to properly control the daemons or run advanced cmds

2014-11-30 Thread Lennart Poettering
On Tue, 25.11.14 00:09, Flavio Leitner (f...@redhat.com) wrote: Hello, The Open vSwitch is comprised by two daemons. One is a database and another is the switch itself. Currently we have the openvswitch.service which start/stop/reload the service (both daemons) just fine. In general

Re: [systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-11-30 Thread Lennart Poettering
On Tue, 25.11.14 09:23, Jan Synacek (jsyna...@redhat.com) wrote: #ifdef HAVE_XKBCOMMON static void log_xkb(struct xkb_context *ctx, enum xkb_log_level lvl, const char *format, va_list args) { -/* suppress xkb messages for now */ +_cleanup_free_ char *fmt = NULL; +

Re: [systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-11-30 Thread Lennart Poettering
On Tue, 25.11.14 10:01, David Herrmann (dh.herrm...@gmail.com) wrote: char fmt[LINE_MAX]; snprintf(fmt, sizeof(fmt), libxkbcommon: %s, format); e = xkb_context_get_user_data(ctx); bus_error_setfv(e, SD_BUS_ERROR_INVALID_ARGS, fmt, args); We use LINE_MAX as explicit limit on a lot of

Re: [systemd-devel] [PATCH 2/2] core: warn and ignore SysVStartPriority=

2014-11-30 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Nov 30, 2014 at 10:51:36PM +0100, Lennart Poettering wrote: On Sun, 30.11.14 16:55, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: Option was parsed but was not being used for anything. Maybe call this DISABLED_LEGACY then? OK. Thank you for the review. Will push. Zbyszek

Re: [systemd-devel] [PATCH] localed: forward xkbcommon errors

2014-11-30 Thread Lennart Poettering
On Tue, 25.11.14 10:01, David Herrmann (dh.herrm...@gmail.com) wrote: I explicitly ignore errors from verify_xkb_rmlvo() and proceed. libxkbcommon is still not 100% compatible to libxkb (and doesn't intend to be that, I guess). As we write X11 configs here, I just continue with a warning.

Re: [systemd-devel] [PATCH] build-sys: remove --gc-sections to fix debugging

2014-11-30 Thread Lennart Poettering
On Mon, 24.11.14 20:00, Peter Wu (pe...@lekensteyn.nl) wrote: The --gc-sections linker option triggers a bug in the gold linker[1] which results in a bogus .eh_frame section making debugging harder: gdb backtraces stop at a library built by systemd and libunwind simply segfaults. To my

Re: [systemd-devel] [systemd-commits] 4 commits - man/systemd.mount.xml man/systemd.swap.xml src/core src/fstab-generator src/journal src/shared

2014-11-30 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Nov 30, 2014 at 10:55:03PM +0100, Lennart Poettering wrote: On Sun, 30.11.14 01:09, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: I think we really should close the fd here. audit is actually really a good example why: the audit kernel side has a logic to pass audit msgs

Re: [systemd-devel] [systemd-commits] src/cryptsetup

2014-11-30 Thread Lennart Poettering
On Mon, 24.11.14 19:25, Quentin Lefebvre (qlefebvre_...@yahoo.com) wrote: Le 24/11/2014 19:17, Zbigniew Jędrzejewski-Szmek a écrit : On Mon, Nov 24, 2014 at 07:03:27PM +0100, Quentin Lefebvre wrote: Le 24/11/2014 19:01, Zbigniew Jędrzejewski-Szmek a écrit : On Mon, Nov 24, 2014 at 06:44:25PM

Re: [systemd-devel] Scope units get SIGKILL when stopped, not SIGTERM

2014-11-30 Thread Michael Chapman
On Sun, 30 Nov 2014, Lennart Poettering wrote: The only solution that will really fix this for good is probably to move things to the new unified cgroup controller logic that finally gives us useful ways to get notifications for cgroups running empty. Also see what I just replied here:

Re: [systemd-devel] [systemd-commits] 4 commits - man/systemd.mount.xml man/systemd.swap.xml src/core src/fstab-generator src/journal src/shared

2014-11-30 Thread Lennart Poettering
On Mon, 01.12.14 01:10, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Sun, Nov 30, 2014 at 10:55:03PM +0100, Lennart Poettering wrote: On Sun, 30.11.14 01:09, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: I think we really should close the fd here. audit is

Re: [systemd-devel] Service not restarting after Condition failed

2014-11-30 Thread Lennart Poettering
On Mon, 24.11.14 20:02, D.S. Ljungmark (spi...@aanstoot.se) wrote: Basically, some files (config certificates) may not exist on a system until it's provisioned properly, something that may take a while ( a few days) After provisioning, we want the services depending on those file to start

Re: [systemd-devel] [systemd-commits] 4 commits - man/systemd.mount.xml man/systemd.swap.xml src/core src/fstab-generator src/journal src/shared

2014-11-30 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Dec 01, 2014 at 01:15:59AM +0100, Lennart Poettering wrote: On Mon, 01.12.14 01:10, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: On Sun, Nov 30, 2014 at 10:55:03PM +0100, Lennart Poettering wrote: On Sun, 30.11.14 01:09, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl)

Re: [systemd-devel] [PATCH] x86: defconfig: Enable CONFIG_FHANDLE

2014-11-30 Thread Richard Weinberger
Am 01.12.2014 um 01:18 schrieb Dave Chinner: On Sun, Nov 30, 2014 at 10:08:01PM +0100, Richard Weinberger wrote: Am 30.11.2014 um 21:54 schrieb Dave Chinner: On Wed, Nov 26, 2014 at 12:36:52AM +0100, Richard Weinberger wrote: systemd has a hard dependency on CONFIG_FHANDLE. If you run systemd

Re: [systemd-devel] [PATCH] x86: defconfig: Enable CONFIG_FHANDLE

2014-11-30 Thread Lennart Poettering
On Mon, 01.12.14 01:41, Richard Weinberger (rich...@nod.at) wrote: CC'ing systemd folks. Lennart, can you please explain why you need CONFIG_FHANDLE for systemd? Maybe I'm reading the source horrible wrong. For two usecases: a) Being able to detect if something is a mount point. The

Re: [systemd-devel] systemctl list-dependencies: consider BindsTo as well?

2014-11-30 Thread Lennart Poettering
On Sun, 23.11.14 12:55, Peter Mattern (matte...@arcor.de) wrote: Thanks for fixing this. May I suggest to adjust man systemctl accordingly, too? Necessary parts would be the one about option --reverse and command list-dependencies. As for the latter I'd suggest another change while you're

Re: [systemd-devel] [PATCH] Stop crashing on empty TXT

2014-11-30 Thread Lennart Poettering
On Tue, 18.11.14 14:52, Stanisław Pitucha (virap...@gmail.com) wrote: TXT records should have at least one character, so enforce this. Previously parser SIGSEGV'd on -txt.strings being NULL. --- src/resolve/resolved-dns-packet.c | 4 1 file changed, 4 insertions(+) diff --git

[systemd-devel] [PATCH] Delete ZX as sole compression; Compress= as boolean

2014-11-30 Thread Chris Atkinson
In man journald.conf, removes reference to XZ as sole form of compression. See commit d89c8fdf48c7bad5816b9f2e77e8361721f22517. In man coredump.conf, clarifies that Compression= controls existence, not type, of compression. Regards,From c8e0efc6226f27171d57706eb1a864d05d7e60e2 Mon Sep 17

Re: [systemd-devel] [PATCH] Delete ZX as sole compression; Compress= as boolean

2014-11-30 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Nov 30, 2014 at 10:13:06PM -0500, Chris Atkinson wrote: In man journald.conf, removes reference to XZ as sole form of compression. See commit d89c8fdf48c7bad5816b9f2e77e8361721f22517. In man coredump.conf, clarifies that Compression= controls existence, not type, of compression.

Re: [systemd-devel] [PATCH] man: BusName= is not optional for Type!=bus

2014-11-30 Thread Zbigniew Jędrzejewski-Szmek
On Sun, Nov 30, 2014 at 09:32:39AM +0100, Umut Tezduyar Lindskog wrote: http://lists.freedesktop.org/archives/systemd-devel/2014-November/025492.html --- man/systemd.service.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/man/systemd.service.xml

Re: [systemd-devel] [PATCH v3] build-sys: configure the list of system users, files and directories

2014-11-30 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Nov 28, 2014 at 03:59:59PM +0100, Łukasz Stelmach wrote: Choose which system users defined in sysusers.d/systemd.conf and files or directories in tmpfiles.d/systemd.conf, should be provided depending on comile-time configuration. --- Makefile.am| 4

Re: [systemd-devel] [PATCH] cgroup-util: Add more well-known controller names

2014-11-30 Thread Martin Pitt
Hey Lennart, Lennart Poettering [2014-12-01 0:44 +0100]: +hugetlb\0 +cpuset\0 +net_cls\0 +net_prio\0 +freezer\0 +perf_event\0; In general we should be really careful about manipulating hierarchies we don't know enough about, since

Re: [systemd-devel] [PATCH] cgroup-util: Add more well-known controller names

2014-11-30 Thread Stéphane Graber
On Mon, Dec 01, 2014 at 06:24:48AM +0100, Martin Pitt wrote: Hey Lennart, Lennart Poettering [2014-12-01 0:44 +0100]: +hugetlb\0 +cpuset\0 +net_cls\0 +net_prio\0 +freezer\0 +perf_event\0; In general we should be really

[systemd-devel] [PATCH] journalctl: respect --after-cursor semantics with --follow in all cases

2014-11-30 Thread Wesley Dawson
In the case where no entries have been added to the journal after the specified cursor, set need_seek before the main loop to prevent display of the entry at said cursor. --- src/journal/journalctl.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git