Re: [systemd-devel] Run cleanup service on stop

2015-11-04 Thread Andrei Borzenkov
03.11.2015 09:21, Kai Hendry пишет: Hi there guys, I have a service where it's important that it cleans up *after* it's run. In fact it's probably a good idea to make sure it's clean *before* it's run too. I got as far as: After=clean.service Requires=clean.service But that does not seem to c

Re: [systemd-devel] [PATCH 2/2] detect-virt: dmi: fix mem leak

2015-11-04 Thread Lennart Poettering
On Tue, 03.11.15 15:04, Andrew Jones (drjo...@redhat.com) wrote: > The variable 's' is still in scope until we exit the function. We > can't call read_one_line_file on it multiple times without calling > free in between. > --- > src/basic/virt.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 del

Re: [systemd-devel] [PATCH 1/2] arm/aarch64: detect-virt: check dmi

2015-11-04 Thread Lennart Poettering
On Tue, 03.11.15 22:52, Wei Huang (w...@redhat.com) wrote: > > -/* Both CPUID and DMI are x86 specific interfaces... */ > > -#if defined(__i386__) || defined(__x86_64__) > > +#if defined(__i386__) || defined(__x86_64__) || defined(__arm__) || > > defined(__aarch64__) > > > > st

Re: [systemd-devel] [PATCH 0/2] arm/aarch64: detect-virt: check dmi

2015-11-04 Thread Lennart Poettering
On Tue, 03.11.15 15:19, Andrew Jones (drjo...@redhat.com) wrote: > ARM/AArch64 guests now have SMBIOS tables populated (when boot > with a late enough QEMU and a late enough AAVMF is used as the > bootloader). Furthermore, when booting ARM/AArch64 guests with > ACPI, the DT detection obviously no

Re: [systemd-devel] [PATCH 1/2] arm/aarch64: detect-virt: check dmi

2015-11-04 Thread Lennart Poettering
On Tue, 03.11.15 15:19, Andrew Jones (drjo...@redhat.com) wrote: > --- > src/basic/virt.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/basic/virt.c b/src/basic/virt.c > index fb181e5b55ee5..b0e33dc5f4d24 100644 > --- a/src/basic/virt.c > +++ b/src/basic/virt

Re: [systemd-devel] [PATCH 0/2] detect-virt: fixes

2015-11-04 Thread Lennart Poettering
On Tue, 03.11.15 15:04, Andrew Jones (drjo...@redhat.com) wrote: > These fixes are untested, as I don't have a good test environment for > systemd. I noticed the issues in the code while preparing a couple > patches (which are coming shortly). Well, tbh whenever we touch that code our testing is

Re: [systemd-devel] backlight service stopped at boot

2015-11-04 Thread Vlad
Unfortunately with systemd-227 the behaviour hasn't been changed. Vladimir. On 21/10/15 13:26, Vlad wrote: > Thanks for the explanation. I'll try 227 asap. > > Vladimir. > > On 20/10/15 12:19, Lennart Poettering wrote: >> On Tue, 20.10.15 08:21, Vlad (vo...@vovan.nl) wrote: >> >>> Hello, >>> >>>

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-04 Thread Andrei Borzenkov
04.11.2015 00:04, Andrew Jones пишет: afaict, this will fix a regression caused by commit 75f86906c5. Where we used to report "kvm" before that patch, without this patch, we would only report "qemu". Are you sure it is regression? QEMU is a program (platform) while KVM is technology. Modern Vi

Re: [systemd-devel] systemd-nspawn and process spawning using nsenter issue

2015-11-04 Thread Karel Zak
On Mon, Nov 02, 2015 at 03:36:49PM +, Richard Maw wrote: > > for that? If not is there a kernel interface to create one? > > I don't know of any utilities, but /proc/$pid/ns/net is a symlink pointing > to a magic file that refers to the network namespace. I think about "lsns" command to list

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-04 Thread Lennart Poettering
On Wed, 04.11.15 15:54, Andrei Borzenkov (arvidj...@gmail.com) wrote: > 04.11.2015 00:04, Andrew Jones пишет: > >afaict, this will fix a regression caused by commit 75f86906c5. > >Where we used to report "kvm" before that patch, without this patch, > >we would only report "qemu". > > Are you sure

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-04 Thread Mantas Mikulėnas
On Wed, Nov 4, 2015 at 3:52 PM, Lennart Poettering wrote: > On Wed, 04.11.15 15:54, Andrei Borzenkov (arvidj...@gmail.com) wrote: > > > 04.11.2015 00:04, Andrew Jones пишет: > > >afaict, this will fix a regression caused by commit 75f86906c5. > > >Where we used to report "kvm" before that patch,

Re: [systemd-devel] [PATCH 1/2] detect-virt: detect in best-heuristic order

2015-11-04 Thread Andrew Jones
On Wed, Nov 04, 2015 at 03:54:45PM +0300, Andrei Borzenkov wrote: > 04.11.2015 00:04, Andrew Jones пишет: > >afaict, this will fix a regression caused by commit 75f86906c5. > >Where we used to report "kvm" before that patch, without this patch, > >we would only report "qemu". > > Are you sure it i

Re: [systemd-devel] [PATCH 2/2] detect-virt: dmi: fix mem leak

2015-11-04 Thread Andrew Jones
On Wed, Nov 04, 2015 at 11:46:22AM +0100, Lennart Poettering wrote: > On Tue, 03.11.15 15:04, Andrew Jones (drjo...@redhat.com) wrote: > > > The variable 's' is still in scope until we exit the function. We > > can't call read_one_line_file on it multiple times without calling > > free in between.

Re: [systemd-devel] [PATCH 1/2] arm/aarch64: detect-virt: check dmi

2015-11-04 Thread Andrew Jones
On Wed, Nov 04, 2015 at 11:52:03AM +0100, Lennart Poettering wrote: > On Tue, 03.11.15 15:19, Andrew Jones (drjo...@redhat.com) wrote: > > > --- > > src/basic/virt.c | 6 ++ > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/src/basic/virt.c b/src/basic/virt.c > > index

Re: [systemd-devel] [PATCH 0/2] arm/aarch64: detect-virt: check dmi

2015-11-04 Thread Andrew Jones
On Tue, Nov 03, 2015 at 10:50:40PM -0600, Wei Huang wrote: > > > On 11/03/2015 03:19 PM, Andrew Jones wrote: > > ARM/AArch64 guests now have SMBIOS tables populated (when boot > > with a late enough QEMU and a late enough AAVMF is used as the > > bootloader). Furthermore, when booting ARM/AArch64

Re: [systemd-devel] [PATCH 0/2] arm/aarch64: detect-virt: check dmi

2015-11-04 Thread Andrew Jones
On Wed, Nov 04, 2015 at 11:51:10AM +0100, Lennart Poettering wrote: > On Tue, 03.11.15 15:19, Andrew Jones (drjo...@redhat.com) wrote: > > > ARM/AArch64 guests now have SMBIOS tables populated (when boot > > with a late enough QEMU and a late enough AAVMF is used as the > > bootloader). Furthermor

Re: [systemd-devel] [PATCH 2/2] detect-virt: dmi: fix mem leak

2015-11-04 Thread Andrew Jones
On Wed, Nov 04, 2015 at 08:26:00AM -0600, Andrew Jones wrote: > On Wed, Nov 04, 2015 at 11:46:22AM +0100, Lennart Poettering wrote: > > On Tue, 03.11.15 15:04, Andrew Jones (drjo...@redhat.com) wrote: > > > > > The variable 's' is still in scope until we exit the function. We > > > can't call read

Re: [systemd-devel] Run cleanup service on stop

2015-11-04 Thread Kai Hendry
On Wed, 4 Nov 2015, at 05:41 PM, Andrei Borzenkov wrote: > Why? It sounds like exact use case for Pre/Post commands. Well, with long lines like: ExecStartPre=/bin/bash -c 'grep -q noclean /etc/webc/cmdline || for d in ~/{.mozilla,.cache,.adobe,.macromedia,Downloads}; do rm -vrf $d; done' ExecStop

[systemd-devel] about libmount

2015-11-04 Thread yan...@iscas.ac.cn
hi guys I try to build the Systemd219 and get this " configure: error: *** libmount support required but libraries not found" what I do is “./configure” and when I use "dpkg -s libmount " ,I get this "Source: util-linux Version: 2.25.2-4ubuntu3" . So where is the problem? thanks! yan...@