Re: [systemd-devel] [PATCH] shell-completion: fix zsh completion installation
On Thu, Jul 25, 2013 at 02:00:06PM -0500, William Giokas wrote: Moved zsh shell completion to shell-completion/zsh/_systemd for automake's sake. Also allow users to specify where the files should go with:: Makes sense, imho. Should we go one step further and split _systemd like the bash completions were split? This would have at least the advantage that people packaging a subset of systemd could package a subset of completion scripts. Zbyszek ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] shell-completion: fix zsh completion installation
On Mon, Jul 29, 2013 at 04:07:31PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Jul 25, 2013 at 02:00:06PM -0500, William Giokas wrote: Moved zsh shell completion to shell-completion/zsh/_systemd for automake's sake. Also allow users to specify where the files should go with:: Makes sense, imho. Should we go one step further and split _systemd like the bash completions were split? This would have at least the advantage that people packaging a subset of systemd could package a subset of completion scripts. Sorry, replied off list first. Originally this was there just to have the make install put zsh completion files in the right place. I would be open to doing this, however there are quite a few shared functions between commands, and as I have been told, there isn't really a good way to source or store the shared functions. I'm still going to try, but I make no promises. Thanks, -- William Giokas | KaiSforza | http://kaictl.net/ GnuPG Key: 0x73CD09CF Fingerprint: F73F 50EF BBE2 9846 8306 E6B8 6902 06D8 73CD 09CF pgpxLMAg4adI5.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] shell-completion: fix zsh completion installation
On Mon, Jul 29, 2013 at 12:23:54PM -0500, William Giokas wrote: On Mon, Jul 29, 2013 at 04:07:31PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Jul 25, 2013 at 02:00:06PM -0500, William Giokas wrote: Moved zsh shell completion to shell-completion/zsh/_systemd for automake's sake. Also allow users to specify where the files should go with:: Makes sense, imho. Should we go one step further and split _systemd like the bash completions were split? This would have at least the advantage that people packaging a subset of systemd could package a subset of completion scripts. Sorry, replied off list first. Originally this was there just to have the make install put zsh completion files in the right place. I would be open to doing this, however there are quite a few shared functions between commands, and as I have been told, there isn't really a good way to source or store the shared functions. I'm still going to try, but I make no promises. I take back what I just said. All that really stands out is the -H completion, and that is just a few lines that I don't feel bad about having in all of the files. Currently I have 13 different files:: _hostnamectl _journalctl _localectl _loginctl _machinectl _systemctl _systemd _systemd-analyze _systemd-coredumpctl _systemd-inhibit _systemd-nspawn _timedatectl _udevadm with _systemd being the kind of 'fallback' option, containing the systemd commands that are less complex, and don't require as much in the way of functions (most simply use 'flag:desc:(a b c)' or some such). Thanks, -- William Giokas | KaiSforza | http://kaictl.net/ GnuPG Key: 0x73CD09CF Fingerprint: F73F 50EF BBE2 9846 8306 E6B8 6902 06D8 73CD 09CF pgpANqVtnodp6.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] shell-completion: fix zsh completion installation
On Mon, Jul 29, 2013 at 04:07:31PM +0200, Zbigniew Jędrzejewski-Szmek wrote: On Thu, Jul 25, 2013 at 02:00:06PM -0500, William Giokas wrote: Moved zsh shell completion to shell-completion/zsh/_systemd for automake's sake. Also allow users to specify where the files should go with:: Makes sense, imho. Should we go one step further and split _systemd like the bash completions were split? This would have at least the advantage that people packaging a subset of systemd could package a subset of completion scripts. Please refer to the git pull request I sent in: http://lists.freedesktop.org/archives/systemd-devel/2013-July/012387.html -- William Giokas | KaiSforza | http://kaictl.net/ GnuPG Key: 0x73CD09CF Fingerprint: F73F 50EF BBE2 9846 8306 E6B8 6902 06D8 73CD 09CF pgpUbx2qKr1PC.pgp Description: PGP signature ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] shell-completion: fix zsh completion installation
On 7-26-13 00:41:11 Michael Biebl wrote: 2013/7/25 William Giokas 1007...@gmail.com: Moved zsh shell completion to shell-completion/zsh/_systemd for automake's sake. Also allow users to specify where the files should go with:: ./configure --with-zshcompletiondir=/path/to/some/where and by default going to `$datadir/zsh/site-functions` I was told [1], the directory for 3rd party packages would be /usr/share/zsh/vendor-completions. But I'm not a zsh user, so I'm just paroting what I read there. If it's any help, I am a zsh user and Fedora 19 has this file installed on my system: /usr/share/zsh/5.0.2/functions/_systemd My /usr/share/zsh/site-functions directory is empty. -- Garry T. Williams ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] shell-completion: fix zsh completion installation
On Sat, Jul 27, 2013 at 5:30 PM, Garry T. Williams gtwilli...@gmail.comwrote: On 7-26-13 00:41:11 Michael Biebl wrote: 2013/7/25 William Giokas 1007...@gmail.com: Moved zsh shell completion to shell-completion/zsh/_systemd for automake's sake. Also allow users to specify where the files should go with:: ./configure --with-zshcompletiondir=/path/to/some/where and by default going to `$datadir/zsh/site-functions` I was told [1], the directory for 3rd party packages would be /usr/share/zsh/vendor-completions. But I'm not a zsh user, so I'm just paroting what I read there. If it's any help, I am a zsh user and Fedora 19 has this file installed on my system: /usr/share/zsh/5.0.2/functions/_systemd My /usr/share/zsh/site-functions directory is empty. -- Garry T. Williams ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel That version is the old systemd completion that is still in the last zsh release, from before I moved it to the systemd repository and added a most of the other commands and options -- Daniel Wallace ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] shell-completion: fix zsh completion installation
2013/7/25 William Giokas 1007...@gmail.com: Moved zsh shell completion to shell-completion/zsh/_systemd for automake's sake. Also allow users to specify where the files should go with:: ./configure --with-zshcompletiondir=/path/to/some/where and by default going to `$datadir/zsh/site-functions` I was told [1], the directory for 3rd party packages would be /usr/share/zsh/vendor-completions. But I'm not a zsh user, so I'm just paroting what I read there. Michael [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717540#15 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
