Re: [Tails-dev] Adding "look at test suite results" to our reviewing guidelines

2016-11-27 Thread intrigeri
anonym: > +1. Done in 14958e2. ___ Tails-dev mailing list Tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] Adding "look at test suite results" to our reviewing guidelines

2016-11-12 Thread anonym
intrigeri: > anonym: >> IMHO those of us with access to jenkins should also make sure to >> check the tests before asking for a review. Clearly I failed at that >> this time (but I have done it at other times, so it was just a slip!), >> so the blame is on me, really! :S > > Feel free to add this

Re: [Tails-dev] Adding "look at test suite results" to our reviewing guidelines

2016-11-11 Thread intrigeri
anonym: > IMHO those of us with access to jenkins should also make sure to > check the tests before asking for a review. Clearly I failed at that > this time (but I have done it at other times, so it was just a slip!), > so the blame is on me, really! :S Feel free to add this to our branch

Re: [Tails-dev] Adding "look at test suite results" to our reviewing guidelines

2016-11-11 Thread anonym
intrigeri: > Hi! > > Recently a branch was merged, that introduced a regression in our test > suite, which Jenkins was able to spot. But for some reason, we noticed > that regression only *after* the branch was merged into stable & devel. > > I think that one of the key features of our test

[Tails-dev] Adding "look at test suite results" to our reviewing guidelines

2016-11-11 Thread intrigeri
Hi! Recently a branch was merged, that introduced a regression in our test suite, which Jenkins was able to spot. But for some reason, we noticed that regression only *after* the branch was merged into stable & devel. I think that one of the key features of our test suite, by design [1], is to