Re: [Tails-dev] Please test pre-commit hook for po files

[u]

Hi!

sajolida:
> u:
>> Upon a technical remark, I moved the pre-commit file to
>> bin/pre-commit-translation instead. See updated instructions below.
>>
>> git fetch tails translation_platform_hooks
>> git submodule update --init
>> cd .git/hooks
>> ln -s ../../bin/pre-commit-translation pre-commit
> 
> Doing only `git fetch` doesn't change my checkout and nor creates
> ../../bin/pre-commit-translation locally.

Indeed!

> So instead I did:
> 
>   git checkout -t origin/translation_platform_hooks
>   git submodule update --init
>   cd .git/hooks
>   ln -s ../../bin/pre-commit-translation pre-commit

Thanks for the updated version of the instructions.

> Then I did a dummy change to index.es.po and tried to commit it.
> 
> I got the following:
> 
>   Project-Id-Version header is not empty for following files:
>   wiki/src/index.es.po
> 
>   The po files you're trying to commit contain errors. Please fix them 
> and try again.
> 
> Which make me believe that you didn't run your new PO file validator on all 
> the current PO files.

Absolutely, as said in my email, we did not do that yet and we'll do it
once people have tested it and we are ready to merge. At least that was
the initial plan.

> If you're adding validity checks to our current PO files it would be nice to 
> also make them comply
> with them, otherwise:
> 
> - Translators (and mergers) will have to fix them one by one

So, would you suggest we do that on master right now? Or should we
instead wait for more comments before making such a modification?

> - Ikiwiki on the production server might not be able to do the automatic 
> "Update PO files"

ikiwiki on the production server is currently not impacted by this hook
and we are aware that we will have to fix this, but it'll happen at a
later stage.

> I'm also curious about what `git submodule update --init` does. Are you using 
> submodules for that?
> I'm asking out of curiosity because I don't know much about submodules but I 
> couldn't find spot what
> is specific to your work under .git/modules/submodules.

check_po.sh lives in a submodule and we have updated this script in a
branch of the same name. So people need to update - at least in case
they've never checked out the repository. I'm not 100% sure it's needed
in the case you have checked out the submodules, but I've put it in the
instructions to be sure.

Cheers!
u.
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

[Tails-dev] Functions request

[AlfaOmega33]

Hi. I would like to ask if, beyond Tor and I2P, is possible add an ability to 
work with GNUnet services or others, and, if yes, how to do. If this function 
is not available, I would like to ask you to create it. Please! --- It would be 
useful to start, as a menu or profile, to choose the anonymous network to use.. 
think about it, please!___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] Please test pre-commit hook for po files

[u]

Hi!

intrigeri:
> u:
>> intrigeri:
>>> u:
   ln -s ../../wiki/src/contribute/l10n_tricks/pre-commit .
>>>
>>> This caught my eye before I could test this.
>>>
>>> I'd rather not ask all Tails contributors to run code, on every
>>> commit, that lives in a section of our website that's publicly
>>> writable. Please consider moving this script to bin/ :)
> 
>> With a notion of 'public' that allows only some people to write here, right?

>  - I believe that the only thing that prevent ikiwiki.cgi from
>allowing anyone with an Internet connection to edit arbitrary files
>under wiki/src/ is our lockedit plugin configuration.
>There's already been security issues in this part of the ikiwiki
>code so I'd rather not rely on it when we can cheaply avoid it.

Oops. I was not aware of that.
> So yeah, in theory, assuming no software bugs, it's safe to put such
> code under wiki/src/; but it increases attack surface a fair bit, with
> no substantial benefit I can think of, so let's err on the safe side,
> as you did already, thanks!

If there's a place for such scripts, let's put them there :)

> Now, this hook runs wiki/src/contribute/l10n_tricks/check_po.sh so the
> problem I'm describing above is still there. This could not fixed in
> pre-commit hook by calling submodules/jenkins-tools/slaves/check_po
> directly instead of going through the symlink.

Agreed. I'll modify this, this will be transparent for the testers.

Cheers!
u.
___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.

Re: [Tails-dev] Tails on MacBook?

[Marco Betschart]

Hi Intrigeri,

Thanks for your feedback. I understand the situation and your proposed steps 
are absolutely legitimate from a Tails angle.
What would be the best approach for provide you a patch? I’ve seen 
https://tails.boum.org/contribute/how/code 


But since I only own my MacBook 12“ I’m not quite sure if it is fast enough to 
build the whole project and how I would ensure everything is working correctly 
afterwards?

Cheers,
  Marco


> Am 29.05.2018 um 20:08 schrieb intrigeri :
> 
> Hi Marco,
> 
> Marco Betschart:
>> I wanted to boot Tails on my MacBook 12“ from 2015, but the keyboard as well 
>> as the trackpad do not work at all.
>> Seems like this is a known issue and there is a driver available which 
>> should help out:
>> https://mknowles.com.au/wordpress/2017/11/02/installing-fedora-27-on-a-2017-macbook-12-retina-macbook-101/
>> 
> 
>> Are there any plans for adding this to the official Tails?
> 
> This driver is marked "WIP" (work in progress) and as far as I know
> it's not been submitted for inclusion into the Linux kernel yet.
> The list of known issues on
> https://github.com/cb22/macbook12-spi-driver is not exactly confidence
> inspiring. So it's not available in Debian and thus not in Tails yet.
> Once the authors of this driver deem it ready for prime time, it'll
> propagate to Debian and then to Tails.
> 
> In the meantime, the amount of work required to go out of our way and
> include this third-party driver does not fit into our
> current resources. But assuming it's Free Software and builds
> reproducibly, I think we would happily consider a good patch that
> implements this :)
> 
> Cheers,
> -- 
> intrigeri

___
Tails-dev mailing list
Tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
To unsubscribe from this list, send an empty email to 
tails-dev-unsubscr...@boum.org.