Re: fdisk geom fixes

2011-07-04 Thread Kenneth R Westerback
On Tue, Jul 05, 2011 at 12:28:38AM -0430, Andres Perera wrote: > On Mon, Jul 4, 2011 at 11:32 PM, Kenneth R Westerback > wrote: > > On Mon, Jul 04, 2011 at 09:38:37PM -0430, Andres Perera wrote: > >> On Mon, Jul 4, 2011 at 8:56 PM, Kenneth R Westerback > >> wrote: > >> > The use of CHS should be

Re: thou shalt not call hardclock() with biglock held.

2011-07-04 Thread Artur Grabowski
this diff doesn't apply > diff --git a/arch/amd64/isa/clock.c b/arch/amd64/isa/clock.c > index 23fc0f0..1b4ff7c 100644 > --- a/arch/amd64/isa/clock.c > +++ b/arch/amd64/isa/clock.c

rfc3021, aka /31s on broadcast interfaces

2011-07-04 Thread David Gwynne
ola, i recently had a chance to deploy an openbsd box in a predominantly cisco shop to offload NAT from an aging 7200 router. it would have gone well except they'd allocated me /31 networks on ethernet ports for us to talk with. /31s currently dont work well because of how the kernel handles broad

Re: fdisk geom fixes

2011-07-04 Thread Andres Perera
On Mon, Jul 4, 2011 at 11:32 PM, Kenneth R Westerback wrote: > On Mon, Jul 04, 2011 at 09:38:37PM -0430, Andres Perera wrote: >> On Mon, Jul 4, 2011 at 8:56 PM, Kenneth R Westerback >> wrote: >> > The use of CHS should be hard and attempted only by >> > those who know all the rules already. >> >>

Re: Better buf validation in bounds_check_with_label()

2011-07-04 Thread Matthew Dempsky
On Mon, Jul 04, 2011 at 05:11:35PM -0700, Matthew Dempsky wrote: > Once this goes in, I'll start updating the xxstrategy() methods to > remove these redundant checks. And here's my promised followup diff. The convention now in xxstrategy() functions is that the 'bad' label sets B_ERROR and sets b

Re: rtadvd diff to fix route msg handling

2011-07-04 Thread Claudio Jeker
Where are all the IPv6 zealots hiding? -- :wq Claudio On Mon, Jul 04, 2011 at 07:57:01AM +0200, Claudio Jeker wrote: > Doing (ifam + 1) to find the start of the sockaddrs in a rt msg is wrong > better use the rtm_hdrlen field. > > I only compile tested this since I have nothing that uses the IP

Re: Better buf validation in bounds_check_with_label()

2011-07-04 Thread Matthew Dempsky
On Mon, Jul 4, 2011 at 7:55 PM, Kenneth R Westerback wrote: > I like this a *lot*. My only question is why the whitespace before bad: and > done:? ok krw@ I think it's more useful for "diff -p" to show the function name, not the most recent label, but I don't feel strongly about it.

Re: fdisk geom fixes

2011-07-04 Thread Andres Perera
On Mon, Jul 4, 2011 at 8:56 PM, Kenneth R Westerback wrote: > The use of CHS should be hard and attempted only by > those who know all the rules already. which is made difficult by not being able to select a subset of cyls, since fdisk caps them at 1024 on amd64 note that geom was, and continues

Re: Better buf validation in bounds_check_with_label()

2011-07-04 Thread Kenneth R Westerback
On Mon, Jul 04, 2011 at 05:11:35PM -0700, Matthew Dempsky wrote: > A bunch of disk drivers currently check whether a buf request is > sector-aligned (e.g., vnd(4)) or that a request is for a multiple of > secsize (e.g., sd(4)), but none of them check both. > > Instead of doing this in each disk dr

Re: fdisk geom fixes

2011-07-04 Thread Kenneth R Westerback
On Mon, Jul 04, 2011 at 07:59:41PM -0430, Andres Perera wrote: > On Mon, Jul 4, 2011 at 7:31 PM, Kenneth R Westerback > wrote: > > On Mon, Jul 04, 2011 at 02:26:42PM -0700, andre...@zoho.com wrote: > >> cmd.c: > >> > >> x86* maxhead should be 255, not 256 > >> > >> make geom less useless by using

Re: fdisk geom fixes

2011-07-04 Thread Andres Perera
On Mon, Jul 4, 2011 at 7:31 PM, Kenneth R Westerback wrote: > On Mon, Jul 04, 2011 at 02:26:42PM -0700, andre...@zoho.com wrote: >> cmd.c: >> >> x86* maxhead should be 255, not 256 >> >> make geom less useless by using disklabel for cyl, if available > > geom is useless, period. Making it easier w

Better buf validation in bounds_check_with_label()

2011-07-04 Thread Matthew Dempsky
A bunch of disk drivers currently check whether a buf request is sector-aligned (e.g., vnd(4)) or that a request is for a multiple of secsize (e.g., sd(4)), but none of them check both. Instead of doing this in each disk driver, the logical place to validate this is in bounds_check_with_label().

Re: fdisk geom fixes

2011-07-04 Thread Kenneth R Westerback
On Mon, Jul 04, 2011 at 02:26:42PM -0700, andre...@zoho.com wrote: > cmd.c: > > x86* maxhead should be 255, not 256 > > make geom less useless by using disklabel for cyl, if available geom is useless, period. Making it easier will only encourage people to use it. > > part.c: > > x86* maxhead

small fix in ehci

2011-07-04 Thread Eric Faurot
actually read the register from the right place, and simplify code a bit. Index: ehci.c === RCS file: /cvs/src/sys/dev/usb/ehci.c,v retrieving revision 1.117 diff -u -r1.117 ehci.c --- ehci.c 3 Jul 2011 15:47:17 - 1.117

termtypes moar faster

2011-07-04 Thread Nicholas Marriott
A little crude, but this knocks 30-50% off the build time for termtypes/ on my boxes... Index: Makefile === RCS file: /cvs/src/share/termtypes/Makefile,v retrieving revision 1.18 diff -u -p -r1.18 Makefile --- Makefile4 Jul 2011

Re: BSD Authentication for popa3d(8)

2011-07-04 Thread Nils Anspach
Hello, Nicholas Marriott schrieb am 02.07.2011 um 23:11:49 +0100: > Hi > > I don't think you need to strsep out the style yourself, a NULL style to > auth_userokay will look for it after a : itself. > > Otherwise this reads fine to me. > > > On Mon, Jun 27, 2011 at 07:30:53PM +0200, Nils Anspa

Re: tcp keepalives

2011-07-04 Thread Stuart Henderson
On 2011/07/04 22:44, Claudio Jeker wrote: > But this is correct since because of the reception of a TCP keepalive > response we do not consider the TCP session idle anymore Ah, this is what I was missing. > and keepintvl > comes only into play when the other side does not respond. > At least that

fdisk geom fixes

2011-07-04 Thread andres . p
cmd.c: x86* maxhead should be 255, not 256 make geom less useless by using disklabel for cyl, if available part.c: x86* maxhead should be 254, not 255 (other arches?) maxcyl gets set to 1023 before this function gets called, so it's a redundant check Index: src/sbin/fdisk/cmd.c ==

nuke map3270

2011-07-04 Thread Nicholas Marriott
This brave individual escaped the tn3270 purge for over 9 months. ok? Index: Makefile === RCS file: /cvs/src/share/termtypes/Makefile,v retrieving revision 1.17 diff -u -p -r1.17 Makefile --- Makefile14 Oct 2009 19:52:23 -

Big Sectors: disklabel, amd64 label writes vs readdoslabel, i386/amd64 installboot

2011-07-04 Thread Kenneth R Westerback
We should not allow disklabel to 'hint' that an ffs filesystem can have a fragment size less than the disk's sector size. amd64 should write the disklabel at the same spot that readdoslabel() reads it no matter what the sector size is. amd64/i386 installboot should provide the correct shift value

Re: tcp keepalives

2011-07-04 Thread Claudio Jeker
On Mon, Jul 04, 2011 at 09:01:12PM +0100, Stuart Henderson wrote: > On 2011/07/04 19:02, Claudio Jeker wrote: > > On Mon, Jul 04, 2011 at 12:32:51PM -0400, David Hill wrote: > > > On Mon, Jul 04, 2011 at 09:47:36AM +0100, Stuart Henderson wrote: > > > :let's try again with this. regenerated diffs b

Re: tcp keepalives

2011-07-04 Thread Stuart Henderson
On 2011/07/04 19:02, Claudio Jeker wrote: > On Mon, Jul 04, 2011 at 12:32:51PM -0400, David Hill wrote: > > On Mon, Jul 04, 2011 at 09:47:36AM +0100, Stuart Henderson wrote: > > :let's try again with this. regenerated diffs because the only > > :complaints were about whitespace issues, no real chan

Re: svlan taghash

2011-07-04 Thread Camiel Dobbelaar
On Mon, 4 Jul 2011, Camiel Dobbelaar wrote: > When svlan(4) was introduced, it got its own taghash in if_vlan.c. > This wasn't necessary as "etype" was already checked in the old hash > lookup. Hmmm, etype wasn't checked in rev 1.83 so it looks like my memory is shady... I also see a comment abo

thou shalt not call hardclock() with biglock held.

2011-07-04 Thread Owain Ainsworth
i386 is a very naughty arch. While messing with this code make i386 and amd64 more identical. guenther@ tested this on an mp i386 for me yesterday, the machine seemed happy. Cheers, -0- diff --git a/arch/amd64/isa/clock.c b/arch/amd64/isa/clock.c index 23fc0f0..1b4ff7c 100644 --- a/arch/amd64/

msync retardery

2011-07-04 Thread Owain Ainsworth
So, the msync implementation in uvm says this: /* * XXXCDC: do we really need this semantic? * * XXX Gak! If size is zero we are supposed to sync "all modified * pages with the region containing addr". Unfortunately, we * don't really keep track

svlan taghash

2011-07-04 Thread Camiel Dobbelaar
When svlan(4) was introduced, it got its own taghash in if_vlan.c. This wasn't necessary as "etype" was already checked in the old hash lookup. So simplify the code again, and use the savings for some extra hash buckets. :-) Survives this stacked test between i386 and sparc64 (use .1 on one sys

SOCK_SEQPACKET support for UNIX sockets

2011-07-04 Thread Matthew Dempsky
Diff below adds SOCK_SEQPACKET support to UNIX sockets. Just like SOCK_STREAM but with record boundaries like SOCK_DGRAM. Lightly tested that SOCK_SEQPACKET sockets appear to work as expected. Feedback/testing suggestions/ok? Index: uipc_proto.c

Re: Testers needed for ahc(4) diff

2011-07-04 Thread Brett
On 07/04/11 09:59, Henning Brauer wrote: looks like you did everything right, except trhat you don't actually have an ahc controller :) Yes, Theo pointed that out within about 10 seconds of my posting the dmesg. My brain got muddled between ahc and ahci.

Re: tcp keepalives

2011-07-04 Thread Henning Brauer
* Claudio Jeker [2011-07-04 19:05]: > On Mon, Jul 04, 2011 at 12:32:51PM -0400, David Hill wrote: > > On Mon, Jul 04, 2011 at 09:47:36AM +0100, Stuart Henderson wrote: > > :let's try again with this. regenerated diffs because the only > > :complaints were about whitespace issues, no real changes c

Re: lo(4): send RTM_IFINFO when adding if

2011-07-04 Thread Henning Brauer
* Claudio Jeker [2011-07-04 18:43]: > On Mon, Jul 04, 2011 at 09:38:24AM +0100, Stuart Henderson wrote: > > ospfd doesn't pick up an lo(4) added while it's running unless you > > manually ifconfig down+up. > > > > this does the same dance as if_gif.c to ensure RTM_IFINFO gets sent. > > > > ok? >

Re: tcp keepalives

2011-07-04 Thread Claudio Jeker
On Mon, Jul 04, 2011 at 12:32:51PM -0400, David Hill wrote: > On Mon, Jul 04, 2011 at 09:47:36AM +0100, Stuart Henderson wrote: > :let's try again with this. regenerated diffs because the only > :complaints were about whitespace issues, no real changes compared > :to the diffs I sent out previously

specfs kqfilter

2011-07-04 Thread Nicholas Marriott
Don't know how I missed this one... ok? Index: miscfs/specfs/spec_vnops.c === RCS file: /cvs/src/sys/miscfs/specfs/spec_vnops.c,v retrieving revision 1.64 diff -u -p -r1.64 spec_vnops.c --- miscfs/specfs/spec_vnops.c 4 Jul 2011 16:5

Re: lo(4): send RTM_IFINFO when adding if

2011-07-04 Thread Claudio Jeker
On Mon, Jul 04, 2011 at 09:38:24AM +0100, Stuart Henderson wrote: > ospfd doesn't pick up an lo(4) added while it's running unless you > manually ifconfig down+up. > > this does the same dance as if_gif.c to ensure RTM_IFINFO gets sent. > > ok? OK claudio@ I'm wondering if we have other drivers

nix D_KQFILTER

2011-07-04 Thread Nicholas Marriott
We can tell if there is a d_kqfilter function because, well, it is there and not NULL. So D_KQFILTER appears to be useless. Comments/ok? Index: arch/amd64/include/conf.h === RCS file: /cvs/src/sys/arch/amd64/include/conf.h,v retriev

Re: tcp keepalives

2011-07-04 Thread David Hill
On Mon, Jul 04, 2011 at 09:47:36AM +0100, Stuart Henderson wrote: :let's try again with this. regenerated diffs because the only :complaints were about whitespace issues, no real changes compared :to the diffs I sent out previously. : :- add sysctl net.inet.tcp.always_keepalive to act as if :SO_KEE

Re: Minor fixes for bs(6) manual

2011-07-04 Thread Jason McIntyre
On Mon, Jul 04, 2011 at 05:01:39PM +0300, Arto Jonsson wrote: > Hi, > > some minor fixes in bs(6) manual: > > - use `Ds' for indentation this might be worth fixing as part of a larger commit, but not on its own (see below...) > - re-order the arguments list so its order matches SYNOPSIS > no.

Minor fixes for bs(6) manual

2011-07-04 Thread Arto Jonsson
Hi, some minor fixes in bs(6) manual: - use `Ds' for indentation - re-order the arguments list so its order matches SYNOPSIS Index: games/bs/bs.6 === RCS file: /cvs/src/games/bs/bs.6,v retrieving revision 1.13 diff -u -r1.13 bs.6 -

Dire Straits y Mark Knopfler - Discografia mas pendrive de regalo

2011-07-04 Thread Discos MP3 - Solo de Oferta
DIRE STRAITS Dire Straits / Leeds / Live In Rotterdam/ Making Movies / Love Over Gold / Extended DancePlay / Alchemy / Brothers In Arms / Dire Straits& Eric Clapton - So

Re: USB keyboard in boot_config(8)

2011-07-04 Thread Olivier A.
On 01/07/2011 10:06, Christopher Zimmermann wrote: > I just installed the June 29 snapshot and noticed that my USB keyboard > no longer works in the boot_config(8) prompt. It still did work in the > June 24 snapshot. pckbd(4) works fine. Hi, Similar problem here with 'boot -a' and a USB keyboard o

tcp keepalives

2011-07-04 Thread Stuart Henderson
let's try again with this. regenerated diffs because the only complaints were about whitespace issues, no real changes compared to the diffs I sent out previously. - add sysctl net.inet.tcp.always_keepalive to act as if SO_KEEPALIVE was set on all TCP connections. - fix old bug where net.inet.tcp

lo(4): send RTM_IFINFO when adding if

2011-07-04 Thread Stuart Henderson
ospfd doesn't pick up an lo(4) added while it's running unless you manually ifconfig down+up. this does the same dance as if_gif.c to ensure RTM_IFINFO gets sent. ok? Index: if_loop.c === RCS file: /cvs/src/sys/net/if_loop.c,v retr

Userland ppp stopped working between Mar24 and Apr8

2011-07-04 Thread Scott McEachern
(I've been advised to send this to tech@, so here goes..) I originally sent this message to misc@ on April 17/2011, but I never got a response and I can't find it in the archives. (I found this copy in my sent mail). I guess it never went through. Since I never heard anything back, I figur