Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Claudio Jeker
On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: What about using a more generic name which is not bound to 80211 since the field is a generic pointer. This may allow us to use something similar in other drivers like mpe(4), gif(4), gre(4). That is basically the only thought

bgpctl show_attr bad length fix

2014-03-18 Thread rivo nurges
Hi! When show_attr reads data length from provided data it reads carbage to alen and fails afterwards. This patch fixes the problem by casting the data to u_char. While at it I noticed data gets assigned twice. bgpctl.c: /* bad imsg len how can that happen!? */ bgpctl.c: if (alen len)

fix for fs tests

2014-03-18 Thread Sergey Bronnikov
Somehow fstests from src/regress were broken. Patch fix creation of temporary files and add mark test target as required root permissions. Ok? Was: 3053 tests completed, 2738 failed. Now: 3053 tests completed, 275 failed. Another failes connected to abcense of syscalls (lchflags), abcense of

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Mike Belopuhov
On 18 March 2014 07:20, Claudio Jeker cje...@diehard.n-r-g.com wrote: On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: What about using a more generic name which is not bound to 80211 since the field is a generic pointer. This may allow us to use something similar in other

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Martin Pieuchot
On 18/03/14(Tue) 11:26, Mike Belopuhov wrote: On 18 March 2014 07:20, Claudio Jeker cje...@diehard.n-r-g.com wrote: On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: What about using a more generic name which is not bound to 80211 since the field is a generic pointer.

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Claudio Jeker
On Tue, Mar 18, 2014 at 12:28:41PM +0100, Martin Pieuchot wrote: On 18/03/14(Tue) 11:26, Mike Belopuhov wrote: On 18 March 2014 07:20, Claudio Jeker cje...@diehard.n-r-g.com wrote: On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: What about using a more generic name which

Re: bgpctl show_attr bad length fix

2014-03-18 Thread Stuart Henderson
On 2014/03/18 08:57, rivo nurges wrote: Hi! When show_attr reads data length from provided data it reads carbage to alen and fails afterwards. This patch fixes the problem by casting the data to u_char. While at it I noticed data gets assigned twice. bgpctl.c: /* bad imsg len how can

Re: bgpctl show_attr bad length fix

2014-03-18 Thread Florian Obser
Commited, thanks On Tue, Mar 18, 2014 at 08:57:40AM +, rivo nurges wrote: Hi! When show_attr reads data length from provided data it reads carbage to alen and fails afterwards. This patch fixes the problem by casting the data to u_char. While at it I noticed data gets assigned twice.

Re: USB install image for OpenBSD 5.5 - TESTING REQUIRED

2014-03-18 Thread sven falempin
Some issue here, using install55.fs (today 18/3/2014 downloaded snaps) boot is ok (warn: entropy file missing) but /dev has no /dev/sd1 (is the usb key) and so i cannot look for the sets . I did MAKEDEV all so i can mount keys to get the dmesg. currently outputing dmesg on usb3 key, the

Re: USB install image for OpenBSD 5.5 - TESTING REQUIRED

2014-03-18 Thread Chris Cappuccio
sven falempin [sven.falem...@gmail.com] wrote: Some issue here, using install55.fs (today 18/3/2014 downloaded snaps) boot is ok (warn: entropy file missing) but /dev has no /dev/sd1 (is the usb key) and so i cannot look for the sets . I did MAKEDEV all so i can mount keys to get the

Re: USB install image for OpenBSD 5.5 - TESTING REQUIRED

2014-03-18 Thread sven falempin
On Tue, Mar 18, 2014 at 12:39 PM, Chris Cappuccio ch...@nmedia.net wrote: sven falempin [sven.falem...@gmail.com] wrote: Some issue here, using install55.fs (today 18/3/2014 downloaded snaps) boot is ok (warn: entropy file missing) but /dev has no /dev/sd1 (is the usb key) and so i