Re: Make sysctl_file more smp friendly

2015-05-12 Thread Philip Guenther
Vitaliy, As I told you directly last week, proposing changes in anticipation of future work requires some sort of plan about that future work. Without some sort of model for locking the access paths, it's impossible to judge whether the proposed change is useful or pointless. On Fri, 8 May

Re: [patch] Relayd crash

2015-05-12 Thread Bertrand PROVOST
Apparently Google remove tabulations when I copy/paste the patch. Please download attachment to gets patch with tabulations. -- Bertrand PROVOST Index: http.h === RCS file: /cvs/src/usr.sbin/relayd/http.h,v retrieving revision 1.5

use device.h in midi(4)

2015-05-12 Thread Alexandre Ratchov
This is to use device_lookup() instead of digging into midi_cd.cd_devs[] and maintaining a dying flag which is already present in the device structure. As a side-effect, this adds the missing refcounting that mididetach() was missing. The diff is a mostly mechanical change, except for the

[patch] Relayd crash

2015-05-12 Thread Bertrand PROVOST
Hi, I found a crash in relayd when using http relay. `bev` pointer is used after a free in `relay_http.c` lines: 438, 492 and 609 In `relay_http.c` there is 3 functions, used as read callback for libevent buffer: * `relay_read_http`: parse http headers * `relay_read_httpcontent`: parse simple

Re: GSoC project: KMS driver for Cirrus Logic graphics

2015-05-12 Thread Léo Grange
2015-05-11 4:59 GMT+02:00 Damien Miller d...@mindrot.org: Possibly dumb question: why the Cirrus CLGD 5446? It doesn't seem like a very common chipset. Is the goal of the project to have a model KMS driver and documentation that can serve as a guide? Or a KMS driver that works well in a

Re: UPD regression with

2015-05-12 Thread David Higgs
On May 11, 2015, at 9:02 PM, David Higgs hig...@gmail.com wrote: On May 11, 2015, at 8:21 PM, David Higgs hig...@gmail.com mailto:hig...@gmail.com wrote: On Mon, May 11, 2015 at 8:07 PM, Alexander Hall alexan...@beard.se mailto:alexan...@beard.sewrote: Upgrading to the latest snapshot,

Take vlan(4) out of ether_input()

2015-05-12 Thread Martin Pieuchot
Diff below convert vlan(4) to the new if_input() framework which means that vlan_input() will now be executed before ether_input(). Compared to trunk(4) multiple vlan(4)s can be attached to the same parent interface. When such thing happens only one input handler is added to keep the if_inputs

[patch] urtwn(4) 8188eu additions

2015-05-12 Thread Mikhail
Hello, inlined patch is a compilation of fixes which were pushed into FreeBSD tree after 8188eu driver came in. It adds four new usbdevs (r270191, r273589, r282120), fixes efuse length and replaces magic numbers with proper defines (r281918), fixes efuse access (r281592, r282623), and fixes man

Re: Introducing if_output()

2015-05-12 Thread Martin Pieuchot
On 07/05/15(Thu) 11:50, Martin Pieuchot wrote: This diff is a first step towards removing all pseudo-driver #ifdef in ether_output(). As for ether_input() the goal of this work is to provide an elegant design to make it easier to turn pseudo-drivers MP-safe. So instead of including some

Re: [patch] urtwn(4) 8188eu additions

2015-05-12 Thread Stuart Henderson
On 2015/05/12 16:35, Mikhail wrote: Hello, inlined patch is a compilation of fixes which were pushed into FreeBSD tree after 8188eu driver came in. It adds four new usbdevs (r270191, r273589, r282120), fixes efuse length and replaces magic numbers with proper defines (r281918), fixes efuse

Kill NTRUNK

2015-05-12 Thread Martin Pieuchot
There's only one #if NTRUNK left in the tree, this diff gets rid of it by overwriting trunk ports' if_output(). ok? Index: net/if_ethersubr.c === RCS file: /cvs/src/sys/net/if_ethersubr.c,v retrieving revision 1.196 diff -u -p

Re: Introducing if_output()

2015-05-12 Thread Martin Pieuchot
On 12/05/15(Tue) 12:15, Martin Pieuchot wrote: On 07/05/15(Thu) 11:50, Martin Pieuchot wrote: This diff is a first step towards removing all pseudo-driver #ifdef in ether_output(). As for ether_input() the goal of this work is to provide an elegant design to make it easier to turn

Re: Brainy: Kernel Use-after-free Memory Leak in hifn

2015-05-12 Thread Mike Belopuhov
On Mon, May 11, 2015 at 22:11 +0200, Maxime Villard wrote: Hi, I put here two bugs among others: sys/dev/pci/hifn7751.c 2757 if (!(m0-m_flags M_EXT)) m_freem(m0); len = MCLBYTES; totlen -= len;

rework armv7 board name handling

2015-05-12 Thread Jonathan Gray
Instead of hard coding board names twice use an array and put the value in hw_prod so it will show up in sysctl. This omits setting hw_vendor as fdt sets just one string and we'll likely move to that at some point. The printf from before copyright changes to the decimal machine id/board id.

Re: [ping] dump -U by default

2015-05-12 Thread Manuel Giraud
Philip Guenther guent...@gmail.com writes: Can we suppress the device form if there's a matching DUID entry? Okay. The DUID/device dance is not that easy (at least for me). So here is a new patch that should work. For your issue, I choose to convert dumpdates entries to DUID (when possible) at

Re: Brainy: Kernel Use-after-free Memory Leak in hifn

2015-05-12 Thread sam
On Mon, 11 May 2015 22:11:10 +0200 Maxime Villard m...@m00nbsd.net wrote: Hi, I put here two bugs among others: sys/dev/pci/hifn7751.c 2757 if (!(m0-m_flags M_EXT)) m_freem(m0); len = MCLBYTES;

Re: Kill NTRUNK

2015-05-12 Thread Claudio Jeker
On Tue, May 12, 2015 at 01:34:20PM +0200, Martin Pieuchot wrote: There's only one #if NTRUNK left in the tree, this diff gets rid of it by overwriting trunk ports' if_output(). ok? Looks good to me. Lets try to layer stuff properly. OK claudio@ Index: net/if_ethersubr.c