Re: pflow(4) percpu counters

Florian Obser writes: > On Sat, Feb 18, 2017 at 06:06:01PM +0100, Jeremie Courreges-Anglas wrote: >> >> This one is a bit weird, the driver doesn't just increment the stats but >> also uses them at runtime, hence the additional helper functions. > > I'm wondering if we

Re: npppd: reload enables stripping NT domains on radius

On Tue, Feb 21, 2017 at 02:11:05PM +0900, YASUOKA Masahiko wrote: > Hi, > > On Mon, 20 Feb 2017 11:38:19 +0100 > Patrick Wildt wrote: > > when using RADIUS, the NT domains should not be stripped from the > > username. > > I suppose it depends on the use-case. > >

Re: [PATCH] bc(1) should write error messages to standard error

On Tue, Feb 21, 2017 at 07:00:34AM +0100, Otto Moerbeek wrote: > On Tue, Feb 21, 2017 at 04:08:57AM +0100, Martijn Dekker wrote: > > > Upon encountering a parsing error, bc(1) passes an error message on to > > dc(1), which writes the error message to standard output along with the > > normal

set sc_vendor in bcm2835_dwctwo

Maybe one day these drivers will attach to a non-Broadcom dwc2 but for now they only match the Broadcom compat strings. -uhub0 at usb0 configuration 1 interface 0 "vendor 0x DWC2 root hub" rev 2.00/1.00 addr 1 +uhub0 at usb0 configuration 1 interface 0 "Broadcom DWC2 root hub" rev 2.00/1.00

Re: [PATCH] bc(1) should write error messages to standard error

On Tue, Feb 21, 2017 at 04:08:57AM +0100, Martijn Dekker wrote: > Upon encountering a parsing error, bc(1) passes an error message on to > dc(1), which writes the error message to standard output along with the > normal output. > > That is a bug. Error messages should go to standard error

Re: npppd: reload enables stripping NT domains on radius

Hi, On Mon, 20 Feb 2017 11:38:19 +0100 Patrick Wildt wrote: > when using RADIUS, the NT domains should not be stripped from the > username. I suppose it depends on the use-case. npppd.conf(5) mentions "strip-nt-domain" is "yes" by default and adding "strip-nt-domain no" in

[PATCH] honor proxy setting in pkg.conf

I have a number of OpenBSD instances in an isolated lab environment with access to the internet solely through a squid proxy. I'd like them to be able to install packages but I don't want to globally configure proxy environment variables because they also communicate with other systems that

Re: [PATCH] bc(1) should write error messages to standard error

Op 21-02-17 om 04:08 schreef Martijn Dekker: > bc() { > _bc_err=$(command -p bc "$@" 1>&3 2>&1) Correction, the redirections should be the other way around: _bc_err=$(command -p bc "$@" 2>&1 1>&3) Sorry about that, - M.

[PATCH] bc(1) should write error messages to standard error

Upon encountering a parsing error, bc(1) passes an error message on to dc(1), which writes the error message to standard output along with the normal output. That is a bug. Error messages should go to standard error instead, as POSIX specifies:

Re: asr: slightly better error reporting for getnameinfo()

On Mon, Feb 20, 2017 at 09:37:28PM +0100, Eric Faurot wrote: > Report the errno set by getifaddrs(3) if the setup for AI_ADDRCONFIG fails, > rather than a non-informative EAI_FAIL. Compare to -1 for error detection > while here. > > Eric. ok gilles@ > Index: asr/getaddrinfo_async.c >

ip6_ctloutput - check invalid level first

Hello - The *ctloutput functions all check for an invalid level first, except ip6_ctloutput. This diff makes ip6_ctloutput do the same. As a bonus, we save on indentation. No functional change. Index: netinet6/ip6_output.c ===

Re: don't attempt to build binutils 2.15 on arm64

Jonathan Gray schreef op 2017-02-19 03:16: binutils 2.15 is built for gdb. There is no support for arm64/aarch64 here and it doesn't build so don't try to. Manual pages depend on running configure which again doesn't know about aarch64. ok kettenis@ Index: Makefile.bsd-wrapper

Re: c99 initialize struct protosw

David Hill schreef op 2017-02-19 03:22: Hello - This moves the 'struct protosw' declarations to use C99 initializers. Requested by mpi@ With C99 initializers it is no longer necessary to explicitly initialize zero-initialized members (such as null-pointers). That could reduce the diff

Re: asr: slightly better error reporting for getnameinfo()

Eric Faurot writes: > Report the errno set by getifaddrs(3) if the setup for AI_ADDRCONFIG fails, > rather than a non-informative EAI_FAIL. Compare to -1 for error detection > while here. ok jca@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

asr: slightly better error reporting for getnameinfo()

Report the errno set by getifaddrs(3) if the setup for AI_ADDRCONFIG fails, rather than a non-informative EAI_FAIL. Compare to -1 for error detection while here. Eric. Index: asr/getaddrinfo_async.c === RCS file:

Re: pflow(4) percpu counters

On Sat, Feb 18, 2017 at 06:06:01PM +0100, Jeremie Courreges-Anglas wrote: > > This one is a bit weird, the driver doesn't just increment the stats but > also uses them at runtime, hence the additional helper functions. I'm wondering if we should just drop the reading. We have two cases, the init

Re: struct ipipstat: use 64 bits counters

On Mon, Feb 20, 2017 at 04:30:31PM +0100, Jeremie Courreges-Anglas wrote: > Jeremie Courreges-Anglas writes: > > > Using a mix of 32 and 64 bits counters leads to an ugly conversion to > > percpu counters. Why not move to 64 bits counters? struct ipipstat is > > afaik only

Re: inteldrm: setup backlight pwm alternate increment on backlight enable

On Fri, 10 Feb 2017 at 10:46:08 +0100, Peter Hessler wrote: > On 2017 Feb 10 (Fri) at 11:52:20 +1100 (+1100), Jonathan Gray wrote: > :On Thu, Feb 09, 2017 at 06:39:13PM -0600, joshua stein wrote: > :> I have no idea why there are chickens involved, but this fixes the > :> problem on at least the

Re: umb: aggregate packets on tx

On Mon, 12 Dec 2016 14:50:50 +0100 Gerhard Roth wrote: > The current umb(4) implementation needs one USB transfer for every packet > that is sent. With the following patch, we can now aggregate several > packets from the ifq into one single USB transfer. > > This may speed

Re: struct ipipstat: use 64 bits counters

Jeremie Courreges-Anglas writes: > Using a mix of 32 and 64 bits counters leads to an ugly conversion to > percpu counters. Why not move to 64 bits counters? struct ipipstat is > afaik only used by netstat and ports/shells/nsh (I can cook a fix for > the latter). > > ok? ping

[PATCH 5/7] ldpd: implement RFC 5919 (LDP End-of-LIB)

--- init.c | 67 +- labelmapping.c | 72 ++ lde.c | 40 lde.h | 3 +++ lde_lib.c | 43 +++

[PATCH 7/7] ldpd: send VPLS MAC withdrawals

RFC 4762 says that MAC address withdrawal messages can be used to improve convergence time in VPLS networks. This patch makes ldpd send MAC withdrawals whenever a non-pseudowire interface pertaining to a VPLS goes down. The processing of received MAC withdrawals will be implemented later (need to

[PATCH 6/7] ldpd: fix parsing of optional tlvs in address messages

We were aborting the session upon receipt of MAC Address Withdrawal messages. Now make the parser aware that optional TLVs are possible in address messages. --- address.c | 73 +++ 1 file changed, 59 insertions(+), 14 deletions(-) diff

[PATCH 3/7] ldpd: implement RFC 5918 (Typed Wildcard FEC)

--- init.c | 68 +++- labelmapping.c | 120 - lde.c | 14 +++ lde.h | 3 ++ lde_lib.c | 56 +++ ldp.h | 8 ldpd.8 | 9 +

[PATCH 4/7] ldpd: implement RFC 6667 (Typed Wildcard FEC for PWid)

--- l2vpn.c| 22 +- labelmapping.c | 23 +++ lde.c | 14 ++ lde.h | 2 ++ lde_lib.c | 7 +++ ldp.h | 3 +++ ldpd.8 | 9 + ldpd.h | 1 + logmsg.c | 8 9

[PATCH 2/7] ldpd: implement RFC 5561 (LDP Capabilities)

This patch per-se doesn't introduce any useful functionality, but prepares the ground for new enhancements to ldpd (i.e. implementation of new RFCs that make use of LDP capabilities). --- init.c | 152 +++-- labelmapping.c | 8 +--

[PATCH 1/7] ldpd: implement support for PWid group wildcards

This was missing from our original RFC 4447 VPLS implementation. Now ldpd understands group wildcards as mandated by the RFC, but we still don't send them ourselves. I can't see any case in which sending a group wildcard would be useful, but nonetheless this patch provides a function called

npppd: reload enables stripping NT domains on radius

Hi, when using RADIUS, the NT domains should not be stripped from the username. When a base object is instantiated based on an auth object, the "strip_nt_domain" variable is always enforced to zero in case of using RADIUS. The auth object itself though has it set to one by default. Now on

Re: ksh(1): fix $RANDOM documentation

Thanks for the feedback. The transcript of my reasoning in my previous email was too brief, sorry about that. After reading the man-page, I was surprised that grepping the ksh source for arc4random yielded nothing. But after reading the rand man-page its behavior and relation to arc4random became