Support for 8265 and maybe 3168 in iwm(4)

2017-04-03 Thread Claudio Jeker
Thanks to stsp@ I looked into adding support for 8265 and 3168 variants of iwm(4) this diff seems to work for me with a "Dual Band Wireless-AC 8265" card. You need to get the iwm-8265-22 and iwm-3168-22 firmware files yourself and put them in /etc/firmware the iwm firmware package will be updated

Another arm64 pmap.c cleanup

2017-04-03 Thread Mark Kettenis
So here is another big cleanup diff. It gets rid of the last C++ comments, removes some debug printfs that I don't consider useful anymore, gets rid of the STATIC and __inline defines and removes a bit more unused code. There are a few places where I reordered statements for consistency with

Re: shutdown(8): warn format string should be literal

2017-04-03 Thread Todd C. Miller
On Mon, 03 Apr 2017 22:21:10 +0200, Frederic Cambus wrote: > warn format string should be literal. OK millert@ Note that path can only be set to either _PATH_REBOOT or _PATH_HALT so there is no security issue, but the compiler doesn't know this. Changing the code helps eliminate false positives

shutdown(8): warn format string should be literal

2017-04-03 Thread Frederic Cambus
Hi tech@, warn format string should be literal. Comments? OK? Index: sbin/shutdown/shutdown.c === RCS file: /cvs/src/sbin/shutdown/shutdown.c,v retrieving revision 1.45 diff -u -p -r1.45 shutdown.c --- sbin/shutdown/shutdown.c1

Re: comsat: prefer pread() over lseek+read

2017-04-03 Thread Ted Unangst
Theo de Raadt wrote: > > > Philip Guenther wrote: > > > - nutmp = read(uf, utmp, statbf.st_size)/sizeof(struct utmp); > > > + nutmp = pread(uf, utmp, statbf.st_size, 0)/sizeof(struct utmp); > > > dsyslog(LOG_DEBUG, "read %d utmp entries", nutmp); > > > > I guess you're

Re: comsat: prefer pread() over lseek+read

2017-04-03 Thread Theo de Raadt
> Philip Guenther wrote: > > - nutmp = read(uf, utmp, statbf.st_size)/sizeof(struct utmp); > > + nutmp = pread(uf, utmp, statbf.st_size, 0)/sizeof(struct utmp); > > dsyslog(LOG_DEBUG, "read %d utmp entries", nutmp); > > I guess you're going to claim it was like

Re: comsat: prefer pread() over lseek+read

2017-04-03 Thread Ted Unangst
Philip Guenther wrote: > - nutmp = read(uf, utmp, statbf.st_size)/sizeof(struct utmp); > + nutmp = pread(uf, utmp, statbf.st_size, 0)/sizeof(struct utmp); > dsyslog(LOG_DEBUG, "read %d utmp entries", nutmp); I guess you're going to claim it was like this when

Re: [PATCH] openbgpd: Add support for BGP Validation State Communities (RFC 8097)

2017-04-03 Thread Job Snijders
On Wed, Mar 29, 2017 at 12:14:24AM +0200, Sebastian Benoit wrote: > Job Snijders(j...@instituut.net) on 2017.03.28 14:12:42 -0500: > > > > match from any \ > > set { ext-community bovs not-found \ > > do other implementations call this "bovs"? dont get me wrong, i think > junipers