ocspcheck.c patch

2017-12-20 Thread Edgar Pettijohn
poll.h doesn't appear to be needed Index: ocspcheck.c === RCS file: /cvs/src/usr.sbin/ocspcheck/ocspcheck.c,v retrieving revision 1.21 diff -u -p -u -r1.21 ocspcheck.c --- ocspcheck.c 8 May 2017 20:15:34 - 1.21 +++

Re: git a/ b/ diffs vs /dev/null

2017-12-20 Thread Todd C. Miller
Yes please. OK millert@ - todd

Re: git a/ b/ diffs vs /dev/null

2017-12-20 Thread Ted Unangst
Theo Buehler wrote: > The diff below only skips 6 letters if they actually are '--- a/' or > '+++ b/' and seems to do the trick for me in various scenarios. asymptotically approaching correct, i like it.

Re: libsndio: further reduce PLT size

2017-12-20 Thread Alexandre Ratchov
On Wed, Dec 20, 2017 at 04:10:15PM +0100, Jeremie Courreges-Anglas wrote: > > Diff on top of Symbols.map addition, using the same tools as other libs. > > check_sym output: > /usr/lib/libsndio.so.7.0 --> obj/libsndio.so.7.0 > No dynamic export changes > PLT removed: > mio_rmidi_getfd >

libsndio: further reduce PLT size

2017-12-20 Thread Jeremie Courreges-Anglas
Diff on top of Symbols.map addition, using the same tools as other libs. check_sym output: /usr/lib/libsndio.so.7.0 --> obj/libsndio.so.7.0 No dynamic export changes PLT removed: mio_rmidi_getfd sio_revents sio_sun_fdopen sio_sun_getfd I have already discussed a

Re: [EXTERNAL] Export IPsec flows via snmpd(8)

2017-12-20 Thread Eichert, Diana
Marco's reference to RFC4807 looks interesting. I started reading it yesterday afternoon, it appears to be much more extensive, including packet filter information. -Original Message- From: Martin Pieuchot [mailto:m...@openbsd.org] Sent: Wednesday, December 20, 2017 4:22 AM To:

libsndio: Symbols.map for libsndio

2017-12-20 Thread Jeremie Courreges-Anglas
Hi, Here's a simple diff to tighten things up. check_sym output: /usr/lib/libsndio.so.6.1 --> obj/libsndio.so.7.0 Dynamic export changes: removed: __bss_start __data_start _aucat_close _aucat_open _aucat_pollfd _aucat_rdata _aucat_revents

Re: if_ioctl: move NET_LOCK down

2017-12-20 Thread Martin Pieuchot
On 20/12/17(Wed) 15:35, Alexander Bluhm wrote: > On Wed, Dec 20, 2017 at 01:43:13PM +0100, Martin Pieuchot wrote: > > [...] > > Flags are modified by the driver, not by the stack. Some of them are > > event immutable and might be better moved to a different field. > > You have marked if_flags

Re: if_ioctl: move NET_LOCK down

2017-12-20 Thread Alexander Bluhm
On Wed, Dec 20, 2017 at 01:43:13PM +0100, Martin Pieuchot wrote: > > rtm_ifchg() calls route_input() which needs the net lock. > > Does it? What needs the lock in route_input()? I thought routing > sockets are still protected by the KERNEL_LOCK(). My fault. I have misread the code. Your

git a/ b/ diffs vs /dev/null

2017-12-20 Thread Theo Buehler
Our patch was modified a while ago to cope a bit better with git diffs containing a/ and b/. There is still a common case where things don't work as they should. Consider this simple patch: diff --git a/afile b/afile new file mode 100644 index 000..9daeafb9864

Re: Properly sync filesystems during {suspend,hibernate}/resume

2017-12-20 Thread Grégoire Jadi
"Theo de Raadt" writes: >> > I'd appreciate reports about how well it delivers and if any new >> > problems show up. >> >> Tested on amd64 with softdep and softraid (CRYPTO). >> Works as expected with suspend and hibernate. > > Thanks. > >> However, in both cases there is a

Re: if_ioctl: move NET_LOCK down

2017-12-20 Thread Martin Pieuchot
On 19/12/17(Tue) 19:24, Alexander Bluhm wrote: > On Mon, Dec 18, 2017 at 04:01:12PM +0100, Martin Pieuchot wrote: > > Diff below moves the NET_LOCK() into every switch case that need it and > > document locking for most of the fields of 'struct ifnet'. > > > > case SIOCSIFXFLAGS: > >

Re: [EXTERNAL] Export IPsec flows via snmpd(8)

2017-12-20 Thread Martin Pieuchot
On 19/12/17(Tue) 13:40, Eichert, Diana wrote: > tech lurker here, long time NMS/EMS admin > > I did not see diffs to an OpenBSD MIB file. I assume that will be included > in a "more complete solution"? Yes, I did not want to spend some time writing a MIB if the format is going to change. I

Re: C mutex impl. for x86

2017-12-20 Thread Martin Pieuchot
On 15/12/17(Fri) 22:03, Mateusz Guzik wrote: > [...] > However, contended behaviour is a regression compared to the asm > variant. Now that I checked the files in could you generate a diff with your suggestions? > From what I gather this is a step towards unifying all mutex > implementations,

Re: iked: multiple proposals

2017-12-20 Thread Patrick Wildt
On Tue, Dec 05, 2017 at 12:53:38PM +0100, Patrick Wildt wrote: > Hi, > > this diff changes the config parsing code so that we can specify > multiple ikesa and childsa proposals by using the keywords multiple > times. It needs the other payload parsing diff that I posted as well. > > Multiple