[diff] acme-client - clean up main.c

2018-07-29 Thread Ross L Richardson
[This diff is very similar to one I sent previously off-list to a few.] Just some style(9) and simple cleanup: - order getopt string and switch cases - add space between "if" and "(" - wrap a long line - return rather than exit() from main() - move chngdir == NULL test to where it belongs

Re: [bugfix] xterm(1) needs "cpath" pledge(2)

2018-07-29 Thread lists
Sun, 29 Jul 2018 15:46:20 +0300 (EEST) Leonid Bobrov > Lauri, Matthieu, thank you for saving me the trouble having to read and > understand the code of this big fat hippopotamus. > > So, that means somehow I actually accidentally pressed annoying touchpad > and was lucky enough to click

Re: paste(1): use getline instead of fgetln

2018-07-29 Thread Ingo Schwarze
Hi, Lauri Tirkkonen wrote on Tue, Jul 17, 2018 at 09:14:29PM +0300: > In the same vein as my previous diff for join(1), > make paste(1) use getline instead of fgetln. I think it's correct, but i tweaked it a bit for simplicity. In sequential(), the double loop with double getline(), both with

Re: remove uaudio_id_name()

2018-07-29 Thread Klemens Nanni
On Sun, Jul 29, 2018 at 09:31:51PM +0800, Michael W. Bombardieri wrote: > The function uaudio_id_name() was used once for formatting a string > and its return value was used to format a second string. By rolling > the prepended letter "i" into the outer snprintf() the function can > be removed

remove uaudio_id_name()

2018-07-29 Thread Michael W. Bombardieri
Hello, The function uaudio_id_name() was used once for formatting a string and its return value was used to format a second string. By rolling the prepended letter "i" into the outer snprintf() the function can be removed entirely. Does this look correct? - Michael Index: uaudio.c

Re: stop using WSMOUSE_TYPE_ELANTECH in other drivers

2018-07-29 Thread Ulf Brosziewski
ok bru@ (but please see my comments on the second diff) On 07/27/2018 09:59 PM, joshua stein wrote: > Back when touchpad drivers were using the synaptics Xorg driver, > they had to pretend to be Elantech devices in order to get > particular packet processing. > > Since Ulf switched us to

Re: [bugfix] xterm(1) needs "cpath" pledge(2)

2018-07-29 Thread Leonid Bobrov
Lauri, Matthieu, thank you for saving me the trouble having to read and understand the code of this big fat hippopotamus. So, that means somehow I actually accidentally pressed annoying touchpad and was lucky enough to click "Print-All Immediately" without noticing that... I regret that I've sent

pfctl: Simplify host()

2018-07-29 Thread Klemens Nanni
This gets rid of the `cont' flag and squashes the code a bit. `host_*()' are pretty self explanatory so I zapped the comments as well. Regress tests pass, no issues in production use. Feedback? OK? Index: pfctl_parser.c === RCS

Re: [bugfix] xterm(1) needs "cpath" pledge(2)

2018-07-29 Thread Sebastien Marie
On Sun, Jul 29, 2018 at 08:43:22AM +0200, Matthieu Herrb wrote: > On Sun, Jul 29, 2018 at 07:28:19AM +0200, Sebastien Marie wrote: > > > > but to decide, we should know *what* triggered this behaviour. > > Hi, > > After digging a bit, there is at least the 'Print All Immediatly' > function from

Re: [bugfix] xterm(1) needs "cpath" pledge(2)

2018-07-29 Thread Matthieu Herrb
On Sun, Jul 29, 2018 at 07:28:19AM +0200, Sebastien Marie wrote: > Hi, > > First, thanks to (trying) to search for solve the problem you encountered. > > On Sat, Jul 28, 2018 at 10:08:04PM +0300, Leonid Bobrov wrote: > > Hi! > > > > Like I said yesterday, I don't know how to reproduce this bug,

Re: [bugfix] xterm(1) needs "cpath" pledge(2)

2018-07-29 Thread Lauri Tirkkonen
On Sun, Jul 29 2018 07:28:19 +0200, Sebastien Marie wrote: > personally, I like to know that xterm is unable to create a file. At least this feature will create files (accessible through the context menu through ctrl-left click): Print-All Immediately (resource print-immediate)