Re: replacing timeout_add() with timeout_add_msec()

2019-01-06 Thread Claudio Jeker
On Sun, Jan 06, 2019 at 01:43:19PM -0600, Amit Kulkarni wrote: > Hi, > > Referring to the end of mpi's message, and also mlarkin@ later comment > https://marc.info/?l=openbsd-tech=154577028830964=2 > > I am trying to replace some easy timeout_add() calls with timeout_add_msec(). > > My current

Re: replacing timeout_add() with timeout_add_msec()

2019-01-06 Thread Amit Kulkarni
> > Even on amd64, I won't be able to test, because of missing hardware. > > If you think something is wrong, please will you let me have your > > feedback? > > I'm a bit stunned at the zeal to push untested diffs into the tree > > (you didn't ask anyone to test it for you) I requested for

Re: replacing timeout_add() with timeout_add_msec()

2019-01-06 Thread Theo de Raadt
Amit Kulkarni wrote: > Even on amd64, I won't be able to test, because of missing hardware. > If you think something is wrong, please will you let me have your > feedback? I'm a bit stunned at the zeal to push untested diffs into the tree (you didn't ask anyone to test it for you)

Re: replacing timeout_add() with timeout_add_msec()

2019-01-06 Thread Amit Kulkarni
Even on amd64, I won't be able to test, because of missing hardware. If you think something is wrong, please will you let me have your feedback? Thanks On Sun, Jan 6, 2019 at 4:56 PM Theo de Raadt wrote: > > Amit Kulkarni wrote: > > > Hi, > > > > Referring to the end of mpi's message, and

Re: vmd console freeze and locked (?) qcow2 image

2019-01-06 Thread Thomas L.
On Sat, 5 Jan 2019 17:56:01 -0800 Mike Larkin wrote: > Did you kill all the old vmd processes? > > -ml > I tested again and it works now. There were restarts in between. I will try killing vmd processes if this happens again, thanks. Kind regards, Thomas

Re: relayd and TLS client cert verification

2019-01-06 Thread Ashe Connor
On 18 Dec 2018, at 11:34, Ashe Connor wrote: > Revised patch follows (includes mandoc changes). Last bump. Happy new year!

Re: pfctl: zap unused function parameter

2019-01-06 Thread Alexandr Nedvedicky
Hello, On Sat, Jan 05, 2019 at 10:10:07PM +0100, Klemens Nanni wrote: > Never used, probably just copy/pasta since introduction in 2006. > > `-i' and other flags are completely ignored with `-K' anyway. > > OK? > OK sashan@ > Index: pfctl.c >

Re: pfctl: defuse `-F all -i ...'

2019-01-06 Thread Alexandr Nedvedicky
Hello, > mcbride introduced this code with r1.298 in 2010 but used > > if (*ifaceopt) { > > only to have stsp fix a segfault in r1.299 by changing it to the current > form. > > One might as well assume that my proposed condition was the originally > intended behaviour after all and

Re: pfctl: tables: improve namespace collision warnings

2019-01-06 Thread Alexandr Nedvedicky
Hello, > > > As I've said I don't object your change. I agree it does, > > what you intend, however I'm not sure how much it buys. > My intention is to make warnings clear and unambiguous, such that > referred table and anchor names can be copied and pasted into successive > pfctl

Re: replacing timeout_add() with timeout_add_msec()

2019-01-06 Thread Theo de Raadt
Amit Kulkarni wrote: > Hi, > > Referring to the end of mpi's message, and also mlarkin@ later comment > https://marc.info/?l=openbsd-tech=154577028830964=2 > > I am trying to replace some easy timeout_add() calls with timeout_add_msec(). > > My current understanding with the occurences of

[patch] cwm: tile only within active monitor

2019-01-06 Thread Charles A Daniels
Hi all, I'm new around here, so apologies in advance if I miss something obvious. I have written a patch to cwm so that the htile/vtile functionality only affect windows within the same monitor as the active window. For single monitor setups, this will have no effect. For multi-monitor setups,

replacing timeout_add() with timeout_add_msec()

2019-01-06 Thread Amit Kulkarni
Hi, Referring to the end of mpi's message, and also mlarkin@ later comment https://marc.info/?l=openbsd-tech=154577028830964=2 I am trying to replace some easy timeout_add() calls with timeout_add_msec(). My current understanding with the occurences of timeout_add() in the tree is that: if

Re: grep: convert fgetln to getline

2019-01-06 Thread Ted Unangst
Lauri Tirkkonen wrote: > Hi, another simple diff converting fgetln usage to getline. > > I also considered converting grep_fgetln to grep_getline, but that would > mean that for FILE_MMAP we'd have to copy the string. So this diff keeps > the grep_fgetln interface as is, but avoids using fgetln

Re: sbin/wsconsctl: show more data

2019-01-06 Thread Robert Curry
Thank you Frederic for the new console font. I agree with Mischa and Paul and find it very clean and readable, a definite improvement. -- Robert W. Curry

Re: adjust rdate example

2019-01-06 Thread Theo de Raadt
Ingo Schwarze wrote: > Hm, you have a point. > > I guess i got confused by my experience with LC_CTYPE; even though > that is also a standard variable, its effects on different programs > vary wildly, so the text for LC_CTYPE reads very differently in > different utility manual pages, and it is

Re: sbin/wsconsctl: show more data

2019-01-06 Thread Mischa Peters
I have to concur with Paul! Saw the new font yesterday and was pleasantly surprised. Very nice! Mischa -- > On 6 Jan 2019, at 15:51, Paul de Weerd wrote: > > Lots of negativity here, so I just wanted to chime in - really love > the new console font! Crisp and easily readable letters, big

Re: sbin/wsconsctl: show more data

2019-01-06 Thread Paul de Weerd
Lots of negativity here, so I just wanted to chime in - really love the new console font! Crisp and easily readable letters, big enough to be readable, with a reasonable number of letters per line (${COLUMNS}) en lines per screen (${LINES}). It does mean pretty big characters on big screens when

grep: convert fgetln to getline

2019-01-06 Thread Lauri Tirkkonen
Hi, another simple diff converting fgetln usage to getline. I also considered converting grep_fgetln to grep_getline, but that would mean that for FILE_MMAP we'd have to copy the string. So this diff keeps the grep_fgetln interface as is, but avoids using fgetln from libc (and adds error handling

ehci(4): interrupt transfer fix

2019-01-06 Thread SASANO Takayoshi
Hello, RL (NAK count reload) field in QH should be zero when using periodic (interrupt) transfer. Currently it is always set 8, but this causes high-speed interrupt transfer malfunction in my machines, Hudson-D2 chipset(amd64) and Allwinner A10(armv7). This causes USB2.0 hub cannot detect