Re: trunk(4) shouldn't need to play with a port's if_type

2019-06-11 Thread sven falempin
Some interfaces are marked as busy ( promiscuitous ?) so they can’t be added in two bridges for example, this could be extended and make things more consistent? Just my two cents On Tue, Jun 11, 2019 at 8:27 PM David Gwynne wrote: > I get that trunk ports should not be able to be added to

Re: trunk(4) shouldn't need to play with a port's if_type

2019-06-11 Thread David Gwynne
I get that trunk ports should not be able to be added to bridges or have carp interfaces hanging off them, but I think the value of making the if_type immutable outweighs this usability feature. Especially when you consider that you can have an interface that is already a member of a bridge (or

drm(4), multi-threaded task queues and barriers

2019-06-11 Thread Mark Kettenis
The drm(4) codebase really needs multi-threaded task queues since the code has taks that wait for the completion of other tasks that are submitted to the same task queue. Thank you Linux... Unfortunately the code also needs to wait for the completion of submitted tasks from other threads. This

Re: mg(1) log internals to file

2019-06-11 Thread Florian Obser
On Fri, Jun 07, 2019 at 03:18:27PM +, Mark Lumsden wrote: > This diff allows mg to log its internal status to a file. At the moment it > only logs line information like front and back pointers in the linked list, > how many characters are used and where the cursor is placed in the file, but >

Check your machdep.allowaperture setting

2019-06-11 Thread Mark Kettenis
These days most OpenBSD users should have the machdep.allowaperture sysctl set to 0 (the default). Having it set to seomething else poses security risks and can actually cause problems, in particular on systems that have multiple GPUs where one of tha GPUs is supported by inteldrm(4) or

Re: pflog(4) free sizes

2019-06-11 Thread Klemens Nanni
OK kn

Re: [patch] use acme-client to sign certificated with ecdsa keys

2019-06-11 Thread Gilles Chehade
On Tue, Jun 11, 2019 at 01:37:24PM +0200, Renaud Allard wrote: > > > On 6/11/19 10:17 AM, Renaud Allard wrote: > > > > Hello, > > > > Here is a patch with ecdsa and rsa in %token after the domain key name > > > > OK? comments? > > I just made a small modification in the formatting of

Re: pflog(4) free sizes

2019-06-11 Thread Martin Pieuchot
On 10/06/19(Mon) 19:04, Klemens Nanni wrote: > On Mon, Jun 10, 2019 at 01:55:29PM -0300, Martin Pieuchot wrote: > > ok? > OK kn > > There's another in `pflog_clone_destroy()'. Updated diff including your suggestions. Index: net/if_pflog.c

About transient mark mode

2019-06-11 Thread Leonid Bobrov
Hi! If we don't have to follow what GNU Emacs is doing anyway, let's just change behavior of {beginning,end}-of-buffer to this instead of implementing a useless mode: Index: basic.c === RCS file: /cvs/src/usr.bin/mg/basic.c,v

Re: fsync(2) and I/O errors

2019-06-11 Thread Ted Unangst
Maximilian Lorlacks wrote: > This looks okay to me. > > (plus two months ping) oh, good news, committed two months ago. sorry, forgot to reply. > > ‐‐‐ Original Message ‐‐‐ > On Tuesday, April 16, 2019 8:19 PM, Ted Unangst wrote: > > > Oh, right, I reworded it slightly, but I think

Re: fsync(2) and I/O errors

2019-06-11 Thread Maximilian Lorlacks
This looks okay to me. (plus two months ping) ‐‐‐ Original Message ‐‐‐ On Tuesday, April 16, 2019 8:19 PM, Ted Unangst wrote: > Oh, right, I reworded it slightly, but I think this is something we should > note. > > Index: fsync.2 > >

Re: ssh_config.5: refer consistently to HostName, not Hostname

2019-06-11 Thread Jason McIntyre
On Tue, Jun 11, 2019 at 03:11:03PM +0300, Lauri Tirkkonen wrote: > Hi, trivial manpage diff. > fixed, thanks. jmc > diff --git a/usr.bin/ssh/ssh_config.5 b/usr.bin/ssh/ssh_config.5 > index b8ba4022a56..1f2094cb981 100644 > --- a/usr.bin/ssh/ssh_config.5 > +++ b/usr.bin/ssh/ssh_config.5 > @@

ssh_config.5: refer consistently to HostName, not Hostname

2019-06-11 Thread Lauri Tirkkonen
Hi, trivial manpage diff. diff --git a/usr.bin/ssh/ssh_config.5 b/usr.bin/ssh/ssh_config.5 index b8ba4022a56..1f2094cb981 100644 --- a/usr.bin/ssh/ssh_config.5 +++ b/usr.bin/ssh/ssh_config.5 @@ -203,7 +203,7 @@ The criteria for the .Cm host keyword are matched against the target hostname, after

arm: cleanup cpuid assembly

2019-06-11 Thread Patrick Wildt
Hi, in a recent discussion I was told we can throw out all the !ARMv7 architecture code and !OpenBSD and if portable needs it they can add it back. With this in mind we can throw out quite a bit of ifdefs. ok? Patrick diff --git a/lib/libcrypto/armv4cpuid.S b/lib/libcrypto/armv4cpuid.S index

Re: [patch] use acme-client to sign certificated with ecdsa keys

2019-06-11 Thread Renaud Allard
On 6/11/19 10:17 AM, Renaud Allard wrote: Hello, Here is a patch with ecdsa and rsa in %token after the domain key name OK? comments? I just made a small modification in the formatting of acme.conf man page, putting keytype as an arg. And also a cleaner key.h OK? Index: Makefile

athn(4): Set frame's Tx duration and power

2019-06-11 Thread Stefan Sperling
Linux ath9k provides Tx time of an entire frame to hardware. Make our athn(4) driver do the same. ALso set registers which contain Tx power values for retried frames. Please test. diff 8885fdfe4213e1feed4da2ad98226517b33cdcf5 /usr/src blob - 1890ab7d38911a4917ed03869d7cc734669506cb file +

Re: [patch] use acme-client to sign certificated with ecdsa keys

2019-06-11 Thread Renaud Allard
On 6/7/19 2:38 PM, Renaud Allard wrote: On 6/7/19 2:28 PM, Florian Obser wrote: On Fri, Jun 07, 2019 at 10:40:36AM +0200, Renaud Allard wrote: On 6/6/19 10:46 AM, Renaud Allard wrote: On 6/6/19 10:10 AM, Florian Obser wrote: I currently don't have time to review this. I'm busy

Re: bpf(4) free sizes

2019-06-11 Thread Alexandr Nedvedicky
Hello, On Mon, Jun 10, 2019 at 01:53:06PM -0300, Martin Pieuchot wrote: > `bd_bufsize' can change via the BIOCSBLEN ioctl(2) but iff the > descriptor hasn't been linked to an interface. Which means the > buffers haven't been allocated yet. > > ok? reads OK to me. regards sashan > >

Re: pf_state_key_link_reverse() needs atomic ops

2019-06-11 Thread Alexandr Nedvedicky
Hello, > > > > > > yes that's correct. the patch above comes from my private branch [1]. > > > mpi@ pointed out in off-line email exchange the patch unlocks local > > > inbound > > > packets too, which is coming bit early. However for forwarding case > > > things > > > seem

Re: trunk(4) shouldn't need to play with a port's if_type

2019-06-11 Thread Reyk Floeter
Hi, the initial intention was to differentiate a trunk port from a regular Ethernet interface. As long as an interface is a member of a trunk, it is not a fully featured Ethernet interface. The changed type prevented from using it elsewhere. I‘m not so familiar with the current network stack

Re: [patch] use acme-client to sign certificated with ecdsa keys

2019-06-11 Thread Renaud Allard
On 6/7/19 2:28 PM, Florian Obser wrote: On Fri, Jun 07, 2019 at 10:40:36AM +0200, Renaud Allard wrote: On 6/6/19 10:46 AM, Renaud Allard wrote: On 6/6/19 10:10 AM, Florian Obser wrote: I currently don't have time to review this. I'm busy switching acme-client to the rfc 8555 /

trunk(4) shouldn't need to play with a port's if_type

2019-06-11 Thread David Gwynne
i think trunk(4) is the only thing left in the kernel that modifies an interfaces if_type at runtime. this diff removes that fiddling, so hopefully we can say that if_type is immutable after this. however, while this diff reads well to me, i don't actually know if it works. could someone kick the